Eric Huss
660ef4ffe8
Ignore flaky clippy tests.
2023-07-12 06:59:57 -07:00
bors
a8939e5eae
Auto merge of #111717 - Urgau:uplift_fn_null_check, r=oli-obk
...
Uplift `clippy::fn_null_check` lint
This PR aims at uplifting the `clippy::fn_null_check` lint into rustc.
## `incorrect_fn_null_checks`
(warn-by-default)
The `incorrect_fn_null_checks` lint checks for expression that checks if a function pointer is null.
### Example
```rust
let fn_ptr: fn() = /* somehow obtained nullable function pointer */
if (fn_ptr as *const ()).is_null() { /* ... */ }
```
### Explanation
Function pointers are assumed to be non-null, checking for their nullity is incorrect.
-----
Mostly followed the instructions for uplifting a clippy lint described here: https://github.com/rust-lang/rust/pull/99696#pullrequestreview-1134072751
`@rustbot` label: +I-lang-nominated
r? compiler
2023-07-11 09:34:48 +00:00
Urgau
103949b241
Drop uplifted clippy::fn_null_check
2023-07-10 18:12:41 +02:00
Nilstrieb
31d50a6e21
Delete to_string_in_format_args_incremental.rs
...
It fails CI and passes locally. It passes random directores in
`-Cincremental` so maybe something's up. It shouldn't block us here.
2023-07-08 17:17:40 +02:00
Alex Macleod
87373d7f52
Fix failing clippy tests
...
Comments out the C string literals due to https://github.com/rust-lang/rust/pull/113334
Fixes https://github.com/rust-lang/rust-clippy/issues/11121
2023-07-07 18:19:08 +00:00
Philipp Krones
4aa4fecf89
Fix compile-test tests to work with the new ui_test crate
2023-07-02 15:07:39 +02:00
Philipp Krones
cb3ecf7b79
Merge commit '37f4c1725d3fd7e9c3ffd8783246bc5589debc53' into clippyup
2023-07-02 14:59:02 +02:00
Oli Scherer
7bd8ab77e5
Make simd_shuffle_indices use valtrees
2023-06-26 09:34:52 +00:00
yukang
23d7a07e86
Do not offer any of the suggestions in emit_coerce_suggestions for expr from destructuring assignment desugaring
2023-06-25 09:26:17 +08:00
bors
70c2d0cfe5
Auto merge of #106450 - albertlarsan68:fix-arc-ptr-eq, r=Amanieu
...
Make `{Arc,Rc,Weak}::ptr_eq` ignore pointer metadata
FCP completed in https://github.com/rust-lang/rust/issues/103763#issuecomment-1362267967
Closes #103763
2023-06-21 05:13:39 +00:00
Michael Goulet
f711c7e1f6
Treat TAIT equation as always ambiguous in coherence
2023-06-18 22:52:30 +00:00
Oli Scherer
5777494f99
Add AliasKind::Weak
for type aliases.
...
Only use it when the type alias contains an opaque type.
Also does wf-checking on such type aliases.
2023-06-16 19:39:48 +00:00
许杰友 Jieyou Xu (Joe)
a35c78fa70
Extend unused_must_use
to cover block exprs
2023-06-15 17:59:13 +08:00
Urgau
edb3266b91
Drop uplifted clippy:cmp_nan
2023-06-10 11:13:01 +02:00
Urgau
f47e9156a4
Drop uplifted clippy::undropped_manually_drops
2023-06-08 11:41:34 +02:00
bors
6a5e3de812
Auto merge of #112203 - flip1995:clippyup, r=Manishearth
...
Update Clippy
r? `@Manishearth`
2023-06-02 10:55:54 +00:00
Philipp Krones
e6dc0efc00
Merge commit '30448e8cf98d4754350db0c959644564f317bc0f' into clippyup
2023-06-02 11:41:57 +02:00
bors
427a4538db
Auto merge of #112198 - compiler-errors:rollup-o2xe4of, r=compiler-errors
...
Rollup of 7 pull requests
Successful merges:
- #111670 (Require that const param tys implement `ConstParamTy`)
- #111914 (CFI: Fix cfi with async: transform_ty: unexpected GeneratorWitness(Bi…)
- #112030 (Migrate `item_trait_alias` to Askama)
- #112150 (Support 128-bit atomics on all x86_64 Apple targets)
- #112174 (Fix broken link)
- #112190 (Improve comments on `TyCtxt` and `GlobalCtxt`.)
- #112193 (Check tuple elements are `Sized` in `offset_of`)
Failed merges:
- #112071 (Group rfcs tests)
r? `@ghost`
`@rustbot` modify labels: rollup
2023-06-02 07:57:21 +00:00
Michael Goulet
b4f074c588
Implement custom diagnostic for ConstParamTy
2023-06-01 18:21:42 +00:00
Deadbeef
ec2c6155aa
Use translatable diagnostics in rustc_const_eval
2023-06-01 14:45:18 +00:00
Urgau
1a5db18b11
Drop uplifted clippy::cast_ref_to_mut
2023-05-31 13:42:53 +02:00
Urgau
5a2094319b
Drop uplifted clippy::invalid_utf8_in_unchecked
2023-05-27 00:16:47 +02:00
Urgau
915ff71b7c
Rename forget_ref
lint to forgetting_references
2023-05-21 14:28:09 +02:00
Urgau
fdbfe0e249
Rename drop_ref
lint to dropping_references
2023-05-21 14:16:41 +02:00
Urgau
234f2b67cb
Rename forget_copy
lint to forgetting_copy_types
2023-05-21 14:09:03 +02:00
Urgau
9b97ae98f8
Rename drop_copy
lint to dropping_copy_types
2023-05-21 13:37:32 +02:00
Philipp Krones
b76b0aeb63
Merge commit '435a8ad86c7a33bd7ffb91c59039943408d3b6aa' into clippyup
2023-05-20 15:39:26 +02:00
León Orell Valerian Liehr
0eb364b8d6
Exclude inherent projections from some alias ty matches
2023-05-17 23:53:58 +02:00
David Tolnay
fcb132765c
Exposes false negative in clippy's diverging_sub_expression
2023-05-14 07:58:45 -07:00
Urgau
35e5aac5c8
Drop uplifted clippy::forget_copy
2023-05-10 19:36:02 +02:00
Urgau
22688fc91f
Drop uplifted clippy::forget_ref
2023-05-10 19:36:01 +02:00
Urgau
551f6e6154
Drop uplifted clippy::drop_copy
2023-05-10 19:36:01 +02:00
Urgau
6af0359f2a
Drop uplifted clippy::drop_ref
2023-05-10 19:36:01 +02:00
Philipp Krones
7e9abb311d
Merge commit '371120bdbf58a331db5dcfb2d9cddc040f486de8' into clippyup
2023-05-05 17:45:49 +02:00
Dylan DPC
eac589b4e4
Rollup merge of #110955 - fee1-dead-contrib:sus-operation, r=compiler-errors
...
uplift `clippy::clone_double_ref` as `suspicious_double_ref_op`
Split from #109842 .
r? ``@compiler-errors``
2023-05-02 11:44:52 +05:30
Deadbeef
81a614145f
uplift clippy::clone_double_ref
as suspicious_double_ref_op
2023-04-28 17:24:48 +00:00
Michael Goulet
83504fa763
Make clippy happy
2023-04-27 17:18:12 +00:00
Albert Larsan
9a61550e78
Make {Arc,Rc,Weak}::ptr_eq
ignore pointer metadata
2023-04-26 15:27:32 +00:00
Philipp Krones
a1b75c5108
Merge commit 'a3ed905928a03b6e433d0b429190bf3a847128b3' into clippyup
2023-04-23 13:28:56 +02:00
Camille GILLOT
cb3e0fbb59
Evaluate place expression in PlaceMention
.
2023-04-21 21:34:59 +00:00
Matthias Krüger
1dfc231b10
clippy: add test for https://github.com/rust-lang/rust-clippy/issues/10645
2023-04-18 18:46:41 +00:00
bors
d61570ceb6
Auto merge of #110160 - petrochenkov:notagain2, r=cjgillot
...
resolve: Pre-compute non-reexport module children
Instead of repeating the same logic by walking HIR during metadata encoding.
The only difference is that we are no longer encoding `macro_rules` items, but we never currently need them as a part of this list. They can be encoded separately if this need ever arises.
`module_reexports` is also un-querified, because I don't see any reasons to make it a query, only overhead.
2023-04-14 01:14:36 +00:00
Esteban Küber
4680aa2fd0
Special-case item attributes in the suggestion output
2023-04-12 22:50:10 +00:00
Esteban Küber
7a0fb902bc
Tweak output for 'add line' suggestion
2023-04-12 22:50:10 +00:00
Vadim Petrochenkov
5989400e2e
resolve: Pre-compute non-reexport module children
...
Instead of repeating the same logic by walking HIR during metadata encoding.
The only difference is that we are no longer encoding `macro_rules` items, but we never currently need them as a part of this list.
They can be encoded separately if this need ever arises.
`module_reexports` is also un-querified, because I don't see any reasons to make it a query, only overhead.
2023-04-12 15:22:03 +03:00
Philipp Krones
6b95029f17
Merge commit '83e42a2337dadac915c956d125f1d69132f36425' into clippyup
2023-04-11 15:31:08 +02:00
Trevor Gross
4cf5bdc60c
Stabilize a portion of 'once_cell'
...
Move items not part of this stabilization to 'lazy_cell' or 'once_cell_try'
2023-03-29 18:04:44 -04:00
Jamen Marz
28b80059ed
Add notes to non-structural const in pattern error message
2023-03-27 11:08:11 -04:00
Philipp Krones
8df896c076
Merge commit 'd5e2a7aca55ed49fc943b7a07a8eba05ab5a0079' into clippyup
2023-03-24 14:26:19 +01:00
bors
491f63214a
Auto merge of #104833 - Swatinem:async-identity-future, r=compiler-errors
...
Remove `identity_future` indirection
This was previously needed because the indirection used to hide some unexplained lifetime errors, which it turned out were related to the `min_choice` algorithm.
Removing the indirection also solves a couple of cycle errors, large moves and makes async blocks support the `#[track_caller]`annotation.
Fixes https://github.com/rust-lang/rust/issues/104826 .
2023-03-14 10:12:58 +00:00