Aleksey Kladov
71b9f06c89
don't insert parens for self methods
2019-01-23 16:21:20 +03:00
Aleksey Kladov
2dbf58c579
move completion item tests closer to the code
...
this is the reason why we need marks: the tests were spread across two
files, because I've forgotten that there were tests already
2019-01-23 16:05:13 +03:00
bors[bot]
86507c0626
Merge #606
...
606: generalize marking infrastructure r=matklad a=matklad
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2019-01-23 12:40:36 +00:00
Aleksey Kladov
45da21672a
generalize marking infrastructure
2019-01-23 15:36:29 +03:00
bors[bot]
b846832b8b
Merge #605
...
605: ⬆️ insta r=matklad a=matklad
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2019-01-23 12:05:12 +00:00
Aleksey Kladov
28661facf6
⬆️ insta
2019-01-23 15:04:38 +03:00
bors[bot]
1d7baef0e9
Merge #603
...
603: fix completion bugs r=gfreezy a=gfreezy
The result is as below.
before:
![image](https://user-images.githubusercontent.com/510012/51483467-0f641400-1dd4-11e9-9921-ef21d15cc343.png )
after:
![image](https://user-images.githubusercontent.com/510012/51483433-fb201700-1dd3-11e9-9730-c2a5d3dd5f5a.png )
Co-authored-by: gfreezy <gfreezy@gmail.com>
2019-01-23 07:45:08 +00:00
gfreezy
13d2fd32ab
fix completion bugs
2019-01-23 15:43:47 +08:00
bors[bot]
488326ffa7
Merge #598
...
598: Add function signature to CompletionItem detail r=matklad a=kjeremy
Co-authored-by: Jeremy A. Kolb <jkolb@ara.com>
2019-01-23 07:27:09 +00:00
Jeremy A. Kolb
a3472f8fe1
Move label from hir to ide_api
2019-01-22 18:20:40 -05:00
bors[bot]
f90783fc53
Merge #602
...
602: add status command r=matklad a=matklad
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2019-01-22 22:25:22 +00:00
Aleksey Kladov
c0dba92b7f
document status command
2019-01-23 01:24:53 +03:00
Aleksey Kladov
0ba7e2eaeb
ad status command
2019-01-23 01:24:53 +03:00
bors[bot]
e08df3219d
Merge #601
...
601: Simplify CallInfo label and documentation r=matklad a=kjeremy
Co-authored-by: Jeremy A. Kolb <jkolb@ara.com>
2019-01-22 21:46:11 +00:00
Jeremy A. Kolb
9582a439e1
Simplify CallInfo label and documentation
2019-01-22 16:28:02 -05:00
bors[bot]
cc6898acd1
Merge #600
...
600: ⬆️ rowan r=matklad a=matklad
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2019-01-22 20:37:27 +00:00
Aleksey Kladov
7b28a15202
⬆️ rowan
2019-01-22 23:37:03 +03:00
bors[bot]
b9f65b18b8
Merge #599
...
599: Allow placeholder parameters in trait function definitions r=matklad a=regiontog
fixes #597
Co-authored-by: Erlend Tobiassen <erlend.tobiassen@gmail.com>
2019-01-22 17:56:00 +00:00
Erlend Tobiassen
c550c6759d
Add test for placeholder parameters in trait fn defs
2019-01-22 18:46:15 +01:00
Erlend Tobiassen
234b65fd61
Allow placeholder parameters in trait fn defs
2019-01-22 18:33:53 +01:00
Jeremy A. Kolb
070a980224
Add function signature to CompletionItem detail
2019-01-22 10:54:50 -05:00
bors[bot]
595a2f9900
Merge #593
...
593: Docs for completion r=matklad a=kjeremy
The first commit adds documentation support to CompletionItems.
The second one I am unsure about. Is that the right way to add docs for functions? If so should I do something similar for other `hir` types and CompletionItems?
Co-authored-by: Jeremy Kolb <kjeremy@gmail.com>
Co-authored-by: Jeremy A. Kolb <jkolb@ara.com>
2019-01-22 15:06:32 +00:00
Jeremy A. Kolb
7c27e6d2b3
Update snaps
2019-01-22 09:51:29 -05:00
Jeremy Kolb
b540451483
Move docs to Function
2019-01-22 08:55:05 -05:00
bors[bot]
9e0abfc0c9
Merge #592
...
592: Allow types to the left of `:` in where predicates r=matklad a=regiontog
Adresses #584
Co-authored-by: Erlend Tobiassen <erlend.tobiassen@gmail.com>
2019-01-22 13:49:33 +00:00
Erlend Tobiassen
84f888e93d
No need for is_type_start
2019-01-22 14:46:06 +01:00
Erlend Tobiassen
9f3d133813
Prefer TYPE_FIRST
2019-01-22 14:36:57 +01:00
Erlend Tobiassen
8198cde13b
Update tests after allowing where predicate to accept types
2019-01-22 14:32:23 +01:00
bors[bot]
e396cb3548
Merge #594
...
594: fold macros r=matklad a=matklad
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2019-01-22 13:27:17 +00:00
Aleksey Kladov
cd67fb3ac1
fold macros
2019-01-22 16:26:32 +03:00
Erlend Tobiassen
2b22f5fb43
Optimistically bail out of where clause loop if not at start of a type or lifetime
2019-01-22 13:17:10 +01:00
Jeremy Kolb
b77d780f0e
Thread documentation through FnSignature and CompletionItem
2019-01-21 21:42:37 -05:00
Jeremy Kolb
5d110c0ee2
Teach CompletionItem about documentation
2019-01-21 21:41:39 -05:00
Erlend Tobiassen
1aba42128f
Don't leave a marker hanging without completing it.
2019-01-22 01:25:00 +01:00
Erlend Tobiassen
1059ec74e2
Allow types to the left of : in where predicates.
2019-01-22 01:11:35 +01:00
bors[bot]
b59334e67a
Merge #591
...
591: ⬆️ insta r=matklad a=matklad
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2019-01-21 22:29:25 +00:00
Aleksey Kladov
49596bbc2b
⬆️ insta
2019-01-22 01:28:57 +03:00
bors[bot]
5a753b39c7
Merge #590
...
590: Use insta for ty tests r=matklad a=flodiebold
Co-authored-by: Florian Diebold <flodiebold@gmail.com>
2019-01-21 22:16:33 +00:00
bors[bot]
79720549be
Merge #588
...
588: Fix .not postfix completion r=matklad a=flodiebold
The postfix snippets are awesome! I don't think the `.not` one is supposed to always replace the receiver by literally `!not` 😄
Co-authored-by: Florian Diebold <flodiebold@gmail.com>
2019-01-21 22:10:43 +00:00
Florian Diebold
a252110616
Use insta for ty tests
2019-01-21 22:52:35 +01:00
Florian Diebold
0cfd80422a
Fix .not postfix completion
2019-01-21 22:33:30 +01:00
bors[bot]
0d2cb60f93
Merge #586
...
586: Fix panic trying to get substs on unknown type r=matklad a=flodiebold
Fixes #585 .
Co-authored-by: Florian Diebold <flodiebold@gmail.com>
2019-01-21 20:47:01 +00:00
Florian Diebold
e45f476d56
Fix panic trying to get substs on unknown type
...
Fixes #585 .
2019-01-21 21:42:19 +01:00
Aleksey Kladov
e0d8c86563
mention guide in architecture
2019-01-21 10:27:01 +02:00
Aleksey Kladov
5a4276b1af
add illustrations
2019-01-21 10:27:01 +02:00
Pascal Hertleif
9b0aa786ee
Apply suggestions from code review
...
Co-Authored-By: matklad <aleksey.kladov@gmail.com>
2019-01-21 10:27:01 +02:00
Aleksey Kladov
f0a26d93c7
create a reference cycle by linking the video
2019-01-21 10:27:01 +02:00
Aleksey Kladov
ce47d6b7b6
reach fixed-point for rust-analyzer spelling
2019-01-21 10:27:01 +02:00
Aleksey Kladov
7433842040
fix a ton of typos
2019-01-21 10:27:01 +02:00
Aleksey Kladov
068db9fd6d
fix the tag
2019-01-21 10:27:01 +02:00