Oli Scherer
44d1936d00
Some tracing and comment cleanups
2022-11-04 17:10:07 +00:00
bors
c2a5c3a50f
Auto merge of #101703 - nicholasbishop:bishop-add-uefi-ci-2, r=jyn514
...
Add QEMU test for x86_64-unknown-uefi
The UEFI targets don't have std support yet, so the normal tests don't work. However, we can compile a simple no-std program and run it under QEMU to at least check that the target compiles, links, and runs.
Tested locally with: `src/ci/docker/run.sh x86_64-uefi`
2022-11-04 17:00:24 +00:00
Oli Scherer
a2325fe3a9
Remove an option and choose a behaviour-preserving default instead.
2022-11-04 16:28:01 +00:00
Onur Özkan
71a3a48ee5
improve filesearch::get_or_default_sysroot
r=ozkanonur
...
Signed-off-by: Onur Özkan <work@onurozkan.dev>
2022-11-04 17:06:47 +03:00
yukang
18511ba1cb
test tidy should not count untracked paths towards entries limit
2022-11-04 21:48:56 +08:00
bors
6330c27ae2
Auto merge of #103962 - matthiaskrgr:rollup-9av8i6k, r=matthiaskrgr
...
Rollup of 7 pull requests
Successful merges:
- #103680 (CStr: add some doc links)
- #103780 (Fix late-bound lifetime closure ICEs in HIR typeck and MIR borrowck)
- #103845 (Add track_caller to some Lock methods)
- #103935 (Remove rustdoc clean::Visibility type)
- #103941 (Fixed typos)
- #103950 (Fix ICE when negative impl is collected during eager mono)
- #103953 (Remove unused argument from `throw_unresolved_import_error`)
Failed merges:
r? `@ghost`
`@rustbot` modify labels: rollup
2022-11-04 13:47:37 +00:00
clubby789
28819cbb7e
Formatting changes + add UI test
2022-11-04 12:58:20 +00:00
clubby789
b7360fa23f
Give a specific lint for unsafety not being inherited
2022-11-04 12:26:21 +00:00
yukang
4b77e730b5
fake a base to suppress later extra error message
2022-11-04 19:32:32 +08:00
Matthias Krüger
1edd63f1e7
Rollup merge of #103953 - TaKO8Ki:remove-unused-arg-from-throw_unresolved_import_error, r=oli-obk
...
Remove unused argument from `throw_unresolved_import_error`
`throw_unresolved_import_error` does not need the second argument.
2022-11-04 12:18:03 +01:00
Matthias Krüger
ee3c9f7051
Rollup merge of #103950 - nbdd0121:master, r=tmiasko
...
Fix ICE when negative impl is collected during eager mono
```rust
trait Foo {
fn foo() {}
}
impl !Foo for () {}
```
This code will currently cause an ICE when mono collection mode is "eager" (with `-C link-dead-code=y` or `-Z print-mono-items=eager`.
2022-11-04 12:18:03 +01:00
Matthias Krüger
9398676635
Rollup merge of #103941 - douweschulte:patch-1, r=jyn514
...
Fixed typos
Fixed a typo that has been found on two locations in comments.
2022-11-04 12:18:02 +01:00
Matthias Krüger
c6e5150441
Rollup merge of #103935 - GuillaumeGomez:remove-rustdoc-visibility-ty, r=notriddle
...
Remove rustdoc clean::Visibility type
Fixes #90852 .
Follow-up of https://github.com/rust-lang/rust/pull/103690 .
This PR completely removes the rustdoc `clean::Visibility` type to use the `rustc_middle` one instead. I don't think there will be any impact on perf.
r? `@notriddle`
2022-11-04 12:18:02 +01:00
Matthias Krüger
d976a29c30
Rollup merge of #103845 - camsteffen:data-structures-track-caller, r=compiler-errors
...
Add track_caller to some Lock methods
Would have helped to diagnose #103844 .
2022-11-04 12:18:01 +01:00
Matthias Krüger
d10187f040
Rollup merge of #103780 - compiler-errors:bound-closure-lifetimes, r=jackh726
...
Fix late-bound lifetime closure ICEs in HIR typeck and MIR borrowck
During HIR typeck, we need to teach astconv to treat late-bound regions within a closure body as free, fixing escaping bound vars ICEs in both of the issues below.
However, this then gets us to MIR borrowck, which itself needs to be taught how to instantiate free region vids for late-bound regions that come from items that _aren't_ the typeck root (for now, just closures).
Fixes #103771
Fixes #103736
2022-11-04 12:18:01 +01:00
Matthias Krüger
428dd011ca
Rollup merge of #103680 - RalfJung:cstr-links, r=JohnTitor
...
CStr: add some doc links
2022-11-04 12:18:00 +01:00
bors
47c008e440
Auto merge of #103098 - Amanieu:asm-tied-fixed, r=bjorn3
...
asm: Match clang behavior for inlateout fixed register operands
We have 2 options for representing LLVM constraints for `inlateout` operands on a fixed register (e.g. `r0`): `={r0},0` or `={r0},{r0}`.
This PR changes the behavior to the latter, which matches the behavior of Clang since https://reviews.llvm.org/D87279 .
2022-11-04 10:39:04 +00:00
bors
2efb0cd4b2
Auto merge of #103954 - matthiaskrgr:rollup-tskpxnj, r=matthiaskrgr
...
Rollup of 10 pull requests
Successful merges:
- #103825 (Remove let_underscore_must_use from list of uplifted lints)
- #103884 (Add visit_fn_ret_ty to hir intravisit)
- #103892 (Properly render asyncness for trait fns without default body)
- #103905 (rustdoc: remove redundant mobile CSS `.sidebar-elems { background }`)
- #103912 (Add howto for adding new targets)
- #103915 (Improve use of ErrorGuaranteed and code cleanup)
- #103930 (Move some tests from `src/test/ui` to more reasonable places)
- #103931 (Add note to RELEASES.md regarding issue 102754.)
- #103938 (rustdoc: clean up hardcoded CSS border color on search results)
- #103940 (rustdoc: remove no-op CSS `#main-content > .item-info { margin-top: 0 }`)
Failed merges:
r? `@ghost`
`@rustbot` modify labels: rollup
2022-11-04 07:26:56 +00:00
Jakob Degen
d98cce19b2
Make mir opt unused file check blessable
2022-11-03 23:19:59 -07:00
Matthias Krüger
923d907a75
Rollup merge of #103940 - notriddle:notriddle/main-content-item-info-margin-top, r=GuillaumeGomez
...
rustdoc: remove no-op CSS `#main-content > .item-info { margin-top: 0 }`
When this line was added in 04b4c40682
, it overrode a negative `margin-top` that was set on it by default.
04b4c40682/src/librustdoc/html/static/rustdoc.css (L500-L516)
That negative top margin was removed in 593d6d1cb1
.
2022-11-04 06:40:34 +01:00
Matthias Krüger
f35dccbc72
Rollup merge of #103938 - notriddle:notriddle/search-results-border-bottom, r=GuillaumeGomez
...
rustdoc: clean up hardcoded CSS border color on search results
Hardcoded colors in rustdoc.css should usually be avoided.
Preview: http://notriddle.com/notriddle-rustdoc-demos/border-bottom-search/test_dingus/?search=test
2022-11-04 06:40:34 +01:00
Matthias Krüger
9ef3b414a5
Rollup merge of #103931 - pnkfelix:note-eh-personality-limit-atop-lld, r=Mark-Simulacrum
...
Add note to RELEASES.md regarding issue 102754.
As discussed in [compiler triage meeting today](https://rust-lang.zulipchat.com/#narrow/stream/238009-t-compiler.2Fmeetings/topic/.5Bweekly.5D.202022-11-03/near/307746618 ); it would have been nice to get this in time for the stable notes, but having it only in nightly only is better than nothing...
r? `@Mark-Simulacrum`
2022-11-04 06:40:33 +01:00
Matthias Krüger
e6eaa2fe69
Rollup merge of #103930 - fee1-dead-contrib:mv-from-root, r=jyn514
...
Move some tests from `src/test/ui` to more reasonable places
2022-11-04 06:40:33 +01:00
Matthias Krüger
61c6cdb5f4
Rollup merge of #103915 - chenyukang:yukang/fix-103874, r=lcnr
...
Improve use of ErrorGuaranteed and code cleanup
Part of #103874
2022-11-04 06:40:32 +01:00
Matthias Krüger
47bf74302b
Rollup merge of #103912 - flba-eb:doc_adding_tier3_target, r=davidtwco
...
Add howto for adding new targets
When new targets are added, often a reviewer finds out that e.g. the target-3-tier-policy is not filled out (missing), there is no description etc.
This change adds a description of what I've learned while working on #102701 . It should make reviews easier in the future with less rework.
r? compiler-team
2022-11-04 06:40:32 +01:00
Matthias Krüger
a81a531210
Rollup merge of #103905 - notriddle:notriddle/sidebar-elems-background, r=GuillaumeGomez
...
rustdoc: remove redundant mobile CSS `.sidebar-elems { background }`
The exact same background is already set for its parent, the `nav.sidebar`.
2022-11-04 06:40:31 +01:00
Matthias Krüger
6e582cadc3
Rollup merge of #103892 - compiler-errors:afit-rustdoc, r=GuillaumeGomez
...
Properly render asyncness for trait fns without default body
We weren't properly desugaring async fns in traits unless they had default bodies (in which case rustdoc treats them much like they came from an impl).
cc ```@yoshuawuyts``` should help with https://rust-lang.zulipchat.com/#narrow/stream/330606-wg-async.2Fasync-fn-in-trait-impl/topic/type.20inside.20.60async.20fn.60.20body.20must.20be.20known.20in.20this.20context/near/306894869
2022-11-04 06:40:31 +01:00
Matthias Krüger
14fdfcb38c
Rollup merge of #103884 - spastorino:visit-fn-ret-ty-intravisit, r=compiler-errors
...
Add visit_fn_ret_ty to hir intravisit
I'm working on some RPITIT changes and I need to specialize `visit_fn_ret_ty` in my visitor impl. So I guess it's better to land it separately.
r? `@compiler-errors`
2022-11-04 06:40:31 +01:00
Matthias Krüger
a5efeb3ea7
Rollup merge of #103825 - Mark-Simulacrum:fix-relnotes, r=pietroalbini
...
Remove let_underscore_must_use from list of uplifted lints
Per https://internals.rust-lang.org/t/rust-1-65-0-pre-release-testing/17660/2
We probably won't backport this (not worth rebuilding stable artifacts over it) but still should be fixed.
2022-11-04 06:40:30 +01:00
Jhonny Bill Mena
540c3f94d7
UPDATE - accept dyn error and make Box<dyn error> conform to IntoDiagnosticArg
2022-11-04 01:17:03 -04:00
Jhonny Bill Mena
28491a7b36
UPDATE - address PR Comments
...
FIX - StrippingDebugInfoFailed typo
DELETE - unneeded FIXME comment
UPDATE - only declare the error with ExtractBundledLibsError as an enum and use the Diagnostic derive macro
2022-11-04 01:17:03 -04:00
Jhonny Bill Mena
2678765d08
FIX - Migrate missing errors in link.rs
2022-11-04 01:17:02 -04:00
Jhonny Bill Mena
1f4c5a624f
ADD - ExtractBundledLibsError. Migrated extract_bundled_libs to translatable diagnostics
2022-11-04 01:17:02 -04:00
Jhonny Bill Mena
4c80f50fc6
UPDATE - Complete link.rs migration to new diagnostics infraestructure
2022-11-04 01:17:02 -04:00
Takayuki Maeda
97ddc6343a
remove unused argument from throw_unresolved_import_error
2022-11-04 13:59:04 +09:00
bors
15d7556de9
Auto merge of #102928 - notriddle:notriddle/rustdoc-thin-vec, r=GuillaumeGomez
...
rustdoc: use ThinVec for cleaned generics
Depends on https://github.com/Gankra/thin-vec/pull/38
2022-11-04 03:32:18 +00:00
Gary Guo
1013ee8df5
Fix ICE when negative impl is collected during eager mono
2022-11-04 03:08:28 +00:00
yukang
1e25882944
fix #102806 , suggest use .. to fill in the rest of the fields of Struct
2022-11-04 10:35:36 +08:00
bors
6718ea1cff
Auto merge of #101834 - compiler-errors:super-deduce-closure-sig, r=lcnr
...
Elaborate supertrait obligations when deducing closure signatures
We elaborate the supertrait obligations of any registered predicates for a closure to see if we can infer a closure signature.
This is not as general of a fix as it *could* be, since we just elaborate supertrait bounds instead of doing a theoretical walk of _all_ registered predicates that might cause us to deduce `Fn` trait information for a closure infer var. I don't even know how to come up with an example that fails here but would work with a more general system.
Fixes #23012
Also fixes the existing compile failure in #57611
r? `@ghost` for now until I do a perf run
cc `@nikomatsakis` since you commented on https://github.com/rust-lang/rust/issues/23012#issuecomment-1152397290
2022-11-04 00:51:37 +00:00
Cameron Steffen
e7bae89a3c
Cleanup bind_pattern args
2022-11-03 19:33:59 -05:00
bors
215e3cd218
Auto merge of #103922 - Mark-Simulacrum:revert-cargo, r=Mark-Simulacrum
...
Revert "Update cargo"
This reverts commit 331aa45093
.
This Cargo upgrade introduced a regression into dependency resolution, so reverting the upgrade until we can fix that.
cc https://github.com/rust-lang/rust/pull/103860 ,
https://rust-lang.zulipchat.com/#narrow/stream/247081-t-compiler.2Fperformance/topic/cargo.20and.20rustc.20benchmarks.20broken
2022-11-03 21:37:05 +00:00
Douwe Schulte
f65cb6868d
Fixed typos
...
Fixed a typo that has been found on two locations in comments.
2022-11-03 21:19:02 +00:00
Michael Howell
c51c07d30f
rustdoc: remove no-op CSS #main-content > .item-info { margin-top: 0 }
...
When this line was added in 04b4c40682
, it
overrode a negative `margin-top` that was set on it by default.
04b4c40682/src/librustdoc/html/static/rustdoc.css (L500-L516)
That negative top margin was removed in
593d6d1cb1
.
2022-11-03 13:22:54 -07:00
Michael Howell
f097940da8
rustdoc: clean up hardcoded CSS border color on search results
...
Hardcoded colors in rustdoc.css should usually be avoided.
2022-11-03 12:29:17 -07:00
Charles Lew
a777c46dff
Use derive(Subdiagnostic)
for ChangeFieldsToBeOfUnitType
.
2022-11-04 03:02:09 +08:00
Boxy
3583f2758b
Cleanups
2022-11-03 18:52:16 +00:00
Guillaume Gomez
df326946ed
Remove rustdoc clean::Visibility type
2022-11-03 18:15:24 +01:00
Deadbeef
35b16d01ce
Move some tests from src/test/ui
to more reasonable places
2022-11-03 16:26:43 +00:00
Michael Goulet
bc3516d474
reverse obligations for better diagnostics on multiple conflicting fn bounds
2022-11-03 15:52:39 +00:00
Michael Goulet
caa701e3c1
Elaborate supertrait obligations when deducing closure signature
2022-11-03 15:52:38 +00:00