mikros/rust
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
2,817 Commits 2 Branches 0 Tags 1.4 GiB
56c6d73d82
Commit Graph

1113 Commits

Author SHA1 Message Date
Seiichi Uchida
56c6d73d82 Reorder modules 
Add `reorder_modules` config option.

Two things we must keep in mind when reordering modules:
1. We should not reorder modules with attributes, as doing so could
   potentially break the code (e.g. `#[macro_use]`).
2. We should not reorder inline modules e.g. `mod foo { /* .. */ }`.
   We should only reorder module declarations e.g. `mod foo;`.

Some open questions:
1. Should we bring modules with `pub` in front of those without `pub`
   so that they stand out from others?
2. Instead of keeping modules with attributes in the same place,
   can we bring them in front of others? Is this safe?
 2018-01-29 21:59:15 +09:00
Seiichi Uchida
298f29a57d Do not panic when special macros have less args than expected 2018-01-18 00:50:16 +09:00
Nick Cameron
74a957e80f
Merge pull request #2357 from topecongiro/issue-2342 
Put attributes and struct fields on different line by default
 2018-01-12 17:32:55 +13:00
Nick Cameron
b356fc06f7
Merge pull request #2352 from topecongiro/issue-2337 
Break after colon if static item does not fit in a single line
 2018-01-12 17:31:12 +13:00
Nick Cameron
09e44b22f2
Merge pull request #2351 from topecongiro/issue-2256 
Use correct BytePos when recovering comments on removed import
 2018-01-12 17:30:27 +13:00
Nick Cameron
be0000380b
Merge pull request #2350 from topecongiro/issue-2324 
Issue 2324
 2018-01-12 17:27:45 +13:00
David Alber
9f5f9d2250 Consolidating the logic for printing output 2018-01-11 08:02:57 -08:00
Seiichi Uchida
6e05ca87b0 Add a test for #2343 and update tests 2018-01-11 16:53:13 +09:00
Seiichi Uchida
279acda4c4 Remove same_line_attributes config option 2018-01-11 16:52:28 +09:00
Seiichi Uchida
eaab51db2e Break after colon if static item does not fit in a single line 2018-01-10 23:23:42 +09:00
Seiichi Uchida
1e7ff38c2d Add a test for #2256 2018-01-10 21:30:13 +09:00
Seiichi Uchida
727f7b08f2 Fix error message printing wrong file names 
The error messsages from `self_test` does not display correct file names
(it just prints `src/lib.rs` for every file). This commit fixes it.
 2018-01-10 17:17:18 +09:00
Seiichi Uchida
60256b7f3d Add a test for #2324 2018-01-10 17:14:50 +09:00
David Alber
873abf01b5 Modifying failure messages to be consistent with mismatch message 2018-01-09 08:36:24 -08:00
David Alber
85ccb98469 Adding test to verify code block idempotency in Configurations.md 2018-01-04 00:01:18 -08:00
Nick Cameron
91a332483b
Merge pull request #2316 from topecongiro/issue-2315 
Remove trailing comma from extern items snippet before comparing
 2018-01-04 17:49:47 +13:00
topecongiro
75cb236711 Compare extern crate items with its name instead of span 
When we use span, bugs easily sneak in.
 2018-01-04 12:49:37 +09:00
topecongiro
19d6a3c786 Put the opening brace of impl on the next line 
We put the opening brace on the next line if the following conditions hold:

1. the result before '{' ends with comments or contains newline
2. the last line of the result before '{' is not extendable (i.e. consists of
   '>' and whitespaces).
 2018-01-04 12:46:55 +09:00
topecongiro
a6d609b45e Add and update tests for #2320 and #2331 2018-01-04 12:46:05 +09:00
Nick Cameron
0f24bc0d44
Merge pull request #2330 from topecongiro/issue-2329 
Issue 2329
 2018-01-04 15:07:05 +13:00
Nick Cameron
9368de276c
Merge pull request #2327 from nrc/macro-defs 
Some macros 2.0 macro defs
 2018-01-04 14:02:37 +13:00
Nick Cameron
e52b383a57
Merge pull request #2306 from dtwood/assert-eq-on-one-line 
Add assert_eq! to special-cased macros
 2018-01-04 13:42:24 +13:00
Nick Cameron
aa758d671f Better handling of comments in macro defs 2018-01-03 20:36:52 +13:00
topecongiro
7c9686f349 Add a test for #2329 2018-01-02 13:04:26 +09:00
Nick Cameron
47d9ccd6a1 Tests for formatting macro 2.0 defs 2018-01-01 19:51:54 +13:00
David Alber
8b4e9df915 Updating error message 2017-12-28 10:29:48 -08:00
David Alber
aa70bbe377 Moving test files to satisfy verify_config_test_names test 2017-12-28 10:29:48 -08:00
David Alber
72dc52ec2c Testing that config option tests use the expected config option 2017-12-28 10:29:48 -08:00
David Alber
6939e21f43 Moving config option tests to subdirectory 
This was done by running the following.

```sh
for f in `find . -name "configs-*.rs"`; do
    topdir=`echo $f | cut -d/ -f2`;
    configname=`echo $f | cut -d/ -f3 | cut -d- -f2`;
    testname=`echo $f | cut -d/ -f3 | cut -d- -f3`;
    mkdir -p $topdir/configs/$configname;
    git mv $f $topdir/configs/$configname/$testname;
done
```
 2017-12-28 10:29:48 -08:00
David Alber
8fb3342ca2 Renaming tests to match existing convention 2017-12-28 10:29:48 -08:00
David Alber
6a583399ff Renaming test to match existing convention 2017-12-28 10:29:48 -08:00
David Wood
39e2f43f91 Split assert_eq! if any arguments are not simple 2017-12-27 21:19:42 +00:00
Seiichi Uchida
5160b49e67
Merge pull request #2308 from davidalber/recursive-test-files 
Adding ability to recursively find test files
 2017-12-27 19:16:01 +09:00
Nick Cameron
9feb4988f2
Merge pull request #2310 from topecongiro/issue-2309 
Do not give up rewriting struct field when attribute is long
 2017-12-27 14:12:45 +13:00
Nick Cameron
a6244c2f58
Merge pull request #2311 from topecongiro/format-code-block 
Format code block in comment
 2017-12-27 13:32:14 +13:00
David Alber
65a48da02d Updating error message 2017-12-24 13:31:46 -08:00
Seiichi Uchida
4604fea0a0 Refactoring 
1. Cargo clippy
2. Run 'cargo fmt' with import reordering options set to `true`.
3. Factor out `rewrite_lifetime_param()`.
 2017-12-25 00:13:59 +09:00
Seiichi Uchida
27167cbbaa Format code block in comment 
Closes #554.
Closes #1695.
 2017-12-24 23:56:51 +09:00
Seiichi Uchida
f523ec58ab Do not give up rewriting struct field when attribute is long 2017-12-24 13:57:29 +09:00
David Alber
9405e05d83 Adding ability to recursively find test files 
Part of #1492.
 2017-12-23 11:40:37 -08:00
David Wood
ef8b2efd13 Fix off-by-one error in assert_eq! line wrapping 
If two really long conditions are checked for equality, they wouldn't be split
into multiple lines if the last condition is the one to push the line past the
width limit.

Fix the off-by-one error that caused this, and add a test-case for it.
 2017-12-23 01:32:55 +00:00
David Wood
e343521276 Add assert_eq! to special-cased macros 
Allows for this form of assert_eq! macros:
```rust
assert_eq!(
    left.id, right.id,
    "IDs are not equal: {:?} {:?}",
    left, right
);
```

Also allows for assert! macros to have the format arguments split across
multiple lines even if the assert condition is not simple:
```rust
assert!(
    result >= 42,
    "The result must be at least 42: {:?}",
    result, result.code, context
);
```
 2017-12-23 01:06:17 +00:00
topecongiro
984ac100a4 Fix indent width bug when recovering comments 
Using last_line_width() ignores the width of tab character ('\t').
 2017-12-22 12:05:36 +09:00
Nick Cameron
baa0dad582
Merge pull request #2288 from davidalber/fix-2078 
Reporting test parse errors as test failures
 2017-12-22 15:44:19 +13:00
Nick Cameron
723b938057
Merge pull request #2291 from topecongiro/issue-2289 
Take the width of block's prefix into account only once
 2017-12-22 12:58:02 +13:00
topecongiro
1d8619d49a Fix wrong indentation on type alias 
Use rewrite_assign_rhs() when rewriting type alias.
 2017-12-21 09:58:13 +09:00
topecongiro
366ff40ae7 Take the width of block's prefix into account only once 2017-12-20 15:44:11 +09:00
David Alber
fa0a63989e Using if let to be more concise 2017-12-18 01:03:12 -08:00
David Alber
54067a7466 Reporting test parse errors as test failures 
Fixes 2078.
 2017-12-17 16:50:09 -08:00
Seiichi Uchida
366621eb46 Add a test for #2123 and update tests 2017-12-17 15:23:17 +09:00