Samuel Moelius
4dbd8ad34e
Address https://github.com/rust-lang/rust/pull/105659
2022-12-20 05:30:12 -05:00
Samuel Moelius
c7dc961558
Address review comments
2022-12-20 05:12:13 -05:00
Samuel Moelius
26df55112f
Fix adjacent code
2022-12-20 05:12:13 -05:00
Samuel Moelius
ed519ad746
Improve possible_borrower
2022-12-20 05:12:13 -05:00
Samuel Moelius
cd3d38aa27
Use rustc_mir_dataflow::impls::MaybeStorageLive
2022-12-20 05:12:13 -05:00
Niki4tap
3cc67d0856
Relax clippy_utils::consts::miri_to_const pointer type restrictiveness
2022-12-18 03:02:45 +03:00
Philipp Krones
1c422524c7
Merge commit '4bdfb0741dbcecd5279a2635c3280726db0604b5' into clippyup
2022-12-17 14:12:54 +01:00
Philipp Krones
1f1d23cf51
Bump Clippy version -> 0.1.68
2022-12-17 13:57:41 +01:00
Philipp Krones
d6488ae144
Merge remote-tracking branch 'upstream/master' into rustup
2022-12-17 13:56:32 +01:00
Matthias Krüger
cfe1e040e7
Rollup merge of #105743 - nnethercote:SimplifiedType-cleanups, r=lcnr
...
`SimplifiedType` cleanups
r? `@lcnr`
2022-12-15 22:03:01 +01:00
Gary Guo
7574c98371
Fix new_return_no_self with recursive bounds
2022-12-15 18:56:13 +00:00
Nicholas Nethercote
e723fc4f56
Merge SimplifiedTypeGen<D>
into SimplifiedType
.
...
`SimplifiedTypeGen<DefId>` is the only instantiation used, so we don't
need the generic parameter.
2022-12-15 15:13:19 +11:00
Oli Scherer
65069d5c5b
Ensure no one constructs AliasTy
s themselves
2022-12-14 15:36:39 +00:00
Michael Goulet
957ab6ae52
Combine projection and opaque into alias
2022-12-13 17:48:55 +00:00
Michael Goulet
89b8840543
squash OpaqueTy and ProjectionTy into AliasTy
2022-12-13 17:40:27 +00:00
Michael Goulet
a274e7e9a2
ProjectionTy.item_def_id -> ProjectionTy.def_id
2022-12-13 17:34:44 +00:00
Michael Goulet
ad55e4c972
Use ty::OpaqueTy everywhere
2022-12-13 17:29:26 +00:00
bors
17a092f467
Auto merge of #105160 - nnethercote:rm-Lit-token_lit, r=petrochenkov
...
Remove `token::Lit` from `ast::MetaItemLit`.
Currently `ast::MetaItemLit` represents the literal kind twice. This PR removes that redundancy. Best reviewed one commit at a time.
r? `@petrochenkov`
2022-12-12 05:16:50 +00:00
koka
055f349670
Avoid match_wildcard_for_single_variants
on guarded wild matches
...
fix #9993
changlog: [`match_wildcard_for_single_variants`] avoid suggestion on wildcard with guard
2022-12-10 21:05:08 +09:00
Taiki Endo
e5010c996e
uninlined_format_args: Ignore assert! and debug_assert! before 2021 edition
2022-12-10 18:35:24 +09:00
Jakob Degen
dc50bb0961
Remove unneeded field from SwitchTargets
2022-12-09 04:53:10 -08:00
Alex Macleod
591c18d2f0
Add 1.58 MSRV for collapsible_str_replace
2022-12-07 17:45:12 +00:00
Samuel Tardieu
fa4288af1f
Add missing slash to produce function documentation
2022-12-02 16:26:15 +01:00
bors
a1d22808af
Auto merge of #104963 - petrochenkov:noaddids2, r=cjgillot
...
rustc_ast_lowering: Stop lowering imports into multiple items
Lower them into a single item with multiple resolutions instead.
This also allows to remove additional `NodId`s and `DefId`s related to those additional items.
2022-12-02 04:24:57 +00:00
Nicholas Nethercote
6481d37bb9
Add StrStyle
to ast::LitKind::ByteStr
.
...
This is required to distinguish between cooked and raw byte string
literals in an `ast::LitKind`, without referring to an adjacent
`token::Lit`. It's a prerequisite for the next commit.
2022-12-02 10:38:58 +11:00
bors
e16a8b93ba
Auto merge of #10008 - Jarcho:issue_9882, r=Manishearth
...
Treat custom enum discriminant values as constants
fixes #9882
changelog: All lints: Don't lint in enum discriminant values when the suggestion won't work in a const context
2022-12-01 22:37:15 +00:00
Philipp Krones
d05e2865a0
Merge commit 'd822110d3b5625b9dc80ccc442e06fc3cc851d76' into clippyup
2022-12-01 18:29:38 +01:00
Vadim Petrochenkov
b0d490e308
rustc_ast_lowering: Stop lowering imports into multiple items
...
Lower them into a single item with multiple resolutions instead.
This also allows to remove additional `NodId`s and `DefId`s related to those additional items.
2022-12-01 18:51:20 +03:00
Vadim Petrochenkov
4f8c49e950
rustc_hir: Relax lifetime requirements on Visitor::visit_path
2022-12-01 17:04:02 +03:00
Philipp Krones
11434f270f
Merge remote-tracking branch 'upstream/master' into rustup
2022-12-01 12:55:15 +01:00
Jason Newcomb
a1b15f13f7
Treat custom enum discriminant values as constants
2022-11-30 22:34:42 -05:00
Jason Newcomb
e0eba9cafc
Don't cross contexts while building the suggestion for redundant_closure_call
2022-11-30 10:53:27 -05:00
Michael Goulet
a61e2a91f5
FnCtxt normalization stuff
2022-11-28 17:35:39 +00:00
Michael Goulet
82c07f09e5
partially_normalize_... -> At::normalize
2022-11-28 17:35:39 +00:00
bors
696ea0627d
Auto merge of #104048 - cjgillot:split-lifetime, r=compiler-errors
...
Separate lifetime ident from lifetime resolution in HIR
Drive-by: change how suggested generic args are computed.
Fixes https://github.com/rust-lang/rust/issues/103815
I recommend reviewing commit-by-commit.
2022-11-27 14:30:19 +00:00
Alex Macleod
461e219d1d
Allow using clippy::msrv
as an outer attribute
2022-11-27 12:43:17 +00:00
bors
8b2f7e3b52
Auto merge of #104846 - spastorino:santa-clauses-make-goals-early-christmas- 🎄 , r=oli-obk
...
Branch Clause from Predicate
r? `@oli-obk`
This is part of what's proposed in https://github.com/rust-lang/compiler-team/issues/531
2022-11-25 15:59:31 +00:00
kraktus
2fd10bc59b
dogfood with expanded uninlined_format_args
2022-11-25 16:49:05 +01:00
Matthias Krüger
268d230231
Rollup merge of #104873 - RalfJung:therefore, r=Dylan-DPC
...
RefCell::get_mut: fix typo
and fix the same typo in a bunch of other places
2022-11-25 10:44:40 +01:00
Lukas Wirth
4fa5757530
Lint unnecessary safety comments on statements and block tail expressions
2022-11-25 10:09:34 +01:00
Ralf Jung
424ae23958
RefCell::get_mut: fix typo
...
and fix the same typo in a bunch of other places
2022-11-25 08:52:06 +01:00
Santiago Pastorino
3f059a49a4
Introduce PredicateKind::Clause
2022-11-25 00:04:54 -03:00
Matthias Krüger
ac6a77ed95
Rollup merge of #104742 - WaffleLapkin:forbidden-SUPER-deref, r=compiler-errors
...
Make `deref_into_dyn_supertrait` lint the impl and not the usage
Proposed by ``@compiler-errors`` in https://github.com/rust-lang/rust/issues/89460#issuecomment-1320806785
r? ``@crlf0710``
2022-11-24 08:42:34 +01:00
Esteban Küber
2a530dce53
Fix clippy code
2022-11-23 12:17:47 -08:00
Camille GILLOT
93cfcedfd5
Separate lifetime ident from resolution in HIR.
2022-11-23 19:33:06 +00:00
Maybe Waffle
284ce9ed0d
Move get_associated_type
from clippy
to rustc_lint
2022-11-23 15:40:27 +00:00
Manish Goregaokar
91d2ce3020
Rollup merge of #103488 - oli-obk:impl_trait_for_tait, r=lcnr
...
Allow opaque types in trait impl headers and rely on coherence to reject unsound cases
r? ````@lcnr````
fixes #99840
2022-11-22 22:54:38 -05:00
bors
69c5128cda
Auto merge of #9924 - Alexendoo:msrv-stack, r=Jarcho
...
Add `clippy_utils::msrv::Msrv` to keep track of the current MSRV
changelog: Fix the scoping of the `#![clippy::msrv]` attribute
Fixes #6920
r? `@Jarcho`
2022-11-22 20:09:58 +00:00
bors
5595d7f5d5
Auto merge of #9750 - kraktus:lazy_eval, r=xFrednet
...
Fix [`unnecessary_lazy_eval`] when type has significant drop
fix for https://github.com/rust-lang/rust-clippy/issues/9427#issuecomment-1295742590
However current implementation gives too many false positive, rending the lint almost useless.
I don't know what's the best way to check if a type has a "significant" drop (in the common meaning, not the internal rustc one, for example Option<(u8, u8)> should not be considered significant)
changelog: Fix [`unnecessary_lazy_eval`] when type has significant drop
2022-11-22 17:21:23 +00:00
bors
b33afd61ed
Auto merge of #104688 - flip1995:clippyup, r=Manishearth,flip1995
...
Update Clippy
r? `@Manishearth`
Sorry for taking so long. There were so many blockers and so little time. This situation should be mitigated with #104007 in the future.
2022-11-22 17:09:06 +00:00