Commit Graph

299 Commits

Author SHA1 Message Date
Manish Goregaokar
6ff1e9a766 Merge pull request #143 from birkenfeld/more_methods
methods: move misc.StrToStringPass to MethodsPass
2015-08-12 17:32:16 +05:30
llogiq
fc6dfafc30 fixed if-condition match 2015-08-12 14:02:13 +02:00
Georg Brandl
225969e8a3 methods: move misc.StrToStringPass to MethodsPass 2015-08-12 13:58:55 +02:00
llogiq
a7527adf08 First (incomplete) const folding 2015-08-12 13:49:28 +02:00
Georg Brandl
e8fed074cf new lint: warn if let-binding has unit value (fixes #74) 2015-08-12 13:21:07 +02:00
Manish Goregaokar
8bcd01ff47 Bump to 0.0.11 2015-08-12 15:20:18 +05:30
Manish Goregaokar
ca3b4330f1 Use snippet, pprust methods expand AST 2015-08-12 15:19:57 +05:30
Manish Goregaokar
0481d04d6f Merge pull request #137 from birkenfeld/collapsible_if_fix
collapsible_if: do not show Debug display of expression
2015-08-12 15:06:24 +05:30
Manish Goregaokar
85499f31a7 Merge pull request #136 from birkenfeld/len_zero_expr
len_zero: display full suggested expr in message
2015-08-12 15:03:21 +05:30
Manish Goregaokar
640c3ff8aa Merge pull request #135 from birkenfeld/consistent_msgs
all: make style of lint messages consistent
2015-08-12 14:47:24 +05:30
Georg Brandl
7b3299e009 collapsible_if: do not show Debug display of expression
Instead, pretty-print the inner block and use the same style as for
the "single match => if let" lint.
2015-08-12 11:00:08 +02:00
Georg Brandl
b831bd1d1d len_zero: display full suggested expr in message 2015-08-12 10:53:14 +02:00
Georg Brandl
bcd95aec1c all: make style of lint messages consistent
* start first sentence lowercased
* use backticks to delimit code snippets
* use "this is wrong. Consider doing X." consistently
2015-08-12 10:47:09 +02:00
Manish Goregaokar
2ec933377c Merge pull request #134 from birkenfeld/if_let_chain_macro
utils: implement if_let_chain macro as suggested by isHavvy
2015-08-12 13:07:37 +05:30
Manish Goregaokar
9be32ea7a4 Merge pull request #133 from birkenfeld/readme_fix
README: update lint output
2015-08-12 13:02:09 +05:30
Georg Brandl
2eacb3c146 README: update lint output 2015-08-12 07:52:45 +02:00
Georg Brandl
6d5f9478b2 utils: implement if_let_chain macro as suggested by isHavvy 2015-08-12 07:48:47 +02:00
Manish Goregaokar
854212ce85 Update CONTRIBUTING.md 2015-08-12 03:32:20 +05:30
Manish Goregaokar
7c14b5b67f Merge pull request #132 from birkenfeld/let_and_return
New lint: let and immediately return
2015-08-12 02:27:48 +05:30
Georg Brandl
f6dc48fe3a new lint for "let x = EXPR; x" at the end of functions (fixes #104) 2015-08-11 22:25:47 +02:00
Georg Brandl
02c0cafa14 move NeedlessReturn pass out to its own module and rename to ReturnPass 2015-08-11 22:06:59 +02:00
Manish Goregaokar
1d948705bf Merge pull request #130 from birkenfeld/use_help
types: remove almost duplicate helper function
2015-08-12 01:35:15 +05:30
Manish Goregaokar
20c0c22017 Merge pull request #131 from birkenfeld/readme_update
README: update with recently added lints
2015-08-12 01:34:53 +05:30
Georg Brandl
dfd1f42dd2 README: update with recently added lints 2015-08-11 21:31:04 +02:00
Georg Brandl
4350dab761 types: remove almost duplicate helper function
I guess "help" instead of "note" is fine as well, so we can
get rid of the extra function.
2015-08-11 21:25:51 +02:00
Manish Goregaokar
0d125a298b Merge pull request #129 from birkenfeld/unwrap_lint
Lint for Result/Option.unwrap()
2015-08-12 00:52:03 +05:30
Georg Brandl
2bcc151888 new lint for Option.unwrap() and Result.unwrap()
The latter is set to Allow by default (fixes #24)
2015-08-11 21:19:11 +02:00
Georg Brandl
cf96042c65 move walk_ty() to utils module and rename to walk_ptrs_ty 2015-08-11 21:16:10 +02:00
Manish Goregaokar
6bc69fa342 Merge pull request #127 from birkenfeld/better-helptext-if-let
better help text for "match -> if let" lint
2015-08-12 00:44:51 +05:30
Manish Goregaokar
cadd9bb954 Merge pull request #128 from birkenfeld/whitespace-cleanup
all: whitespace cleanup
2015-08-12 00:36:21 +05:30
Manish Goregaokar
5060e9e685 Bump to 0.0.10 2015-08-12 00:28:46 +05:30
Georg Brandl
e318328d63 all: whitespace cleanup
* 4-space indentation
* no trailing whitespace
* no tabs
2015-08-11 20:22:50 +02:00
Manish Goregaokar
2cb26126d3 Merge branch 'pr-78'
Conflicts:
	src/lib.rs
2015-08-11 23:28:06 +05:30
Manish Goregaokar
efdbfe0d31 nit 2015-08-11 23:11:20 +05:30
Georg Brandl
cab9905705 better help text for "match -> if let" lint
Implements the suggestion from #87.

Changes span_help_and_lint(), which is only used for this lint,
to use fileline_help() instead of span_help() to avoid printing
the span twice.

Also adds complete suggested new code. I had to distinguish
between blocks, which need no additionals braces, and other exprs.
2015-08-11 19:26:51 +02:00
Georg Brandl
0ff476b529 new lint for unneeded return stmts 2015-08-11 19:05:11 +02:00
Georg Brandl
7b074d3ac7 Remove tabs and trailing whitespace from lib and misc. 2015-08-11 17:02:04 +02:00
llogiq
50ebdaa79d Merge pull request #125 from Manishearth/parent
added parent method, also changed match-if-let note to help
2015-08-11 15:27:19 +02:00
llogiq
f0eb36c2af added parent method, also changed match-if-let note to help 2015-08-11 15:07:21 +02:00
Manish Goregaokar
940c713f66 Update CONTRIBUTING.md 2015-08-11 18:35:05 +05:30
Manish Goregaokar
678a79d45a CONTRIBUTING 2015-08-11 18:33:56 +05:30
Manish Goregaokar
228f06a960 Upgrade Rust to rustc 1.4.0-nightly (a5d33d891 2015-08-08) (fixes #123) 2015-08-09 22:16:39 +05:30
llogiq
48a9ed9b33 Merge pull request #122 from Manishearth/strings
New string_add_assign lint
2015-08-07 10:02:34 +02:00
llogiq
27f8fa75e1 whitespace 2015-08-07 09:33:54 +02:00
llogiq
b393752814 New string_add_assign lint (first part of #121), also formatting & refactoring 2015-08-05 15:10:45 +02:00
Manish Goregaokar
6ebb9b1551 Fix crash with idents from different contexts 2015-08-02 20:59:12 +05:30
Manish Goregaokar
de5ccdfab6 Upgrade to rustc 1.3.0-nightly (4d52d7c85 2015-07-30) 2015-07-31 12:00:06 +05:30
Manish Goregaokar
0e8e8cfc9b Basic framework for structured logging 2015-07-27 00:39:09 +05:30
Manish Goregaokar
ac698826d7 Merge pull request #117 from Manishearth/rustup
rustup, also first time clippy was used on itself, which led to a sma…
2015-07-17 00:10:15 +05:30
llogiq
251c5cfffd rustup, also first time clippy was used on itself, which led to a small refactoring 2015-07-16 08:53:02 +02:00