mcarton
|
b8b6b7fee6
|
Try to explain MATCH_SAME_ARMS better
|
2016-07-10 14:46:39 +02:00 |
|
mcarton
|
eb75d4ee62
|
Fix suggestions for NEW_WITHOUT_DEFAULT
|
2016-07-10 14:20:38 +02:00 |
|
mcarton
|
3a7402a6d2
|
Fix FP with for loops and shadowed loop variable
|
2016-07-10 14:05:57 +02:00 |
|
llogiq
|
ad1cd99054
|
Merge pull request #1060 from Manishearth/sugg
Improve suggestions
|
2016-07-10 00:06:30 +02:00 |
|
Martin Pool
|
585a3b2565
|
Fix Markdown syntax in description of collapsible_if
|
2016-07-09 12:20:54 -07:00 |
|
mcarton
|
56d3bc7008
|
Handle /** and ~~~ in DOC_MARKDOWN
|
2016-07-08 18:24:47 +02:00 |
|
David Tolnay
|
33c767c510
|
Add "JavaScript" to doc-valid-idents
|
2016-07-06 21:27:29 -07:00 |
|
mcarton
|
bf513229b1
|
Address PR's comments
|
2016-07-06 15:49:49 +02:00 |
|
mcarton
|
02547b9392
|
Merge remote-tracking branch 'origin/master' into sugg
|
2016-07-06 14:54:10 +02:00 |
|
mcarton
|
3bd0acaa5c
|
Remove useless feature attribute
`iter_arith` has been stabilized in rustc 1.11.0.
|
2016-07-06 14:51:20 +02:00 |
|
mcarton
|
8aaaf198e3
|
Use utils::sugg in methods lints
|
2016-07-05 23:26:47 +02:00 |
|
mcarton
|
c5e91e70d0
|
Use sugg::Sugg in transmute links
|
2016-07-04 02:22:57 +02:00 |
|
mcarton
|
9b79b1022c
|
Fix suggestions for needless_bool
|
2016-07-04 01:43:47 +02:00 |
|
mcarton
|
7778f314f2
|
Merge branch 'master' into sugg
|
2016-07-04 00:51:19 +02:00 |
|
mcarton
|
2f259b8cd3
|
Use span_suggestion in entry lints
|
2016-07-03 23:27:44 +02:00 |
|
mcarton
|
ffa840d4f2
|
Use utils::sugg in match related lints
Also don't build suggestion when unnecessary.
|
2016-07-03 23:27:37 +02:00 |
|
James Lucas
|
10b545e30b
|
Check for constant expression in useless_vec lint
|
2016-07-03 12:12:43 -07:00 |
|
Manish Goregaokar
|
31948c4815
|
Make #991 work with current rust
|
2016-07-03 13:55:23 +05:30 |
|
mcarton
|
0e3dcd1376
|
Improve NOT_UNSAFE_PTR_ARG_DEREF with functions
|
2016-07-03 13:29:04 +05:30 |
|
mcarton
|
7781f1d7c5
|
Add a new not_unsafe_ptr_arg_deref lint
|
2016-07-03 13:28:34 +05:30 |
|
mcarton
|
cc18556ae5
|
Use utils::sugg in swap lints
|
2016-07-02 17:31:22 +02:00 |
|
Martin Carton
|
d243d686fd
|
Merge pull request #1054 from Manishearth/rustup
Rustup to ea0dc92972
|
2016-07-02 16:15:57 +02:00 |
|
Ben Boeckel
|
d35b94349c
|
typo: use commas around "e.g."
|
2016-07-02 07:59:20 -04:00 |
|
mcarton
|
139b977d9d
|
Cleanup
|
2016-07-01 21:01:56 +02:00 |
|
mcarton
|
2a45a2ab6b
|
Use utils::sugg in FOR_KV_MAP
|
2016-07-01 20:55:45 +02:00 |
|
mcarton
|
f6c9490e65
|
Fix wrong suggestion with ... and for loops
|
2016-07-01 19:31:14 +02:00 |
|
mcarton
|
dbf6dc66d8
|
Add more sugggestion-building functions
|
2016-07-01 19:30:38 +02:00 |
|
mcarton
|
9bd7fa05e0
|
Improve NEEDLESS_RANGE_LOOP error reporting
|
2016-07-01 18:53:04 +02:00 |
|
mcarton
|
e613c8b492
|
Introduce multispan_sugg
|
2016-07-01 18:43:42 +02:00 |
|
mcarton
|
97f65b0296
|
Rustup to ea0dc92972 III
|
2016-07-01 17:49:18 +02:00 |
|
mcarton
|
d6182b365c
|
Merge remote-tracking branch 'origin/rustup' into sugg
|
2016-07-01 17:48:57 +02:00 |
|
mcarton
|
55b78ae478
|
Rustup to ea0dc92972 II
|
2016-07-01 17:44:17 +02:00 |
|
mcarton
|
3c4af49662
|
Rustup to ea0dc92972
|
2016-07-01 17:44:17 +02:00 |
|
mcarton
|
28bd591f05
|
Only build suggestion if necessary in USELESS_VEC
|
2016-07-01 17:12:49 +02:00 |
|
mcarton
|
98f18f0474
|
Move vec! unexpanding function to utils::higher
|
2016-07-01 17:12:49 +02:00 |
|
mcarton
|
4dff4df577
|
Move more functions to utils::higher
|
2016-07-01 17:12:49 +02:00 |
|
mcarton
|
92b04129fe
|
Move unsugar_range to utils::higher
|
2016-07-01 17:12:49 +02:00 |
|
mcarton
|
ebf72cb67f
|
Use util::sugg in TRANSMUTE_PTR_TO_REF
|
2016-07-01 17:12:48 +02:00 |
|
mcarton
|
169b63a84a
|
Improve TOPLEVEL_REF_ARG message
|
2016-07-01 17:12:48 +02:00 |
|
mcarton
|
7023988020
|
Use utils::sugg in TOPLEVEL_REF_ARG
|
2016-07-01 17:12:48 +02:00 |
|
mcarton
|
a3c505551f
|
Cleanup
|
2016-07-01 17:12:48 +02:00 |
|
mcarton
|
7a1fc9fce5
|
Use utils::sugg in MATCH_BOOL
|
2016-07-01 17:12:48 +02:00 |
|
mcarton
|
66808c1e77
|
Use utils::sugg in COLLAPSIBLE_IF
|
2016-07-01 17:12:48 +02:00 |
|
mcarton
|
2e8edde6e9
|
Use utils::sugg in FLOAT_CMP
|
2016-07-01 17:12:48 +02:00 |
|
mcarton
|
8d58a928e5
|
Use utils::sugg in ASSIGN_OPS
|
2016-07-01 17:12:48 +02:00 |
|
mcarton
|
9811dea237
|
Add a module to pretty-print suggestions
|
2016-07-01 17:12:48 +02:00 |
|
mcarton
|
580ae5a879
|
Use span_suggestion in FLOAT_CMP
|
2016-07-01 17:12:48 +02:00 |
|
Andre Bogus
|
b73180231a
|
fixed doc nit
|
2016-06-30 06:33:21 +02:00 |
|
Andre Bogus
|
a12e8394d7
|
new lint: double_neg
|
2016-06-30 01:00:25 +02:00 |
|
mcarton
|
ea76ac5562
|
Make COLLAPSIBLE_IF consider if let
|
2016-06-29 17:09:39 +02:00 |
|
mcarton
|
f6ba217c1c
|
Small cleanup
|
2016-06-29 17:09:39 +02:00 |
|
mcarton
|
f37c9adbd9
|
Make CollapsibleIf an EarlyLintPass
It doesn't need any `hir` feature and `ast` is much more stable.
|
2016-06-29 17:09:39 +02:00 |
|
mcarton
|
7fa38f6787
|
Fix FP with mut_mut and for loops
|
2016-06-29 17:09:39 +02:00 |
|
Oliver Schneider
|
9ceb708727
|
Merge pull request #1053 from oli-obk/char_float_transmute
lint on unnecessary and plain wrong transmutes
|
2016-06-28 14:50:39 +02:00 |
|
Oliver Schneider
|
e06bc37477
|
lint on unnecessary and plain wrong transmutes
|
2016-06-28 14:08:08 +02:00 |
|
Manish Goregaokar
|
cdce78a4be
|
Add parentheses when necessary in transmute suggestion (fixes #1049)
|
2016-06-28 14:03:46 +05:30 |
|
llogiq
|
5aea20da7f
|
Merge pull request #1046 from oli-obk/unify_span_lint_usage
use span_lint_and_then instead of adding to the `DiagnosticWrapper`
|
2016-06-27 17:20:03 +02:00 |
|
Oliver Schneider
|
799861d7e0
|
use span_lint_and_then instead of adding to the DiagnosticWrapper
|
2016-06-27 17:14:04 +02:00 |
|
Oliver Schneider
|
a469ee1061
|
lint transmuting references to pointers
|
2016-06-27 16:12:48 +02:00 |
|
Oliver Schneider
|
083c57867a
|
refactor transmute lints into a single match
|
2016-06-27 13:46:21 +02:00 |
|
Oliver 'ker' Schneider
|
8c5e617c9a
|
don't lint on comparing *const f32s
|
2016-06-25 18:59:37 +02:00 |
|
llogiq
|
f81d253c07
|
Merge pull request #995 from oli-obk/oh_the_horror
lint on `filter(x).map(y)`, `filter(x).flat_map(y)`, `filter_map(x).flat_map(y)`
|
2016-06-22 13:06:12 +02:00 |
|
Oliver Schneider
|
262148c946
|
update lint doc text
|
2016-06-22 13:03:59 +02:00 |
|
Oliver Schneider
|
5ccbf3d437
|
unify the lints
|
2016-06-22 10:44:46 +02:00 |
|
Martin Carton
|
294aeaf4b3
|
Merge pull request #1012 from Manishearth/nohyg
Don't use identifier hygiene in HIR
|
2016-06-21 21:23:39 +02:00 |
|
Oliver Schneider
|
415ddfb630
|
lint message nits
|
2016-06-21 14:41:16 +02:00 |
|
Oliver Schneider
|
8bfb31ee97
|
doc nits
|
2016-06-21 14:39:56 +02:00 |
|
Oliver Schneider
|
f5dfcd694b
|
fallout2
|
2016-06-21 13:51:44 +02:00 |
|
Oliver Schneider
|
48a5f8446d
|
fallout
|
2016-06-21 13:49:08 +02:00 |
|
Oliver Schneider
|
77e2155778
|
update lints
|
2016-06-21 13:32:34 +02:00 |
|
Oliver Schneider
|
4e52852146
|
create a lint for each of the messages
|
2016-06-21 13:04:50 +02:00 |
|
Oliver Schneider
|
36c5026c48
|
fix cargo clippy when using with --manifest-path
|
2016-06-21 12:31:30 +02:00 |
|
Oliver Schneider
|
69c796e118
|
lint on filter(x).map(y), filter(x).flat_map(y), filter_map(x).flat_map(y)
|
2016-06-21 12:29:44 +02:00 |
|
Manish Goregaokar
|
5b1d849c7e
|
Revert "fix cargo clippy when using with --manifest-path"
This reverts commit b31bebeea4.
|
2016-06-21 15:24:04 +05:30 |
|
Oliver Schneider
|
b31bebeea4
|
fix cargo clippy when using with --manifest-path
|
2016-06-21 11:35:34 +02:00 |
|
Devon Hollowood
|
0e04153a70
|
Remove uneccessary, leftover comments in lint_iter_mut()
|
2016-06-16 14:51:16 -07:00 |
|
Devon Hollowood
|
cfa0c5782e
|
Extend iter_nth lint to work with iter_mut() and VecDeque
|
2016-06-16 14:46:29 -07:00 |
|
llogiq
|
f3397afacb
|
Merge pull request #994 from oli-obk/stuttter
Stuttter lint
|
2016-06-16 19:00:43 +02:00 |
|
Oliver 'ker' Schneider
|
e628e4d513
|
allow by default
|
2016-06-16 18:37:56 +02:00 |
|
Martin Carton
|
4e8c87ad08
|
Merge pull request #1021 from Manishearth/issue1017
Fix FP with `WHILE_LET_LOOP` and break expressions
|
2016-06-16 16:30:44 +02:00 |
|
mcarton
|
836554387a
|
Fix FP with WHILE_LET_LOOP and break expressions
|
2016-06-16 16:21:11 +02:00 |
|
Oliver Schneider
|
af98a7ce52
|
round 3
|
2016-06-16 12:20:05 +02:00 |
|
Oliver Schneider
|
a976401171
|
round 2
|
2016-06-16 12:20:05 +02:00 |
|
Oliver Schneider
|
4701f13551
|
round 1
|
2016-06-16 12:20:05 +02:00 |
|
Oliver Schneider
|
7253ce73bb
|
only lint public stutter namings
|
2016-06-16 12:17:15 +02:00 |
|
Oliver Schneider
|
8356d2fb21
|
lint items whose name starts/ends with their enclosing module's name
|
2016-06-16 12:17:15 +02:00 |
|
Oliver Schneider
|
32894d503e
|
lint enum variants names that start or end with their enum's name
|
2016-06-16 12:17:15 +02:00 |
|
Oliver Schneider
|
5726216c9b
|
Skip for Chars doesn't help us b/c of the ExactSizeIterator bound
|
2016-06-16 12:17:15 +02:00 |
|
Devon Hollowood
|
74025be59d
|
Make iter_nth work for Vecs too
|
2016-06-16 02:04:32 -07:00 |
|
Devon Hollowood
|
7764dc5ef4
|
Add slice_iter_nth lint
|
2016-06-16 01:36:11 -07:00 |
|
mcarton
|
e6cbe970c8
|
Don't use identifier hygiene in HIR
|
2016-06-15 16:36:22 +02:00 |
|
mcarton
|
350f3a7fe5
|
Rustup to *1.11.0-nightly (7d2f75a95 2016-06-09)*
|
2016-06-10 20:08:55 +02:00 |
|
Martin Carton
|
f9b3aebfdf
|
Merge pull request #1000 from Manishearth/doc_whitelist
added GPLv{2,3} to doc-valid-idents
|
2016-06-10 00:44:52 +02:00 |
|
mcarton
|
dd99a88289
|
Dogfood inside if_let_chain!
|
2016-06-10 00:09:17 +02:00 |
|
mcarton
|
489576437d
|
Cleanup dependencies and features
|
2016-06-10 00:09:17 +02:00 |
|
mcarton
|
d85b8062e3
|
Format all if_let_chain consistently
|
2016-06-10 00:09:17 +02:00 |
|
mcarton
|
44cb6106a7
|
Cleanup trailing space
|
2016-06-10 00:08:14 +02:00 |
|
mcarton
|
90453fd893
|
Run rustfmt
Only partially apply suggestions.
|
2016-06-10 00:08:14 +02:00 |
|
mcarton
|
cca6eb2e2b
|
Cleanup
|
2016-06-10 00:08:14 +02:00 |
|
Andre Bogus
|
8756ae5082
|
added GPLv{2,3} to doc-valid-idents
|
2016-06-10 00:06:50 +02:00 |
|
llogiq
|
e6832317fa
|
Merge pull request #999 from Manishearth/whitelist
Some small fixes
|
2016-06-10 00:04:50 +02:00 |
|
mcarton
|
e9360f7675
|
Fix suggestions for REVERSE_RANGE_LOOP
|
2016-06-09 23:34:19 +02:00 |
|
mcarton
|
3ae39145fc
|
Fix false-positive in LET_AND_RETURN
If the declaration has a type, it might be required for coercion to
happen.
|
2016-06-09 23:34:16 +02:00 |
|
mcarton
|
ce2b96abe9
|
Fix yet another FP in USELESS_LET_IF_SEQ
The block expression before the assignment must be `None`.
|
2016-06-09 23:33:38 +02:00 |
|
mcarton
|
c5affa2efc
|
Whitelist Nan in DOC_MARKDOWN
|
2016-06-09 23:33:28 +02:00 |
|
Carol (Nichols || Goulding)
|
8e1dc0481c
|
Include consts in the approx_consts lint for easier copypasting
If you try to use `f64::PI`, it won't work-- you need to use
`f64::consts::PI`, so suggest that in the lint message.
|
2016-06-08 19:58:29 -04:00 |
|
mcarton
|
3415a18feb
|
Rustup to *1.11.0-nightly (763f9234b 2016-06-06)*
|
2016-06-08 12:21:50 +02:00 |
|
mcarton
|
dd3fd41a03
|
Use span_suggestion for WHILE_LET_ON_ITERATOR
|
2016-06-07 18:32:40 +02:00 |
|
mcarton
|
3df32cc723
|
Fix span in REVERSE_RANGE_LOOP’s suggestion
|
2016-06-07 17:58:52 +02:00 |
|
mcarton
|
5b09501d61
|
Fix typo in REVERSE_RANGE_LOOP’s suggestion
|
2016-06-07 17:49:13 +02:00 |
|
Oliver Schneider
|
a3f7fea36c
|
simply parse unknown json-strings as strings instead of erroring
|
2016-06-06 11:03:15 +02:00 |
|
mcarton
|
a7a6c0461d
|
Add environment variable to deactivate wiki links
|
2016-06-05 22:03:02 +02:00 |
|
mcarton
|
158183adf5
|
Fix false-positive in USELESS_LET_IF_SEQ
|
2016-06-05 21:46:48 +02:00 |
|
mcarton
|
7bc7c675f2
|
Cleanup, use matches! some more
|
2016-06-05 20:46:42 +02:00 |
|
mcarton
|
7211df5a17
|
Remove useless if_let_chain
|
2016-06-05 20:46:27 +02:00 |
|
mcarton
|
9f70d04000
|
Fix wrong suggestion with MANUAL_SWAP and slices
|
2016-06-05 20:19:00 +02:00 |
|
mcarton
|
bdd6d2c35e
|
Fix wrong suggestion in MANUAL_SWAP
|
2016-06-05 15:47:57 +02:00 |
|
llogiq
|
66c03f980e
|
Merge pull request #962 from Manishearth/fix-doc
Fix DOC_MARKDOWN and multiline links and quotes
|
2016-06-04 09:24:39 +02:00 |
|
mcarton
|
5c2a10d703
|
Correctly check for variable use in useless_let_if_seq
|
2016-06-03 19:35:39 +02:00 |
|
Manish Goregaokar
|
bf4ce86e9e
|
Make new_without_default ignore const fns; fixes #977
|
2016-06-03 20:17:39 +05:30 |
|
Oliver Schneider
|
7bb8ba4631
|
process more kinds of metadata
|
2016-06-02 17:29:25 +02:00 |
|
Andre Bogus
|
49982036fc
|
only lint new_without_default for public items
This fixes #953.
|
2016-06-01 23:35:14 +02:00 |
|
Andre Bogus
|
2811dd64ec
|
added missing PatKind::Path + tests
|
2016-05-31 23:35:42 +02:00 |
|
Andre Bogus
|
e18dc948c7
|
another one. Somehow I failed to correctly commit
|
2016-05-31 23:30:49 +02:00 |
|
Andre Bogus
|
46491443ff
|
dogfood error in consts fixed
|
2016-05-31 23:30:49 +02:00 |
|
Andre Bogus
|
6aa37e57a2
|
s/PatKind::Ident/PatKind::Binding/g
|
2016-05-31 23:30:49 +02:00 |
|
Oliver Schneider
|
80e81d351d
|
add version check to the unit tests
|
2016-05-30 12:47:04 +02:00 |
|
mcarton
|
42879bcdcb
|
Add a USELESS_LET_IF_SEQ lint
|
2016-05-29 12:19:12 +02:00 |
|
mcarton
|
a892a96eeb
|
Rustup to *1.10.0-nightly (7bddce693 2016-05-27)*
|
2016-05-28 16:35:38 +02:00 |
|
mcarton
|
97c9930a3f
|
Fix doc_markdown and multiline quotes and links
|
2016-05-28 03:22:55 +02:00 |
|
mcarton
|
ac0bb4126c
|
Improve markdown parsing for the doc lint
|
2016-05-28 02:08:01 +02:00 |
|
Oliver Schneider
|
bf227f4729
|
split clippy into lints, plugin and cargo-clippy
|
2016-05-27 13:03:58 +02:00 |
|