Kevin Reid
0f5338cd90
For restriction lints, replace “Why is this bad?” with “Why restrict this?”
...
The `restriction` group contains many lints which are not about
necessarily “bad” things, but style choices — perhaps even style choices
which contradict conventional Rust style — or are otherwise very
situational. This results in silly wording like “Why is this bad?
It isn't, but ...”, which I’ve seen confuse a newcomer at least once.
To improve this situation, this commit replaces the “Why is this bad?”
section heading with “Why restrict this?”, for most, but not all,
restriction lints. I left alone the ones whose placement in the
restriction group is more incidental.
In order to make this make sense, I had to remove the “It isn't, but”
texts from the contents of the sections. Sometimes further changes
were needed, or there were obvious fixes to make, and I went ahead
and made those changes without attempting to split them into another
commit, even though many of them are not strictly necessary for the
“Why restrict this?” project.
2024-05-23 15:51:33 -07:00
y21
91f514cc83
fix fallout from previous commit
2024-04-01 15:04:45 +02:00
Alex Macleod
bee4111a61
Remove clippy_utils::get_parent_node
2024-02-25 16:35:17 +00:00
Philipp Krones
dc0bb69e66
Merge remote-tracking branch 'upstream/master' into rustup
2024-02-22 15:59:29 +01:00
Philipp Krones
c9a43b18f1
Merge commit 'f0cdee4a3f094416189261481eae374b76792af1' into clippy-subtree-sync
2023-12-01 18:21:58 +01:00
Alex Macleod
7093444bfa
Use absolute path for declare_tool_lint in declare_clippy_lint
2023-11-25 17:45:27 +00:00
Philipp Krones
77c1e3aaa1
Merge commit '09ac14c901abc43bd0d617ae4a44e8a4fed98d9c' into clippyup
2023-11-02 17:35:56 +01:00
Philipp Krones
62a82b361c
Format let-chains across the code base
...
In the updated nightly version, it seems that rustfmt now supports formatting
let-chains. Since we're using them a lot, it's a lot of reformatting.
2023-11-02 17:24:30 +01:00
Alex Macleod
7347c1803f
Set existing doc-tests to no_run
2023-10-23 15:28:26 +00:00
Philipp Krones
d6d530fd0b
Merge commit 'd9c24d1b1ee61f276e550b967409c9f155eac4e3' into clippyup
2023-07-17 10:22:32 +02:00
Alex Macleod
2811effe34
Add imports_granularity = "Module" to rustfmt.toml
2023-07-13 12:44:57 +00:00
Philipp Krones
cb3ecf7b79
Merge commit '37f4c1725d3fd7e9c3ffd8783246bc5589debc53' into clippyup
2023-07-02 14:59:02 +02:00
Philipp Krones
8010c3462d
Merge remote-tracking branch 'upstream/master' into rustup
2023-06-30 16:09:06 +02:00
Catherine
a5ae9044fb
make note less verbose
2023-06-25 04:28:40 -05:00
Catherine
b6f194b48c
move to drop_forget_ref
2023-06-21 15:56:24 -05:00
Urgau
f47e9156a4
Drop uplifted clippy::undropped_manually_drops
2023-06-08 11:41:34 +02:00
Urgau
915ff71b7c
Rename forget_ref lint to forgetting_references
2023-05-21 14:28:09 +02:00
Urgau
fdbfe0e249
Rename drop_ref lint to dropping_references
2023-05-21 14:16:41 +02:00
Urgau
234f2b67cb
Rename forget_copy lint to forgetting_copy_types
2023-05-21 14:09:03 +02:00
Urgau
9b97ae98f8
Rename drop_copy lint to dropping_copy_types
2023-05-21 13:37:32 +02:00
Urgau
35e5aac5c8
Drop uplifted clippy::forget_copy
2023-05-10 19:36:02 +02:00
Urgau
22688fc91f
Drop uplifted clippy::forget_ref
2023-05-10 19:36:01 +02:00
Urgau
551f6e6154
Drop uplifted clippy::drop_copy
2023-05-10 19:36:01 +02:00
Urgau
6af0359f2a
Drop uplifted clippy::drop_ref
2023-05-10 19:36:01 +02:00
Philipp Krones
d21616737b
Merge commit '7f27e2e74ef957baa382dc05cf08df6368165c74' into clippyup
2023-01-12 19:48:13 +01:00
Philipp Krones
d75b25faab
Merge commit 'ac0e10aa68325235069a842f47499852b2dee79e' into clippyup
2022-10-06 09:44:38 +02:00
Philipp Krones
7d4daaa8fa
Merge commit 'fdb84cbfd25908df5683f8f62388f663d9260e39' into clippyup
2022-07-18 09:39:37 +02:00
flip1995
7cd86aa1be
Merge commit '7c21f91b15b7604f818565646b686d90f99d1baf' into clippyup
2022-05-05 15:12:52 +01:00
flip1995
71131351de
Merge commit '984330a6ee3c4d15626685d6dc8b7b759ff630bd' into clippyup
2022-04-08 10:06:10 +01:00
flip1995
35020280a0
Merge commit 'e329249b6a3a98830d860c74c8234a8dd9407436' into clippyup
2022-02-26 14:26:21 +01:00
flip1995
8fea1d94f3
Merge commit 'a5d597637dcb78dc73f93561ce474f23d4177c35' into clippyup
2021-12-06 12:33:31 +01:00
flip1995
2b20f49841
Merge commit '0cce3f643bfcbb92d5a1bb71858c9cbaff749d6b' into clippyup
2021-07-29 12:16:06 +02:00
flip1995
f6d1f368db
Merge commit 'b40ea209e7f14c8193ddfc98143967b6a2f4f5c9' into clippyup
2021-04-08 17:50:13 +02:00
flip1995
9f6b5de7de
Merge commit '0e87918536b9833bbc6c683d1f9d51ee2bf03ef1' into clippyup
2021-03-25 19:29:11 +01:00
flip1995
f2f2a005b4
Merge commit '6ed6f1e6a1a8f414ba7e6d9b8222e7e5a1686e42' into clippyup
2021-03-12 15:30:50 +01:00
Cameron Steffen
2454408318
Remove qpath_res util function
2021-01-18 14:54:58 -06:00
LeSeulArtichaut
28f9b84042
ty.kind -> ty.kind() in rustdoc and clippy
2020-09-04 18:27:33 +02:00
Valentin Lazureanu
5a20489c5c
Rename TypeckTables to TypeckResults.
2020-07-17 08:47:04 +00:00
Eduard-Mihai Burtescu
30c046ede4
Use 'tcx for references to AccessLevels wherever possible.
2020-07-03 00:04:48 +03:00
Eduard-Mihai Burtescu
f5ce0e5fe9
rustc_lint: only query typeck_tables_of when a lint needs it.
2020-06-26 02:56:23 +03:00
xiongmao86
d7f1a1ed2b
Change note_span argument for span_lint_and_note.
2020-04-18 18:29:36 +08:00
Matthias Krüger
aff57e0f43
rustup https://github.com/rust-lang/rust/pull/70536
2020-03-30 11:17:58 +02:00
flip1995
8472ecda0f
Fix fallout
2020-02-21 11:14:18 +01:00
Yuki Okushi
f5e86d6894
Rename span_note_and_lint to span_lint_and_note
2020-01-27 11:26:42 +09:00
Yuki Okushi
ce1c6b285d
Rustup to rust-lang/rust#68045
2020-01-13 21:55:57 +09:00
Yuki Okushi
39947992b5
Rustup to rust-lang/rust#67806
2020-01-11 21:50:00 +09:00
Yuki Okushi
5ac08b0cc9
Normalize lint messages
2020-01-07 18:26:55 +09:00
Yuki Okushi
2f2eaf8b7e
Rustup to rust-lang/rust#67886
2020-01-07 01:46:33 +09:00
Yuki Okushi
e2636729ec
Rustup to rust-lang/rust#66936
2019-12-27 16:13:53 +09:00
Matthias Krüger
98e433d70d
Rustup to rust-lang/rust#66878
2019-12-04 01:34:01 +01:00
