Matthias Krüger
7c2d57e0fa
couple of clippy::complexity fixes
2022-04-13 22:51:34 +02:00
rainy-me
4a0f8d5175
improve diagnostics for unterminated nested block comment
2022-04-14 03:22:02 +09:00
Dylan DPC
86388f6171
Rollup merge of #95251 - GrishaVar:hashes-u16-to-u8, r=dtolnay
...
Reduce max hash in raw strings from u16 to u8
[Relevant discussion](https://rust-lang.zulipchat.com/#narrow/stream/237824-t-lang.2Fdoc/topic/Max.20raw.20string.20delimiters )
2022-03-31 00:26:31 +02:00
Grisha Vartanyan
759d1e6af8
Update error message & remove outdated test comment
2022-03-30 18:20:30 +02:00
Michael Goulet
928388bad2
Make fatal DiagnosticBuilder yield never
2022-03-27 22:25:32 -07:00
mark
bb8d4307eb
rustc_error: make ErrorReported impossible to construct
...
There are a few places were we have to construct it, though, and a few
places that are more invasive to change. To do this, we create a
constructor with a long obvious name.
2022-03-16 10:35:24 -05:00
mark
e489a94dee
rename ErrorReported -> ErrorGuaranteed
2022-03-02 09:45:25 -06:00
Caio
e3e902bb06
4 - Make more use of let_chains
...
Continuation of #94376 .
cc #53667
2022-02-28 07:49:56 -03:00
Eduard-Mihai Burtescu
b7e95dee65
rustc_errors: let DiagnosticBuilder::emit
return a "guarantee of emission".
2022-02-23 06:38:52 +00:00
Eduard-Mihai Burtescu
02ff9e0aef
Replace &mut DiagnosticBuilder
, in signatures, with &mut Diagnostic
.
2022-02-23 05:38:19 +00:00
est31
2ef8af6619
Adopt let else in more places
2022-02-19 17:27:43 +01:00
Matthias Krüger
637d8b89e8
Rollup merge of #94011 - est31:let_else, r=lcnr
...
Even more let_else adoptions
Continuation of #89933 , #91018 , #91481 , #93046 , #93590 .
2022-02-17 23:00:59 +01:00
est31
60f969a4f2
Adopt let_else in even more places
2022-02-16 22:43:39 +01:00
Erin Petra Sofiya Moon
e59cda9ee1
suggest using raw string literals when invalid escapes appear
...
i'd guess about 70% of "bad escape" cases occur when someone meant to
use a raw string literal because they're passing it directly to
Regex::new(). this emits an advisory (Applicability::MaybeIncorrect)
help: suggestion to the user that they use an r"" string,
on top of the normal notes about looking at the
string literal documentation/spec.
2022-02-14 15:11:38 -05:00
Esteban Kuber
d68add9ecc
review comment: plural of emoji is emoji
2021-11-23 20:36:19 +00:00
Esteban Kuber
21224e6ee0
Account for confusable codepoints when recovering emoji identifiers
2021-11-23 20:36:19 +00:00
Esteban Kuber
5a68abb094
Tokenize emoji as if they were valid indentifiers
...
In the lexer, consider emojis to be valid identifiers and reject
them later to avoid knock down parse errors.
2021-11-23 20:35:07 +00:00
5225225
09e59c2875
Inline printable function
2021-11-16 08:06:31 +00:00
5225225
52199c93bb
Suggest removing the non-printing characters
2021-11-16 08:06:30 +00:00
5225225
de05d3ec31
Print full char literal on error if any are non-printing
2021-11-16 08:06:30 +00:00
Hans Kratz
7885233df0
Optimize literal, doc comment lint as well, extract function.
2021-11-04 23:31:42 +01:00
Hans Kratz
a5b25a2cfa
Create subslice as that leads to a smaller code size.
2021-11-04 17:03:13 +01:00
Hans Kratz
2d9f0e2c50
Optimize bidi character detection.
2021-11-04 12:01:26 +01:00
Pietro Albini
cdd3b8624f
fix formatting
2021-11-01 10:39:43 +01:00
Esteban Küber
c0b134582a
Lint against RTL unicode codepoints in literals and comments
...
Address CVE-2021-42574.
2021-10-31 13:14:04 +01:00
Fabian Wolff
0d8245b5b1
Improve diagnostics if a character literal contains combining marks
2021-09-10 19:23:37 +02:00
Anton Golov
a03fbfe2ff
Warn when an escaped newline skips multiple lines
2021-08-11 11:35:08 +02:00
Cameron Steffen
4380056397
Rollup merge of #87659 - FabianWolff:issue-87397, r=davidtwco
...
Fix invalid suggestions for non-ASCII characters in byte constants
Fixes #87397 .
2021-08-02 09:36:51 -05:00
bors
4e282795d7
Auto merge of #87662 - FabianWolff:rb-string, r=estebank
...
Suggest `br` if the unknown string prefix `rb` is found
Currently, for the following code:
```rust
fn main() {
rb"abc";
}
```
we issue the following suggestion:
```
help: consider inserting whitespace here
|
2 | rb "abc";
| --
```
With my changes (only in edition 2021, where unknown prefixes became an error), I get:
```
help: use `br` for a raw byte string
|
2 | br"abc";
| ^^
```
2021-07-31 20:20:18 +00:00
Fabian Wolff
f2c9654dcd
Suggest br
if the unknown string prefix rb
is found
2021-07-31 15:37:36 +02:00
Fabian Wolff
c1abb6f4d6
Fix invalid suggestions for non-ASCII characters in byte constants
2021-07-31 15:21:11 +02:00
Anton Golov
5d59b4412e
Add warning when whitespace is not skipped after an escaped newline.
2021-07-30 16:26:39 +02:00
Ryan Levick
d4e384bc1d
rename rust_2021_token_prefixes to rust_2021_prefixes_incompatible_syntax
2021-07-06 20:13:36 +02:00
Ryan Levick
81c11a212e
rust_2021_token_prefixes
2021-07-06 20:13:16 +02:00
Ryan Levick
6c87772e3c
Rename reserved_prefix lint to reserved_prefixes
2021-07-06 20:12:55 +02:00
Mara Bos
7490305e13
No reserved_prefix suggestion in proc macro call_site.
2021-06-26 23:11:14 +08:00
Mara Bos
0eeeebc990
Rename 'bad prefix' to 'unknown prefix'.
2021-06-26 23:11:14 +08:00
Mara Bos
d40be0fc64
Check the span's edition for the reserved prefixes.
2021-06-26 23:11:13 +08:00
Mara Bos
6adce70a58
Improve comments for reserved prefixes.
...
Co-authored-by: Niko Matsakis <niko@alum.mit.edu>
2021-06-26 23:11:13 +08:00
Mara Bos
d837c00d10
Add migration lint for reserved prefixes.
2021-06-26 23:11:04 +08:00
Mara Bos
ce43fc9404
Fix note in reserved prefix error.
2021-06-26 23:09:43 +08:00
Mara Bos
c856e6fa53
Add machine applicable suggestion to unknown prefix error.
2021-06-26 23:09:43 +08:00
lrh2000
8dee9bc8fc
Reserve prefixed identifiers and string literals (RFC 3101)
...
This commit denies any identifiers immediately followed by
one of three tokens `"`, `'` or `#`, which is stricter than
the requirements of RFC 3101 but may be necessary according
to the discussion at [Zulip].
[Zulip]: https://rust-lang.zulipchat.com/#narrow/stream/268952-edition-2021/topic/reserved.20prefixes/near/238470099
2021-06-26 23:09:43 +08:00
Smitty
bdfcb88e8b
Use HTTPS links where possible
2021-06-23 16:26:46 -04:00
Joshua Nelson
96509b4835
Make Diagnostic::span_fatal
unconditionally raise an error
...
It had no callers which didn't immediately call `raise()`, and this
unifies the behavior with `Session`.
2021-05-08 23:12:04 -04:00
Joshua Nelson
e49f4471aa
Remove some unnecessary uses of struct_span_fatal
...
All of them immediately called `emit()` then `raise()`, so they could
just call `span_fatal` directly.
2021-05-08 23:12:04 -04:00
pierwill
0019ca9141
Fix outdated crate names in compiler docs
...
Changes `librustc_X` to `rustc_X`, only in documentation comments.
Plain code comments are left unchanged.
Also fix incorrect file paths.
2021-04-08 11:12:14 -05:00
Smitty
c6cb014ad6
Clarify error message wording
2021-02-07 11:02:53 -05:00
Smitty
651d289405
Add note about encoding when null bytes found
2021-02-06 19:17:14 -05:00
Esteban Küber
3b5d018ebb
Handle Span
s for byte and raw strings and add more detail
2021-02-03 13:34:28 -08:00
Nicolas
7be6d67f82
Fix typo in doc comment for report_too_many_hashes
...
"to big" -> "too big"
2020-11-22 07:02:58 -03:00
Guillaume Gomez
99200f760b
Fix even more URLs
2020-11-05 20:11:29 +01:00
Eric Huss
35192ff574
Fix span for unicode escape suggestion.
2020-10-05 11:19:08 -07:00
Matthias Krüger
c690c82ad4
use if let instead of single match arm expressions to compact code and reduce nesting (clippy::single_match)
2020-09-20 11:42:52 +02:00
Aleksey Kladov
ccf41dd5eb
Rename IsJoint -> Spacing
...
To match better naming from proc-macro
2020-09-03 17:32:45 +02:00
Aleksey Kladov
4231fbc0a8
Condense StringReader's API to a single function
2020-09-03 15:52:15 +02:00
Aleksey Kladov
fabd8a6834
Simplify TokenTreesReader
...
This `joint_to_prev` bit of state is no longer needed.
2020-09-01 11:46:49 +02:00
Aleksey Kladov
5326361fc0
Remove trivia tokens
2020-09-01 11:39:11 +02:00
Aleksey Kladov
8f24c2ec9d
Don't emit trivia tokens
2020-09-01 11:39:11 +02:00
Aleksey Kladov
30ce15f1fa
Make StringReader private
...
After the recent refactorings, we can actually completely hide this
type. It should help with #63689 .
2020-08-31 18:01:01 +02:00
Aleksey Kladov
518cac9190
Remove unused function
2020-08-30 19:54:45 +02:00
mark
9e5f7d5631
mv compiler to compiler/
2020-08-30 18:45:07 +03:00