mikros/rust - rust - Gitea.pterpstra.com

mikros/rust

Fork 0

Commit Graph

Author	SHA1	Message	Date
Huon Wilson	900af2c6d9	lint: default methods must be called on Self to unconditionally recur. This catches the case when a trait defines a default method that calls itself, but on a type that isn't necessarily `Self`, e.g. there's no reason that `T = Self` in the following, so the call isn't necessarily recursive (`T` may override the call). trait Bar { fn method<T: Bar>(&self, x: &T) { x.method(x) } } Fixes #26333.	2015-06-29 16:00:54 -07:00
Huon Wilson	b1931e48a0	lint: only consider actual calls as unconditional recursion. Specifically, just mentioning the function name as a value is fine, as long as it isn't called, e.g. `fn main() { let _ = main; }`. Closes #21705.	2015-06-29 15:59:37 -07:00
Huon Wilson	fbef241709	Add a lint to detect unconditional recursion. E.g. `fn foo() { foo() }`, or, more subtlely impl Foo for Box<Foo+'static> { fn bar(&self) { self.bar(); } } The compiler will warn and point out the points where recursion occurs, if it determines that the function cannot return without calling itself. Closes #17899.	2015-01-25 00:21:03 +11:00

Author

SHA1

Message

Date

Huon Wilson

900af2c6d9

lint: default methods must be called on Self to unconditionally recur.

This catches the case when a trait defines a default method that calls
itself, but on a type that isn't necessarily `Self`, e.g. there's no
reason that `T = Self` in the following, so the call isn't necessarily
recursive (`T` may override the call).

    trait Bar {
        fn method<T: Bar>(&self, x: &T) {
            x.method(x)
        }
    }

Fixes #26333.

2015-06-29 16:00:54 -07:00

Huon Wilson

b1931e48a0

lint: only consider actual calls as unconditional recursion.

Specifically, just mentioning the function name as a value is fine, as
long as it isn't called, e.g. `fn main() { let _ = main; }`.

Closes #21705.

2015-06-29 15:59:37 -07:00

Huon Wilson

fbef241709

Add a lint to detect unconditional recursion.

E.g. `fn foo() { foo() }`, or, more subtlely

    impl Foo for Box<Foo+'static> {
        fn bar(&self) {
            self.bar();
        }
    }

The compiler will warn and point out the points where recursion occurs,
if it determines that the function cannot return without calling itself.

Closes #17899.

2015-01-25 00:21:03 +11:00

3 Commits