Corey Farwell
f7d1ef90a0
utilize .is_unsafe_ptr
2018-08-29 07:08:59 -05:00
Corey Farwell
a48a6ef10f
utilize cx.tcx.types.usize
2018-08-29 07:07:23 -05:00
Corey Farwell
a7c1ea96c4
tweak comment
2018-08-29 07:03:50 -05:00
Corey Farwell
feb3e9fd5f
switch lint from 'style' to 'complexity'
2018-08-29 07:02:26 -05:00
Corey Farwell
5ebae01c1e
New lint: Suggest ptr.add([usize])
over ptr.offset([usize] as isize)
.
...
First part of #3047 .
2018-08-28 23:21:29 -05:00
Corey Farwell
05f637cf88
Make clippy_lints::{utils,consts} modules private, remove unused items.
2018-08-28 21:32:20 -05:00
Oliver Schneider
d99cea0f16
Update imports and rustup
2018-08-28 13:13:42 +02:00
Philipp Hansch
b001ab33fe
Merge pull request #3101 from pickfire/patch-1
...
Fix typo for panel cursor
2018-08-28 06:42:36 +01:00
Ivan Tham
340500ede5
Fix typo for panel cursor
2018-08-28 10:24:21 +08:00
Daniel Wagner-Hall
350036a0c7
default_trait_access skips <F as Default>::default()
...
This includes the type name, so is clear, and may be necessary.
There doesn't seem to be an obviously cleaner way to pull out the
literal text of the named type here.
Fixes #2879
2018-08-27 23:22:07 +01:00
llogiq
43c629ebac
Merge pull request #3090 from matthiaskrgr/new_without_default_highlight
...
docs: make example in new_without_default lint syntax highlighted
2018-08-27 21:00:53 +02:00
Matthias Krüger
fc31dc01de
docs: make example in new_without_default lint syntax highlighted
2018-08-27 17:35:30 +02:00
Oliver Schneider
89012722ba
Merge pull request #3018 from rust-lang-nursery/beta
...
We are riding the trains to stable, there's no point in trying to check the rustc version
2018-08-27 11:08:58 +02:00
Oliver Schneider
628934424e
Merge pull request #3087 from rust-lang-nursery/run
...
Use the compilers exit code computation instead of rolling our own
2018-08-26 16:29:11 +02:00
Oliver Schneider
caa59e2e27
Use the compilers exit code computation instead of rolling our own
2018-08-26 15:57:17 +02:00
Philipp Krones
9ce826ade1
Merge pull request #3082 from mikerite/move-range-lints
...
Move some range lints to complexity
2018-08-26 15:08:21 +02:00
Oliver Schneider
ff5f07bbb1
Merge pull request #3084 from mikerite/fix-3083
...
Remove `iterator_find_map` feature attribute
2018-08-26 12:20:35 +02:00
Michael Wright
95fedd2273
Revert "Fix E0502 warnings"
...
This reverts commit 98dbce4fe4
.
The compiler no longer emits the warnings in #2982 with the original
code.
2018-08-26 11:21:22 +02:00
Michael Wright
eef3ffab35
Remove iterator_find_map
feature attribute
...
Closes #3083
2018-08-26 11:11:47 +02:00
Michael Wright
cc87dc7539
Move some range lints to complexity
...
Recategorize `range_plus_one` and `range_minus_one` to `complexity`.
This moves `range_plus_one` out of the nursery as the inclusive range
syntax is now stable. Both are moved to `complexity` as it is more
consistent with other lints such as `int_plus_one`.
2018-08-26 10:57:04 +02:00
Michael Wright
6256ad05ba
fix-3078: verify test case
...
Check the crash test case by commenting out the fix
2018-08-25 22:35:06 +02:00
Michael Wright
45ceecc79c
Fix #3078
2018-08-25 14:49:56 +02:00
Philipp Hansch
296b79bdb8
Merge pull request #3079 from matthiaskrgr/update_cargo_metadata
...
deps: update cargo_metadata from 0.5 to 0.6.
2018-08-24 20:09:50 +02:00
Philipp Krones
b1620f5d3a
Merge pull request #3080 from matthiaskrgr/manual_swap_example
...
add how-to example for std::mem::transmute() usage instead of manual swap
2018-08-24 19:47:17 +02:00
Matthias Krüger
f7be2a0416
add how-to example for std::mem::transmute() usage instead of manual swap
2018-08-24 18:41:49 +02:00
Philipp Krones
e91147832c
Merge pull request #3048 from goodmanjonathan/assign_op
...
deprecate assign_ops lint
2018-08-24 18:29:31 +02:00
Philipp Krones
562c576ed3
Merge pull request #3059 from elpiel/writeln_empty_string_harcoded-suggestion
...
#3016 writeln_empty_string Hardcoded suggestion
2018-08-24 18:28:50 +02:00
Matthias Krüger
2224fbb5f7
deps: update cargo_metadata from 0.5 to 0.6.
2018-08-24 18:14:49 +02:00
Philipp Krones
72344f466f
Merge pull request #2924 from niklasf/copy-iterator
...
Add copy_iterator lint (#1534 )
2018-08-24 12:27:48 +02:00
Niklas Fiekas
afdf350060
Add copy_iterator lint ( #1534 )
2018-08-24 11:57:48 +02:00
Philipp Krones
dda656652e
Merge pull request #3077 from matthiaskrgr/rustup_2
...
fix clippy breakage due to https://github.com/rust-lang/rust/pull/52602
2018-08-23 23:29:00 +02:00
Matthias Krüger
c98987f390
fix clippy breakage due to https://github.com/rust-lang/rust/pull/52602
2018-08-23 21:41:30 +02:00
Matt Brubeck
6a0703664b
Remove incorrect note from string_add_assign docs
...
The docs claim that `String::push_str` is better than `String::add` because `String::add` allocates a new string and drops the old one, but this is not true. In fact, `add` reuses the existing string and grows it only if its capacity is exceeded, exactly like `push_str`. Their performance is identical since `add` is just a wrapper for `push_str`:
```
fn add(mut self, other: &str) -> String {
self.push_str(other);
self
}
```
35bf1ae257/src/liballoc/string.rs (L1922-L1925)
2018-08-23 08:38:41 -07:00
Philipp Krones
e9c3d3d502
Merge pull request #3072 from matthiaskrgr/rustup
...
rustup, fix breakage introduced by rust-lang/rust#53581 and rust-lang/rust#53459
2018-08-23 15:53:07 +02:00
Matthias Krüger
8ab16b678c
remove macro_vis_matcher feature gate since it is stable now.
...
Warning was:
warning: the feature `macro_vis_matcher` has been stable since 1.29.0 and no longer requires an attribute to enable
--> src/lib.rs:4:12
|
4 | #![feature(macro_vis_matcher)]
| ^^^^^^^^^^^^^^^^^
|
= note: #[warn(stable_features)] on by default
2018-08-23 15:40:51 +02:00
flip1995
37099ae034
Remove now stable tool_attributes feature
2018-08-23 15:36:07 +02:00
Matthias Krüger
712d2d4fa1
rustup, fix breakage introduced by https://github.com/rust-lang/rust/pull/53581
2018-08-22 23:34:52 +02:00
flip1995
205db6f686
Add LD_LIBRARY_PATH and GITHUB_TOKEN
2018-08-22 18:08:52 +02:00
flip1995
97a9332014
Remove MinGW from CI
2018-08-22 18:07:39 +02:00
flip1995
efeed9aefc
Remove unused code
2018-08-22 17:47:54 +02:00
Oliver Schneider
f969cf2cb6
Remove rust-toolchain file in CI
2018-08-20 11:21:32 -07:00
Oliver Schneider
d6af6886e7
Keep the rustc master install in the travis file so we can use travis_retry
2018-08-20 11:21:32 -07:00
Oliver Schneider
f8a38140a0
Try running appveyor on master instead of nightly
2018-08-20 11:21:32 -07:00
Lachezar Lechev
76f7bfcefd
#3016 Add backticks for the msg
2018-08-20 15:50:15 +02:00
Lachezar Lechev
c292b80783
#3016 Add feedback and implement test for fixed hardcoded suggestion
2018-08-20 15:33:43 +02:00
Lachezar Lechev
3015987f27
#3016 [WIP] Implement feedback and suggestions
2018-08-20 14:03:13 +02:00
Manish Goregaokar
f05a1038b5
Merge pull request #3065 from rust-lang-nursery/rustup
...
Rustup to rustc 1.30.0-nightly (6bf6d50a6
2018-08-19)
2018-08-19 19:16:54 -07:00
Manish Goregaokar
a7bea134d3
Remove implied rust_2018 feature
...
We are already on the edition and this feature is implied.
2018-08-19 19:14:47 -07:00
Manish Goregaokar
76321d3300
codemap -> source_map
...
https://github.com/rust-lang/rust/pull/52953
2018-08-19 19:06:54 -07:00
Lachezar Lechev
6cb94630fb
WIP of #3016 for hardocded suggestion for writeln on empty string
2018-08-16 18:20:06 +02:00