Matthias Krüger
48fc948ca3
clippy dev crater: address more review commetns
...
make serde a feature-dep
save clippy version in the crater log
2021-01-23 02:18:11 +01:00
Matthias Krüger
94a73d7b11
add shortcut "dev-crater" command to build and run "cargo dev crater"
2021-01-23 02:18:11 +01:00
Matthias Krüger
ec1902ce43
cargo dev crater: throw an error if we can't find our specified crate in the .toml list
2021-01-23 02:18:11 +01:00
Matthias Krüger
b6ef1e282e
clippy dev crater: add option to only check a single one of the listed crates with --only crate
2021-01-23 02:18:11 +01:00
Matthias Krüger
d257101109
make stats stable
2021-01-23 02:18:11 +01:00
Matthias Krüger
e56c9a5253
cargo dev crater: gather and save lint statistics (how often a lint triggered)
2021-01-23 02:18:11 +01:00
Matthias Krüger
4ec9cb84bb
cargo dev crater: refactor to get a list of all ClippyWarnings
2021-01-23 02:18:11 +01:00
Matthias Krüger
6c5bf2778f
clippy dev crater: use and parse clippy messages as json message, to get the lint name of a warning
2021-01-23 02:18:11 +01:00
Matthias Krüger
62337f2842
remove duplicate code and other cleanup
2021-01-23 02:18:11 +01:00
Matthias Krüger
22824d21da
rename symbols: krate -> crate
2021-01-23 02:18:11 +01:00
Matthias Krüger
f986d78c5e
cargo dev crater: support multiple versions per crate
2021-01-23 02:18:11 +01:00
Matthias Krüger
588efa7da9
use a .toml file to list the crates we want to check
...
Also sort lint results alphabetically.
2021-01-23 02:18:11 +01:00
Matthias Krüger
a9fce6d2d0
allow clippy::filter_map
2021-01-23 02:18:11 +01:00
Matthias Krüger
ccfaa338ed
cargo dev crater: share target dir between clippy runs, enable pedantic and cargo lints, ignore tokei for now.
2021-01-23 02:18:11 +01:00
Matthias Krüger
1e5ac1dfd2
cargo dev crater: add more crates to be checked
2021-01-23 02:18:11 +01:00
Matthias Krüger
728dc06d88
add the log file
2021-01-23 02:18:11 +01:00
Matthias Krüger
dbb8c0020e
cargo dev crater: save all warnings into a file
2021-01-23 02:18:11 +01:00
Matthias Krüger
7314133722
cargo dev crater: cleanup, don't re-download and reextract crates on every run
2021-01-23 02:18:11 +01:00
Matthias Krüger
734d2052df
print all clippy warnings in the end
2021-01-23 02:18:11 +01:00
Matthias Krüger
2360a7cad0
cargo clippy dev: collecting one-line clippy warnings works now
2021-01-23 02:18:11 +01:00
Matthias Krüger
69c0757334
clippy cargo dev: fix checking of crates
2021-01-23 02:18:11 +01:00
Matthias Krüger
e69147486e
cargo clippy dev: fix extraction of downloaded crates
2021-01-23 02:18:11 +01:00
Matthias Krüger
63176834c2
cargo dev crater: fixes and debug prints
2021-01-23 02:18:11 +01:00
Matthias Krüger
30d85942cf
crater: hook into main.rs
2021-01-23 02:18:11 +01:00
Matthias Krüger
5353591b1b
cargo dev crater: work on downloading and extracting crate sources
2021-01-23 02:18:11 +01:00
Matthias Krüger
bec916d02d
cargo dev crater: lay out the base plan
2021-01-23 02:18:11 +01:00
bors
693ed05bbd
Auto merge of #81017 - Aaron1011:collect-trailing-token, r=petrochenkov
...
Refactor token collection to capture trailing token immediately
Split out from https://github.com/rust-lang/rust/pull/80689 - when we start capturing more information about attribute targets, we'll need to know in advance if we're capturing a trailing token or not.
r? `@ghost`
2021-01-23 00:42:37 +00:00
Joshua Nelson
bf86fd5221
Fix <unknown> queries
...
This happened because `alloc_query_strings` was never called.
2021-01-22 19:20:37 -05:00
Tomasz Miąsko
99a1dea1b7
Do not mark unit variants as used when in path pattern
...
Record that we are processing a pattern so that code responsible for
handling path resolution can correctly decide whether to mark it as
used or not.
2021-01-23 00:00:00 +00:00
bors
70386ff352
Auto merge of #6403 - camsteffen:similar-names-underscore, r=Manishearth
...
Similar names ignore underscore prefixed names
changelog: Ignore underscore-prefixed names for similar_names
IMO, this lint is not very helpful for underscore-prefixed variables. Usually they are unused or are just there to ignore part of a destructuring.
2021-01-22 23:44:12 +00:00
pierwill
b29353af09
Edit rustc_middle::dep_graph module documentation
...
Co-authored-by: Joshua Nelson <joshua@yottadb.com>
Co-authored-by: Camelid <camelidcamel@gmail.com>
2021-01-22 15:15:05 -08:00
Daniel Conley
0c78500426
library/core/tests/iter documentation and cleanup
2021-01-22 17:57:08 -05:00
Daniel Conley
bc830a274b
library/core/tests/iter rearrange & add back missed doc comments
2021-01-22 17:57:07 -05:00
bors
41d750c76c
Auto merge of #6619 - camsteffen:collapsible-match, r=camsteffen
...
Improve collapsible_match
changelog: Fix collapsible_match false negatives
Allow `&` and/or `*` on the binding and make sure the type still matches.
2021-01-22 22:45:43 +00:00
Cameron Steffen
50abde20c9
Fix dogfood
2021-01-22 16:44:47 -06:00
Cameron Steffen
66afdd1f42
Enhance collapsible_match for adjusted bindings
2021-01-22 16:44:47 -06:00
bors
3c3f4a75b4
Auto merge of #6591 - camsteffen:manual-filter-map, r=llogiq
...
`manual_filter_map` and `manual_find_map`
changelog: Add `manual_filter_map` and replace `find_map` with `manual_find_map`
Replaces #6453
Fixes #3188
Fixes #4193
~Depends on #6567 (to fix an internal lint false positive)~
This replaces `filter_map` and `find_map` with `manual_filter_map` and `manual_find_map` respectively. However, `filter_map` is left in place since it is used for a variety of other cases. See discussion in #6453 .
2021-01-22 22:28:41 +00:00
Daniel Conley
1e3a2def67
library/core/test/iter add newlines between tests
2021-01-22 16:58:21 -05:00
bors
34b3d41e1a
Auto merge of #79233 - yoshuawuyts:alloc-doc-alias, r=GuillaumeGomez
...
Add doc aliases for memory allocations
This patch adds doc aliases for various C allocation functions, making it possible to search for the C-equivalent of a function and finding the (safe) Rust counterpart:
- `Vec::with_capacity` / `Box::new` / `vec!` -> alloc + malloc, allocates memory
- `Box::new_zeroed` -> calloc, allocates zeroed-out memory
- `Vec::{reserve,reserve_exact,try_reserve_exact,shrink_to_fit,shrink_to}` -> realloc, reallocates a previously allocated slice of memory
It's worth noting that `Vec::new` does not allocate, so we don't link to it. Instead people are probably looking for `Vec::with_capacity` or `vec!`. I hope this will allow people comfortable with the system allocation APIs to make it easier to find what they may be looking for.
Thanks!
2021-01-22 21:48:41 +00:00
Manish Goregaokar
65d003a112
Clean up suggestion span; clarify help message
2021-01-22 12:08:47 -08:00
Manish Goregaokar
752274eabd
Fix indentation of suggestion
2021-01-22 11:59:36 -08:00
Manish Goregaokar
8cb7e85006
Add exhaustive_structs lint
2021-01-22 11:59:36 -08:00
Joshua Nelson
0679a4cd93
Remove special casing of rustdoc in rustc_lint
...
This is no longer necessary now that rustdoc doesn't run
everybody_loops.
2021-01-22 14:50:21 -05:00
Jonathan Behrens
0392085f5c
More clear documentation for NonNull<T>
...
Rephrase and hopefully clarify the discussion of covariance in `NonNull<T>` documentation.
2021-01-22 14:46:11 -05:00
bors
22ddcd1a13
Auto merge of #72160 - slo1:libstd-setgroups, r=KodrAus
...
Add setgroups to std::os::unix::process::CommandExt
Should fix #38527 . I'm not sure groups is the greatest name though.
2021-01-22 19:00:11 +00:00
Mara Bos
4d7e48970a
Note library tracking issue template in tracking issue template.
2021-01-22 19:41:20 +01:00
Dániel Buga
f29b32983d
Fix formatting
2021-01-22 18:55:37 +01:00
Benoît du Garreau
9880560a1c
Inline methods of Path and OsString
2021-01-22 18:46:00 +01:00
Dániel Buga
aa4f5833e1
Only query associated_items once
2021-01-22 18:36:33 +01:00
Dániel Buga
ee639de007
Only guess span if absolutely necessary
2021-01-22 18:36:33 +01:00