Jason Newcomb
8ef87455b0
Minor cleanup on transmute lints
2022-02-01 10:58:01 -05:00
Matthias Krüger
c7b7b537ba
Rollup merge of #93290 - lcnr:same_type, r=jackh726
...
remove `TyS::same_type`
This function ignored regions and constants in adts, but didn't do so for references or any other types. cc https://github.com/rust-lang/rust/pull/93148#discussion_r791408057
2022-02-01 16:08:05 +01:00
lcnr
99af4c8971
remove TyS::same_type
...
it ignored regions and constants in adts,
but didn't do so for references or any other types.
This seemed quite weird
2022-02-01 11:21:26 +01:00
lcnr
544ed0b3cf
silence lint in clippy
2022-02-01 10:13:32 +01:00
tamaron
b13704a9cd
update test suites
2022-02-01 13:44:24 +09:00
tamaron
0e1cbc5cd1
fix code
2022-02-01 13:43:39 +09:00
Matthias Krüger
1193abe4c8
multiple configs: add tests
2022-01-31 18:36:15 +01:00
Matthias Krüger
97e5a70f47
warn if we find multiple clippy configs
...
Fixes #8323
2022-01-31 18:36:15 +01:00
bors
7bb69c0ae0
Auto merge of #8369 - Jarcho:ptr_arg_8366, r=flip1995
...
Don't lint `ptr_arg` for `&mut _` types in trait items
fixes #8366
changelog: Don't lint `ptr_arg` for `&mut _` types in trait items
2022-01-31 15:17:38 +00:00
dswij
5faa7ebb70
Fix chars_next_cmp suggestion not escaped
2022-01-31 13:35:14 +08:00
bors
b606d160c8
Auto merge of #90891 - nbdd0121:format, r=Mark-Simulacrum
...
Create `core::fmt::ArgumentV1` with generics instead of fn pointer
Split from (and prerequisite of) #90488 , as this seems to have perf implication.
`@rustbot` label: +T-libs
2022-01-31 00:04:46 +00:00
bors
0ed8ca45f4
Auto merge of #8322 - jubnzv:8282-single-match, r=llogiq
...
single_match: Don't lint non-exhaustive matches; support tuples
`single_match` lint:
* Don't lint exhaustive enum patterns without a wild.
Rationale: The definition of the enum could be changed, so the user can get non-exhaustive match after applying the suggested lint (see https://github.com/rust-lang/rust-clippy/issues/8282#issuecomment-1013566068 for context).
* Lint `match` constructions with tuples (as suggested at https://github.com/rust-lang/rust-clippy/issues/8282#issuecomment-1015621148 )
Closes #8282
---
changelog: [`single_match`]: Don't lint exhaustive enum patterns without a wild.
changelog: [`single_match`]: Lint `match` constructions with tuples
2022-01-30 22:00:36 +00:00
tamaron
447ed5ce52
add attributes
2022-01-30 15:39:47 +09:00
tamaron
df6ef6059b
update get_unwrap.rs
2022-01-30 14:59:46 +09:00
tamaron
1a2364e534
fix code
2022-01-30 14:59:25 +09:00
tamaron
ba80d45b3c
update testsuite
2022-01-30 12:58:49 +09:00
tamaron
8ccd264620
modify code
2022-01-30 12:56:07 +09:00
Jason Newcomb
66bb7263b5
Don't lint ptr_arg for &mut _ types in trait items
2022-01-29 12:03:54 -05:00
Samuel E. Moelius III
e7922f745d
Format if_chain invocations in clippy_utils
2022-01-29 10:50:18 -05:00
Gary Guo
bee482b44c
Change index_refutable_slice to use FxIndexMap
...
This will prevent unstable order when HirIds are pertubated.
2022-01-29 13:52:19 +00:00
Gary Guo
4119f60c1f
Create core::fmt::ArgumentV1 with generics instead of fn pointer
2022-01-29 13:52:19 +00:00
bors
7ceffdee9b
Auto merge of #8289 - jubnzv:unspecified-layout-union, r=camsteffen
...
Add `default_union_representation` lint
Closes #8235
changelog: Added a new lint [`default_union_representation`]
2022-01-29 10:58:16 +00:00
Georgy Komarov
b7000b2a53
Add default_union_representation lint
...
Closes #8235
2022-01-29 07:02:28 +03:00
Cameron Steffen
bd583d91a1
Factor out is_qpath_def_path
2022-01-28 16:05:39 -06:00
Cameron Steffen
ece7fa4f9c
Factor out match_any_diagnostic_items
2022-01-28 16:05:35 -06:00
Cameron Steffen
3771fe4ade
Factor out expr_path_res
2022-01-28 16:04:30 -06:00
Cameron Steffen
98c6381a38
Factor out single_segment_path
2022-01-28 16:02:43 -06:00
Cameron Steffen
deadc25588
Factor out differing_macro_contexts
2022-01-28 16:02:40 -06:00
Cameron Steffen
66a83d33ea
Factor out some ty param utils
2022-01-28 15:45:41 -06:00
Cameron Steffen
145d7fc529
Factor out get_qpath_generics
2022-01-28 15:45:41 -06:00
Cameron Steffen
20781f195d
Rename qpath_generic_tys
2022-01-28 15:45:41 -06:00
Cameron Steffen
bea09a2329
Add path_def_id util
2022-01-28 15:45:41 -06:00
Cameron Steffen
cc975929c5
Rename path_to_res to def_path_res
2022-01-28 15:45:41 -06:00
bors
8d5d9e0103
Auto merge of #8250 - pr2502:fix_repeat_underflow, r=giraffate
...
Fix underflow in `manual_split_once` lint
Hi, a friend found clippy started crashing on a suspiciously large allocation of `u64::MAX` memory on their code.
The mostly minimized repro is:
```rust
fn _f01(title: &str) -> Option<()> {
let _ = title[1..].splitn(2, '[').next()?;
Some(())
}
```
The underflow happens in this case on line 57 of the patch but I've changed the other substraction to saturating as well since it could potentially cause the same issue.
I'm not sure where to put a regression test, or if it's even worth for such a thing.
Aside, has it been considered before to build clippy with overflow checks enabled?
changelog: fix ICE of underflow in `manual_split_once` lint
2022-01-28 13:31:51 +00:00
bors
fb94992c39
Auto merge of #8354 - dswij:8345, r=giraffate
...
Update docs for `map_flatten` on `Option` case
closes #8345
changelog: [`map_flatten`] Add docs info for `Option` case
2022-01-28 05:11:09 +00:00
dswij
515ed80b9d
Update docs for map_flatten on Option
2022-01-28 12:00:30 +08:00
max
23fd95a5e9
fix underflow in check_manual_split_once lint
2022-01-27 17:54:40 +01:00
flip1995
bf66aeda0a
Merge commit 'a98e7ab8b94485be6bd03e0c6b8682ecab5b52e6' into clippyup
2022-01-27 15:12:45 +01:00
bors
a98e7ab8b9
Auto merge of #8359 - flip1995:rustup, r=flip1995
...
Rustup
r? `@ghost`
changelog: none
2022-01-27 13:48:23 +00:00
flip1995
b96e76869d
Bump nightly version -> 2022-01-27
2022-01-27 14:23:42 +01:00
flip1995
d037b28025
Merge remote-tracking branch 'upstream/master' into rustup
2022-01-27 14:23:31 +01:00
bors
ea4db3a6c6
Auto merge of #8350 - dswij:8331, r=Manishearth
...
fix bad suggestion on `numeric_literal`
closes #8331
changelog: [`numeric_literal`] fix suggestion not showing sign
2022-01-26 19:19:28 +00:00
Georgy Komarov
a8fdf5ca8a
matches: Remove extra comment
2022-01-26 19:50:27 +03:00
Georgy Komarov
467a0bfdea
matches: Restore match_type logic; add tests for these cases
2022-01-26 18:20:35 +03:00
Georgy Komarov
81015870df
matches: Improve naming. NFC.
2022-01-26 18:02:32 +03:00
Georgy Komarov
4aee3b1f1e
matches: Clarify the behavior of exhaustive check
2022-01-26 14:46:48 +03:00
Georgy Komarov
5416a71dae
Merge remote-tracking branch 'origin/master' into 8282-single-match
2022-01-26 14:16:15 +03:00
Dharma Saputra Wijaya
0d7273fef6
fix bad suggestion on numeric_literal
2022-01-26 15:02:13 +08:00
bors
02516c47ab
Auto merge of #93095 - Aaron1011:remove-assoc-ident, r=cjgillot
...
Store a `Symbol` instead of an `Ident` in `AssocItem`
This is the same idea as #92533 , but for `AssocItem` instead
of `VariantDef`/`FieldDef`.
With this change, we no longer have any uses of
`#[stable_hasher(project(...))]`
2022-01-25 18:53:45 +00:00
flip1995
64f5b3611e
Update Changelog
2022-01-25 16:59:31 +01:00
