Laurențiu Nicola
efcc487dff
Fix a couple of clippy nits
2021-07-22 09:03:54 +03:00
bors[bot]
a36c9d8b5c
Merge #9669
...
9669: minor: Move out fn_param tests r=Veykril a=Veykril
bors r+
Co-authored-by: Lukas Wirth <lukastw97@gmail.com>
2021-07-21 19:41:59 +00:00
Lukas Wirth
03efb50ae8
Move out fn_param tests
2021-07-21 21:39:40 +02:00
bors[bot]
b7e80d14f5
Merge #9668
...
9668: minor: Simplify r=Veykril a=Veykril
bors r+
Co-authored-by: Lukas Wirth <lukastw97@gmail.com>
2021-07-21 18:52:49 +00:00
Lukas Wirth
dfdf6fd9f8
Fix some more basic clippy lints
2021-07-21 20:52:08 +02:00
bors[bot]
695f315d64
Merge #9667
...
9667: minor: Remove proc macro ABI issue from bug report template r=lnicola a=lnicola
bors r+
Co-authored-by: Laurențiu Nicola <lnicola@dend.ro>
2021-07-21 18:38:51 +00:00
Laurențiu Nicola
fa2b7b7462
Remove proc macro ABI issue from bug report template
2021-07-21 21:03:06 +03:00
bors[bot]
1864147d92
Merge #9666
...
9666: minor: Fix some clippy lints in ide_completion r=Veykril a=Veykril
bors r+
Co-authored-by: Lukas Wirth <lukastw97@gmail.com>
2021-07-21 17:52:57 +00:00
Lukas Wirth
9485d6efba
Fix some clippy lints in ide_completion
2021-07-21 19:52:10 +02:00
bors[bot]
4d457e26e1
Merge #9665
...
9665: Only complete ancestors and self in visibility path completions r=Veykril a=Veykril
bors r+
Co-authored-by: Lukas Wirth <lukastw97@gmail.com>
2021-07-21 17:05:44 +00:00
Lukas Wirth
ccde0bcd1f
Only complete ancestors and self in visibility path completions
2021-07-21 18:54:12 +02:00
bors[bot]
99451a5fc2
Merge #9664
...
9664: Minor completions cleanup r=Veykril a=Veykril
bors r+
Co-authored-by: Lukas Wirth <lukastw97@gmail.com>
2021-07-21 16:47:41 +00:00
Lukas Wirth
3956a5b757
Simplify
2021-07-21 18:34:43 +02:00
bors[bot]
f2736c969c
Merge #9663
...
9663: fix: Don't offer extract_variable assist when there is no surrounding block r=Veykril a=Veykril
Fixes #9143
bors r+
Co-authored-by: Lukas Wirth <lukastw97@gmail.com>
2021-07-21 16:00:08 +00:00
bors[bot]
06b0cbf607
Merge #9662
...
9662: fix: filter visiblities when resolving in extern crate r=jonas-schievink a=jonas-schievink
Fixes https://github.com/rust-analyzer/rust-analyzer/issues/9650
Also fixes a bunch of incorrect tests that were importing private items.
bors r+
Co-authored-by: Jonas Schievink <jonasschievink@gmail.com>
2021-07-21 15:53:06 +00:00
Lukas Wirth
9279c1c939
Don't offer extract_variable assist when there is no surrounding block
2021-07-21 17:52:54 +02:00
Jonas Schievink
837eec8dab
filter visiblities when resolving in extern crate
2021-07-21 17:51:56 +02:00
bors[bot]
e6a237e75c
Merge #9660
...
9660: hide keyword suggestions in non trivial paths r=Veykril a=Freax13
This pr hides keyword suggestions in non trivial paths:
Previously rust analyzer suggested a lot of keywords even when completing non trivial paths:
This had 2 problems:
1. Suggesting a keyword in this position doesn't make sense.
2. There are a lot of keywords, so they make it a lot harder to find the things you're actually looking for (note the scrollbar and that `instructions`, `registers` and `structures` are not visible).
Co-authored-by: Tom Dohrmann <erbse.13@gmx.de>
2021-07-21 12:57:30 +00:00
Tom Dohrmann
7b20904e8b
hide keyword suggestions in non trivial paths
2021-07-21 12:53:50 +02:00
bors[bot]
478d435640
Merge #9658
...
9658: docs: fix typo r=lnicola a=jsejcksn
tree -> three
Co-authored-by: Jesse Jackson <jsejcksn@users.noreply.github.com>
2021-07-21 09:07:54 +00:00
Jesse Jackson
a9f4527fd3
docs: fix typo
...
tree -> three
2021-07-21 04:06:19 -05:00
bors[bot]
32b5635274
Merge #9656
...
9656: Revert #9655 because it breaks some type inference r=flodiebold a=flodiebold
This reverts commit 8c8c6fb73dec7b4cbf8f
2021-07-20 20:55:21 +00:00
Florian Diebold
7c00ca2f51
Revert "Merge #9655 "
...
This reverts commit 8c8c6fb73dec7b4cbf8f
2021-07-20 22:53:39 +02:00
bors[bot]
8c8c6fb73d
Merge #9655
...
9655: fix: Determine expected parameters from expected return in calls r=flodiebold a=flodiebold
Fixes #9560
Co-authored-by: Florian Diebold <flodiebold@gmail.com>
2021-07-20 20:17:03 +00:00
bors[bot]
ec7b4cbf8f
Merge #9654
...
9654: minor: remove dead code r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2021-07-20 17:23:18 +00:00
Aleksey Kladov
08caf36d9a
minor: remove dead code
...
It has been living in RootDatabase::apply_change almost a year by now.
2021-07-20 20:22:56 +03:00
bors[bot]
92877d37c3
Merge #9653
...
9653: minor: cov-mark r=Veykril a=Veykril
bors r+
Co-authored-by: Lukas Wirth <lukastw97@gmail.com>
2021-07-20 17:04:56 +00:00
Lukas Wirth
c83e37c001
cov-mark
2021-07-20 19:00:52 +02:00
bors[bot]
1c8cfa4310
Merge #9652
...
9652: Don't concat path in replace_qualified assist when they start with a keyword r=Veykril a=Veykril
Also keep the path if we can't find a path to the item instead of becoming non applicable.
bors r+
Co-authored-by: Lukas Wirth <lukastw97@gmail.com>
2021-07-20 16:58:30 +00:00
Lukas Wirth
4f99c6467b
Don't concat path in replace_qualified assist when they start with a keyword
2021-07-20 18:57:12 +02:00
bors[bot]
33972da625
Merge #9651
...
9651: Restrict completions inside visibility modifiers r=Veykril a=Veykril
bors r+
Co-authored-by: Lukas Wirth <lukastw97@gmail.com>
2021-07-20 16:38:40 +00:00
Lukas Wirth
f6cb42fdb8
Restrict completions inside visibility modifiers
2021-07-20 18:37:52 +02:00
bors[bot]
4705df44c7
Merge #9637
...
9637: Overhaul doc_links testing infra r=Veykril a=Veykril
and fix several issues with current implementation.
Fixes #9617
Co-authored-by: Lukas Wirth <lukastw97@gmail.com>
2021-07-20 16:06:37 +00:00
Lukas Wirth
2e39d4757b
More tests
2021-07-20 18:05:25 +02:00
Lukas Wirth
bb71ebb985
Move doc_links tests from hover to doc_links
2021-07-20 17:57:47 +02:00
Lukas Wirth
a35687fe1f
Minor cleanups
2021-07-20 17:41:10 +02:00
Lukas Wirth
cb7b4a5d5b
Some more fragment fixes
2021-07-20 17:03:39 +02:00
bors[bot]
ea71e57705
Merge #9648
...
9648: minor: address review comments r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2021-07-20 14:50:43 +00:00
Aleksey Kladov
60e7c1de83
minor: address review comments
2021-07-20 17:49:33 +03:00
bors[bot]
c7c2144fa3
Merge #9647
...
9647: internal: remove potentially slow method r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2021-07-20 14:20:31 +00:00
Aleksey Kladov
7ec8434674
internal: remove potentially slow method
2021-07-20 17:19:58 +03:00
Aleksey Kladov
3c5827cc18
internal: remove one usage of a slow method
2021-07-20 17:11:09 +03:00
bors[bot]
a646ddf230
Merge #9646
...
9646: add 'use' prefix for any auto-import r=Veykril a=mahdi-frms
Fixes #9643
looks like there was an if condition that had to be removed.
Co-authored-by: mahdi-frms <mahdif1380@outlook.com>
2021-07-20 14:09:24 +00:00
mahdi-frms
65839f4069
add 'use' prefix for any auto-import
2021-07-20 18:35:19 +04:30
Aleksey Kladov
8e0630e728
internal: remove one usage of a slow method
2021-07-20 17:02:37 +03:00
Lukas Wirth
e8f1abf5f7
Correctly generate link fragments for associated items
2021-07-20 16:01:27 +02:00
Lukas Wirth
113beab473
Cleanup runnables canonical path impl
2021-07-20 16:00:44 +02:00
bors[bot]
5fee2bef19
Merge #9644
...
9644: internal: add simple smoke test for project model r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2021-07-20 13:31:11 +00:00
Aleksey Kladov
b0c4b776b5
internal: add simple smoke test for project model
...
Our project model code is rather complicated -- the logic for lowering
from `cargo metadata` to `CrateGraph` is fiddly and special-case. So
far, we survived without testing this at all, but this increasingly
seems like a poor option.
So this PR introduces a simple tests just to detect the most obvious
failures. The idea here is that, although we rely on external processes
(cargo & rustc), we are actually using their stable interfaces, so we
might just mock out the outputs.
Long term, I would like to try to virtualize IO here, so as to do such
mocking in a more principled way, but lets start simple.
Should we forgo the mocking and just call `cargo metadata` directly
perhaps? Touch question -- I personally feel that fast, in-process tests
are more important in this case than any extra assurance we get from
running the real thing.
Super-long term, we would probably want to extend our heavy tests to
cover more use-cases, but we should figure a way to do that without
slowing the tests down for everyone.
Perhaps we need two-tiered bors system, where we pull from `master` into
`release` branch only when an additional set of tests passes?
2021-07-20 16:23:57 +03:00
bors[bot]
2211d2cece
Merge #9645
...
9645: internal: easier to skim CI logs r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2021-07-20 12:58:31 +00:00
