Lukas Wirth
486c7175fe
Remove unnecessary allocs in case_conv
2021-02-05 15:02:39 +01:00
Lukas Wirth
426ad8e165
Classify function calls as functions when shadowed by types
2021-01-28 19:08:55 +01:00
Phil Ellison
65a5ea581d
Update tests to register the required standard library types
2021-01-23 07:40:25 +00:00
Phil Ellison
8c7ccdc29d
Identify methods using functions ids rather than string names
2021-01-23 07:40:25 +00:00
Phil Ellison
1ff860b93c
Implement fix, add tests
2021-01-23 07:40:25 +00:00
Phil Ellison
1316422a7c
Add diagnostic for filter_map followed by next
2021-01-23 07:40:24 +00:00
Aleksey Kladov
4c4e54ac8a
prepare to publish el libro de arena
2021-01-14 19:06:02 +03:00
Vincent Esche
c8c2bd097a
Fixed typos in local bindings
2021-01-09 15:41:29 +01:00
Vincent Esche
21f8239ac8
Fixed typos in code comments
2021-01-09 15:41:29 +01:00
Phil Ellison
554ee6ea02
cargo fmt
2021-01-07 19:01:33 +00:00
Phil Ellison
b2dbe6e43a
Add fix to wrap return expression in Some
2021-01-07 19:01:33 +00:00
Florian Diebold
29acd39800
Don't emit arg count diagnostics for method calls with unknown receiver
...
Fixes #7098 .
2021-01-01 20:49:18 +01:00
Jonas Schievink
6615fda695
decl_check: don't pass db
around so often
2020-12-17 01:19:56 +01:00
bors[bot]
44978acf51
Merge #6769
...
6769: Add native "remove this semicolon" diagnostics r=matklad a=ivan770
Closes #6739
![demo2](https://user-images.githubusercontent.com/14003886/101530533-b76c3180-399a-11eb-9d18-5c8457721655.gif )
Co-authored-by: ivan770 <leshenko.ivan770@gmail.com>
2020-12-10 16:18:49 +00:00
ivan770
bbb0bc7b04
Cast to ExprStmt, style fixes
2020-12-10 18:10:39 +02:00
Jonas Schievink
05d4a5a150
Use mark/hit
2020-12-10 15:56:04 +01:00
Jonas Schievink
d82292e1ce
Ignore extern items in incorrect-case check
2020-12-10 15:45:01 +01:00
ivan770
35006eba79
Apply rustfmt changes
2020-12-09 08:22:13 +00:00
ivan770
86c183716c
Apply suggestions from code review
...
Co-authored-by: bjorn3 <bjorn3@users.noreply.github.com>
2020-12-09 10:17:28 +02:00
ivan770
7738467e0a
Format code
2020-12-08 19:25:21 +00:00
ivan770
581567a4c8
Remove use via super
2020-12-08 20:50:13 +02:00
ivan770
cb66bb8ff9
Remove this semicolon
2020-12-08 20:47:20 +02:00
Lukas Wirth
377fa7db3f
Check structs for match exhaustiveness
2020-11-24 18:50:56 +01:00
Lukas Wirth
4d841dc4e7
Add middle ellipsis missing arm text
2020-11-24 16:46:06 +01:00
Lukas Wirth
a4b5275656
Handle ellipsis in tuple patterns in match exhaustiveness checking
2020-11-24 16:43:28 +01:00
Igor Aleksanov
dd2febf05a
Improve decl_check module readability
2020-11-03 10:13:49 +03:00
Igor Aleksanov
9e172ffeb7
Remove numbers from comments in decl_check.rs
2020-11-03 10:11:02 +03:00
Igor Aleksanov
bdfe12df8f
Check for allow(..) attributes for case diagnostic
2020-11-03 10:11:02 +03:00
Aleksey Kladov
b610118453
Deny unreachable-pub
...
It's very useful when `pub` is equivalent to "this is crate's public
API", let's enforce this!
Ideally, we should enforce it for local `cargo test`, and only during
CI, but that needs https://github.com/rust-lang/cargo/issues/5034 .
2020-11-02 14:07:08 +01:00
Arif Roktim
afb2166aeb
Make IncorrectDiagnostic match rustc by copying rustc's code.
2020-10-24 19:21:53 -04:00
bors[bot]
31db677a94
Merge #6319
...
6319: Properly identify camel cased acronyms as UpperCamelCase r=popzxc a=ArifRoktim
This closes #6305 .
Co-authored-by: Arif Roktim <arifrroktim@gmail.com>
2020-10-22 14:24:10 +00:00
Arif Roktim
854b133181
Properly identify camel cased acronyms as UpperCamelCase
2020-10-21 17:10:22 -04:00
Francesco Zardi
0be21b05d6
Move safe intrinsic tests
2020-10-21 21:53:05 +02:00
Igor Aleksanov
fb0ab9f745
Keep SyntaxNodePtr::range private
2020-10-12 11:05:00 +03:00
Igor Aleksanov
66cea8cbaa
Replace 'if let' with 'match' in decl_check.rs
2020-10-12 11:05:00 +03:00
Igor Aleksanov
559cc97073
Add to_upper_snake_case function to stdx
2020-10-12 11:05:00 +03:00
Igor Aleksanov
ebd30033b3
Fix compilation error
2020-10-12 11:05:00 +03:00
Igor Aleksanov
f2c91fc5a8
Apply suggestions from code review
...
Co-authored-by: Lukas Wirth <lukastw97@gmail.com>
2020-10-12 11:05:00 +03:00
Igor Aleksanov
9ea57cac0e
Fix code style issues
2020-10-12 11:05:00 +03:00
Igor Aleksanov
2a72f876d6
Fix issues with match arm bindings
2020-10-12 11:05:00 +03:00
Igor Aleksanov
45ac2b2ede
Code style adjustments
2020-10-12 11:05:00 +03:00
Igor Aleksanov
b42562b5de
Make incorrect case diagnostic work inside of functions
2020-10-12 11:05:00 +03:00
Igor Aleksanov
9ec1741b65
Refactor string helpers for decl_check module
2020-10-12 11:05:00 +03:00
Igor Aleksanov
fb96bba878
Add diagnostics for enum names and variants
2020-10-12 11:05:00 +03:00
Igor Aleksanov
17f1026c46
Improve string helpers functions
2020-10-12 10:59:54 +03:00
Igor Aleksanov
21dd704b6b
Check structure fields to be snake_case
2020-10-12 10:59:54 +03:00
Igor Aleksanov
329626124f
Add check for structure names to be CamelCase
2020-10-12 10:59:54 +03:00
Igor Aleksanov
1773c6d154
Extract helper functions into a separate module
2020-10-12 10:59:54 +03:00
Igor Aleksanov
f5cea35986
Add checks for function parameters
2020-10-12 10:59:54 +03:00
Igor Aleksanov
4039176ec6
Create basic support for names case checks and implement function name case check
2020-10-12 10:59:54 +03:00
CAD97
c822bb68ce
Fix missing match arm false error on unknown type
2020-08-17 13:27:12 -04:00
CAD97
2eaf79cfbb
Document missing match arm false positive
...
This should already be guarded against
(d2212a49f6/crates/hir_ty/src/diagnostics/expr.rs (L225-L230)
)
but it isn't preventing this false positive for some reason.
2020-08-17 13:19:15 -04:00
Aleksey Kladov
6a77ec7bbe
Rename ra_hir_ty -> hir_ty
2020-08-13 16:35:29 +02:00