375 Commits

Author SHA1 Message Date
Alex Crichton
f006e86eed rollup merge of #17992 : jkleint/guide-double-borrow 2014-10-13 15:10:08 -07:00
Alex Crichton
ad25e560a0 rollup merge of #17986 : gamazeps/docissue 2014-10-13 15:10:01 -07:00
John Kleint
ed7d1be12f Guide: specify that both shared and mutable borrows can be re-lent. 2014-10-12 23:50:22 -04:00
Felix Raimundo
1cbce309fe Fixes small error on the doc (task part) 2014-10-13 00:13:41 +02:00
John Kleint
67418f5509 Guide: remove promise of a counter in the guessing game.
Issue #17964.
2014-10-12 15:24:39 -04:00
bors
afb5fcd553 auto merge of #17843 : coffeejunk/rust/guide-macros, r=steveklabnik
The old version switched in between examples from the value `5i` to `"Hello"` and back.

Additionally, the code generated by `rustc print.rs --pretty=expanded` is not as verbose anymore.
2014-10-08 17:52:08 +00:00
bors
0606234880 auto merge of #17836 : typelist/rust/guide-tuples, r=steveklabnik
Currently, the Guide says tuples "are only equivalent if the arity, types, and values are all identical", before presenting an example that uses `==` to compare two tuples whose arity and contained types match. This is misleading, because it implies that `==` can dynamically check whether two tuples have the same arity and contained types, whereas trying to do this would lead to a compiler error.

I tried to avoid destroying the flow of this section, but I'm not sure if I've been successful.
2014-10-08 01:02:10 +00:00
Maximilian Haack
e656affa79 Guide: Fix inconsistency in 'Marcos' section
The old version switched in between examples from the value `5i` to `"Hello"`
and back. Additionally, the code generated by `rustc print.rs
--pretty=expanded` is not as verbose anymore.
2014-10-07 13:12:27 +02:00
Johannes Muenzel
c211d132c3 Clarify that assigning/comparing different tuple types to one another won't compile 2014-10-07 01:43:18 -04:00
Brian Anderson
25e81d2f5f doc: Update output of rustc --version 2014-10-06 16:22:44 -07:00
bors
8794107f74 auto merge of #17754 : O-I/rust/update-guide, r=steveklabnik
Hi,

These are a few small edits to the Guide that I made while reading online. Really well done and approachable.

I have a few questions below, but I don't know if this is the proper place to ask them, so feel free to ignore the below.

1. Trailing commas seem to be a convention in Rust and are used quite a bit throughout the Guide, but are never explicitly mentioned. Maybe adding a short mention about them when they first appear in the Structs section might be helpful to those who are unfamiliar with or don't use them in other languages.

2. In the Iterators section, there is a block of code like this:

```rust
let mut range = range(0i, 10i);

loop {
    match range.next() {
        Some(x) => {
            println!("{}", x);
        }  // no comma needed?
        None => { break }
    }
}
```

My inclination would be to put a comma where the comment is to separate the two arms to get this to compile, but it runs fine either way. Is there a convention on commas for scenarios like this where each arm is enclosed in `{}`?

All the best,
O-I
2014-10-04 04:27:05 +00:00
Rahul Horé
9040948ef3 Adds comma
Oddly (to me), this code runs fine without the comma separating the `Some` and `None` arms of the `match` construct. It seems like Rust doesn't require you to separate arms with commas if all the expressions are enclosed in braces.
2014-10-03 16:40:58 -04:00
Rahul Horé
083b46dd29 Fixes wording 2014-10-03 15:59:57 -04:00
Rahul Horé
0eb4df9ace Removes extra . 2014-10-03 15:41:59 -04:00
Rahul Horé
d3f8f8a849 Adds missing cd 2014-10-03 14:47:57 -04:00
Rahul Horé
816c56e1d5 Use similar syntax in all arms
See issue #17672. This was started in commit ee1cbb9c71bfab8500dfabedb35ba63dd1e5b7ff, but there were a few more lines to update.
2014-10-03 14:41:55 -04:00
Rahul Horé
060224af68 Fixes output 2014-10-03 13:59:32 -04:00
Rahul Horé
e8ddad18e8 Adds trailing comma 2014-10-03 13:50:42 -04:00
Rahul Horé
8a6342f751 Fixes spacing 2014-10-03 13:37:05 -04:00
Steve Klabnik
71f752bbc4 Update signature of try_recv() 2014-10-03 11:58:52 -04:00
bors
9a2286d3a1 auto merge of #16995 : kmcallister/rust/plugin-tutorial, r=alexcrichton
@steveklabnik, are you interested in looking this over?
2014-10-03 07:33:26 +00:00
Alex Crichton
005ae8e3dd rollup merge of #17717 : steveklabnik/gh17190 2014-10-02 14:50:46 -07:00
Alex Crichton
6ee3c2854f rollup merge of #17698 : jistr/guide_export 2014-10-02 14:50:27 -07:00
Steve Klabnik
85a8b92b51 extra comment about macros
Fixes #17190
2014-10-02 15:12:27 -04:00
Steve Klabnik
dc35a53d15 Fix incorrect statement about ok()
Fixes #17676.
2014-10-01 17:16:34 -04:00
Steve Klabnik
e2357cf41b Don't compare () to null.
Fixes #17671.
2014-10-01 17:14:29 -04:00
Steve Klabnik
ee1cbb9c71 use similar syntax in all arms
Fixes #17672
2014-10-01 17:12:29 -04:00
Keegan McAllister
e3828026d5 Use relative doc URLs in top-level guides 2014-10-01 13:21:52 -07:00
Jiří Stránský
ac956c013f Guide: clarify exporting
Mention that using `pub` is called exporting.

Remove that `use` is called re-exporting, because `pub use` should be
called re-exporting. The guide currently doesn't cover `pub use`.
2014-10-01 22:20:58 +02:00
Patrick Walton
416144b827 librustc: Forbid .. in range patterns.
This breaks code that looks like:

    match foo {
        1..3 => { ... }
    }

Instead, write:

    match foo {
        1...3 => { ... }
    }

Closes #17295.

[breaking-change]
2014-09-30 09:11:26 -07:00
Alex Crichton
1ebf456fb0 rollup merge of #17510 : MatejLach/find_fix 2014-09-29 08:10:32 -07:00
bors
eb816eee0f auto merge of #17535 : Manishearth/rust/patch-2, r=steveklabnik
It's a rather useful syntax, and non-obvious.

A friend of mine is learning Rust and was trying to find a way to easily do such an initialization — he couldn't find it in the guide and was pretty surprised when I showed him. Looks like something that should be mentioned.

r? @steveklabnik
2014-09-29 07:43:07 +00:00
Manish Goregaokar
1f4cd80ac5 Mention array sugar in guide 2014-09-26 00:00:27 +05:30
Matej Lach
9ca399f14e Correct tense 2014-09-25 16:13:20 +01:00
Matej Lach
5a25537faf Correct typo in the Iterator adapters section 2014-09-24 13:35:33 +01:00
Matej Lach
3c47d89614 Remove unnecessary code from an example 2014-09-24 12:39:16 +01:00
bors
7fbbfe6bf2 auto merge of #17366 : ohazi/rust/master, r=steveklabnik
See: http://doc.rust-lang.org/std/from_str/trait.FromStr.html
```
let input_num = from_str::<Option<uint>>("5");
```
```
<anon>:2:21: 2:45 error: failed to find an implementation of trait std::from_str::FromStr for core::option::Option<uint>
<anon>:2     let input_num = from_str::<Option<uint>>("5");
                             ^~~~~~~~~~~~~~~~~~~~~~~~
```
2014-09-23 20:20:41 +00:00
Alex Crichton
dbaa9300ac rollup merge of #17350 : pablobm/doc-fix 2014-09-19 10:00:32 -07:00
Oren Hazi
c942df9fa5 from_str has an impl for uint, not Option<uint> 2014-09-18 00:52:42 -07:00
Pablo Brasero
17674e02fc Fix warning and make code follow the text better 2014-09-17 21:05:16 +01:00
Alex Crichton
1921055dda rollup merge of #17294 : theevocater/master 2014-09-17 08:49:31 -07:00
Alex Crichton
b27947ac4d rollup merge of #17278 : steveklabnik/gh17242 2014-09-17 08:49:08 -07:00
Alex Crichton
b4bff574d2 rollup merge of #17277 : steveklabnik/doc_fix_rollup 2014-09-17 08:49:06 -07:00
bors
ff613abaa2 auto merge of #17227 : tshepang/rust/stronger-break, r=aturon
Remove trailing whitespace while at it
2014-09-17 03:46:15 +00:00
Aaron Turon
fc525eeb4e Fallout from renaming 2014-09-16 14:37:48 -07:00
Jake Kaufman
7d00eb6133 Update triple per comments 2014-09-16 08:44:47 -07:00
bors
c09437ab2d auto merge of #17244 : spastorino/rust/patch-1, r=alexcrichton 2014-09-16 11:11:03 +00:00
Jake Kaufman
2f35723170 Correct windows install link in guide
This closes #17260. The guide references the old install location for
the windows rust install before it was split into 64bit and 32bit
installers. This adds a link to each binary.
2014-09-15 23:36:17 -07:00
Dan Connolly
2ee91ea437 use _sample configurations..._ rather than _here_ as link text 2014-09-15 13:40:16 -04:00
Steve Klabnik
51b4c515f4 remove rendundant function
Fixes #17230.
2014-09-15 13:23:46 -04:00