bors
3899d6001c
Auto merge of #5878 - flip1995:rustup, r=flip1995
...
Rustup
r? @ghost
changelog: none
2020-08-08 17:28:34 +00:00
flip1995
fd87cdb357
Run fmt
2020-08-08 19:20:34 +02:00
Eduardo Broto
888657e09a
Fix ICE in loops
module
2020-08-08 18:13:43 +02:00
Nicholas Nethercote
01bba2c532
Eliminate the SessionGlobals
from librustc_ast
.
...
By moving `{known,used}_attrs` from `SessionGlobals` to `Session`. This
means they are accessed via the `Session`, rather than via TLS. A few
`Attr` methods and `librustc_ast` functions are now methods of
`Session`.
All of this required passing a `Session` to lots of functions that didn't
already have one. Some of these functions also had arguments removed, because
those arguments could be accessed directly via the `Session` argument.
`contains_feature_attr()` was dead, and is removed.
Some functions were moved from `librustc_ast` elsewhere because they now need
to access `Session`, which isn't available in that crate.
- `entry_point_type()` --> `librustc_builtin_macros`
- `global_allocator_spans()` --> `librustc_metadata`
- `is_proc_macro_attr()` --> `Session`
2020-08-08 12:03:42 +10:00
Camelid
bd71b01a82
Make the docs clearer for new contributors
...
* Add an easy-to-see note at the top of `CONTRIBUTING.md` that points
new contributors to the Basics docs
* Add a note about compiler errors as a result of internals changes
that break Clippy
2020-08-07 16:15:44 -07:00
Christoph Walcher
87e740921a
check impl Ord / is_float
2020-08-07 18:30:20 +02:00
Christoph Walcher
bfe610cc8d
ignore mutable self reference parameters
2020-08-07 18:08:51 +02:00
Christoph Walcher
e03f73e627
fix nits
2020-08-07 18:08:51 +02:00
Christoph Walcher
c87d999fa2
fix ui tests
2020-08-07 18:08:51 +02:00
Christoph Walcher
d635b76eaf
adopt comments from review
2020-08-07 18:08:51 +02:00
Christoph Walcher
737f62cb6e
fix doc
2020-08-07 18:08:51 +02:00
Christoph Walcher
e0a4988fcc
Lint against Self
as an arbitrary self type
...
Fixes #5861
2020-08-07 18:08:51 +02:00
bors
a7fa264ae7
Auto merge of #74821 - oli-obk:const_eval_read_uninit_fast_path, r=wesleywiser
...
Check whether locals are too large instead of whether accesses into them are too large
Essentially this stops const prop from attempting to optimize
```rust
let mut x = [0_u8; 5000];
x[42] = 3;
```
I don't expect this to be a perf improvement without #73656 (which is also where the lack of this PR will be a perf regression).
r? @wesleywiser
2020-08-07 15:28:07 +00:00
Ryan1729
fe9ad57e98
copy over *.fixed file
2020-08-06 20:28:29 -06:00
Vadim Petrochenkov
a285b58368
Add some comments for magic numbers + Add tests
2020-08-06 22:55:26 +03:00
Vadim Petrochenkov
d642c3b6f8
Fix clippy
2020-08-06 22:13:11 +03:00
Ryan Wiedemann
49c7e39d03
Apply suggestions from code review
...
Co-authored-by: Philipp Krones <hello@philkrones.com>
2020-08-06 07:57:31 -06:00
Ryan1729
42f3d39a54
run clippy_dev fmt
...
This seemed to overdo it a bit, affecting multiple submodules, and changing a file I didn't touch, so I didn't commit those changes
2020-08-06 06:15:57 -06:00
Ryan1729
0d2a378547
run clippy_dev update_lints
2020-08-06 06:11:23 -06:00
Ryan1729
b0c8c7af16
add newline to transmutes_expressible_as_ptr_casts.rs
2020-08-06 04:49:06 -06:00
Ryan1729
8997c558d8
change filter to assert, and update comments
2020-08-06 04:24:25 -06:00
Ryan1729
ded2d6c233
add extra error message to the expected stderr for transmutes_expressible_as_ptr_casts test
2020-08-06 04:24:25 -06:00
Ryan1729
94340d6e17
add documentation to functions that call do_check
and add a test against lint ordering changing
2020-08-06 04:24:25 -06:00
Ryan1729
19f36bc2f3
add description to assert
2020-08-06 04:24:25 -06:00
Ryan1729
d38766ed96
address some review comments
2020-08-06 04:24:25 -06:00
Ryan1729
ccc4747f46
get the expected number of errors by acknowledging that other lints are covering the same ground
2020-08-06 04:24:25 -06:00
Ryan1729
de05212987
try putting the can_be_expressed_as_pointer_cast at the top and find that we still get an ICE
2020-08-06 04:24:24 -06:00
Ryan1729
34d3a0086c
accidentally cause an ICE by putting the TRANSMUTES_EXPRESSIBLE_AS_PTR_CASTS handling after the match
...
The reason I did this in the first place was to try and figure out why I don't see my expected 7 error messages
2020-08-06 04:24:24 -06:00
Ryan1729
46ef4e8651
write currently failing test for transmutes_expressible_as_ptr_casts
...
There are 5 errors, when there should be 7.
2020-08-06 04:24:24 -06:00
Ryan1729
069f851671
initial compiling version of TRANSMUTES_EXPRESSIBLE_AS_PTR_CASTS
2020-08-06 04:24:24 -06:00
Ryan1729
5e84b8c2fb
run cargo dev new_lint then move transmutes_expressible_as_ptr_casts into transmute module
2020-08-06 04:24:24 -06:00
Christoph Walcher
0abc4833e5
Lint .min(x).max(y) with x < y
...
Fixes #5854
2020-08-06 02:56:07 +02:00
Eduardo Broto
50a86d4927
enable #[allow(clippy::unsafe_derive_deserialize)]
2020-08-06 00:45:30 +02:00
bors
2d4c3379d3
Auto merge of #5809 - JarredAllen:stable_sort_primitive, r=Manishearth
...
Stable sort primitive
changelog: Implements #5762
2020-08-05 20:41:21 +00:00
bors
2eab060ab7
Auto merge of #5859 - ebroto:5765_manual_async_fn_fp, r=yaahc
...
manual_async_fn: take input lifetimes into account
The anonymous future returned from an `async fn` captures all input
lifetimes. This was not being taken into account.
See https://github.com/rust-lang/rfcs/blob/master/text/2394-async_await.md#lifetime-capture-in-the-anonymous-future
changelog: Take input lifetimes into account in [`manual_async_fn`].
Fixes #5765
2020-08-05 17:52:28 +00:00
Takayuki Nakata
610d4e3c8b
rustfmt
2020-08-05 23:10:30 +09:00
Takayuki Nakata
e48685edef
Just check if it contains _
in for pat
2020-08-05 23:00:03 +09:00
Takayuki Nakata
228f668282
Use mutated_variables
2020-08-05 23:00:03 +09:00
Takayuki Nakata
b7ceb4d3d7
rustfmt
2020-08-05 23:00:03 +09:00
Takayuki Nakata
14a4e3bcc8
Fix a lint message
2020-08-05 22:59:12 +09:00
Takayuki Nakata
1543e117cc
cargo dev update_lints
2020-08-05 22:51:38 +09:00
Takayuki Nakata
2beb9090d1
Rename TypeckTables to TypeckResults
2020-08-05 22:51:38 +09:00
Takayuki Nakata
161f475100
Add test case for same_item_push
2020-08-05 22:51:38 +09:00
Takayuki Nakata
1e8ada3cab
Add lint same_item_push
2020-08-05 22:51:38 +09:00
bors
3d7e3fdffd
Auto merge of #5857 - tmiasko:try-err-poll, r=matthiaskrgr
...
try_err: Consider Try impl for Poll when generating suggestions
There are two different implementation of `Try` trait for `Poll` type:
`Poll<Result<T, E>>` and `Poll<Option<Result<T, E>>>`. Take them into
account when generating suggestions.
For example, for `Err(e)?` suggest either `return Poll::Ready(Err(e))` or
`return Poll::Ready(Some(Err(e)))` as appropriate.
Fixes #5855
changelog: try_err: Consider Try impl for Poll when generating suggestions
2020-08-05 08:43:37 +00:00
JarredAllen
542740c2ec
Run cargo dev fmt
2020-08-04 17:53:29 -07:00
bors
2ceb8c6c2d
Auto merge of #5865 - camsteffen:unnecessary-fold-known-probs, r=Manishearth
...
Remove obsolete known problems unnecessary_fold
The known problems looks to be obsolete since NLL is stable.
changelog: none
2020-08-04 23:09:35 +00:00
bors
80121781a3
Auto merge of #5868 - flip1995:rollup-5g8vft5, r=flip1995
...
Rollup of 5 pull requests
Successful merges:
- #5837 (needless_collect: catch x: Vec<_> = iter.collect(); x.into_iter() ...)
- #5846 (Handle mapping to Option in `map_flatten` lint)
- #5848 (Add derive_ord_xor_partial_ord lint)
- #5852 (Add lint for duplicate methods of trait bounds)
- #5856 (Remove old Symbol reexport)
Failed merges:
r? @ghost
changelog: rollup
2020-08-04 10:07:47 +00:00
Philipp Krones
fb7ad956f6
Rollup merge of #5856 - phansch:remove-symbol-reexport, r=flip1995
...
Remove old Symbol reexport
I couldn't really tell what it was meant to improve. It seems more clear
without the renaming to `Name`?
changelog: none
2020-08-04 12:06:43 +02:00
Philipp Krones
84455b211f
Rollup merge of #5852 - wiomoc:feature/lint-duplicate-trait, r=Manishearth
...
Add lint for duplicate methods of trait bounds
rel: #5777
changelog: Add [`trait_duplication_in_bounds`] lint
2020-08-04 12:06:41 +02:00