Matthias Kaak
7c82e78f30
improved help message for suspicious_map
2021-10-05 19:09:08 +00:00
hkalbasi
388a3d0983
Implement equatable if let lint
2021-10-04 22:16:42 +03:30
Takayuki Nakata
72f0180f7b
Fix ICE in implicit_hasher
2021-10-04 23:31:40 +09:00
bors
63b04f7d7f
Auto merge of #7755 - HKalbasi:master, r=xFrednet
...
exclude enum from derivable impls
fix #7753
changelog: Exclude enum from ``[`derivable_impls`]``
2021-10-03 10:30:16 +00:00
bors
33c34fb2d7
Auto merge of #7709 - Qwaz:drop_non_send, r=xFrednet
...
Implement `non_send_field_in_send_ty` lint
changelog: Implement [`non_send_fields_in_send_ty`] lint
Fixes #7703
2021-10-03 08:43:32 +00:00
hkalbasi
ea8e65f0da
exclude enum from derivable impls
2021-10-03 11:58:27 +03:30
Yechan Bae
fb0353b28d
Update documentation and name for non_send_fields_in_send_ty lint
2021-10-02 19:22:37 -04:00
Manish Goregaokar
6bf5c0b185
Correctly handle signs in exponents in numeric_literal::format()
2021-10-01 17:27:47 -07:00
Manish Goregaokar
51160808b8
Add regression test
2021-10-01 16:14:35 -07:00
Yechan Bae
ef8df9df68
Forgot to bless ui-toml test
2021-10-01 14:26:04 -04:00
Yechan Bae
dfed2e31d5
Do not use full type path in help message
2021-10-01 14:04:20 -04:00
Yechan Bae
4f01656a7d
Add ui-test for enable-raw-pointer-heuristic-for-send config
2021-10-01 14:04:20 -04:00
Yechan Bae
08f0aecffd
Minor changes from PR feedback
2021-10-01 14:04:20 -04:00
Yechan Bae
427a09ba7b
Add configuration for raw pointer heuristic
2021-10-01 14:04:20 -04:00
Yechan Bae
d413e157a5
Look into tuple, array, ADT args in raw pointer heuristic
2021-10-01 14:04:20 -04:00
Yechan Bae
ee74574876
Emit one report for all fields in the same ADT
2021-10-01 14:04:20 -04:00
Yechan Bae
d7a9ec2c50
Fix attribute handling
2021-10-01 14:04:20 -04:00
Yechan Bae
e4c3000e5b
Initial implementation
2021-10-01 14:04:20 -04:00
bors
fe999e88ed
Auto merge of #7741 - surechen:fix_if_then_panic, r=flip1995
...
Make if_then_panic handle situation of BinOpKind::And || BinOpKind::Or
fixes #7731
Make if_then_panic handle situation of cond.kind = ExprKind::DropTemps(ExprKind::Binary(BinOpKind::And || BinOpKind::Or, left, right), ..) =
changelog: [`if_then_panic`] Fix suggestion for more complex conditions
2021-10-01 10:04:19 +00:00
surechen
41e2c68a6e
use sugg::Sugg::maybe_par
2021-10-01 13:13:09 +08:00
Cameron Steffen
a17359c696
Remove shadow allows
2021-09-30 14:07:58 -05:00
Cameron Steffen
8c0e4d5ccf
Rewrite shadow lint
2021-09-30 14:07:58 -05:00
Cameron Steffen
99861c0e88
Remove initialization note from shadow lint
2021-09-30 13:54:30 -05:00
bors
a893eb993b
Auto merge of #7677 - surechen:edit_large_enum_variant, r=camsteffen
...
fix bug for large_enum_variants
Fix the discussion problem in the issue of https://github.com/rust-lang/rust-clippy/issues/7666#issuecomment-919654291
About the false positive problem of case:
```rust
enum LargeEnum6 {
A,
B([u8;255]),
C([u8;200]),
}
```
changelog: Fix largest_enum_variant wrongly identifying the second largest variant.
2021-09-30 12:45:17 +00:00
surechen
4babfae9cb
fix issue #7731
...
Make if_then_else handle situation of cond.kind = ExprKind::DropTemps(ExprKind::Binary(BinOpKind::And || BinOpKind::Or, left, right), ..) =
2021-09-30 19:06:42 +08:00
bors
ab99eec15f
Auto merge of #7684 - surechen:solve_derivable_impls, r=flip1995
...
fix for issue #7683
Fixes #7683 .
For Repeat [x; y] (x is the type and y is the times to repeat) . When y > 32, the compiler will report an error:
https://play.rust-lang.org/?version=stable&mode=debug&edition=2018&gist=7148558162685e91056e0550797ea74c
Because 6cdd42f9f8/library/std/src/primitive_docs.rs (L538)
2021-09-30 08:19:58 +00:00
surechen
a3d3735515
Arrays of sizes from 0 to 32 (inclusive) implement [Default] trait, edit method is_default_equivalent() to satisfy with this.
2021-09-30 10:41:36 +08:00
surechen
56f0c9afdd
fix bug for large_enum_variants
2021-09-30 10:07:57 +08:00
bors
fb17671eb0
Auto merge of #7734 - Manishearth:doc-unsafe-trait, r=camsteffen
...
Make `doc_unsafe` warn on unsafe traits as well
Fixes #7732
changelog: Make [`doc_unsafe`] warn on unsafe traits as well
2021-09-28 17:09:34 +00:00
bors
9fc4b92eb2
Auto merge of #7711 - camsteffen:depinfo-error, r=flip1995
...
Improve depinfo error
changelog: none
r? `@flip1995`
2021-09-28 16:56:02 +00:00
bors
cb7915b00c
Auto merge of #7733 - flip1995:rustup, r=flip1995
...
Rustup
This needs a review this time. Especially 521bf8f0fa🤔
( I forgot about the sync last week. I should get to document this process better, so other people can do it when I'm not around )
changelog: none
2021-09-28 16:42:31 +00:00
Manish Goregaokar
53c534d11b
Update clippy_lints/src/doc.rs
...
Co-authored-by: Cameron Steffen <cam.steffen94@gmail.com>
2021-09-28 09:37:58 -07:00
flip1995
ec38746b4a
Allow internal lint INVALID_PATHS for itertools path
...
Since clippy_utils doesn't depend on the itertools crate anymore, the
lint can't find the path.
2021-09-28 17:07:51 +01:00
Manish Goregaokar
25850fc264
Make doc_unsafe lint on unsafe traits as well
2021-09-28 08:40:59 -07:00
flip1995
707494eca9
Merge remote-tracking branch 'upstream/master' into rustup
2021-09-28 10:52:31 +01:00
Andrew Pollack
b7d40bc103
Adding new linting
2021-09-27 22:23:17 -07:00
David Tolnay
e63d69244e
Stop suggesting a float truncation that is not shorter
2021-09-25 22:55:23 -07:00
Cameron Steffen
f6c5d580b8
Improve depinfo error
2021-09-24 10:27:11 -05:00
Labelray
543b638dbe
Add new lint if_then_panic
2021-09-24 22:14:20 +08:00
bors
cd3f3cf8a8
Auto merge of #7707 - Jarcho:suspicious_else_proc_mac, r=Manishearth
...
Don't lint `suspicious_else_formatting` inside proc-macros
fixes : #7650
I'll add a test for this one soon.
changelog: Don't lint `suspicious_else_formatting` inside proc-macros
2021-09-23 16:14:29 +00:00
Jason Newcomb
e69154f370
Add test for #7650
2021-09-23 11:22:38 -04:00
bors
ef2e2f0a0c
Auto merge of #7693 - F3real:vec2, r=Manishearth
...
Expand box_vec lint to box_collection
fixed #7451
changelog: Expand `box_vec` into [`box_collection`], and have it error on all sorts of boxed collections
2021-09-22 22:13:13 +00:00
bors
a4a8ec2d52
Auto merge of #7679 - lengyijun:issue4546, r=xFrednet
...
add #4546 test
changelog: none
fixed #4546
I notice #4546 was fixed some time, I just add the tests.
2021-09-22 09:00:30 +00:00
lengyijun
b68325ecf6
add #4546 test
2021-09-22 16:04:04 +08:00
bors
8a75002930
Auto merge of #7685 - camsteffen:let-else-needless-ret, r=giraffate
...
Fix needless_return with let-else
changelog: Fix needless_return FP with `let...else`
Fixes #7637
2021-09-22 00:23:23 +00:00
F3real
63ed2f9eb4
Expand BOX_VEC to BOX_COLLECTION
2021-09-20 10:23:55 +02:00
bors
871ad80bb0
Auto merge of #7690 - Jarcho:while_loop_by_ref, r=xFrednet
...
Change `while_let_on_iterator` suggestion to use `by_ref()`
It came up in the discussion #7659 that suggesting `iter.by_ref()` is a clearer suggestion than `&mut iter`. I personally think they're equivalent, but if `by_ref()` is clearer to people then that should be the suggestion.
changelog: Change `while_let_on_iterator` suggestion when using `&mut` to use `by_ref()`
2021-09-19 17:37:04 +00:00
Cameron Steffen
b36591217d
Fix needless_return with let-else
2021-09-18 09:42:51 -05:00
Jason Newcomb
ee6a6b55c4
Change the suggestion for while_let_on_iterator when the iterator cannot be consumed to iter.by_ref()
2021-09-17 21:44:21 -04:00
bors
59cd77710d
Auto merge of #7657 - dswij:needless-borrow-mut, r=llogiq
...
`needless_borrow` checks for mutable borrow
closes #7635
changelog: [`needless_borrow`] now checks for needless mutable borrow
2021-09-17 22:25:07 +00:00
