Aleksey Kladov
136151515a
Replace generic with a concrete type
2020-02-25 12:43:08 +01:00
bors[bot]
c4c15363fb
Merge #3295
...
3295: Refactoring fetchArtifactReleaseInfo() r=matklad a=Veetaha
https://github.com/typescript-eslint/typescript-eslint/blob/master/packages/eslint-plugin/docs/rules/no-unnecessary-type-assertion.md
I fact this rule doesn't work when you put an unnecessary non-null assertion in an expression (as we had `(awat f())!`, but it is useful in other cases...
Closes #3295 , i guess...
Co-authored-by: Veetaha <gerzoh1@gmail.com>
2020-02-25 10:09:14 +00:00
bors[bot]
1fe48a0115
Merge #3159
...
3159: Server-side Semantic Tokens r=matklad a=kjeremy
Takes the output of `syntax_highlighting` and converts it to the proposed semantic tokens API (so far only `textDocument/semanticTokens`. There's a lot of cool stuff we could do with this and the "Inspect Editor Tokens and Scopes" vscode command (pic below) is a cool way to see what has tokens and what doesn't.
Incredibly hacky and could panic due to unwraps, `panic!` etc. To use: run with `code-insiders --enable-proposed-api matklad.rust-analyzer`. If you try to run this without `--enable-proposed-api` it will crash.
![image](https://user-images.githubusercontent.com/4325700/74595603-7c66cf00-5011-11ea-9593-312663f04fc1.png )
@matklad I'm mostly looking for design feedback.
Co-authored-by: kjeremy <kjeremy@gmail.com>
Co-authored-by: Jeremy Kolb <kjeremy@gmail.com>
2020-02-25 10:02:21 +00:00
bors[bot]
5e6f4ca690
Merge #3299
...
3299: vscode: migrate to request type api r=matklad a=Veetaha
More type-safety to the god of type-safety.
Co-authored-by: Veetaha <gerzoh1@gmail.com>
2020-02-25 09:55:56 +00:00
Jeremy Kolb
17ffdf9c27
Add docs
2020-02-24 21:17:20 -05:00
kjeremy
9f0cfb7ad2
Teach the server about Semantic Tokens proposed LSP
2020-02-24 20:59:58 -05:00
Veetaha
6ec4a7db42
vscode: wrap non-single-line if body with curlies as per matklad
2020-02-25 01:58:43 +02:00
Veetaha
18b97d9d36
vscode: migrate rust-analyzer-api to import * as lc as per matklad and kjeremy
2020-02-25 01:43:52 +02:00
bors[bot]
558d263a0c
Merge #3296
...
3296: vscode: bump TypeScript version r=matklad a=Veetaha
There is a new [`type-only` import and export feature](https://www.typescriptlang.org/docs/handbook/release-notes/typescript-3-8.html#-type-only-imports-and-export ), but let's keep our codebase as simple as it is now.
Also, top-level await 🎉 , though with a caveat ))
![image](https://user-images.githubusercontent.com/36276403/75185341-93629b00-574e-11ea-8d5c-4a4293f140f7.png )
Co-authored-by: Veetaha <gerzoh1@gmail.com>
2020-02-24 23:09:19 +00:00
Veetaha
72e81dae71
vscode: run fmt
2020-02-25 01:00:00 +02:00
Veetaha
c9230b88b4
vscode: migrate inlay_hints to rust-analyzer-api.ts
2020-02-25 00:57:49 +02:00
Veetaha
8aea0ec511
vscode: migrate syntax_tree to rust-analyzer-api.ts
2020-02-25 00:57:14 +02:00
Veetaha
9ea63d5a86
vscode: migrate ssr to rust-analyzer-api.ts
2020-02-25 00:56:57 +02:00
Veetaha
8a8a4d08ef
vscode: migrate runnables to rust-analyzer-api.ts
2020-02-25 00:56:38 +02:00
Veetaha
d6a96a90f4
vscode: migrate parent_module to rust-analyzer-api.ts
2020-02-25 00:56:19 +02:00
Veetaha
8c6581dcc3
vscode: migrate on_enter to rust-analyzer-api.ts
2020-02-25 00:55:48 +02:00
Veetaha
56d1ff6532
vscode: migrate matching_brace to rust-analyzer-api.ts
2020-02-25 00:55:13 +02:00
Veetaha
38d7945ec7
vscode: migrate join_lines to rust-analyzer-api.ts
2020-02-25 00:54:50 +02:00
Veetaha
c9a2fa1835
vscode: migrate collectGarbage to rust-analyzer-api.ts
2020-02-25 00:50:57 +02:00
Veetaha
31d9932d18
vscode: migrate expand_macro to rust-analyzer-api.ts
2020-02-25 00:50:36 +02:00
Veetaha
603bc71a57
vscode: migrate analyzer_status to rust-analyzer-api.ts
2020-02-25 00:50:14 +02:00
Veetaha
8c4409b3bb
vscode: migrate highlighting to rust-analyzer-api.ts
2020-02-25 00:49:54 +02:00
Veetaha
21ab133966
vscode: migrate source_cnage.rs to rust-analyzer-api.rs
2020-02-25 00:49:19 +02:00
Veetaha
39efb301ff
vscode: create rust-analyzer-api.ts
2020-02-25 00:48:44 +02:00
Laurențiu Nicola
ed69482d90
Bump chalk and replace TypeFamily with Interner
2020-02-24 22:36:57 +02:00
Veetaha
6d15f89a4b
vscode: bump TypeScript version
2020-02-24 21:37:53 +02:00
Veetaha
af57251c31
vscode: remove type assertion
2020-02-24 21:23:56 +02:00
Veetaha
b4db089a6b
add error handling to fetchArtifactReleaseInfo(), throw Error when no artifact found
2020-02-24 21:13:10 +02:00
nmio
34e3ef61bd
Initial debugging code
2020-02-24 16:38:59 +00:00
bors[bot]
bd4ea87f74
Merge #3294
...
3294: When joining lines, unwrap trivial diverging blocks r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2020-02-24 16:18:12 +00:00
Aleksey Kladov
f551e50c16
When joining lines, unwrap trivial diverging blocks
2020-02-24 17:17:05 +01:00
bors[bot]
49b9c8a052
Merge #3293
...
3293: Cleanp r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2020-02-24 14:41:37 +00:00
Aleksey Kladov
cc1469fe9e
Cleanp
2020-02-24 15:41:13 +01:00
bors[bot]
cba3c991c8
Merge #3291
...
3291: Update deps r=kjeremy a=kjeremy
Co-authored-by: Jeremy Kolb <kjeremy@gmail.com>
2020-02-24 12:59:56 +00:00
Jeremy Kolb
0419dbacc9
Update deps
2020-02-24 07:58:54 -05:00
bors[bot]
e2a8e891c1
Merge #3290
...
3290: Don't block onEnter if request fails r=matklad a=matklad
closes #3286
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2020-02-24 11:48:15 +00:00
Aleksey Kladov
910adb9dc7
Don't block onEnter if request fails
...
closes #3286
2020-02-24 12:45:34 +01:00
bors[bot]
223a6676fd
Merge #3288
...
3288: Quick fix circular json error when sanity-check fails r=matklad a=Veetaha
Related issue: #3280
Co-authored-by: Veetaha <gerzoh1@gmail.com>
2020-02-24 11:40:06 +00:00
bors[bot]
dc6383c422
Merge #3289
...
3289: Don't break onEnter if rust-analyzer fails to start r=matklad a=matklad
closes #3253
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2020-02-24 11:33:00 +00:00
Aleksey Kladov
b12cbd6062
Don't break onEnter if rust-analyzer fails to start
...
closes #3253
2020-02-24 12:32:15 +01:00
Veetaha
ef4dfab3cc
Quick fix circular json error when sanity-check fails
...
Related issue: #3280
2020-02-24 11:56:52 +02:00
bors[bot]
1d1c1b0d85
Merge #3287
...
3287: Omit type hints for enum variant bind pats r=matklad a=SomeoneToIgnore
After using new hints for a while, I've started to think that hints for enum variants are an overkill.
Another user also shares the same toughts: https://github.com/rust-analyzer/rust-analyzer/issues/3273#issuecomment-590172297
Co-authored-by: Kirill Bulatov <mail4score@gmail.com>
2020-02-24 08:46:07 +00:00
Kirill Bulatov
7f3c0e8564
Omit type hints for enum variant bind pats
2020-02-24 10:32:46 +03:00
adamrk
4f1d90e73b
Handle trivia in strucural search and replace
2020-02-23 22:14:47 +01:00
bors[bot]
cd01e72a9e
Merge #3277
...
3277: vscode: gracefully handle cancellation errors r=matklad a=Veetaha
This PR fixes a fleet of errors that rapidly populate the Developer Tools console.
![image](https://user-images.githubusercontent.com/36276403/75097665-0c7aba80-55b6-11ea-8edd-ab5dc5f89e1e.png )
Co-authored-by: Veetaha <gerzoh1@gmail.com>
2020-02-23 15:26:20 +00:00
bors[bot]
3d6ec45a01
Merge #3282
...
3282: Add suggestion for failed path resolution r=matklad a=yoshuawuyts
This adds https://github.com/rust-analyzer/rust-analyzer/issues/3245 as an inline help text for when path resolution fails. I saw this error, but also `"Failed to read Cargo metadata from Cargo.toml file"` several times while trying to debug what was failing.
There's probably a more structured way of displaying help texts in VS Code popups. But this would've saved me 20 mins of debugging when installing `rust-analyzer` under WSL today. Thanks!
Co-authored-by: Yoshua Wuyts <yoshuawuyts@gmail.com>
2020-02-23 15:17:08 +00:00
Yoshua Wuyts
b4970b0fe9
Add suggestion for failed path resolution
...
This adds https://github.com/rust-analyzer/rust-analyzer/issues/3245 as an inline help text for when path resolution fails.
2020-02-23 15:51:32 +01:00
Veetaha
4cee7cddc8
vscode: gracefully handle cancellation errors
2020-02-23 15:49:09 +02:00
bors[bot]
838ad6bcfb
Merge #3279
...
3279: Add basic parameter name hints heuristics r=matklad a=SomeoneToIgnore
Co-authored-by: Kirill Bulatov <mail4score@gmail.com>
2020-02-23 10:09:35 +00:00
bors[bot]
58d44c6ba2
Merge #3261
...
3261: Extract client-side logging r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2020-02-23 10:02:08 +00:00