Sander Saares
a067cd24ac
Replace incorrect suggested fix for float_cmp
...
Using `f32::EPSILON` or `f64::EPSILON` as the floating-point equality comparison error margin is incorrect, yet `float_cmp` has until now recommended this be done. This change fixes the given guidance (both in docs and compiler hints) to not reference these unsuitable constants.
Instead, the guidance now clarifies that the scenarios in which an absolute error margin is usable, provides a reference implementation of using a user-defined absolute error margin (as an absolute error margin can only be used-defined and may be different for different comparisons) and references the floating point guide for a reference implementation of relative error based equaltiy comparison for when absolute error margin cannot be used.
changelog: Fix guidance of [`float_cmp`] and [`float_cmp_const`] to not incorrectly recommend `f64::EPSILON` as the error margin.
Fixes #6816
2024-07-09 10:12:09 +03:00
Trevor Gross
c693f31ee2
Update float tests to include f16 and f128
2024-06-19 13:30:21 -04:00
Philipp Krones
7be6e2178e
Merge commit '10136170fe9ed01e46aeb4f4479175b79eb0e3c7' into clippy-subtree-update
2024-02-27 15:50:17 +01:00
Philipp Krones
471469d30f
Merge commit '98363cbf6a7c3f8b571a7d92a3c645bb4376e4a6' into clippyup
2023-09-12 18:44:06 +02:00
Urgau
a86e758228
Adjust clippy tests with new rustc help suggestion for lints
2023-09-04 14:22:02 +02:00
Philipp Krones
cc61aeea54
Merge commit '080b587854a73f2a8cbaecff1884860a78e2ff37' into clippyup
2023-08-24 21:32:12 +02:00
Maybe Waffle
8dfbad9e49
bless clippy
2022-10-01 10:03:06 +00:00
flip1995
23d5457e6d
Merge commit 'cb7915b00c235e9b5861564f3be78dba330980ee' into clippyup
2021-09-28 18:03:12 +01:00
flip1995
f2f2a005b4
Merge commit '6ed6f1e6a1a8f414ba7e6d9b8222e7e5a1686e42' into clippyup
2021-03-12 15:30:50 +01:00
Eduardo Broto
cdb555f4fc
Merge commit 'bf1c6f9871f430e284b17aa44059e0d0395e28a6' into clippyup
2020-10-23 22:16:59 +02:00
flip1995
d1f9cad102
Merge commit 'e636b88aa180e8cab9e28802aac90adbc984234d' into clippyup
2020-09-24 14:49:22 +02:00
Marcin Serwin
4449cc799b
Make the epsilon note spanless
2020-04-09 08:18:52 +02:00
Marcin Serwin
f637c45f8b
Indicate when arrays are compared in error message
2020-04-09 08:10:14 +02:00
Marcin Serwin
84ae3d8bc8
Make epsilon note spanless when comparing arrays
2020-04-09 08:10:14 +02:00
Marcin Serwin
3c738b2286
Add float cmp tests for arrays
2020-04-09 08:08:36 +02:00
Marcin Serwin
b4ff774d72
Update stderr of float_cmp test
2020-04-09 08:05:51 +02:00
briankabiro
0d00eafd32
Add tests for float in array comparison
2020-04-09 08:05:51 +02:00
Linus Färnstrand
645b62e436
Fix float cmp to use assoc fxx::EPSILON
2020-04-08 00:43:27 +02:00
Yuki Okushi
07e33633a3
Update stderrs
2020-01-07 18:38:12 +09:00
xd009642
bba2c7f02c
Updated tests.
...
Removed unnecessary type repetition in float test and regenerated stderr
Regenerated type_repetition stderr
2019-07-27 22:53:26 +01:00
xd009642
925e8207fa
Respond to review comments
...
Update README and CHANGELOG using the util scripts, refine the help message and fix the float_cmp error.
2019-07-27 21:58:29 +01:00
Daniele D'Orazio
be14ea8c37
fix suggestion for floating points inequality
...
It should be of the form `(a - b).abs() > error` whereas it was
`(a - b).abs() < error` that is instead what should be used for equality.
2019-06-17 16:42:43 +02:00
Philipp Hansch
38d4ac7cea
Remove all copyright license headers
...
Discussion previously happened in https://github.com/rust-lang/rust/pull/43498
2019-01-08 21:46:39 +01:00
flip1995
d2dbd0b8a5
Update *.stderr files
2018-12-28 12:41:12 +01:00
Matthias Krüger
7bcc2cd9c8
update test stderr
2018-12-10 08:22:07 +01:00
Manish Goregaokar
e9c025ea70
Add license header to Rust files
2018-10-06 09:43:08 -07:00
flip1995
e9af09c274
Adapt the *.stderr files of the ui-tests to the tool_lints
2018-08-29 11:08:29 -07:00
Oliver Schneider
f7b2578aea
Update to rustc master
2018-03-13 11:38:21 +01:00
Oliver Schneider
4f21b5b112
Update changed ui tests
2018-01-17 14:44:40 +01:00
Oliver Schneider
50ffaca4c9
Reduce the hackiness of cargo-clippy
2017-10-03 12:07:24 +02:00
Oliver Schneider
74c776585c
Move all our tests back to ui tests
2017-08-01 17:54:21 +02:00
Oliver Schneider
4465bc3e3f
Make most tests an example so we can run them one by one
2017-05-17 14:19:44 +02:00
Luis de Bethencourt
faca269488
clean tests/ui/float.rs
...
Cleaning the empty lines for clarity.
2017-05-11 16:22:32 +01:00
Oliver Schneider
a6c8464dde
Update to rustc 1.19.0-nightly ( 6a5fc9eec 2017-05-02)
2017-05-03 12:51:47 +02:00
Oliver Schneider
fd1351f6e3
rustup and compile-fail -> ui test move
2017-02-07 21:05:30 +01:00
