Commit Graph

94568 Commits

Author SHA1 Message Date
bors
e70d5386d7 Auto merge of #61140 - estebank:attr-diagnostics, r=michaelwoerister
Reword malformed attribute input diagnostics

- Handle empty `cfg_attr` attribute
- Reword empty `derive` attribute error
- Use consistend error message: "malformed `attrname` attribute input"
- Provide suggestions when possible
- Move note/help to label/suggestion
- Use consistent wording "ill-formed" -> "malformed"
- Move diagnostic logic out of parser

Split up from https://github.com/rust-lang/rust/pull/61026, where there's prior conversation.
2019-05-27 20:12:14 +00:00
Santiago Pastorino
acaf284e55 Remove unused tcx and mir params 2019-05-27 21:46:15 +02:00
Aleksey Kladov
fe31ad38cb
Update src/liballoc/boxed.rs
Co-Authored-By: Ralf Jung <post@ralfj.de>
2019-05-27 22:42:50 +03:00
Aleksey Kladov
0653e78ae1 make Box<str>::clone simpler & safer 2019-05-27 21:17:12 +03:00
bors
fa40a111ff Auto merge of #60827 - oli-obk:late_symbol, r=nnethercote
Use `Symbol` more in lint APIs

r? @nnethercote

This will cause clippy breakage, but super trivial to fix since we can then remove the hacky `match_def_path` function that I added and go back to calling rustc's `match_def_path` method.
2019-05-27 15:36:32 +00:00
Michael Woerister
577ea539dc Only build clang_rt when RUSTBUILD_FORCE_CLANG_BASED_TESTS is set. 2019-05-27 16:40:00 +02:00
Christian
b560b9cd36 Updated the Iterator docs with information about overriding methods. 2019-05-27 16:17:39 +02:00
Lzu Tao
06eb412741 Stabilize bufreader_buffer feature 2019-05-27 13:42:21 +00:00
bors
1a56ec4dae Auto merge of #59627 - LooMaclin:issue_57128_improve_miri_error_reporting_in_check_in_alloc, r=RalfJung
Improve miri error reporting in check_in_alloc

Fixes https://github.com/rust-lang/rust/issues/57128

r? @RalfJung @oli-obk
2019-05-27 12:46:12 +00:00
Michael Woerister
48b9896eeb Fix unit test after pgo-use change. 2019-05-27 14:32:03 +02:00
Michael Woerister
1de93a7814 Add a smoketest for combining PGO with xLTO. 2019-05-27 14:32:03 +02:00
Michael Woerister
30a3fad316 rustbuild: Also build compiler-rt when building LLDB. This allows clang-based run-make tests to use PGO. 2019-05-27 14:32:03 +02:00
Michael Woerister
eeb7348dc3 PGO: Check that pgo-use file actually exists. LLVM seems to only emit an easy-to-overlook warning otherwise. 2019-05-27 14:32:03 +02:00
Michael Woerister
e943426045 Use a PathBuf instead of String for representing the pgo-use path internally. 2019-05-27 14:32:03 +02:00
Ralf Jung
fe19ed8737 factor out some common code and make the on-elimination truncation test debug-only 2019-05-27 12:54:05 +02:00
Ralf Jung
fe7b6a943d fix truncate and sign_extend for size == 0 2019-05-27 12:53:27 +02:00
Oliver Scherer
d6ca34c9d2 Use Symbol more in lint APIs 2019-05-27 12:28:54 +02:00
Felix S. Klock II
c8887abf20 Tests for external linkage symbol collision check.
Fix #61232
2019-05-27 12:10:58 +02:00
bors
4dbc7f96d6 Auto merge of #60967 - Zoxc:fix-syntax-sync, r=michaelwoerister
Short circuit Send and Sync impls for TokenTree

Workaround to make the parallel compiler build after https://github.com/rust-lang/rust/pull/60444.

r? @nikomatsakis
2019-05-27 09:49:18 +00:00
Felix S. Klock II
4e60f53280 Regression test for issue #59548. 2019-05-27 10:26:02 +02:00
Felix S. Klock II
444f2bae59 Refine the message to at least *mention* the attribute itself.
Update pre-existing test's diagnostic output accordingly.
2019-05-27 10:26:02 +02:00
Felix S. Klock II
64edaec6b3 Always supply span to check_and_apply_linkage, sidestepping need to add bug!s to rustc. 2019-05-27 10:26:02 +02:00
Felix S. Klock II
21aa149b0b Move existing #[linkage] tests to a subdirectory where I can add more tests. 2019-05-27 10:26:02 +02:00
Aleksey Kladov
a23a77fb19 avoid materializing unintialized Boxes in RawVec 2019-05-27 11:15:31 +03:00
John Kåre Alsaker
3ed05613ee Short circuit Send and Sync impls for TokenTree 2019-05-27 08:58:05 +02:00
bors
ab7cf71d4c Auto merge of #61035 - nnethercote:avoid-more-symbol-interning, r=petrochenkov
Avoid more symbol interning

r? @petrochenkov
2019-05-27 06:53:53 +00:00
diwic
5c5f08ab93
Use .await syntax instead of await! 2019-05-27 07:27:13 +02:00
Nicholas Nethercote
33a3206dc5 Use Symbol equality in may_begin_with and parse_nt. 2019-05-27 14:05:05 +10:00
Nicholas Nethercote
15789a9773 Use Symbol equality in check_ident_token. 2019-05-27 14:05:05 +10:00
Nicholas Nethercote
8ae01a9008 Use Symbol equality in is_ident_named. 2019-05-27 14:05:05 +10:00
Nicholas Nethercote
303bf1509b Avoid some re-interning in to_lit_token. 2019-05-27 14:05:05 +10:00
Nicholas Nethercote
21f28448e0 Add to_symbol methods. 2019-05-27 14:05:02 +10:00
bors
be10e6277b Auto merge of #61215 - paoloteti:armebv7r, r=alexcrichton
Docker: remove environment variable `CC_armebv7r_none_eabi`

`cc-rs` take care of selecting the tool-chain, so this `ENV` variable can be safely removed.
2019-05-27 03:58:56 +00:00
Nicholas Nethercote
9c7d28d4fd Pre-intern "0", "1", ..., "9", and use where appropriate. 2019-05-27 13:58:38 +10:00
Nicholas Nethercote
58c68d00fd Pass symbols to ExtCtxt::std_path instead of strings.
Because this function is hot.

Also remove the dead `ty_option` function.
2019-05-27 13:58:38 +10:00
Nicholas Nethercote
26451ef7b5 Avoid unnecessary internings.
Most involving `Symbol::intern` on string literals.
2019-05-27 13:58:38 +10:00
Nicholas Nethercote
6c0ff3dd97 Avoid interning in resolve_place_op.
This function is hot for `keccak`.
2019-05-27 13:58:38 +10:00
Chris Gregory
0fd9934b1e Document tuple's Ord behavior as sequential 2019-05-26 21:04:05 -05:00
bors
ed2a5115da Auto merge of #61147 - estebank:suggest-as-ref, r=oli-obk
When encountering move error on an `Option`, suggest using `as_ref`

Fix #61109, cc #15457.
2019-05-27 01:10:22 +00:00
bors
37c45ec398 Auto merge of #61214 - oli-obk:clippy, r=Manishearth
Update clippy submodule

r? @Manishearth
2019-05-26 21:38:04 +00:00
Jad Ghalayini
03cce1d81e Added error message for E0284 2019-05-26 16:48:02 -04:00
bors
5187be620c Auto merge of #61213 - pietroalbini:fix-azure-multiple-checkouts, r=alexcrichton
azure: fix multiple checkouts on azure

We were checking out the rustc repo multiple times on auto macOS, and
that was causing an error on the Azure side since multiple checkouts are
apparently not supported. This removes the extra checkout.

r? @alexcrichton
fixes #61170
2019-05-26 18:48:12 +00:00
Esteban Küber
24b2e20b31 Account for short-hand init structs when suggesting conversion 2019-05-26 11:39:48 -07:00
Paolo Teti
6e4c12c768 Docker: remove environment variable CC_armebv7r_none_eabi
`cc-rs` take care of selecting the tool-chain, so this ENV variable
can be safely removed.
2019-05-26 19:31:40 +02:00
Oliver Scherer
2a789518b0 Update cargo lockfile 2019-05-26 19:21:54 +02:00
Oliver Scherer
e8b09ff92b Update clippy submodule 2019-05-26 18:59:51 +02:00
Pietro Albini
4af19b0ce9
ci: increase timeout on the auto branch in azure 2019-05-26 18:35:32 +02:00
Pietro Albini
d185feae4f
ci: fix multiple checkouts on azure
We were checking out the rustc repo multiple times on auto macOS, and
that was causing an error on the Azure side since multiple checkouts are
apparently not supported. This removes the extra checkout.
2019-05-26 17:12:13 +02:00
Alex Crichton
ad52c77a46 ci: Attempt to skip a full rustc compile on dist*
Currently when we're preparing cross-compiled compilers it can take
quite some time because we have to build the compiler itself three
different times. The first is the normal bootstrap, the second is a
second build for the build platform, and the third is the actual target
architecture compiler. The second compiler was historically built
exclusively for procedural macros, and long ago we didn't actually need
it.

This commit tries out avoiding that second compiled compiler, meaning we
only compile rustc for the build platform only once. Some local testing
shows that this is promising, but bors is of course the ultimate test!
2019-05-26 07:39:14 -07:00
bors
dc6db14e1c Auto merge of #61210 - Centril:rollup-ofr6h5b, r=Centril
Rollup of 4 pull requests

Successful merges:

 - #61077 (Don't arena-allocate static symbols.)
 - #61102 (Move path for iterate)
 - #61120 (Make eval_place iterate instead of recurse)
 - #61205 (docs: fix typo #61197)

Failed merges:

r? @ghost
2019-05-26 12:24:25 +00:00