bors[bot]
2cee8531c5
Merge #3814
...
3814: Add impl From for enum variant assist r=flodiebold a=mattyhall
Basically adds a From impl for tuple enum variants with one field. It was recommended to me on the zulip to maybe try using the trait solver, but I had trouble with that as, although it could resolve the trait impl, it couldn't resolve the variable unambiguously in real use. I'm also unsure of how it would work if there were already multiple From impls to resolve - I can't see a way we could get more than one solution to my query.
Fixes #3766
Co-authored-by: Matthew Hall <matthew@quickbeam.me.uk>
2020-04-03 07:46:46 +00:00
Matthew Hall
1fee60181f
Add impl From for enum variant assist
...
Basically adds a From impl for tuple enum variants with one field. Added
to cover the fairly common case of implementing your own Error that can
be created from another one, although other use cases exist.
2020-04-01 22:26:41 +01:00
Josh Mcguigan
d0b6b2ee2f
lower bool literal with the value from source code rather than default bool value
2020-04-01 04:47:41 -07:00
bors[bot]
2cdeb7363a
Merge #3786
...
3786: When adding match arm, don't let the floating comma r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2020-03-31 12:53:51 +00:00
Aleksey Kladov
2fe6e23138
When adding match arm, don't let the floating comma
2020-03-31 14:52:20 +02:00
Leander Tentrup
77f89a700b
Attach doc-comment to declaration if there are newlines in between
...
This commit changes the parser to attach doc-comments to the corresponding declaration in case there are newlines in between the doc-comment and the declaration.
2020-03-31 14:27:23 +02:00
Aleksey Kladov
0cfa9eb445
Use IntoIter
2020-03-30 12:28:22 +02:00
Matthew Hall
ddb9cc47d1
Tidy up insertion position logic
2020-03-29 12:45:15 +01:00
Matthew Hall
b8b271d984
Remove unneeded variables
2020-03-29 12:32:01 +01:00
Matthew Hall
ecc2615ba2
Append new match arms rather than replacing all of them
...
This means we now retain comments when filling in match arms.
2020-03-28 20:58:46 +00:00
Aleksey Kladov
6596e7cddf
Nice string formatting
2020-03-28 12:27:54 +01:00
Piotr Szpetkowski
f016d8b900
Fix merge-imports assist for wildcard imports
2020-03-27 17:28:25 +01:00
bors[bot]
a4901fdcfd
Merge #3742
...
3742: Replace if with if-let r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2020-03-27 11:21:57 +00:00
Aleksey Kladov
91e482b46d
Replace if with if-let
2020-03-27 12:15:46 +01:00
bors[bot]
f9cf86475c
Merge #3741
...
3741: More general ctor for ifs r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2020-03-27 10:38:31 +00:00
Aleksey Kladov
cbb53cf55c
More general ctor for ifs
2020-03-27 11:38:00 +01:00
bors[bot]
31528620a8
Merge #3740
...
3740: Simplify r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2020-03-27 10:27:01 +00:00
Aleksey Kladov
d953df319b
Simplify
2020-03-27 11:25:11 +01:00
bors[bot]
20c110e57f
Merge #3732
...
3732: Assist: replace unwrap with match r=matklad a=unrealhoang
attempt on #3669
Co-authored-by: Unreal Hoang <unrealhoang@gmail.com>
2020-03-26 15:38:03 +00:00
Aleksey Kladov
db34abeb85
Get rid of ItemOrMacro
2020-03-26 16:10:01 +01:00
Unreal Hoang
d9df0f43ac
Assist: replace unwrap with match
2020-03-27 00:08:12 +09:00
Aleksey Kladov
f6188caaa0
Fix parsing lambdas with return type
...
We should eat only a single block, and not whatever larger expression
may start with a block.
closes #3721
2020-03-25 17:01:28 +01:00
Aleksey Kladov
f7f0f33e05
Remove dead code
2020-03-25 10:09:50 +01:00
bors[bot]
9690f6bc43
Merge #3708
...
3708: Generalise syntax rewriting infrastructure to allow removal of nodes r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2020-03-24 16:15:08 +00:00
Aleksey Kladov
062f6e3bbe
Generalise syntax rewriting infrastructure to allow removal of nodes
2020-03-24 17:14:33 +01:00
bors[bot]
7c2cc85806
Merge #3705
...
3705: Align naming r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2020-03-24 11:56:43 +00:00
Aleksey Kladov
9bf2cd609c
Align naming
2020-03-24 12:56:07 +01:00
Josh Mcguigan
7ba934fe58
fill match arms with empty block rather than unit tuple
2020-03-23 19:23:30 -07:00
Josh Mcguigan
df58ab8963
update itertools version to 0.9.0
2020-03-23 16:22:46 -07:00
Josh Mcguigan
bc48c9d511
review comments
2020-03-23 05:19:09 -07:00
Josh Mcguigan
2afccbe477
implement fill match arm assist for tuple of enums
2020-03-22 23:28:25 -07:00
Edwin Cheng
bb22a4e386
Add support for macro in symbo_index
2020-03-22 15:00:44 +08:00
Edwin Cheng
e1a9461806
Add identity expansion checking
2020-03-21 22:43:48 +08:00
Aleksey Kladov
89694ec8f6
Support arbitrary discriminants
...
Closes #3661
2020-03-20 08:50:34 +01:00
Aleksey Kladov
ef3bf906c4
Generalize
2020-03-19 11:38:26 +01:00
Aleksey Kladov
0bf903411c
Use match_ast
2020-03-18 20:51:47 +01:00
Aleksey Kladov
3f6dc20d3c
Merge imports assist
...
Work towards #2220
2020-03-18 19:34:47 +01:00
Aleksey Kladov
4e50efcfc5
Strongly-typed generic methods for editing nodes
2020-03-18 19:34:47 +01:00
bors[bot]
a99cac671c
Merge #3540
...
3540: Swtches to rust SSR query check r=matklad a=mikhail-m1
related to #3186
Co-authored-by: Mikhail Modin <mikhailm1@gmail.com>
2020-03-16 09:48:09 +00:00
Mikhail Modin
b150965ed7
Swtches to rust SSR query check
2020-03-15 21:23:18 +00:00
Aleksey Kladov
bee5cdb359
Parse variadics correctly
...
closes #3571
2020-03-13 13:54:14 +01:00
Aleksey Kladov
1e19847af3
Move verbose tests out of line
2020-03-13 12:20:42 +01:00
CAD97
88c944f96b
Remove some TextUnit->usize escapees
2020-03-12 22:33:27 -04:00
Aleksey Kladov
afd64ef4f7
Merge pull request #3562 from FireofGods/display_for_node
...
Add `std::fmt::Display` as a supertrait for `AstNode`
2020-03-12 15:40:53 +01:00
Fireassember
31eec5e80c
implementing Display for enums too.
2020-03-11 22:54:24 +02:00
Aleksey Kladov
4a745cc8cf
Fix parsing of stement-ish binary expressions
...
closes #3512
2020-03-11 14:28:18 +01:00
Edwin Cheng
e7206467d5
Add parse_to_token_tree
2020-03-09 00:13:04 +08:00
Fireassember
787043496a
added fmt::Display as a supertrait for AstNode and changed generation.
2020-03-06 19:29:30 +02:00
Aleksey Kladov
1f84c3b18f
make::use_item
2020-03-06 15:56:25 +01:00
Aleksey Kladov
85e2346b74
Simplify creation of T[,]
2020-03-06 15:38:48 +01:00