bors[bot]
9cb6e3a190
Merge #11394
...
11394: feat: Deprioritize completions of private but editable definitions r=Veykril a=Veykril
Co-authored-by: Lukas Wirth <lukastw97@gmail.com>
2022-02-02 11:42:40 +00:00
Lukas Wirth
2d77eb1e12
Fix test fixture
2022-02-02 12:42:13 +01:00
Lukas Wirth
70650897d8
Fix generate_function assist trying to use name-ref like keywords for names
2022-02-02 11:37:24 +01:00
bors[bot]
34138379b5
Merge #11322
...
11322: Extract function also extracts comments r=Vannevelj a=Vannevelj
Fixes #9011
The difficulty I came across is that the original assist works from the concept of a `ast::StmtList`, a node, but that does not allow me to (easily) represent comments, which are tokens. To combat this, I do a whole bunch of roundtrips: from the `ast::StmtList` I retrieve the `NodeOrToken`s it encompasses.
I then cast all `Node` ones back to a `Stmt` so I can apply indentation to it, after which it is again parsed as a `NodeOrToken`.
Lastly, I add a new `make::` api that accepts `NodeOrToken` rather than `StmtList` so we can write the comment tokens.
Co-authored-by: Jeroen Vannevel <jer_vannevel@outlook.com>
2022-02-01 23:05:28 +00:00
Jeroen Vannevel
493642ab3a
rollup match
2022-02-01 22:38:37 +00:00
Lukas Wirth
d7a544e69a
fix: Complete functions and methods from block level impls
2022-02-01 23:29:40 +01:00
Jeroen Vannevel
1811f6330b
better comparison
2022-02-01 09:00:30 +00:00
Jeroen Vannevel
b290285dd8
removed redundant test
2022-02-01 00:38:33 +00:00
Jeroen Vannevel
269153388a
added FIXME
2022-02-01 00:37:48 +00:00
Jeroen Vannevel
51c50dd5ac
don't tear body
2022-02-01 00:36:50 +00:00
Jeroen Vannevel
e72ed9230a
no longer support comments on their own
2022-02-01 00:21:35 +00:00
Jeroen Vannevel
8f09e13c06
fixed whitespace
2022-01-22 13:28:23 +00:00
Jeroen Vannevel
8e8e1951e2
whitespace
2022-01-22 12:25:33 +00:00
Jeroen Vannevel
9725eaa21c
generated docs
2022-01-22 12:17:24 +00:00
Jeroen Vannevel
61ab31f709
clarify doc
2022-01-22 12:10:48 +00:00
Jeroen Vannevel
4972cb759e
Support standalone comments
2022-01-22 12:08:32 +00:00
Jeroen Vannevel
8d61216957
redundant type specified
2022-01-22 12:08:32 +00:00
Jeroen Vannevel
a1c246b1c4
shorter arms
2022-01-22 12:08:32 +00:00
Jeroen Vannevel
4ab7c4d99b
removed prints
2022-01-22 12:08:32 +00:00
Jeroen Vannevel
96ab4c6e6c
hacky_block_expr_with_comments
2022-01-22 12:08:32 +00:00
Jeroen Vannevel
5d35e5882c
removed unwrapping from indent
2022-01-22 12:08:32 +00:00
Jeroen Vannevel
ee862cec10
simplified tail_expr
2022-01-22 12:08:32 +00:00
Jeroen Vannevel
4896ffb65c
removing unwraps
2022-01-22 12:08:32 +00:00
Jeroen Vannevel
50c913c733
don't remove the comment token if it's last
2022-01-22 12:08:32 +00:00
Jeroen Vannevel
4f3dd5bc08
very rough but comments get extracted
2022-01-22 12:08:32 +00:00
Jeroen Vannevel
f662d8bf38
repro
2022-01-22 12:08:32 +00:00
Jeroen Vannevel
ffe4352d7c
styling fixes
2022-01-14 18:53:28 +00:00
Jeroen Vannevel
683de877ce
simple return
2022-01-14 01:32:12 +00:00
Jeroen Vannevel
0700282b75
formatting
2022-01-14 01:32:12 +00:00
Jeroen Vannevel
e5cdde95ab
removed toy
2022-01-14 01:32:12 +00:00
Jeroen Vannevel
5e4370fe56
happy slice
2022-01-14 01:32:12 +00:00
Jeroen Vannevel
8deadb18ae
refpat & slicepat
2022-01-14 01:32:12 +00:00
Jeroen Vannevel
82d3238da8
ParenPat
2022-01-14 01:32:12 +00:00
Jeroen Vannevel
c955ea11b4
support TuplePat
2022-01-14 01:32:12 +00:00
Jeroen Vannevel
a347cb5f86
battle of the Some
2022-01-14 01:32:12 +00:00
Jeroen Vannevel
7daca6fe97
cleaning up Some
2022-01-14 01:32:11 +00:00
Jeroen Vannevel
08300284e7
removed unwrap
2022-01-14 01:32:11 +00:00
Jeroen Vannevel
7bc89f2542
formatting
2022-01-14 01:32:11 +00:00
Jeroen Vannevel
bd77d8c3d1
removed prints
2022-01-14 01:32:11 +00:00
Jeroen Vannevel
18fb5412b2
all tests work
2022-01-14 01:32:11 +00:00
Jeroen Vannevel
aaec467cfd
merge_match_arms_nested_with_conflicting_identifier
2022-01-14 01:32:11 +00:00
Jeroen Vannevel
169ec2fdc1
Added a few more test cases
2022-01-14 01:32:11 +00:00
Jeroen Vannevel
b27b882e72
fixed test case
2022-01-14 01:32:11 +00:00
Jeroen Vannevel
2329b42407
test for different number of fields
2022-01-14 01:32:10 +00:00
Jeroen Vannevel
5675e0cd40
test cases with more branches
2022-01-14 01:32:10 +00:00
Jeroen Vannevel
130f11f270
simplified chain
2022-01-14 01:32:10 +00:00
Jeroen Vannevel
5dfc8da77e
don't need the as_ref()
2022-01-14 01:32:10 +00:00
Jeroen Vannevel
c52605024c
extracted function
2022-01-14 01:32:10 +00:00
Jeroen Vannevel
d8a3e51a5f
added tests for multiple fields
2022-01-14 01:32:10 +00:00
Jeroen Vannevel
9252c76255
using classify()
2022-01-14 01:32:10 +00:00
