bors
2320e12541
Auto merge of #16771 - Veykril:self-param-split, r=Veykril
...
internal: Don't desugar self param into a pattern
Small experiment to see if this simplifies things
2024-03-11 12:45:46 +00:00
Young-Flash
562f4a2688
test: update test for unused_variables
2024-03-11 19:36:53 +08:00
Young-Flash
77136575da
feat: add fix for unused_variables
2024-03-11 19:36:53 +08:00
Wyatt Herkamp
0fb5d0d918
Check for cfg_attr on the actual item and Debug instead of info in cfg_process
2024-03-11 06:55:04 -04:00
bors
a0dd822972
Auto merge of #16473 - SomeoneToIgnore:kb/remove-resolve-stub, r=Veykril
...
Stop eagerly resolving inlay hint text edits for VSCode
Send less json over the wire.
After https://github.com/microsoft/vscode/issues/193124 was fixed, this change is not needed anymore.
VSCode 1.86.0 now supports double click for unresolved hint data too.
2024-03-11 09:44:02 +00:00
bors
a58f574816
Auto merge of #16762 - wyatt-herkamp:master, r=Veykril
...
Added QuickFix for unresolved field.
Adds an AssistKind::QuickFix for unresolved field.
Currently, Snippets are not available for Diagnostics. So the type defaults to the Unit type if the type is not able to be inferred.
https://github.com/rust-lang/rust-analyzer/assets/11785959/bd4c67bd-f8cb-4254-9a87-641ae80a7a28
Closes https://github.com/rust-lang/rust-analyzer/issues/4563
2024-03-11 09:31:22 +00:00
Lukas Wirth
0dbaccd484
Track vscode version for conditional bug server sided bugfixes
2024-03-11 10:31:06 +01:00
Kirill Bulatov
57a0ad4343
Stop eagerly resolving inlay hint text edits for VSCode
...
After https://github.com/microsoft/vscode/issues/193124 was fixed,
this change is not needed anymore.
2024-03-11 10:22:02 +01:00
bors
a5035f4931
Auto merge of #16749 - Veykril:on-demand-validation-err, r=Veykril
...
internal: Some method resolution cleanups
2024-03-11 09:18:24 +00:00
bors
1069f57d8b
Auto merge of #16784 - Veykril:body-invalid, r=Veykril
...
internal: Remove synstructure const hack support
The latest version of it no longer emits these
2024-03-11 09:05:26 +00:00
Lukas Wirth
c679482d7e
Add method resolution deref inference var test
2024-03-11 10:02:03 +01:00
Lukas Wirth
458f4a2960
internal: Treat the self param as different from patterns when lowering
2024-03-11 09:46:28 +01:00
Lukas Wirth
558feeab61
internal: Remove synstructure const hack support
2024-03-11 09:44:40 +01:00
bors
0931361b8f
Auto merge of #16807 - lnicola:sync-from-rust3, r=lnicola
...
minor: sync last two releases from downstream
Turns out I made quite a mess on the last two syncs, and this PR is a mess too, but I hope it's fine.
2024-03-11 07:41:25 +00:00
Laurențiu Nicola
f65fe4e281
Fix import
2024-03-11 09:31:02 +02:00
Laurențiu Nicola
fb9744e97c
Merge branch 'master' into sync-from-rust3
2024-03-11 09:17:40 +02:00
Laurențiu Nicola
ce642071d8
Bring back in-rust-tree feature to ide
2024-03-10 11:08:11 +02:00
Laurențiu Nicola
aa74d57825
Merge commit '574e23ec508064613783cba3d1833a95fd9a5080' into sync-from-ra
2024-03-10 08:47:38 +02:00
Laurențiu Nicola
717ba1d56a
Clippy fixes
2024-03-10 08:42:50 +02:00
Wyatt Herkamp
948a2dee09
Clippy Fix
2024-03-09 14:12:27 -05:00
Wyatt Herkamp
79f2651262
Add cfg_attr and cleanup code
2024-03-09 13:25:56 -05:00
bors
574e23ec50
Auto merge of #16794 - HKalbasi:test-explorer, r=lnicola
...
Some minor changes in the test explorer lsp extension
followup #16662
cc `@nemethf` `@ShuiRuTian`
2024-03-09 10:01:41 +00:00
bors
8f08bbe637
Auto merge of #16795 - mu001999:master, r=Veykril
...
remove unused struct Snap in lsif
Detected by #121752 , see https://github.com/rust-lang/rust/pull/121752#issuecomment-1986378328
2024-03-09 06:30:07 +00:00
r0cky
79508d909a
remove unused struct Snap in lsif
2024-03-09 09:09:27 +08:00
hkalbasi
dc99ad912a
Some minor changes in the test explorer lsp extension
2024-03-09 01:21:27 +03:30
Laurențiu Nicola
a12ccd5923
Fix test
2024-03-08 20:39:47 +02:00
Laurențiu Nicola
0f43b55e83
Stop using an Arc when setting the file text
2024-03-08 20:30:12 +02:00
Laurențiu Nicola
02b6c181dd
Compress file text using lz4 in salsa
2024-03-08 20:22:08 +02:00
Wyatt Herkamp
f45b080965
Starting Fix for cfg stripping
2024-03-08 11:10:29 -05:00
bors
2397e7a887
Auto merge of #16787 - pksunkara:remove-macro-call-check, r=lnicola
...
Remove unncessary check for macro call
Since `macro_rules` is a contextual keyword, it is an `IDENT` token and thus `is_path_start` already identifies it correctly. You can tell the previous check is unnecessary because the relevant tests still pass.
2024-03-08 13:23:31 +00:00
bors
2b7b44bf27
Auto merge of #16786 - pksunkara:improve-readability, r=lnicola
...
internal: Improve readability of the parser code
The code is basically equivalent to the previous version, but it improves the readability by making it much more simpler and concise.
2024-03-08 12:21:18 +00:00
bors
1487bc2af6
Auto merge of #16785 - pksunkara:remove-crate-visibility-recovery, r=lnicola
...
internal: Remove unused keyword from visibility recovery
We removed support `crate` visibility keyword, but forgot to remove it from the recovery token list.
2024-03-08 12:08:06 +00:00
Pavan Kumar Sunkara
a838e44032
Remove unncessary check for macro call
2024-03-08 12:03:35 +00:00
Pavan Kumar Sunkara
2a41b2cd94
Improve readability of the parser code
2024-03-08 12:00:24 +00:00
Pavan Kumar Sunkara
b37ccfce44
Remove unused keyword from visibility recovery
2024-03-08 11:53:03 +00:00
bors
00a0125372
Auto merge of #16782 - DropDemBits:format-string-exprs-comments, r=Veykril
...
fix: Preserve $ and \ in postfix format completions
`parse_format_exprs` doesn't escape these two as of #16781 , so they have to be escaped as a separate step.
2024-03-08 08:23:04 +00:00
DropDemBits
bc381837e3
fix: Preserve $ and \ in postfix format completions
...
`parse_format_exprs` doesn't escape these two anymore, so they have to be escaped as a separate step.
2024-03-07 16:55:09 -05:00
DropDemBits
7dadc64d1c
minor: Update comments in format_string_exprs
...
`parse_format_exprs` no longer handles escaping `$` and `\`
2024-03-07 16:08:20 -05:00
bors
48cb059182
Auto merge of #16781 - DropDemBits:extract-format-args-escaping, r=Veykril
...
fix: Don't escape `\` and `$` in "Extract format expressions" assist
Fixes #16745
2024-03-07 20:04:33 +00:00
DropDemBits
1f37e5ac9a
fix: Don't escape \ and $ in "Extract format expressions" assist
2024-03-07 14:20:23 -05:00
bors
7f19beb9b4
Auto merge of #16779 - lnicola:skip-unknown-types-match-diagnostics, r=Veykril
...
minor: Skip match diagnostics for partially unknown types
CC https://github.com/rust-lang/rust-analyzer/issues/16746#issuecomment-1981071008
2024-03-07 17:26:16 +00:00
Laurențiu Nicola
cd2347e132
Skip match diagnostics for partially unknown types
2024-03-07 19:11:23 +02:00
bors
bbb441ec6d
Auto merge of #16778 - Nadrieril:update-pat-ana, r=lnicola
...
Update `rustc_pattern_analysis` to 0.42.0
There was an important API change in 0.41.0, and (hopefully) a fix for https://github.com/rust-lang/rust-analyzer/issues/16774 in 0.42.0.
2024-03-07 16:22:26 +00:00
Nadrieril
e31484c108
Update the other crates too
2024-03-07 16:44:46 +01:00
Nadrieril
1b0b4220fd
Update rustc_pattern_analysis to 0.42.0
2024-03-07 16:33:31 +01:00
bors
b1f6d56e44
Auto merge of #16777 - Veykril:body-invalid, r=Veykril
...
fix: Don't invalid body query results when generating desugared names
The hack remains until we get hygiene, but with this the generated names are stable across bodies
2024-03-07 14:21:26 +00:00
Lukas Wirth
09b9a921a8
fix: Don't invalid body query results when generating desugared names
2024-03-07 15:03:16 +01:00
bors
e101f24798
Auto merge of #16776 - Veykril:parse-macro-parse, r=Veykril
...
fix: Don't force draw a dependency edge to the real_span_map query
This can cause extra invalidations as like direct `AstIdMap` dependencies
2024-03-07 13:19:36 +00:00
Lukas Wirth
c04c0dd5ba
fix: Don't force draw a dependency edge to the real_span_map query
2024-03-07 14:14:59 +01:00
bors
0ffc1ef115
Auto merge of #16775 - Veykril:parse-macro-parse, r=Veykril
...
fix: Remove accidental dependency between `parse_macro_expansion` and `parse`
Turns out my idea from https://github.com/rust-lang/rust-analyzer/pull/15251 causes all builtin derive expansions to obviously rely on the main parse, meaning the entire `macro_arg` layer becomes kind of pointless. So this reverts that PR again.
2024-03-07 10:47:35 +00:00
