bors
2d9ed4fd48
Auto merge of #13641 - DesmondWillowbrook:fix-move-format-string, r=Veykril
...
fix: format expression parsing edge-cases
- Handle positional arguments with formatting options (i.e. `{:b}`). Previously copied `:b` as an argument, producing broken code.
- Handle indexed positional arguments (`{0}`) ([reference](https://doc.rust-lang.org/std/fmt/#positional-parameters )). Previously copied over `0` as an argument.
Note: the assist also breaks when named arguments are used (`"{name}$0", name = 2 + 2` is converted to `"{}"$0, name`. I'm working on fix for that as well.
2022-11-19 12:46:29 +00:00
bors
8050fdb9c7
Auto merge of #13642 - bvanjoi:fix-13292, r=Veykril
...
fix(assists): remove `item_const` which had default value when implement missing members
Fixed https://github.com/rust-lang/rust-analyzer/issues/13292
2022-11-19 12:33:40 +00:00
bvanjoi
a4f071afd5
fix(assists): remove item_const which had default value when implement missing members`
2022-11-19 19:38:53 +08:00
Kartavya Vashishtha
6d4b2b4b17
run cargo fmt
2022-11-19 15:08:32 +05:30
bors
ac60077ee5
Auto merge of #13639 - Veykril:macro-diags, r=Veykril
...
fix: Fix proc-macro-srv search paths for Arch Linux
Fixes https://github.com/rust-lang/rust-analyzer/issues/13616
2022-11-19 09:33:10 +00:00
Lukas Wirth
dc8254c6ab
fix: Fix nested macro diagnostics pointing at macro expansion files
2022-11-19 10:32:32 +01:00
Kartavya Vashishtha
a3f8fd71df
fix: format expression parsing edge-cases
...
handle positional arg with formatting
handle indexed positional args
2022-11-19 15:00:25 +05:30
Kartavya Vashishtha
8b17681058
fix formatting
...
and remove unnecessary check
2022-11-19 11:34:49 +05:30
Kartavya Vashishtha
a778203db9
simplify ancestor climbing to not consider macros
2022-11-19 11:17:43 +05:30
Kartavya Vashishtha
0ffb361eb9
feat: adds hover hint to ".." in record pattern
...
currently only works with struct pattern
2022-11-19 11:10:47 +05:30
Lukas Wirth
52bc15fc1f
fix: Fix proc-macro-srv search paths for Arch Linux
2022-11-18 23:32:26 +01:00
bors
791cb87cdf
Auto merge of #13633 - Veykril:vscode-full-diagnostics, r=Veykril
...
feat: Allow viewing the full compiler diagnostic in a readonly textview
Also adds a VSCode only config that replaces the split diagnostic message with the first relevant part of the diagnostic output
This only affects diagnostics generated by primary spans and has no effect on other clients than VSCode.
Fixes https://github.com/rust-lang/rust-analyzer/issues/13574
2022-11-18 19:33:38 +00:00
Lukas Wirth
8452844c26
Fix tests checking the data value
2022-11-18 20:15:49 +01:00
Lukas Wirth
073a63b93e
feat: Allow viewing the full compiler diagnostic in a readonly textview
2022-11-18 19:56:08 +01:00
bors
bee27eb471
Auto merge of #13632 - Veykril:scip, r=Veykril
...
Make it more obvious which SCIP features we do not yet emit in code
2022-11-18 10:31:41 +00:00
Lukas Wirth
656d886ca8
Make it more obvious which SCIP features we do not yet emit in code
2022-11-18 11:31:12 +01:00
bors
e162d5800a
Auto merge of #13629 - jonas-schievink:remove-dbg-selection, r=jonas-schievink
...
feat: Make "Remove dbg!()" assist work on selections
Fixes https://github.com/rust-lang/rust-analyzer/issues/12114
2022-11-17 16:41:51 +00:00
Jonas Schievink
cd6459e7b3
Make "Remove dbg!()" assist work on selections
2022-11-17 17:39:31 +01:00
bors
9cf5c2230d
Auto merge of #13625 - lowr:fix/proc-macro-src-test, r=lnicola
...
internal: Update proc-macro-srv tests
Should have been included in #13548 , but I didn't notice as those tests aren't run in our CI.
cc rust-lang/rust#104454
2022-11-16 17:10:59 +00:00
Ryo Yoshida
7577c44c65
Update proc-macro-srv tests
2022-11-17 01:42:56 +09:00
bors
92e393cc40
Auto merge of #13624 - lowr:fix/unsize-array-inference-variable, r=lnicola
...
fix: resolve inference variable before applying adjustments
Fixes #13619
2022-11-16 11:07:18 +00:00
Ryo Yoshida
1ad11b5366
fix: resolve inference variable before applying adjustments
2022-11-16 20:01:55 +09:00
bors
0dd0dfb7df
Auto merge of #13615 - mati865:miow-update, r=jonas-schievink
...
Update several crates to bring support for the new Tier 3 Windows tar…
`cargo t` has passed on Windows 11 with both `x86_64-pc-windows-gnu` and `x86_64-pc-windows-gnullvm` targets.
2022-11-15 11:59:27 +00:00
bors
8292dd8026
Auto merge of #13623 - jonas-schievink:strip-trait-item-completions, r=jonas-schievink
...
fix: Strip comments and attributes off of all trait item completions
Previously, this was done in several places redundantly, but not for all items. It was also untested. This PR fixes that.
2022-11-15 11:45:02 +00:00
Jonas Schievink
7e77d4e310
Strip comments and attributes off of all trait item completions
2022-11-15 12:41:39 +01:00
bors
a516b90dee
Auto merge of #13622 - jonas-schievink:fix-gat-completions, r=jonas-schievink
...
fix: include generic parameter in GAT completions
Fixes https://github.com/rust-lang/rust-analyzer/issues/13586
2022-11-15 11:10:34 +00:00
Jonas Schievink
15dfeabb96
Fix GAT completion not including generic parameters
2022-11-15 12:05:11 +01:00
Mateusz Mikuła
46417add8d
Update several crates to bring support for the new Tier 3 Windows targets
2022-11-13 22:45:09 +01:00
yue4u
f26d5484d8
fix: filter unnecessary completions after colon
2022-11-12 22:33:40 +09:00
bors
45ec315e01
Auto merge of #13607 - Veykril:proc-macro-error, r=Veykril
...
internal: Add version info to unsupported proc macro abi error
cc https://github.com/rust-lang/rust-analyzer/issues/13589#issuecomment-1311824473
2022-11-11 15:57:30 +00:00
Lukas Wirth
6b4b7d81e4
internal: Add version info to unsupported proc macro abi error
2022-11-11 16:57:05 +01:00
bors
2656303c83
Auto merge of #13606 - Veykril:trait-alias, r=Veykril
...
fix: Add trait alias grammar to rust.ungram
We already parse them, but the grammar was never updated to reflect that
2022-11-11 14:26:15 +00:00
Lukas Wirth
6674bd898e
fix: Add trait alias grammar to rust.ungram
2022-11-11 15:25:15 +01:00
bors
d3531e8ce6
Auto merge of #13605 - Veykril:empty-ws-error, r=Veykril
...
fix: Fix r-a eagerly showing no discovered workspace errors
2022-11-11 13:37:27 +00:00
Lukas Wirth
a143ff0248
fix: Fix r-a eagerly showing no discovered workspace errors
2022-11-11 14:36:27 +01:00
Alexis (Poliorcetics) Bourget
0d4737adb6
feat: Support passing multiple targets to cargo (for Rust 1.64.0+)
2022-11-11 14:36:07 +01:00
Alexis (Poliorcetics) Bourget
c6c932d3f3
chore: Align config property
2022-11-11 14:36:07 +01:00
bors
add85397ae
Auto merge of #13604 - Veykril:hover-attr, r=Veykril
...
fix: Fix hover in attributed items not preferring similar kinded tokens
2022-11-11 12:48:48 +00:00
Lukas Wirth
e50712cf2c
fix: Fix hover in attributed items not preferring similar kinded tokens
2022-11-11 13:38:07 +01:00
bors
57cc2a6e27
Auto merge of #13602 - lowr:fix/nameres-transitive-visibility, r=Veykril
...
fix: check visibility of each path segment
Upon path resolution, we have not been checking if every def pointed to by each segment of the path is visible from the original module. This leads to incorrect import resolutions, in particular when one uses glob imports and names collide.
There is decent amount of changes in this PR because:
- some of our tests were not correct in terms of visibility
- I left several basic nameres tests as-is (with expect test updated) since I thought it would be nice to ensure we don't resolve defs that are not visible.
- `fix_visibility` assist relied on `Semantics::resolve_path()`, which uses the name resolution procedure I'm fixing and wouldn't be able to "see through" the items with strict visibility with this patch
The first commit is the gist of the fix itself.
Fixes #10991
Fixes #11473
Fixes #13252
2022-11-11 12:32:21 +00:00
bors
6f313cef8e
Auto merge of #13548 - lowr:fix/tt-punct-spacing, r=Veykril
...
Fix `tt::Punct`'s spacing calculation
Fixes #13499
We currently set a `tt::Punct`'s spacing to `Spacing::Joint` unless its next token is a trivia (i.e. whitespaces or comment). As I understand it, rustc only [sets `Spacing::Joint` if the next token is an operator](5b3e909075/compiler/rustc_parse/src/lexer/tokentrees.rs (L77-L78)
2022-11-11 12:19:30 +00:00
bors
ff78d24e21
Auto merge of #13603 - Veykril:no-workspaces, r=Veykril
...
fix: Send status notification if there are no found workspaces
Closes https://github.com/rust-lang/rust-analyzer/issues/5829
2022-11-11 12:01:52 +00:00
Lukas Wirth
e35836eb81
Send status notification if there are no found workspaces
2022-11-11 13:00:22 +01:00
Ryo Yoshida
19306c070d
Fix tests that depended on loose visibility restriction
2022-11-11 20:31:46 +09:00
Ryo Yoshida
e75afebeb2
Resolve invisible defs in fix_visibility assist
2022-11-11 20:31:44 +09:00
Ryo Yoshida
dea49d0826
fix: check visibility of each segment in path resolution
2022-11-11 20:31:37 +09:00
Ryo Yoshida
5b07061011
Test TokenTrees' equality modulo Puncts' spacing
2022-11-10 19:40:40 +09:00
Ryo Yoshida
4f415fc348
Ignore outermost non-delimited Subtree when reversing fixups
2022-11-10 19:22:20 +09:00
Michael Goulet
61c744d4fd
Rollup merge of #104211 - lnicola:rust-analyzer-2022-11-09, r=lnicola
...
⬆️ rust-analyzer
r? ``@ghost``
2022-11-09 21:53:38 -08:00
bors
599142c34a
Auto merge of #13590 - Veykril:proc-macro-rustc-src, r=Veykril
...
internal: Add proc-macro dependency to rustc_private crates
2022-11-09 19:51:20 +00:00
