roblabla
79203653d1
Missing docs: don't require documenting Global Asm items.
...
global_asm! items cannot be documented, the lint still gets triggered
after adding documentation to the macro invocation. Furthermore, even
if we could add documentation to the AST node, rustdoc doesn't render
it anyways.
Playground example: https://play.rust-lang.org/?version=nightly&mode=debug&edition=2018&gist=5182df182f0ffbbab4c3107e43368ac3
2019-01-13 16:22:48 +00:00
Wilco Kusee
6f17635f94
Add run-rustfix for precedence test
2019-01-13 14:26:09 +01:00
Wilco Kusee
95f2a9dbfc
Add run-rustfix to mem_replace test
2019-01-13 13:55:26 +01:00
Wilco Kusee
9ff821a7e8
Add run-rustfix to map_clone test
2019-01-13 13:10:25 +01:00
Wilco Kusee
fb90fcb610
Add run-rustfix to large_digit_groups
2019-01-13 12:57:13 +01:00
Wilco Kusee
256b641976
Add run-rustfix to into_iter_on_ref
2019-01-13 12:52:51 +01:00
Wilco Kusee
787f5a2c12
Add run-rustfix to infallible_destructuring_match
2019-01-13 12:49:54 +01:00
Wilco Kusee
87407c5e5f
Add rustfix to inconsistent_digit_grouping test
2019-01-13 12:44:21 +01:00
Wilco Kusee
40d9f1d9f4
Add run-rustfix to explicit_write test
2019-01-13 12:22:59 +01:00
bors
ac10c56c71
Auto merge of #3655 - manaskarekar:patch-1, r=flip1995
...
Update Readme for (arguably) better readability
Move final instruction to run clippy into a third step in the Readme so it's easier to spot at a quick glance.
2019-01-13 11:21:24 +00:00
Wilco Kusee
9f8fb8007c
Add run-rustfix to excessive_precision test
2019-01-13 12:09:30 +01:00
Wilco Kusee
29211be896
Add run-rustfix to duration_subsec test
2019-01-13 12:06:28 +01:00
Wilco Kusee
ea7eb49b47
Disable deprecated_cfg_attr lint for inner attributes
2019-01-13 11:53:43 +01:00
Wilco Kusee
c0083e2b98
Add run-rustfix to collapsible_if test
2019-01-13 11:44:45 +01:00
Manas Karekar
a8157d2de7
Update Readme
...
Move instruction to the correct step for installing Clippy.
2019-01-12 20:24:52 -05:00
Manas Karekar
09323d7426
Update Readme for (arguably) better readability
...
Move final instruction to run clippy into a third step in the Readme so it's easier to spot at a quick glance.
2019-01-12 19:42:36 -05:00
bors
9f9ce06624
Auto merge of #3654 - matthiaskrgr:rustup, r=phansch
...
rustup: the features if_while_or_patterns has been stabilized
2019-01-12 15:33:08 +00:00
Matthias Krüger
079a593dab
rustup: the features if_while_or_patterns has been stabilized
2019-01-12 16:11:17 +01:00
bors
91ef4e3ae7
Auto merge of #3646 - matthiaskrgr:travis, r=phansch
...
readme: update travis badge to reflect migration from travis-ci.org to travis-ci.com
2019-01-11 01:11:34 +00:00
Guillaume Endignoux
798a419b1c
Fix comments in clippy_lints/src/len_zero.rs
2019-01-10 22:48:44 +01:00
bors
da7aebc342
Auto merge of #3645 - phansch:remove_copyright_headers, r=oli-obk
...
Remove all copyright license headers
Discussion previously happened in https://github.com/rust-lang/rust/pull/43498 and here: https://github.com/rust-lang/rust-clippy/pull/3642#issuecomment-452251727
2019-01-09 21:53:55 +00:00
A.A.Abroskin
58abdb5918
run ./util/dev update_lints
2019-01-09 21:31:29 +03:00
A.A.Abroskin
a9f8d3c8fd
add assert(true/false, some message) tests
2019-01-09 21:30:47 +03:00
Abroskin Alexander
7075015f31
Merge branch 'master' into add-lints-aseert-checks
2019-01-09 13:49:40 +03:00
A.A.Abroskin
906b51637c
change assert_checks to assertions_on_constants
2019-01-09 13:38:38 +03:00
Matthias Krüger
144f01f381
readme: update travis badge to reflect migration from travis-ci.org to travis-ci.com
2019-01-09 00:50:32 +01:00
Philipp Hansch
38d4ac7cea
Remove all copyright license headers
...
Discussion previously happened in https://github.com/rust-lang/rust/pull/43498
2019-01-08 21:46:39 +01:00
bors
5b8496603c
Auto merge of #3640 - detrumi:nested_use_self, r=flip1995
...
Restrict `use_self` on nested items
Fixes #3637
Fixes #3463
These changes make it so that nested items aren't visited any more by the `use_self` lint.
I think visiting nested items should be possible (so that it uses a different `item_path` for the nested item), but I'm not sure whether it's viable and what the best approach would be.
- Can `item_path` be changed to a new `Self` path before visiting the item, and then changing it back afterwards?
- Alternatively, could a new visitor be created, re-using `check_trait_method_impl_decl`?
2019-01-07 18:54:28 +00:00
bors
140c1650e8
Auto merge of #3600 - xfix:cast-ref-to-mut, r=flip1995
...
cast_ref_to_mut lint
I see this pattern way too often, and it's completely wrong. In fact, due to how common this incorrect pattern is, [the Rustonomicon specifically points this out](https://doc.rust-lang.org/nomicon/transmutes.html ).
> - Transmuting an & to &mut is UB
> - Transmuting an & to &mut is always UB
> - No you can't do it
> - No you're not special
This is my first lint.
2019-01-07 18:30:53 +00:00
bors
dd94d3b93c
Auto merge of #3641 - hellow554:patch-1, r=flip1995
...
Add missing ` in default lint
2019-01-07 17:50:48 +00:00
Konrad Borowski
27ea638a15
Move cast_ref_to_mut list to correctness group
2019-01-07 14:39:56 +01:00
Wilco Kusee
466cd076a2
Rustftmt
2019-01-07 14:38:01 +01:00
Konrad Borowski
21d30450b5
Don't import ty::Ref in cast_ref_to_mut lint
2019-01-07 14:37:28 +01:00
Konrad Borowski
6faf1330aa
Move a hint to an error message in cast_ref_to_mut lint
...
This matches mem::transmute::<&T, &mut T> lint in rustc.
2019-01-07 14:37:28 +01:00
Konrad Borowski
1cab4d15a2
Add a note to cast_ref_to_mut lint
2019-01-07 14:37:28 +01:00
Konrad Borowski
fd57874106
Use ty::Ref instead of ty::TyKind::Ref
2019-01-07 14:37:28 +01:00
Konrad Borowski
34daf09aa4
cast_ref_to_mut lint
2019-01-07 14:37:28 +01:00
Marcel Hellwig
a3931229c4
Add missing ` in default lint
2019-01-07 14:32:32 +01:00
Wilco Kusee
351688db78
Improve tests and exclude nested impls
2019-01-07 14:11:53 +01:00
A.A.Abroskin
96058616e2
run ./util/dev update_lints
2019-01-07 13:33:06 +03:00
A.A.Abroskin
3d9535a106
Add unreachable!() as option
2019-01-07 13:30:17 +03:00
A.A.Abroskin
98c5f37ad2
Add assert(true) and assert(false) lints
2019-01-07 13:30:17 +03:00
bors
81fa26631c
Auto merge of #3638 - mikerite:fix-3625, r=oli-obk
...
Improve `get_unwrap` suggestion
Handle case where a reference is immediately dereferenced.
Fixes #3625
2019-01-07 08:41:43 +00:00
Michael Wright
d2ea6355a8
Update unwrap_get
code review suggestions
2019-01-07 06:22:39 +02:00
Wilco Kusee
7230768998
Update known problems
2019-01-06 15:41:02 +01:00
Wilco Kusee
ff191a808e
Restrict use_self on nested items
2019-01-06 15:34:36 +01:00
Michael Wright
4add1e23f9
Improve get_unwrap
suggestion
...
Handle case where a reference is immediately dereferenced.
Fixes 3625
2019-01-06 11:46:03 +02:00
bors
c63b6349b4
Auto merge of #3635 - matthiaskrgr:revert_random_state_3603, r=xfix
...
Revert the random_state lint.
Remove the random_state lint until it or rustc has been fixed to no longer crash with debug assertions (see #3628 )
We can't update clippy in the rustc repo because of this which is blocking nightlies because toolstate is already broken.
fixes #3628
2019-01-05 14:04:31 +00:00
bors
05467abd24
Auto merge of #3626 - phansch:rustfix_works, r=oli-obk
...
Add run-rustfix where it already works
This PR adds `// run-rustfix` headers to tests for `MachineApplicable` lints where
applying the suggestions works without any errors.
2019-01-05 12:14:30 +00:00
Matthias Krüger
8ff4a1f0a8
Revert "tests: used_underscore_binding_macro: disable random_state lint."
...
This reverts commit 2b80829fe0
.
2019-01-05 10:20:37 +01:00