yukang
0af255a5aa
Fix the bug of next_point in span
2022-10-18 02:59:38 +08:00
Michael Howell
3aa3b8be4e
rustdoc: remove redundant CSS on #copy-path
...
The border and background were removed in
5d004c1e20
, but not all the CSS was.
2022-10-17 11:59:01 -07:00
Michael Howell
3932b2c21d
rustdoc: factor JS mobile scroll lock into its own function
...
https://github.com/rust-lang/rust/pull/98775#issuecomment-1172728308
2022-10-17 11:44:02 -07:00
Josh Stone
d7fd1d57ec
Remove the redundant Some(try_opt!(..))
in checked_pow
...
The final return value doesn't need to be tried at all -- we can just
return the checked option directly. The optimizer can probably figure
this out anyway, but there's no need to make it work here.
2022-10-17 11:21:50 -07:00
Sky
9a7e527e28
Fix typo in ReverseSearcher
docs
2022-10-17 13:14:15 -04:00
bors
9c2797de22
Auto merge of #103151 - matthiaskrgr:rollup-t3mmnsg, r=matthiaskrgr
...
Rollup of 4 pull requests
Successful merges:
- #102454 (Suggest parentheses for possible range method calling)
- #102466 (only allow `ConstEquate` with `feature(gce)`)
- #102945 (Do not register placeholder `RegionOutlives` obligations when `considering_regions` is false)
- #103091 (rustdoc: remove unused HTML class `sidebar-title`)
Failed merges:
r? `@ghost`
`@rustbot` modify labels: rollup
2022-10-17 17:05:17 +00:00
bors
4d4c05d32b
Auto merge of #13428 - Veykril:fmt-stuck, r=Veykril
...
fix: Fix formatting requests hanging when r-a is still starting
The reason for that was that we were calculating the crate defmaps of the file we are saving by accident causing us to get stuck waiting on their expensive computation, while we only need the relevant crate id.
Closes https://github.com/rust-lang/rust-analyzer/issues/4054
Closes https://github.com/rust-lang/rust-analyzer/issues/11654
2022-10-17 16:21:32 +00:00
Lukas Wirth
a762baca02
fix: Fix formatting requests hanging when r-a is still starting
...
The reason for that was that we were calculating the crate defmaps
of the file we are saving by accident causing us to get stuck waiting
on their expensive computation, while we only need the relevant crate
id.
2022-10-17 18:21:18 +02:00
Chris Denton
913393a0f7
Allow Vec::leak
with no_global_oom_handling
2022-10-17 17:12:32 +01:00
Guillaume Gomez
885d69093f
Use named arguments to make test clearer
2022-10-17 18:08:53 +02:00
Guillaume Gomez
a3eab0ba67
Update browser-ui-test version to 0.12.6
2022-10-17 18:08:40 +02:00
Matthias Krüger
e1d72a485a
Rollup merge of #103091 - notriddle:notriddle/sidebar-title, r=GuillaumeGomez
...
rustdoc: remove unused HTML class `sidebar-title`
Since 6a5f8b1aef
, this class is no longer styled.
2022-10-17 17:15:51 +02:00
Matthias Krüger
d02a221d31
Rollup merge of #102945 - compiler-errors:placeholder-region-outlives, r=lcnr
...
Do not register placeholder `RegionOutlives` obligations when `considering_regions` is false
**NOTE:** I'm kinda just putting this up for discussion. I'm not certain this is correct...?
This was introduced in [`608625d`](608625dae9 (diff-6e54b18681342ec725d75591dbf384ad08cd73df29db00485fe51b4e90f76ff7R361)
).
Interestingly, we only check `data.has_placeholders()` for `RegionOutlives`, and not for `TypeOutlives`... why? For the record, that different treatment between `RegionOutlives` and `TypeOutlives` is why the fix "The compiling succeeds when all `'a : 'b` are replaced with `&'a () : 'b`" in #100689 _"works"_, but it seems like an implementation detail considering this.
Also, why do we care about placeholder regions being registered if `considering_regions` is false? It doesn't seem to affect any UI tests, for example.
r? `@lcnr`
Fixes #102899
Fixes #100689
2022-10-17 17:15:50 +02:00
Matthias Krüger
e91fd0b514
Rollup merge of #102466 - lcnr:const-equate-uwu, r=BoxyUwU
...
only allow `ConstEquate` with `feature(gce)`
2022-10-17 17:15:50 +02:00
Matthias Krüger
66de34b035
Rollup merge of #102454 - chenyukang:fix-102396-missing-parentheses, r=lcnr
...
Suggest parentheses for possible range method calling
Fixes #102396
2022-10-17 17:15:49 +02:00
bors
106285b5c4
Auto merge of #13427 - Veykril:cancel-check, r=Veykril
...
feat: Make flycheck workdone progress reports cancellable
In clients that support this (like VSCode), the clients will now render a cancel button on the notification message which can be clicked to cancel the flycheck instead.
Closes https://github.com/rust-lang/rust-analyzer/issues/6895
![Code_VbXgP3SbFD](https://user-images.githubusercontent.com/3757771/196205329-2df93451-c143-4d1b-a700-d988edf55efa.gif )
2022-10-17 14:41:57 +00:00
Lukas Wirth
e41023ce46
Make flycheck workdone progress reports cancellable
2022-10-17 16:32:47 +02:00
bors
a9d1cafa87
Auto merge of #102355 - lcnr:bye-bye-type-traversal, r=oli-obk
...
remove type traversal for mir constants
r? `@oli-obk` cc `@b-naber`
2022-10-17 14:19:28 +00:00
bors
067c410c45
Auto merge of #13426 - Veykril:client-refactor, r=Veykril
...
Refactor language client handling
Follow up to https://github.com/rust-lang/rust-analyzer/pull/12847 (turns out they fixed parts of the problem)
The PR will attempt to allow us to dispose more resources at will, so that we can implement restarts for the server properly instead of restating the entire extension as well as allowing us to implement a stop command.
Closes https://github.com/rust-lang/rust-analyzer/issues/12936
Closes https://github.com/rust-lang/rust-analyzer/issues/4697
2022-10-17 14:12:01 +00:00
Lukas Wirth
d63c44e650
Cleanup output channels
2022-10-17 16:01:39 +02:00
Lukas Wirth
7b5c943129
Downgrade vscode types dependency
2022-10-17 15:48:36 +02:00
Lukas Wirth
0421756b42
Implement stop and start server commands
2022-10-17 15:45:57 +02:00
Lukas Wirth
d68616a140
Make more things private
2022-10-17 15:05:20 +02:00
Lukas Wirth
8aaafddee8
Properly reload changed configs for server start
2022-10-17 14:53:46 +02:00
Lukas Wirth
6f435977df
Refactor language client handling
2022-10-17 14:21:12 +02:00
bors
502e87c379
Auto merge of #9637 - Alexendoo:unused-format-specs, r=xFrednet
...
Add `unused_format_specs` lint
Currently catches two cases:
An empty precision specifier:
```rust
// the same as {}
println!("{:.}", x);
```
And using formatting specs on `format_args!()`:
```rust
// prints `x.`, not `x .`
println("{:5}.", format_args!("x"));
```
changelog: new lint: [`unused_format_specs`]
2022-10-17 11:51:32 +00:00
Alex Macleod
136c2cdb91
Add unused_format_specs
lint
2022-10-17 11:36:05 +00:00
bors
abd7744101
Auto merge of #103145 - matthiaskrgr:rollup-mxwsysv, r=matthiaskrgr
...
Rollup of 4 pull requests
Successful merges:
- #102962 (remote-test-server: Show command line arguments)
- #103129 (rustdoc: remove unused `.sub-logo-container` DOM on non-source pages)
- #103136 (Fix types in documentation for `Alignment::as_usize` and `Alignmnet::as_nonzero`)
- #103139 (Duplicate comment in mod.rs)
Failed merges:
r? `@ghost`
`@rustbot` modify labels: rollup
2022-10-17 11:33:40 +00:00
Matthias Krüger
bb3f60b847
Rollup merge of #103139 - smoelius:patch-2, r=Dylan-DPC
...
Duplicate comment in mod.rs
2022-10-17 13:11:08 +02:00
Matthias Krüger
0c2017ff54
Rollup merge of #103136 - tmccombs:alignment-doc-fixes, r=Dylan-DPC
...
Fix types in documentation for `Alignment::as_usize` and `Alignmnet::as_nonzero`
2022-10-17 13:11:07 +02:00
Matthias Krüger
81ea72b38e
Rollup merge of #103129 - notriddle:notriddle/sub-logo-container, r=GuillaumeGomez
...
rustdoc: remove unused `.sub-logo-container` DOM on non-source pages
2022-10-17 13:11:07 +02:00
Matthias Krüger
9a615fd4e4
Rollup merge of #102962 - flba-eb:remote_test_server_help, r=pietroalbini
...
remote-test-server: Show command line arguments
The user of remote-test-server should get at least some minimal command line help as this is often started manually.
r? `@pietroalbini`
2022-10-17 13:11:07 +02:00
bors
f0797929e5
Auto merge of #13302 - Veykril:auto-publish, r=Veykril
...
Don't auto-publish lib crates
I believe this should *just* work? With this cargo-workspaces should not consider them
2022-10-17 10:22:25 +00:00
León Orell Valerian Liehr
684df4d24e
Make diagnostic for unsatisfied Termination bounds more precise
2022-10-17 12:08:46 +02:00
bors
40cbeb5b3d
Auto merge of #13423 - Veykril:vscode-vars, r=Veykril
...
Substitute some VSCode variables in the VSCode client
cc https://github.com/rust-lang/rust-analyzer/issues/13405
2022-10-17 10:08:12 +00:00
bors
a2e4f783a2
Auto merge of #13399 - DropDemBits:assists-format-args-capture-pt2, r=Veykril
...
Migrate assists to format args captures, part 2
Continuation of #13379
Migrates:
- `generate_constant`
- `generate_default_from_enum_variant`
- `generate_default_from_new`
- `generate_delegate_methods`
- `generate_deref`
- `generate_documentation_template`
- `generate_enum_is_method`
- `generate_enum_projection_method`
- `generate_from_impl_for_enum`
- `generate_function`
- `generate_getter`
- `generate_impl`
- `generate_new`
- `generate_setter`
2022-10-17 09:54:07 +00:00
David Wood
913f597402
infer: use derive more
...
Signed-off-by: David Wood <david.wood@huawei.com>
2022-10-17 09:54:24 +01:00
David Wood
f8b628bce4
session: use derive more
...
Signed-off-by: David Wood <david.wood@huawei.com>
2022-10-17 09:54:24 +01:00
David Wood
21d3bbd8b6
lint: use derive more
...
Signed-off-by: David Wood <david.wood@huawei.com>
2022-10-17 09:54:24 +01:00
David Wood
ea5d258a75
ast_passes: use derive more
...
Signed-off-by: David Wood <david.wood@huawei.com>
2022-10-17 09:54:24 +01:00
David Wood
2a4b587a68
ast_lowering: use derive more
...
Signed-off-by: David Wood <david.wood@huawei.com>
2022-10-17 09:54:24 +01:00
David Wood
feeeb11d89
macros: fully specify path to Fn
...
Signed-off-by: David Wood <david.wood@huawei.com>
2022-10-17 09:54:24 +01:00
David Wood
1045e69e73
macros: allow subdiagnostic-kind-less variants
...
Sometimes it is convenient to return a subdiagnostic enum where one or
more of the variants don't add anything to the diagnostic.
Signed-off-by: David Wood <david.wood@huawei.com>
2022-10-17 09:54:24 +01:00
David Wood
7fbaf27696
macros: support doc comments in diag derives
...
Documentation comments shouldn't affect the diagnostic derive in any
way, but explicit support has to be added for ignoring the `doc`
attribute.
Signed-off-by: David Wood <david.wood@huawei.com>
2022-10-17 09:54:24 +01:00
lcnr
d04bff6583
add inline to TrivialTypeTraversalImpls
2022-10-17 10:54:03 +02:00
lcnr
face090ef1
rm try_normalize_mir_const_after_erasing_regions
2022-10-17 10:54:03 +02:00
lcnr
e8150fa60c
mir constants: type traversing bye bye
2022-10-17 10:54:01 +02:00
lcnr
a5e116e95f
order_dependent_trait_objects
to ReportNow
2022-10-17 10:04:54 +02:00
bors
c19a893f87
Auto merge of #103116 - TaKO8Ki:fix-103053, r=lcnr
...
Fix `own_substs` ICE
Fixes #103053
2022-10-17 08:04:52 +00:00
Samuel Moelius
bf3a29f590
Duplicate comment in mod.rs
2022-10-17 03:54:56 -04:00