unexge
6cb090345e
Pattern match on slice elements instead of using .first().unwrap()
2020-08-05 13:25:26 +03:00
unexge
5214b4cdba
Look for trait methods in expand glob import assist
2020-08-05 11:29:00 +03:00
Paul Daniel Faria
4e2e3543c7
When resolving a rename, fallback to the name higher in the use tree if the path segment is self
2020-08-04 09:28:40 -04:00
Paul Daniel Faria
cc3eb85311
Add test showing unresolved module rename
2020-08-04 09:26:38 -04:00
bors[bot]
af6e9a7eb3
Merge #5658
...
5658: do not add to `pub use` in assists that insert a use statement r=jonas-schievink a=jbr
closes #5657 , see issue for rationale
Initially I wrote a version of this that changed the signature of `insert_use_statement` to take an `Option<VisibilityKind>` and only add to use statements with the same visibility, but that didn't make sense for any of the current uses of `insert_use_statement` (they all expected private visibility).
Co-authored-by: Jacob Rothstein <hi@jbr.me>
2020-08-04 12:47:11 +00:00
bors[bot]
2b0c2f6771
Merge #5659
...
5659: Revert LineIndex optimizations to fix #5656 r=matklad a=lazear
This PR reverts the changes from https://github.com/rust-analyzer/rust-analyzer/pull/5532 , which was causing issues as described in
https://github.com/rust-analyzer/rust-analyzer/issues/5656
Co-authored-by: Michael Lazear <lazear@scripps.edu>
2020-08-03 23:18:16 +00:00
Michael Lazear
2e72e74dbd
Revert "Restore line index micro-optimization"
...
This reverts commit 83a87fcd11
.
2020-08-03 13:35:32 -07:00
Jacob Rothstein
03a61134f2
do not add to pub use
statements
2020-08-03 12:17:05 -07:00
bors[bot]
33e53d4721
Merge #5653
...
5653: Fold trait declarations r=SomeoneToIgnore a=lnicola
Fixes #5652
Co-authored-by: Laurențiu Nicola <lnicola@dend.ro>
2020-08-03 17:25:26 +00:00
Laurențiu Nicola
f1bbc776c0
Fold trait declarations
2020-08-03 15:45:39 +03:00
bors[bot]
f17d2d1289
Merge #5628
...
5628: Rename test modules r=matklad a=lnicola
Co-authored-by: Laurențiu Nicola <lnicola@dend.ro>
2020-08-03 11:47:56 +00:00
unexge
bdb97756ca
Simplify find_mod_path
with use of node.ancestors
2020-08-03 13:04:20 +03:00
unexge
544322e66a
Generate doctest
2020-08-02 23:07:56 +03:00
unexge
a05a2ab1bb
Rename ast::UseItem to ast::Use
2020-08-02 23:07:36 +03:00
unexge
edd79a6b1c
Add expand glob import assist
2020-08-02 22:56:54 +03:00
Aleksey Kladov
e96bfd812a
Tweak style wording
2020-08-02 14:59:18 +02:00
Aleksey Kladov
edee52fa57
reorg docs
2020-08-02 14:37:50 +02:00
Aleksei Trifonov
85d5ed3675
Fix test code lens
2020-08-02 13:53:34 +03:00
bors[bot]
e4d0f19b01
Merge #5638
...
5638: Simplify argument parsing r=matklad a=lnicola
and use `Display` when printing errors.
Co-authored-by: Laurențiu Nicola <lnicola@dend.ro>
2020-08-01 16:47:51 +00:00
Laurențiu Nicola
562491b16b
Simplify argument parsing
2020-08-01 19:31:14 +03:00
bors[bot]
cf17366df9
Merge #5642
...
5642: Grammar updates r=matklad a=matklad
bors r+
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2020-08-01 11:49:36 +00:00
Aleksey Kladov
bff8dd0949
Update grammar
2020-08-01 13:47:19 +02:00
David Lattimore
6bbeffc8c5
SSR: Allow self
in patterns.
...
It's now consistent with other variables in that if the pattern
references self, only the `self` in scope where the rule is invoked will
be accepted. Since `self` doesn't work the same as other paths, this is
implemented by restricting the search to just the current function.
Prior to this change (since path resolution was implemented), having
self in a pattern would just result in no matches.
2020-08-01 17:41:42 +10:00
David Lattimore
21d2cebcf1
SSR: Matching trait associated constants, types and functions
...
This fixes matching of things like `HashMap::default()` by resolving
`HashMap` instead of `default` (which resolves to `Default::default`).
Same for associated constants and types that are part of a trait
implementation.
However, we still don't support matching calls to trait methods.
2020-08-01 12:55:26 +10:00
bors[bot]
5af32aeb2b
Merge #5635
...
5635: Better JSON serialization in metrics r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2020-08-01 02:10:16 +00:00
Aleksey Kladov
a015714def
Better JSON serialization in metrics
2020-08-01 04:09:52 +02:00
kjeremy
fcfd7cb1e3
Handle semantic token deltas
2020-07-31 20:57:53 -04:00
bors[bot]
2346a28c63
Merge #5634
...
5634: Finish rename r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2020-07-31 20:05:10 +00:00
Aleksey Kladov
8cf19847dd
Finish rename
2020-07-31 22:04:12 +02:00
Aleksey Kladov
b9c6aa9ec9
Unify naming of tuple fields
2020-07-31 22:04:12 +02:00
Aleksey Kladov
675e86becf
Section headers
2020-07-31 21:56:52 +02:00
bors[bot]
1914d0aa7b
Merge #5633
...
5633: Rename DotDotPat -> RestPat r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2020-07-31 19:47:23 +00:00
Aleksey Kladov
22d295ceaa
Rename DotDotPat -> RestPat
2020-07-31 21:45:29 +02:00
bors[bot]
215b9b9ccc
Merge #5632
...
5632: Cleanup impl gramamr r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2020-07-31 18:29:21 +00:00
Aleksey Kladov
af53d5f4b0
Rename
2020-07-31 20:23:52 +02:00
Aleksey Kladov
81359af733
Simplify trait gramamr
2020-07-31 20:22:20 +02:00
bors[bot]
38ab326aac
Merge #5631
...
5631: Finalize pattern grammar r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2020-07-31 18:12:38 +00:00
Aleksey Kladov
9818108798
Rename BindPat -> IdentPat
2020-07-31 20:12:10 +02:00
Aleksey Kladov
6791eb9685
Rename PalceholderPat -> WildcardPat
2020-07-31 20:07:21 +02:00
Aleksey Kladov
d7f75db90d
Reorder
2020-07-31 20:04:40 +02:00
Aleksey Kladov
14cb96ec0e
Allign RecordPat with RecordExpr
2020-07-31 20:00:48 +02:00
Aleksey Kladov
572f1c08b6
Minor gramamr reorder
2020-07-31 19:49:26 +02:00
bors[bot]
5cade89d73
Merge #5630
...
5630: Remove dead code r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2020-07-31 16:56:57 +00:00
Aleksey Kladov
45e6052406
Remove dead code
2020-07-31 18:53:10 +02:00
bors[bot]
5d9145ce10
Merge #5629
...
5629: Finalize Path grammar r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2020-07-31 16:50:43 +00:00
Aleksey Kladov
c1c97b2896
Fix leading colon
2020-07-31 18:49:42 +02:00
Aleksey Kladov
ddf08daddf
Fix const arguments grammar
2020-07-31 18:46:07 +02:00
Aleksey Kladov
040b4c800d
Fix GenericArgs grammar
2020-07-31 18:41:37 +02:00
bors[bot]
0392a894b7
Merge #5627
...
5627: Specify literal tokens r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2020-07-31 16:34:18 +00:00
Laurențiu Nicola
e5d7b003af
Rename test modules
2020-07-31 19:30:37 +03:00