Jason Newcomb
cdc4c697b5
Make expr_use_ctxt always return Some unless the syntax context changes.
2023-11-14 23:23:35 -05:00
Jason Newcomb
a68cd88860
Lint needless_borrow on most union field accesses
2023-11-11 14:50:19 -05:00
Jason Newcomb
79247d95f7
Split part of needless_borrow into needless_borrows_for_generic_args
2023-09-17 09:48:12 -04:00
bors
f13e1f429a
Auto merge of #11259 - Jarcho:ice_10253, r=dswij
...
Don't pass extra generic arguments in `needless_borrow`
fixes #10253
Also switches to using `implements_trait` which does ICE when clippy's debug assertions are enabled.
changelog: None
2023-09-04 03:17:50 +00:00
Oli Scherer
3d88fae050
Update ui test crate
2023-08-11 14:02:28 +00:00
Jason Newcomb
8277e7d154
Don't pass extra generic arguments in needless_borrow
2023-07-30 03:47:42 -04:00
Samuel Moelius
b4738a6b57
Add test for #10535
2023-07-08 19:11:15 -04:00
Pavan Kumar Sunkara
bfd5abad4b
Fix all the other tests
2023-06-12 16:21:06 +01:00
Oli Scherer
def1705a27
Update to a compiletest-rs version that requires //@ for commands
2023-04-20 14:44:03 +00:00
Jason Newcomb
5eed9c69ca
Revert 4dbd8ad34e, c7dc961558, ed519ad746 and c6477eb711
2023-01-12 13:28:22 -05:00
Samuel Moelius
ed519ad746
Improve possible_borrower
2022-12-20 05:12:13 -05:00
Samuel Moelius
c6477eb711
Add tests
2022-12-20 05:12:13 -05:00
Alex Macleod
461e219d1d
Allow using clippy::msrv as an outer attribute
2022-11-27 12:43:17 +00:00
Samuel Moelius
50f63a0f24
Address issues 9739 and 9782
2022-11-04 11:19:45 +00:00
Samuel Moelius
c42626f969
Fix #9710
2022-10-28 08:53:06 -04:00
Samuel Moelius
83771c5242
Fix needless_borrow false positive
2022-10-26 19:34:53 -04:00
Samuel Moelius
037f698147
needless_borrow uses used_exactly_once
2022-10-07 05:07:44 -04:00
Yuri Astrakhan
eb3970285b
fallout: fix tests to allow uninlined_format_args
...
In order to switch `clippy::uninlined_format_args` from pedantic to
style, all existing tests must not raise a warning. I did not want to
change the actual tests, so this is a relatively minor change that:
* add `#![allow(clippy::uninlined_format_args)]` where needed
* normalizes all allow/deny/warn attributes
* all allow attributes are grouped together
* sorted alphabetically
* the `clippy::*` attributes are listed separate from the other ones.
* deny and warn attributes are listed before the allowed ones
changelog: none
2022-10-02 15:13:22 -04:00
kraktus
14ba4fba11
fix [needless_borrow] and [explicit_auto_deref] false positive on unions
2022-09-27 21:30:32 +02:00
Samuel E. Moelius III
a05cb74d30
Enhance needless_borrow to consider trait implementations
2022-08-16 18:34:51 -04:00
Evan Typanski
40340745a8
Use parens around [needless_borrow] field calls
2022-07-19 15:17:24 -04:00
Jason Newcomb
988b813649
Use correct substitutions when checking if needless_borrow can apply to a method receiver
2022-07-02 15:48:46 -04:00
Jason Newcomb
6d21b79be9
Fix needless_borrow suggestion when calling a trait method taking self
2022-06-28 12:48:27 -04:00
Jason Newcomb
a187d6412b
Merge different parent walking loops in dereference.rs
...
`needless_borrow` will now walk further to find the target type.
2022-06-28 12:48:26 -04:00
xFrednet
8db734990b
Fix #[expect] for async_yields_async
2022-06-06 14:13:28 +02:00
xFrednet
a613460e8a
Fix #[expect] for needless_borrow, ref_binding_to_ref
2022-06-06 11:51:36 +02:00
Jason Newcomb
a135b52102
Don't lint needless_borrow in method receiver positions
2022-02-16 23:14:39 -05:00
Jason Newcomb
9e9110e4f3
Remove final reference on fields and method calls in needless_borrow
2022-01-22 20:35:32 -05:00
Jason Newcomb
15c068ed0f
Fix needless_borrow causing mutable borrows to be moved
2022-01-21 09:50:11 -05:00
Jason Newcomb
8ded385ddc
Improve needless_borrow lint.
...
* Lint when a borrow is auto dereferenced more than once
* Lint when the expression is used as the expression of a block for a match arm
Moves `needless_borrow` and `ref_binding_to_reference` to `dereference`
lint pass in preperation for `explicit_auto_deref` lint.
2021-11-15 13:17:59 -05:00
dswij
81d57de791
Update needless_borrow test output and expected fix
2021-09-13 12:29:24 +08:00
Jason Newcomb
6d4dc35882
Improve needless_borrow lint
...
Suggest changing usages of ref bindings to match the new type
Split out some cases into new lint `ref_binding_to_reference`
2021-05-20 09:03:47 -04:00
David Tolnay
94154cad20
Downgrade trivially_copy_pass_by_ref to pedantic
2020-04-02 18:56:10 -07:00
Manish Goregaokar
622b167eb8
needless_borrow: allow other lints, make fixable
2019-09-25 14:45:18 -07:00
