Oliver Schneider
af07ccc16c
fallout
2016-02-03 15:39:22 +01:00
Oliver Schneider
3b8375d90b
warn on useing all variants of an enum
2016-02-03 15:38:23 +01:00
mcarton
fab10c07e8
Fix confusing message for STRING_TO_STRING
2016-02-03 13:52:19 +01:00
scurest
908fb143ef
Extend ABSURD_UNSIGNED_COMPARISONS to handle more types
2016-02-03 05:08:00 -06:00
Manish Goregaokar
5eb884b7b0
Merge branch 'pr-593'
...
Conflicts:
README.md
src/lib.rs
2016-02-03 03:26:51 +05:30
mcarton
db205c82a4
Add a lint about using clone on Copy types
2016-02-02 22:35:01 +01:00
mcarton
47e26ab287
Fix warnings about the rustfmt_skip attribute
2016-02-02 22:34:20 +01:00
mcarton
c0d2fdc723
Partially apply rustfmt
2016-02-02 22:34:20 +01:00
mcarton
0c726e8077
Restore some of rustfmt madness
2016-02-02 22:34:20 +01:00
inrustwetrust
d93eca29fc
Fix typo in drop_ref lint description.
2016-02-02 20:47:38 +01:00
inrustwetrust
bd86922c4f
Add lint to warn for calls to std::mem::drop with a reference argument
2016-02-02 20:24:41 +01:00
llogiq
3a31576d76
fixed #606
2016-02-01 20:37:07 +01:00
llogiq
1dd19fbae3
Merge pull request #609 from oli-obk/prefixed_enum_variants
...
lint against enums where all variants share a prefix/postfix
2016-02-01 20:36:18 +01:00
Oliver Schneider
3b1df8d381
fallout
2016-02-01 13:01:16 +01:00
Oliver Schneider
328d2c7626
add lint to check for enums where all variants have the same pre-/postfix
2016-02-01 13:01:16 +01:00
Seo Sanghyeon
35ec57c116
Skip escape analysis for closure arguments
2016-02-01 20:35:01 +09:00
Oliver Schneider
07ace32ac9
fallout
2016-02-01 11:29:04 +01:00
Oliver 'ker' Schneider
d6c0435c81
lint on single match expressions with a value in the else path
2016-02-01 11:29:03 +01:00
llogiq
a2ad0c6695
fixed #528
2016-01-31 23:25:10 +01:00
scurest
e48fbba864
Add a lint to suggest uint == 0 over uint <= 0
2016-01-29 21:21:12 -06:00
llogiq
5402ef3d27
Merge branch 'devonhollowood-for-loop-over-option'
...
Conflicts:
README.md
2016-01-30 01:34:35 +01:00
Devon Hollowood
405d7c691e
Add for_loop_over_result lint
2016-01-29 15:24:17 -08:00
mcarton
f7bab322f6
Fix formatting on wiki
2016-01-29 22:49:48 +01:00
mcarton
95599c6a62
Synchronise comments with wiki
...
Wiki commits bfa439b and 9b8ced8.
2016-01-29 22:42:19 +01:00
mcarton
3a39bbaf74
Small cleanup
2016-01-29 22:31:17 +01:00
mcarton
1b9fbd8801
Fix false positive in NEEDLESS_LIFETIMES
2016-01-29 22:31:12 +01:00
mcarton
afb7e67217
Add a lint to warn about &vec![_] if &[_] would do
2016-01-29 17:41:52 +01:00
Devon Hollowood
f5cc94c96a
Add for_loop_over_option lint
2016-01-28 23:39:00 -08:00
Manish Goregaokar
4c14d98c9f
Merge pull request #549 from mcarton/ifs
...
Remove and lint about useless braces in `else { if .. }`
2016-01-29 03:39:27 +05:30
mcarton
da93643357
Add a lint to warn about use of print{,ln}!
2016-01-28 19:34:52 +01:00
llogiq
291b73b8e8
Merge master and re-run update_lints.py
2016-01-27 22:23:21 +01:00
Florian Hartwig
cee96fab39
Point out that char is 32 bit value
2016-01-27 21:10:35 +01:00
Florian Hartwig
23dfb2fbc0
Make update_lints script accept digits in lint names
2016-01-27 20:59:19 +01:00
Florian Hartwig
04f9d35f64
Add a lint for casts from char literals to u8
2016-01-27 20:23:59 +01:00
llogiq
5d5e50d67e
fixed suggestion for iter case
2016-01-27 14:51:30 +01:00
llogiq
d152e5c683
fixed argument check
2016-01-26 23:51:06 +01:00
llogiq
2d97f916eb
added more test, now works with vecs and iter
2016-01-25 19:46:56 +01:00
llogiq
ed96583677
extend_from_slice lint
2016-01-25 14:02:47 +01:00
mcarton
8ef0b86fab
Lint explicit Clone implementations on Copy type
2016-01-24 15:33:23 +01:00
Oliver 'ker' Schneider
2a51f8d2be
lint on items following statements
2016-01-24 10:16:56 +01:00
Manish Goregaokar
61bfaeb644
Merge branch 'rustup'
2016-01-22 18:36:23 +05:30
Manish Goregaokar
c86a5ccd2e
Upgrade Rust to rustc 1.8.0-nightly ( 18b851bc5 2016-01-22)
...
fixes #573
2016-01-22 18:35:48 +05:30
mcarton
c6c0edb19b
Add a lint about deriving Hash and implementing PartialEq
2016-01-21 19:56:31 +01:00
mcarton
7a26cfc991
Add macro checks in src/methods.rs lints
2016-01-20 18:32:17 +01:00
mcarton
91ff1db5bc
Add a lint for starts_with
2016-01-20 12:57:14 +01:00
mcarton
5ac6659814
Handle Entry types in OR_FUN_CALL lint
2016-01-20 11:42:25 +01:00
Florian Hartwig
ea26ae3888
Add macro check
2016-01-19 20:08:56 +01:00
Florian Hartwig
01eda52cb5
Add lint for "string literal".as_bytes()
2016-01-19 19:17:50 +01:00
Florian Hartwig
6a4d77aa32
Fix deprecation warning on latest nightly
2016-01-19 13:53:49 +01:00
llogiq
5623e9e601
Merge pull request #559 from mcarton/redundant_closure
...
Fix redundant_closure false positive
2016-01-18 19:33:42 +01:00
mcarton
9d5e9cfd97
Fix redundant_closure false positive
2016-01-18 19:28:06 +01:00
mcarton
3713fd3dce
Check types in the CMP_OWNED lint
2016-01-18 15:35:50 +01:00
Manish Goregaokar
5ab5a8801e
Merge pull request #556 from mcarton/or_fun_call
...
New lint, new utility functions and nightly fix
2016-01-18 18:57:35 +05:30
mcarton
21ba315102
Update to rustc 1.7.0-nightly ( d0bac3f14 2016-01-18)
2016-01-18 13:27:42 +01:00
mcarton
b5f65ec699
Improve OR_FUN_CALL to suggest unwrap_or_default
2016-01-18 13:11:07 +01:00
mcarton
fb6b3bed0f
Add utility functions to check for trait impl
2016-01-18 13:10:26 +01:00
mcarton
90cbc858e9
Fix spelling mistake
2016-01-18 13:09:46 +01:00
Florian Hartwig
7e85db645e
Fix another false positive in lifetime elision lint
...
The false positive occurred when we have an anonymous input lifetime and a
named output lifetime. This is not elidable, because if we elided the output
lifetime, it would be inferred to be the same as the input.
2016-01-17 17:53:41 +01:00
mcarton
c6604bb281
Add a lint to warn about call to .*or(foo(..))
2016-01-16 18:47:45 +01:00
llogiq
840d87022e
Merge pull request #523 from sanxiyn/escape-arg
...
Extend escape analysis to arguments
2016-01-16 00:03:58 +01:00
llogiq
da8a788b77
Merge pull request #551 from fhartwig/unused-lifetimes-fix
...
Consider lifetime in self parameter in unused_lifetime lint
2016-01-16 00:02:08 +01:00
mcarton
387e0991e3
Handle more iterator adapter cases in for loops
2016-01-14 20:58:32 +01:00
Florian Hartwig
7499f3c7a9
Consider lifetime in self paramter in unused_lifetime lint
2016-01-14 19:27:24 +01:00
mcarton
c2444c6043
Lint about else { if .. } with useless braces
2016-01-13 18:32:55 +01:00
mcarton
375b8168e4
Remove useless curly braces in else { if .. }
2016-01-13 18:32:05 +01:00
mcarton
6fa9bf64d7
Use span_suggestion in ENTRY lint
2016-01-13 17:27:49 +01:00
mcarton
f63329761f
Cleanup utils, mostly doc
2016-01-13 17:27:49 +01:00
mcarton
09129c1b41
Add BTreeMap to the HASHMAP_ENTRY rule
...
Fixes #433
2016-01-13 17:27:36 +01:00
mcarton
44daa8bd72
Use span_suggestion in matches lints
...
Ref #442
2016-01-13 13:17:11 +01:00
mcarton
9f641a1009
Add known enums to SINGLE_MATCH
2016-01-13 01:19:27 +01:00
llogiq
37707b5a34
added semver lint
2016-01-09 02:05:43 +01:00
Manish Goregaokar
a21108a296
Stronger macro check
2016-01-08 21:21:12 +05:30
Manish Goregaokar
f27cfdb51a
Fix warnings for unused attributes
2016-01-07 12:06:16 +05:30
Manish Goregaokar
002c8c34f8
re-add missing comments
2016-01-04 20:01:08 +05:30
Manish Goregaokar
c1a99fdd90
Fix dogfood failures by refactoring open_options
2016-01-04 12:06:37 +05:30
Manish Goregaokar
c9342d0121
fmt clippy
2016-01-04 09:56:12 +05:30
mcarton
9945bd82a8
Add better error messages for HashMapLint
2016-01-03 17:19:49 +01:00
mcarton
d0bb71e6a2
Finish the HashMapLint
2016-01-03 17:04:08 +01:00
mcarton
54b70ed8e1
Move eq_op::is_exp_equal to utils
2016-01-03 17:04:08 +01:00
mcarton
0c6e385493
Implement a HashMapLint
2016-01-03 17:04:08 +01:00
Manish Goregaokar
4484448cd1
Merge branch 'pr-538'
...
Conflicts:
README.md
2016-01-03 21:26:04 +05:30
Manish Goregaokar
780dedc500
fixups
2016-01-03 21:25:09 +05:30
mcarton
7a4d6aa8b7
Use same error message for OPTION_UNWRAP_USED and RESULT_UNWRAP_USED
...
IIRC, Result::expect wasn't stable until quite recently, which might be
why there was 2 different error messages.
2016-01-03 14:49:54 +01:00
Guillaume Gomez
abfb1d3ca1
Add new lint on function naming check (the '_')
2016-01-03 14:48:54 +01:00
mcarton
52fbf1989d
Add missing WRONG_PUB_SELF_CONVENTION in lint_array! and corresponding test
2016-01-03 14:42:24 +01:00
llogiq
a02f34aba9
Merge pull request #520 from mcarton/#471
...
Implement #471
2016-01-02 21:07:56 +01:00
llogiq
3e20292877
Merge pull request #535 from GuillaumeGomez/improve_field_help
...
Add help on field binding
2016-01-02 21:05:22 +01:00
mcarton
542685dad1
Merge branch 'master' of https://github.com/Manishearth/rust-clippy into #471
2016-01-02 19:36:45 +01:00
Manish Goregaokar
d8d3ee907b
Add macro check for box vec ( fixes #529 )
2016-01-02 21:49:53 +05:30
Manish Goregaokar
a745efd566
Add smarter macro check for block_in_if ( fixes #528 )
2016-01-02 21:41:53 +05:30
Manish Goregaokar
32cf6e32f6
Improve documentation on match_ref_pats ( fixes #532 )
2016-01-02 16:36:17 +05:30
Manish Goregaokar
1605ef6ed4
Rustup to syntax::errors changes
2016-01-02 16:10:15 +05:30
Guillaume Gomez
bd8a265000
Add help on field binding
2016-01-02 06:31:05 +01:00
Johannes Linke
f89e400578
Minor documentation cleanups
2016-01-01 17:49:01 +01:00
Johannes Linke
b287739c0b
Remove reference to a fixed issue
2016-01-01 17:48:46 +01:00
Johannes Linke
06f30a61dd
Add "warn/allow by default" to lint descriptions where it was missing.
2016-01-01 17:48:19 +01:00
Devon Hollowood
093582c102
Make MethodsPass lint notes clearer
2015-12-30 01:07:40 -08:00
Devon Hollowood
2c42d46468
Bug fix
2015-12-30 00:55:38 -08:00
Devon Hollowood
a6bd2d0622
Add SEARCH_IS_SOME lint
2015-12-30 00:38:03 -08:00
Devon Hollowood
bbd439ec9e
Add FILTER_NEXT lint
2015-12-28 16:56:58 -08:00
