bors
f44181e799
Auto merge of #5047 - flip1995:use_debug, r=phansch
...
Don't trigger use_debug lint in Debug impl
Fixes #5039
changelog: Don't trigger [`use_debug`] lint in Debug impl
2020-03-03 11:32:51 +00:00
bors
5d3e3e1a9e
Auto merge of #5250 - mlegner:unused_fp, r=flip1995
...
Whitelist unused attribute for use items.
This PR whitelists the `unused` attribute with `use` items and adds a corresponding test case.
Fixes : #5229
changelog: none
2020-03-03 11:16:55 +00:00
flip1995
91042db2e8
Add path for display trait
2020-03-03 10:54:30 +01:00
flip1995
58cea334ec
Use lang items instead of get_trait_def_id where possible
2020-03-03 10:54:30 +01:00
flip1995
a540b5ca2e
Update stderr
2020-03-03 10:48:08 +01:00
flip1995
a628733ade
Don't lint debug formatting in debug impl
2020-03-03 10:48:08 +01:00
bors
a94b2c1f7d
Auto merge of #5242 - matthiaskrgr:5238_test, r=flip1995
...
add test for #5238
changelog: none
2020-03-02 20:31:27 +00:00
bors
8b7f7e6672
Auto merge of #5254 - JohnTitor:sugg, r=flip1995
...
Rustup to rust-lang/rust#69469
changelog: none
2020-03-02 20:00:31 +00:00
Yuki Okushi
f1d0791c3a
Rustup to rust-lang/rust#69469
2020-03-03 04:53:42 +09:00
mlegner
8669be56c4
Whitelist unused attribute for use items.
2020-03-02 10:22:05 +01:00
JarredAllen
0d584f3ff7
Fix one last test issue
2020-03-01 23:11:29 -08:00
JarredAllen
d88750371d
Refactor suggested by krishna-veerareddy
2020-03-01 22:37:37 -08:00
JarredAllen
0a6d299409
Fixed compile error from merging
2020-03-01 13:12:56 -08:00
JarredAllen
91a1cd562a
Merge branch 'master' of github.com:rust-lang/rust-clippy
2020-03-01 12:48:22 -08:00
bors
0f4a3feccc
Auto merge of #5247 - JohnTitor:syntax, r=flip1995
...
Some rustups
changelog: none
2020-03-01 15:41:00 +00:00
Yuki Okushi
cda7881869
Disable rls test for now
2020-03-02 00:17:14 +09:00
Yuki Okushi
78dc48ea50
Rustup to rust-lang/rust#69579
2020-03-01 23:32:49 +09:00
Yuki Okushi
4253aa7137
Rustup to rust-lang/rust#69592
2020-03-01 12:23:33 +09:00
JarredAllen
ee73972537
Changed test output to reflect cargo fmt
2020-02-29 19:11:38 -08:00
JarredAllen
bfa2691559
Run cargo dev fmt
2020-02-29 18:51:39 -08:00
JarredAllen
028cddb956
Finished checking for cases of absolute values
2020-02-29 13:46:59 -08:00
Matthias Krüger
1e29b36e4e
add test for #5238
2020-02-28 22:00:20 +01:00
JarredAllen
5a21661ce5
Some bugfixing
2020-02-28 12:40:13 -08:00
JarredAllen
ce0dc9b70e
Created floating point abs lint and test, but not yet run
2020-02-27 22:31:41 -08:00
flip1995
f8224977b1
Fix deploy script for tag deploys
2020-02-27 18:03:30 +01:00
bors
610bceae71
Auto merge of #5232 - JohnTitor:git2-0.12, r=phansch
...
Update git2 to 0.12
changelog: none
2020-02-27 09:52:56 +00:00
Yuki Okushi
43e760ce1d
Update git2 to 0.12
2020-02-27 16:13:05 +09:00
bors
384593cd16
Auto merge of #5231 - JohnTitor:associated-type-defaults, r=phansch
...
Rustup to rust-lang/rust#61812
changelog: none
2020-02-27 06:40:31 +00:00
Yuki Okushi
7c760e5f83
Rustup to rust-lang/rust#61812
2020-02-27 12:19:18 +09:00
bors
2734e4e1f7
Auto merge of #4897 - krishna-veerareddy:issue-2040-accurate-float-functions, r=flip1995
...
Add lint to improve floating-point expressions
Looks for floating-point expressions that can be expressed using built-in methods to improve accuracy, performance and/or succinctness.
changelog: Add lint `floating_point_improvements`.
Fixes #4726
Partly addresses [#2040 ](https://github.com/rust-lang/rust-clippy/issues/2040 )
Currently linted expressions:
| Expression | Suggestion |
|---------------------------------|------------|
| x.log(2.0) | x.log2() |
| x.log(10.0) | x.log10() |
| x.log(std::f32::consts::E) | x.ln() |
| (1 + x).ln() | x.ln_1p() |
| (2.0).powf(x) | x.exp2() |
| (std::f32::consts::E).powf(x) | x.exp() |
| x.powf(1/2) | x.sqrt() |
| x.powf(1/3) | x.cbrt() |
| x.powf(y), where y is whole | x.powi(y) |
| x.exp() - 1 | x.exp_m1() |
|x * y + z|x.mul_add(y, z)|
2020-02-24 08:33:03 +00:00
bors
c6ad3db8b5
Auto merge of #5222 - JohnTitor:dont-deploy, r=flip1995
...
Do not run deploy action on other repos
Usually, we don't have to run deploy action on other repos, let's ignore there.
changelog: none
2020-02-24 08:20:10 +00:00
Krishna Sai Veera Reddy
ff0d44e45a
Add imprecise_flops lint
...
Add lint to detect floating point operations that can be computed more
accurately at the cost of performance. `cbrt`, `ln_1p` and `exp_m1`
library functions call their equivalent cmath implementations which is
slower but more accurate so moving checks for these under this new lint.
2020-02-23 22:36:15 -08:00
Krishna Sai Veera Reddy
e94a167508
Rename mul_add test file and add general improvements
2020-02-23 22:20:34 -08:00
Krishna Sai Veera Reddy
4065ca9c8c
Move manual_mul_add into suboptimal_flops lint
2020-02-23 22:20:34 -08:00
Krishna Sai Veera Reddy
454e505c12
Run rust-fix on tests
2020-02-23 22:20:34 -08:00
Krishna Sai Veera Reddy
bc706e3ba9
Fix powi suggestion and add general improvements
2020-02-23 22:20:34 -08:00
Krishna Sai Veera Reddy
6dacb1aa67
Change lint name to suboptimal_flops
2020-02-23 22:20:34 -08:00
Krishna Sai Veera Reddy
bc03f465c3
Remove lint for logarithm division identity
2020-02-23 22:20:34 -08:00
Krishna Veera Reddy
fd2506bcbf
Add type suffixes to unsuffixed method receiver suggestions
2020-02-23 22:20:34 -08:00
Krishna Veera Reddy
de07c84903
Detect usage of (x + 1).ln() and suggest x.ln_1p() instead
2020-02-23 22:20:34 -08:00
Krishna Veera Reddy
a60ae5d31c
Split test cases into separate files
2020-02-23 22:20:34 -08:00
Krishna Veera Reddy
de79733924
Lint expressions of the form x.log(b) / y.log(b)
2020-02-23 22:20:33 -08:00
Krishna Veera Reddy
9520d3dfa4
Suggest usage of powi method when applicable
2020-02-23 22:20:33 -08:00
Krishna Veera Reddy
1f4f357bf5
Consolidate the accuracy and efficiency lints
...
Merge the accuracy and efficiency lints into a single lint that
checks for improvements to accuracy, efficiency and readability
of floating-point expressions.
2020-02-23 22:20:33 -08:00
Krishna Veera Reddy
c636c6a55b
Add lints to detect inaccurate and inefficient FP operations
...
Add lints to detect floating point computations that are either
inaccurate or inefficient and suggest better alternatives.
2020-02-23 22:20:33 -08:00
Yuki Okushi
ee91b5b2dd
Do not run deploy action on other repos
2020-02-24 15:16:23 +09:00
bors
fc5d0cc583
Auto merge of #5221 - JohnTitor:rustup, r=phansch
...
Rustup to rust-lang/rust#69366
changelog: none
2020-02-24 05:58:17 +00:00
Yuki Okushi
036ec5b63d
Rustup to rust-lang/rust#69366
2020-02-24 13:33:04 +09:00
bors
7e49122f20
Auto merge of #5216 - krishna-veerareddy:issue-5192-fp-const-fn, r=flip1995
...
Prevent `missing_const_for_fn` on functions with const generic params
`const` functions cannot have const generic parameters so prevent the
`missing_const_for_fn` lint from firing in that case.
changelog: Fix false positive in `missing_const_for_fn`
Fixes #5192
2020-02-22 12:44:06 +00:00
Krishna Sai Veera Reddy
049079856b
Prevent missing_const_for_fn on functions with const generic params
...
`const` functions cannot have const generic parameters so prevent the
`missing_const_for_fn` lint from firing in that case.
2020-02-21 19:56:44 -08:00
