Jonas Schievink
74ac83a5ac
Fixup botched rename
2020-10-20 18:29:47 +02:00
Jonas Schievink
3fa04f35d2
More detailed message
2020-10-20 18:23:55 +02:00
Jonas Schievink
4cb3cf352f
Rename UnconfiguredCode -> InactiveCode
2020-10-20 18:22:31 +02:00
bors[bot]
5dd99aa016
Merge #6301
...
6301: Don't rely on display names in inlay_hints r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2020-10-20 16:14:40 +00:00
Aleksey Kladov
a3a8ad8bc4
Don't rely on display names in inlay_hints
2020-10-20 18:14:14 +02:00
Jonas Schievink
80d2741401
Add a (hint) diagnostic for unconfigured items
2020-10-20 17:53:04 +02:00
Jonas Schievink
a54e481646
Simplify diagnostic construction, add unused field
2020-10-20 17:53:04 +02:00
bors[bot]
f925735e64
Merge #6297
...
6297: Support Display name in project.json r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2020-10-20 15:15:58 +00:00
Aleksey Kladov
f753c3ecd2
Support Display name in project.json
2020-10-20 17:13:15 +02:00
bors[bot]
1c24f57ef8
Merge #6295
...
6295: More type safety around names r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2020-10-20 15:09:51 +00:00
Aleksey Kladov
3b1a648539
More type safety around names
2020-10-20 17:09:03 +02:00
Aleksey Kladov
a85c4280bf
Introduce CrateDisplayName
2020-10-20 16:00:51 +02:00
Benjamin Coenen
c22c039578
Assist: replace string with char
...
Signed-off-by: Benjamin Coenen <5719034+bnjjj@users.noreply.github.com>
2020-10-20 15:57:50 +02:00
Aleksey Kladov
af4e75533f
Rename declaration_name -> display_name
...
Declaration names sounds like a name of declaration -- something you
can use for analysis. It empathically isn't, and is just a label
displayed in various UI. It's important not to confuse the two, least
we accidentally mix semantics with UI (I believe, there's already a
case of this in the FamousDefs at least).
2020-10-20 15:38:11 +02:00
bors[bot]
be762ccccd
Merge #6294
...
6294: Add a hacky remidy for #6038 r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2020-10-20 10:36:28 +00:00
Aleksey Kladov
7a21e9302e
Add a hacky remidy for #6038
...
The proper fix I think is:
* move rust-lang/rust library crates to a separate workspace
* when packaging rust-src component, vendor sources of external deps
2020-10-20 12:34:39 +02:00
bors[bot]
4c00bdea67
Merge #6266
...
6266: Generate diagnostics docs r=matklad a=popzxc
Resolves #6215
Co-authored-by: Igor Aleksanov <popzxc@yandex.ru>
2020-10-20 09:46:43 +00:00
Igor Aleksanov
b8a74e0370
Add generated_diagnostic.adoc to the release.rs and smoke_test_docs_generation
2020-10-19 21:07:40 +03:00
Igor Aleksanov
aa9be4d523
Use xshell::read_file instead of fs::read_to_string
2020-10-19 20:58:32 +03:00
Igor Aleksanov
2a20e7795c
Add descriptions for diagnostics parseable by xtask
2020-10-19 20:55:16 +03:00
Igor Aleksanov
52b19c39e8
Create xtask module to generate diagnostics docs
2020-10-19 20:55:16 +03:00
bors[bot]
378dd90bab
Merge #6290
...
6290: Fix deprecation warning r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2020-10-19 17:06:34 +00:00
Aleksey Kladov
53a7651673
Fix deprecation warning
...
See https://github.blog/changelog/2020-10-01-github-actions-deprecating-set-env-and-add-path-commands/
2020-10-19 19:05:55 +02:00
bors[bot]
fc2383e783
Merge #6288
...
6288: Tag release branch rather than master r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2020-10-19 16:30:09 +00:00
Aleksey Kladov
895872f076
Tag release branch rather than master
2020-10-19 18:28:59 +02:00
bors[bot]
2c5bd9517e
Merge #6274
...
6274: Check cargoExtraArgs for undefined before using r=matklad a=feileacan
Fixes #6273
Co-authored-by: feileacan <54381366+feileacan@users.noreply.github.com>
2020-10-19 15:35:32 +00:00
bors[bot]
9b656463ce
Merge #6284
...
6284: Document logging of project model r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2020-10-19 14:04:58 +00:00
Aleksey Kladov
a261c7c539
Document logging of project model
2020-10-19 16:04:22 +02:00
bors[bot]
18775643f6
Merge #6283
...
6283: Minor, rename feature r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2020-10-19 13:54:16 +00:00
Aleksey Kladov
4fbb602b2d
Minor, rename feature
2020-10-19 15:53:48 +02:00
bors[bot]
3b4d0e2464
Merge #6282
...
6282: Try to fix publishing r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2020-10-19 13:19:33 +00:00
Aleksey Kladov
8421115354
Try to fix publishing
...
This errro specifically:
Updating crates.io index
error: failed to select a version for the requirement `ra_ap_stdx = "^0.0.0"`
candidate versions found which didn't match: 0.0.20
location searched: /home/runner/work/rust-analyzer/rust-analyzer/crates/stdx
required by package `ra_ap_completion v0.0.20 (/home/runner/work/rust-analyzer/rust-analyzer/crates/completion)`
error: unable to update Cargo.lock
Error: Process completed with exit code 1.
2020-10-19 15:18:28 +02:00
bors[bot]
b19040fae4
Merge #6280
...
6280: ⬆️ crates r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2020-10-19 11:58:33 +00:00
Aleksey Kladov
c4699819d0
⬆️ crates
2020-10-19 13:57:41 +02:00
bors[bot]
3ca97b0e88
Merge #6277
...
6277: Change visibility works for type aliases r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2020-10-18 15:06:08 +00:00
Aleksey Kladov
604caedeb2
Change visibility works for type aliases
2020-10-18 17:04:12 +02:00
bors[bot]
886cfd6821
Merge #6276
...
6276: Extract call_info and completion into separate crates r=matklad a=popzxc
As it was discussed in [zulip](https://rust-lang.zulipchat.com/#narrow/stream/185405-t-compiler.2Fwg-rls-2.2E0/topic/Completion.20refactoring ), we need to move `completions` into a separate crate.
Unfortunately, the dependency on `call_info::ActiveParameter` doesn't look easy to get rid of, and it seems to be a topic for a separate PR, thus I also extracted `call_info` into a separate crate (on which both `ide` and `completion` crates depend).
Additionally, a few `FIXME`s in doc-comments were resolved in order to make `tidy` happy.
Co-authored-by: Igor Aleksanov <popzxc@yandex.ru>
2020-10-18 10:41:46 +00:00
Igor Aleksanov
9e7c952bbd
Extract call_info and completion into separate crates
2020-10-18 13:09:00 +03:00
bors[bot]
2067a410f3
Merge #6275
...
6275: Textmate grammar: prevent unwanted interpolation scopes r=matklad a=dustypomerleau
Fixes the issues noted by @matklad after merging #6248 .
1. prevent accidental interpolation scopes when `{` is used in a string
1. prevent interpolations from extending beyond the end of a string
Co-authored-by: Dusty Pomerleau <dustypomerleau@users.noreply.github.com>
2020-10-18 08:30:28 +00:00
Dusty Pomerleau
06208e622f
fix: prevent unwanted interpolation scopes
2020-10-18 13:27:03 +11:00
feileacan
d019cdbbb2
Check cargoExtraArgs for undefined before using
2020-10-18 11:40:48 +11:00
bors[bot]
7c4bb97145
Merge #6272
...
6272: ⬆️ xshell r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2020-10-17 23:53:42 +00:00
Aleksey Kladov
6c7769a2e3
update deps
2020-10-18 01:53:01 +02:00
Aleksey Kladov
cb63e83237
⬆️ xshell
2020-10-18 01:51:39 +02:00
bors[bot]
aed7b6d98a
Merge #6271
...
6271: Complete methods when receiver is a macro r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2020-10-17 22:45:32 +00:00
bors[bot]
63956e509e
Merge #6248
...
6248: Textmate grammar: prevent early termination of raw strings with hash (closes #6042 ) r=matklad a=dustypomerleau
Problematic sample code from #6042 :
```rust
#[derive(Debug, Clone, Logos)]
enum Quoted<'source> {
#[regex(r#"[^\\"']+"#)]
Text(&'source str),
#[token("\\")]
StartEscape,
#[token("\'", |_| Quote::Single)]
#[token("\"", |_| Quote::Double)]
End(Quote),
#[error]
Error,
}
```
Before fix:
<img width="400" alt="Screen Shot 2020-10-16 at 10 45 59" src="https://user-images.githubusercontent.com/6304651/96198390-6a726d00-0fa0-11eb-8428-e76b2866836b.png ">
After fix:
<img width="400" alt="Screen Shot 2020-10-16 at 10 45 33" src="https://user-images.githubusercontent.com/6304651/96198408-7a8a4c80-0fa0-11eb-9104-ca708009fe63.png ">
Co-authored-by: Dusty Pomerleau <dustypomerleau@users.noreply.github.com>
2020-10-17 22:38:04 +00:00
Aleksey Kladov
13451d3dc4
Complete methods when receiver is a macro
2020-10-17 23:43:13 +02:00
Aleksey Kladov
4fe4c30436
Improve readability
2020-10-17 23:35:21 +02:00
bors[bot]
783c6a333a
Merge #6265
...
6265: ⬆️ xshell r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2020-10-17 11:25:48 +00:00
Aleksey Kladov
0fab08740b
⬆️ xshell
2020-10-17 13:25:22 +02:00