Aleksey Kladov
17e8a00b0b
Use standard code style for test fixtures
2020-11-17 14:43:23 +01:00
Aleksey Kladov
8c6f933773
**Unwrap Block** supports stand-alone blocks
2020-11-17 14:33:30 +01:00
Aleksey Kladov
10fa9c595a
Simplify
2020-11-17 14:33:30 +01:00
Aleksey Kladov
8dd0b7d2b5
Assist target should point at *existing* code
2020-11-17 14:33:30 +01:00
Aleksey Kladov
9a30707281
Add **Ignore Test** assist
2020-11-17 14:22:04 +01:00
Benjamin Coenen
9f15de77f9
add suggestion ..Default::default() for remaining struct fields in a constructor #6492
...
Signed-off-by: Benjamin Coenen <5719034+bnjjj@users.noreply.github.com>
2020-11-13 23:20:26 +01:00
Benjamin Coenen
e73d140b51
add suggestion ..Default::default() for remaining struct fields in a constructor #6492
...
Signed-off-by: Benjamin Coenen <5719034+bnjjj@users.noreply.github.com>
2020-11-13 17:17:16 +01:00
bors[bot]
cf73b6851b
Merge #6514
...
6514: Fix extract_struct_from_enum_variant not updating record references r=Veykril a=Veykril
Related to #6510
Co-authored-by: Lukas Wirth <lukastw97@gmail.com>
2020-11-12 17:48:25 +00:00
Lukas Wirth
ccdcd52975
Add extra test to extract_struct_from_enum_variant
2020-11-12 18:44:37 +01:00
bors[bot]
13cf3b4886
Merge #6513
...
6513: Support qualified function calls in remove_unused_param r=Veykril a=Veykril
Also adds a test to check that it removes unused params across files.
Co-authored-by: Lukas Wirth <lukastw97@gmail.com>
2020-11-12 17:12:21 +00:00
Lukas Wirth
b6e2b28353
Support qualified function calls in remove_unused_param
2020-11-12 18:04:42 +01:00
Lukas Wirth
9454a9e536
Use Module::find_use_path_prefixed in extract_struct_from_enum_variant assist
2020-11-12 17:32:45 +01:00
Lukas Wirth
e24cc77cd1
Fix extract_struct_from_enum_variant not updating record references
2020-11-12 17:13:33 +01:00
Kirill Bulatov
07e633ef0a
Remove the fixme
2020-11-12 13:52:24 +02:00
Kirill Bulatov
3481ea96bd
Add a FIXME for non-unified inner attributes
2020-11-12 13:46:02 +02:00
Kirill Bulatov
335edf87bc
Do not insert imports before inner comments
2020-11-12 13:46:02 +02:00
Lukas Wirth
949c580d1b
Add multiple file edit tes to remove_unused_param assist
2020-11-09 19:06:11 +01:00
Aleksey Kladov
4a16c228e7
Fix panic when extracting struct
2020-11-09 16:59:57 +01:00
Aleksey Kladov
018f826197
Support multi-file assist tests
2020-11-09 14:44:08 +01:00
bors[bot]
73b08131df
Merge #6506
...
6506: Cleanup assists r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2020-11-09 12:28:57 +00:00
Aleksey Kladov
d31ce3b16c
Use standard style for test code
2020-11-09 13:28:04 +01:00
Aleksey Kladov
3cecf78488
More consistent naming
2020-11-09 13:18:40 +01:00
Aleksey Kladov
29bf6bed9b
More consistent naming
2020-11-09 13:07:18 +01:00
bors[bot]
2d3b0571bb
Merge #6465
...
6465: Support multiple file edits in AssistBuilder r=matklad a=Veykril
Fixes #6459
Co-authored-by: Lukas Wirth <lukastw97@gmail.com>
2020-11-09 11:54:42 +00:00
bors[bot]
2f24714081
Merge #6501
...
6501: Remove text_edit_builder api from AssistBuilder r=matklad a=Veykril
Also fixes a small bug in `expand_glob_import` in regards to the very nice looking `something::{*}` import when only one item was used. Before it would duplicate the path and just append it, causing the following wrong import `something::something::UsedItem`.
Co-authored-by: Lukas Wirth <lukastw97@gmail.com>
2020-11-09 11:40:08 +00:00
Lukas Wirth
4c03d98db4
Remove text_edit_builder api from AssistBuilder
2020-11-08 23:22:11 +01:00
bors[bot]
dac7060382
Merge #6476
...
6476: Add missing AssocItems in add_custom_impl assist r=matklad a=Veykril
```rust
use std::fmt;
#[derive(Debu<|>g)]
struct Foo {
bar: String,
}
```
->
```rust
use std::fmt;
struct Foo {
bar: String,
}
impl fmt::Debug for Foo {
fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
${0:todo!()}
}
}
```
Co-authored-by: Lukas Wirth <lukastw97@gmail.com>
2020-11-07 18:21:11 +00:00
m-ysk
69ba62e6cd
Minimize convert_integer_literal tests
2020-11-07 18:47:25 +09:00
Aleksey Kladov
5db789df9c
Cleanup API
2020-11-06 22:52:42 +01:00
bors[bot]
7f12a1f225
Merge #6485
...
6485: Remove RAW literals r=matklad a=matklad
bors r+
🤖
closes https://github.com/rust-analyzer/rust-analyzer/issues/6308
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2020-11-06 21:39:02 +00:00
bors[bot]
cdddcaee85
Merge #6477
...
6477: Add infer_function_return_type assist r=matklad a=Veykril
This adds an assist to insert a functions return type if it hasn't been specified yet by inferring it from the functions tail expression. This assist only becomes active if the cursor is on the tail expression. See https://github.com/rust-analyzer/rust-analyzer/issues/6303#issuecomment-714657326
Co-authored-by: Lukas Wirth <lukastw97@gmail.com>
2020-11-06 21:32:27 +00:00
Aleksey Kladov
6158304f8b
Simplify
2020-11-06 22:30:58 +01:00
Aleksey Kladov
5ba4f949c2
Kill RAW_ literals
...
Syntactically, they are indistinguishable from non-raw versions, so it
doesn't make sense to separate then *at the syntax* level.
2020-11-06 22:23:14 +01:00
Lukas Wirth
186431e178
Adjust test-texts in infer_function_return_type
2020-11-06 21:51:15 +01:00
Lukas Wirth
4f0d02c276
Enable infer_function_return_type in return-type position
2020-11-06 21:49:03 +01:00
bors[bot]
1faa9559fe
Merge #6480
...
6480: Support closure in change_return_type_to_result assist r=Veykril a=Veykril
Co-authored-by: Lukas Wirth <lukastw97@gmail.com>
2020-11-06 19:41:13 +00:00
Lukas Wirth
e95a65ccaf
Support closure in change_return_type_to_result assist
2020-11-06 20:40:03 +01:00
Aleksey Kladov
eb46033390
More orthogonal API
2020-11-06 19:09:01 +01:00
Aleksey Kladov
735aaa7b39
Move int parsing to IntNumber token
2020-11-06 18:54:01 +01:00
Lukas Wirth
c665884474
Wrap non-block expressions in closures with a block
2020-11-06 03:06:08 +01:00
Lukas Wirth
2e6e5d8f73
Ignore unit expressions in infer_function_return_type assist
2020-11-06 02:17:34 +01:00
Lukas Wirth
0a7c8512ff
Support closures in infer_function_return_type assist
2020-11-06 02:15:13 +01:00
Lukas Wirth
a14df19d82
Add infer_function_return_type assist
2020-11-06 01:47:41 +01:00
Lukas Wirth
19443c1fa3
Add missing AssocItems in add_custom_impl assist
2020-11-05 23:41:46 +01:00
bors[bot]
bd6eeffb2f
Merge #6456
...
6456: Support record variants in extract_struct_from_enum_variant r=matklad a=Veykril
As requested :)
This also prevents the assist from being disabled if a definition in the value namespace exists with the same name as our new struct since that won't cause a collision
#4468
Co-authored-by: Lukas Wirth <lukastw97@gmail.com>
2020-11-04 12:37:29 +00:00
bors[bot]
99a8e59f68
Merge #6458
...
6458: Qualify trait impl created by add_custom_impl assist r=matklad a=Veykril
When we find at least one trait with the same name as the derive accessible from the current module we now generate a qualified path to that trait in the generated impl.
If we don't find any we just do what was done before and emit the trait name in the generated impl.
Co-authored-by: Lukas Wirth <lukastw97@gmail.com>
2020-11-04 12:30:09 +00:00
Lukas Wirth
db5c529781
Support multiple file edits in AssistBuilder
2020-11-04 12:34:33 +01:00
Lukas Wirth
4992b75e51
Qualify trait impl created by add_custom_impl assist
2020-11-03 23:41:35 +01:00
Lukas Wirth
6145234450
Support struct variants in extract_struct_from_enum_variant
2020-11-03 20:57:04 +01:00
bors[bot]
7c94f1cb5e
Merge #6454
...
6454: Fix overflow panic in convert_interger_literal assist r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2020-11-03 18:59:15 +00:00