blyxyas
5ed338dff9
impl_trait_in_params now supports impls and traits
2023-10-08 23:49:32 +02:00
Michael Goulet
56794fa5f1
Fix clippy
2023-10-04 21:09:54 +00:00
Philipp Krones
772296c50e
Merge commit '7671c283a50b5d1168841f3014b14000f01dd204' into clippyup
2023-09-25 11:28:58 +02:00
Camille GILLOT
19e160fe2f
Bless clippy.
2023-09-23 13:47:30 +00:00
y21
981e96008b
new lint: path_ends_with_ext
2023-09-15 16:17:51 +02:00
Ralf Jung
3226e4b010
don't point at const usage site for resolution-time errors
...
also share the code that emits the actual error
2023-09-14 22:34:05 +02:00
Philipp Krones
471469d30f
Merge commit '98363cbf6a7c3f8b571a7d92a3c645bb4376e4a6' into clippyup
2023-09-12 18:44:06 +02:00
Philipp Krones
d2b08432db
Merge remote-tracking branch 'upstream/master' into rustup
2023-09-07 21:43:06 +02:00
bors
0d36d57c41
Auto merge of #11439 - Alexendoo:disallowed-macros-bins-attrs, r=xFrednet
...
Check binary operators and attributes in disallowed_macros
changelog: none
2023-09-06 11:36:28 +00:00
Urgau
a86e758228
Adjust clippy tests with new rustc help suggestion for lints
2023-09-04 14:22:02 +02:00
bors
bcf856bfb3
Auto merge of #11375 - J-ZhengLi:issue11246, r=Centri3
...
fix fp when [`undocumented_unsafe_blocks`] not able to detect comment on globally defined const/static variables
fixes : #11246
changelog: fix detection on global variables for [`undocumented_unsafe_blocks`]
2023-09-04 09:47:45 +00:00
Alex Macleod
299fbceb96
Check binary operators and attributes in disallowed_macros
2023-08-31 13:14:44 +00:00
bors
c50d86fc6a
Auto merge of #11418 - Benjscho:explicit_iter_loop_config, r=llogiq
...
Add config flag for reborrows in explicit_iter_loop
This PR adds a config flag for enforcing explicit into iter lint for reborrowed values. The config flag, `enforce_iter_loop_reborrow`, can be added to clippy.toml files to enable the linting behaviour. By default the reborrow lint is disabled.
fixes : #11074
changelog: [`explicit_iter_loop`]: add config flag `enforce_iter_loop_reborrow` to disable reborrow linting by default
2023-08-31 11:19:04 +00:00
Ben Schofield
be55a96d80
Add config flag for reborrows in explicit_iter_loop
...
This commit adds a config flag for enforcing explicit into iter lint
for reborrowed values. The config flag, enforce_iter_loop_reborrow, can be
added to clippy.toml files to enable the linting behaviour. By default
the lint is not enabled.
2023-08-27 21:45:14 -06:00
Alex Macleod
d78d26a8c7
Remove redundant auxiliary test files
2023-08-25 14:25:49 +00:00
Philipp Krones
cc61aeea54
Merge commit '080b587854a73f2a8cbaecff1884860a78e2ff37' into clippyup
2023-08-24 21:32:12 +02:00
J-ZhengLi
77215672e9
fix [undocumented_unsafe_blocks] not able to detect comment for global vars
2023-08-22 10:27:16 +08:00
Oli Scherer
00919a4f92
Update ui test crate to auto-detect aux build crate kind
2023-08-11 14:02:35 +00:00
Oli Scherer
3d88fae050
Update ui test crate
2023-08-11 14:02:28 +00:00
Philipp Krones
f730a2655a
Merge commit '1e8fdf492808a25d78a97e1242b835ace9924e4d' into clippyup
2023-08-11 14:05:13 +02:00
Catherine Flores
71c54137ea
Extract never-like into clippy_utils
2023-08-02 14:00:26 -05:00
Philipp Krones
b0e64a9c09
Merge commit '5436dba826191964ac1d0dab534b7eb6d4c878f6' into clippyup
2023-07-31 23:53:53 +02:00
Catherine
9cf1509b25
New lint absolute_paths
2023-07-21 17:26:58 -05:00
Philipp Krones
d6d530fd0b
Merge commit 'd9c24d1b1ee61f276e550b967409c9f155eac4e3' into clippyup
2023-07-17 10:22:32 +02:00
Alex Macleod
2811effe34
Add imports_granularity = "Module" to rustfmt.toml
2023-07-13 12:44:57 +00:00
bors
ebd8d31542
Auto merge of #11055 - smoelius:try-this, r=dswij
...
"try this" -> "try"
Current help messages contain a mix of "try", "try this", and one "try this instead". In the spirit of #10631 , this PR adopts the first, as it is the most concise.
It also updates the `lint_message_conventions` test to catch cases of "try this".
(Aside: #10120 unfairly contained multiple changes in one PR. I am trying to break that PR up into smaller pieces.)
changelog: Make help messages more concise ("try this" -> "try").
2023-07-09 15:07:25 +00:00
Guillaume Gomez
c62c7fadac
Update UI tests with new needless_pass_by_ref_mut lint
2023-07-03 22:25:36 +02:00
Philipp Krones
cb3ecf7b79
Merge commit '37f4c1725d3fd7e9c3ffd8783246bc5589debc53' into clippyup
2023-07-02 14:59:02 +02:00
Samuel Moelius
420f3d11e8
"try this" -> "try"
2023-07-01 07:08:01 -04:00
Centri3
8cb6c86996
change category and refactor
...
Update raw_strings.rs
Revert "new lints for visibility"
This reverts commit 0e5a537d209727169769dc19cf86aef27122c092.
new lints for visibility
2023-06-27 05:16:40 -05:00
Centri3
bc744eb82b
new lint needless_raw_string + refactor a bit
...
Thanks, #112373 , for the snippet at line 75!
2023-06-27 05:12:00 -05:00
Oli Scherer
5bd97ac17a
Update tests
2023-06-26 14:13:07 +00:00
Centri3
cc2e49f695
allow safety comment above attributes
2023-06-19 23:46:57 -05:00
Renato Lochetti
8625a849d1
adding all ui tests to the configuration test as well
2023-06-17 09:36:38 -03:00
Renato Lochetti
e2e6a02445
Addressing reviewer comments
2023-06-17 09:36:38 -03:00
Renato Lochetti
520228b377
Adding configuration to allow safety comment above stmt containing unsafe block
2023-06-17 09:36:36 -03:00
Pavan Kumar Sunkara
bfd5abad4b
Fix all the other tests
2023-06-12 16:21:06 +01:00
y21
c8c7a3c79c
fix rebase weirdness
2023-06-12 12:21:38 +02:00
y21
7312a93a06
new lint: large_stack_frames
2023-06-12 12:21:38 +02:00
Centri3
243943ff56
make it work for locals as well
...
oopos
2023-06-12 03:22:01 -05:00
Centri3
7cdd87ca4a
ignore generics and allow arbitrary threshold
2023-06-12 03:22:01 -05:00
Centri3
52cfc997af
Add lint single_letter_idents
2023-06-12 03:21:43 -05:00
bors
21e6235b4c
Auto merge of #10921 - Centri3:needless_if, r=blyxyas,Manishearth
...
Add `needless_if` lint
first off: Sorry about the large diff. Seems a ton of tests do this (understandably so).
this is basically everything I wanted in #10868 , while it doesn't lint *all* unnecessary empty blocks, it lints needless if statements; which are basically the crux of the issue (for me) anyway. I've committed code that includes this far too many times 😅 hopefully clippy can help me out soon
closes #10868
changelog: New lint [`needless_if`]
2023-06-12 04:18:50 +00:00
Centri3
7ba904245d
make cargo test pass
2023-06-10 09:39:53 -05:00
bors
e986b6444e
Auto merge of #10917 - Centri3:module_inception, r=xFrednet
...
allow disabling module inception on private modules
Fixes #10842
changelog: Enhancement [`module_inception`]: Added `allow-private-module-inception` configuration.
[#10917 ](https://github.com/rust-lang/rust-clippy/pull/10917 )
<!-- changelog_checked -->
2023-06-10 13:21:48 +00:00
Centri3
b303e2053c
allow disabling module inception on private modules
...
allow disabling module inception on private modules
2023-06-10 08:09:07 -05:00
bors
476efe92e7
Auto merge of #10672 - Centri3:excessive-width-lints, r=Alexendoo
...
Add `excessive_nesting` lint
changelog: new lint [`excessive_nesting`]
2023-06-09 20:47:06 +00:00
Centri3
6afb3555d3
remove revisions
2023-06-08 10:15:58 -05:00
Centri3
5da34559ee
Check if from proc macro and better tests
2023-06-07 18:34:34 -05:00
Centri3
725399a178
move to complexity but don't lint by default
2023-06-07 18:34:34 -05:00
Centri3
378d77584a
work with lint attributes
2023-06-07 18:34:34 -05:00
Centri3
493a23e957
check non-inline modules, ignore all macros
2023-06-07 18:34:34 -05:00
Centri3
88143ac295
decided against reinventing the wheel
2023-06-07 18:34:34 -05:00
Centri3
e68dbc3308
add excessive_nesting
...
Close code block in example
2023-06-07 18:34:34 -05:00
Centri3
97c10075ec
add the excessive_* style lints
2023-06-07 18:22:50 -05:00
y21
05f78e530a
allow the lint in a bunch of tests
2023-06-06 22:56:57 +02:00
Philipp Krones
e6dc0efc00
Merge commit '30448e8cf98d4754350db0c959644564f317bc0f' into clippyup
2023-06-02 11:41:57 +02:00
bors
50ab3ce6c9
Auto merge of #10607 - beetrees:toml-spans, r=giraffate
...
Add spans to `clippy.toml` error messages
Adds spans to errors and warnings encountered when parsing `clippy.toml`.
changelog: Errors and warnings generated when parsing `clippy.toml` now point to the location in the TOML file the error/warning occurred.
2023-06-02 08:01:31 +00:00
beetrees
6f13a37499
Add spans to clippy.toml error messages
2023-06-02 00:56:27 +01:00
Samuel "Sam" Tardieu
e6646eb5fd
needless_else: new lint to check for empty else clauses
2023-05-22 11:52:26 +02:00
Philipp Krones
7e9abb311d
Merge commit '371120bdbf58a331db5dcfb2d9cddc040f486de8' into clippyup
2023-05-05 17:45:49 +02:00
bors
990bbdc2be
Auto merge of #10656 - Centri3:master, r=xFrednet
...
Add configuration for `semicolon_block` lints
Does exactly what it says on the tin, suggests moving a block's final semicolon inside if it's multiline and outside if it's singleline.
I don't really like how this is implemented so I'm not too sure if this is ready yet. Alas, it might be ok.
---
fixes #10654
changelog: Enhancement: [`semicolon_inside_block`]: Added `semicolon-inside-block-ignore-singleline` as a new config value.
[#10656 ](https://github.com/rust-lang/rust-clippy/pull/10656 )
changelog: Enhancement: [`semicolon_outside_block`]: Added `semicolon-outside-block-ignore-multiline` as a new config value.
[#10656 ](https://github.com/rust-lang/rust-clippy/pull/10656 )
<!-- changelog_checked -->
2023-04-25 20:12:00 +00:00
Centri3
e3ee10d428
use //@ for commands in tests
2023-04-25 11:23:02 -05:00
Centri3
aa6c27a74e
change names to not be implicitly negative
2023-04-25 11:14:52 -05:00
Philipp Krones
a1b75c5108
Merge commit 'a3ed905928a03b6e433d0b429190bf3a847128b3' into clippyup
2023-04-23 13:28:56 +02:00
Oli Scherer
def1705a27
Update to a compiletest-rs version that requires //@ for commands
2023-04-20 14:44:03 +00:00
Centri3
a3aeec4f75
config instead of new lint and don't panic
2023-04-19 21:46:13 -05:00
Lukas Lueg
4bc68f9c60
Add size-parameter to unecessary_box_returns
...
Fixes #10641
2023-04-19 14:32:05 +02:00
Philipp Krones
6b95029f17
Merge commit '83e42a2337dadac915c956d125f1d69132f36425' into clippyup
2023-04-11 15:31:08 +02:00
bors
29987062d9
Auto merge of #10536 - mkrasnitski:suggestions, r=flip1995
...
Add suggestions to `extra_unused_type_parameters`
Change the `extra_unused_type_parameters` lint to provide machine applicable suggestions rather than just help messages. Exception to this are cases when any unused type parameters appear bounded in where clauses - for now I've deemed these cases unfixable and separated them out. Future work might be able to provide suggestions in these cases.
Also, added a test case for the `avoid_breaking_exported_api` config option.
r? `@flip1995`
changelog: [`extra_unused_type_parameters`]: Now provides fixable suggestions.
2023-03-31 16:16:36 +00:00
bors
799732cbd8
Auto merge of #10414 - csmoe:large-future, r=xFrednet
...
add large future lint
Closes #5263
---
changelog: new lint: [`large_futures`]
[#10414 ](https://github.com/rust-lang/rust-clippy/pull/10414 )
<!-- changelog_checked -->
2023-03-30 08:51:29 +00:00
csmoe
4f5a019d6e
Update clippy_lints/src/large_futures.rs
...
Co-authored-by: Fridtjof Stoldt <xFrednet@gmail.com>
2023-03-29 08:47:32 +00:00
Alex Macleod
3259b48568
Migrate format_args.rs to rustc_ast::FormatArgs
...
No longer lints empty precisions `{:.}` as the spans aren't available
2023-03-28 12:22:22 +00:00
Philipp Krones
8df896c076
Merge commit 'd5e2a7aca55ed49fc943b7a07a8eba05ab5a0079' into clippyup
2023-03-24 14:26:19 +01:00
Michael Krasnitski
50d92d0b60
Add suggestions to extra_unused_type_parameters
2023-03-23 23:56:31 -04:00
csmoe
4fdae81c70
add large future lint
2023-03-20 22:51:01 +08:00
J-ZhengLi
f4ccb06d69
extract is_interior_mutable_type from [mut_key] to clippy_utils::ty;
...
fix configuration of [`ifs_same_cond`];
add some style improvement for [`ifs_same_cond`];
2023-03-13 20:17:30 +08:00
J-ZhengLi
f0ae2b71ca
make [ifs_same_cond] use ignore_interior_mutablility configuration
2023-03-13 20:13:56 +08:00
Pietro Albini
aff9b72375
move clippy tests back to their intended directory
2023-03-08 14:17:16 +01:00
Alex Macleod
2cadea5dc5
Fix array-size-threshold config deserialization error
2023-02-28 14:37:41 +00:00
Jason Newcomb
0413fb35ba
Merge commit '149392b0baa4730c68f3c3eadf5c6ed7b16b85a4' into clippyup
2023-02-25 19:28:50 -05:00
Liu Dingming
79a90248c3
bless
2023-02-22 21:49:26 +08:00
Liu Dingming
1a474d9179
Recover tests
2023-02-22 21:36:30 +08:00
Christian Poveda
c29e767ef1
Address review comments
2023-02-17 09:09:44 -05:00
Christian Poveda
64b8aaf91a
remove empty file
2023-02-16 11:45:57 -05:00
Christian Poveda
e2e23c0045
Add docs and update tests
2023-02-09 16:41:45 -05:00
Christian Poveda
8eac9e359e
bless tests
2023-02-06 15:19:26 -05:00
Christian Poveda
c6692a8b42
Add configuration to lint missing docs of pub(crate) items
2023-02-06 14:21:37 -05:00
Philipp Krones
d21616737b
Merge commit '7f27e2e74ef957baa382dc05cf08df6368165c74' into clippyup
2023-01-12 19:48:13 +01:00
Caio
4262aebeaa
[arithmetic-side-effects] Consider negative numbers and add more tests
2023-01-06 12:25:51 -03:00
Andy Russell
9aef1a264a
reword dbg_macro labels
2023-01-02 12:09:26 -05:00
Philipp Krones
1c422524c7
Merge commit '4bdfb0741dbcecd5279a2635c3280726db0604b5' into clippyup
2022-12-17 14:12:54 +01:00
bors
39f0719a25
Auto merge of #9840 - c410-f3r:arith-2, r=Alexendoo
...
[`arithmetic-side-effects`]: Consider user-provided pairs
Depends on https://github.com/rust-lang/rust-clippy/pull/9592 .
Because of https://github.com/rust-lang/rust-clippy/pull/9559#discussion_r985293523 , r? `@Alexendoo`
```
changelog: [`arithmetic-side-effects`]: Consider user-provided pairs
```
2022-12-09 11:27:15 +00:00
Caio
1f92f97e5a
[arithmetic-side-effects]: Consider user-provided pairs
2022-12-08 17:41:49 -03:00
naosense
eec5039f09
fix test
2022-12-03 16:06:57 +08:00
Philipp Krones
d05e2865a0
Merge commit 'd822110d3b5625b9dc80ccc442e06fc3cc851d76' into clippyup
2022-12-01 18:29:38 +01:00
naosense
67a94135cb
change note style
2022-11-29 15:00:51 +08:00
naosense
1fc98c51df
change default value
2022-11-29 15:00:51 +08:00
naosense
4528aec7e9
update config and suggest
2022-11-29 15:00:51 +08:00
naosense
aed9497978
add test and stderr
2022-11-29 15:00:51 +08:00
