Commit Graph

341 Commits

Author SHA1 Message Date
Oliver Schneider
6a6dfa59da
factor out decl dumping 2016-10-24 14:29:09 +02:00
Oliver Schneider
1248159f0d
add expression and pattern dump 2016-10-24 14:28:58 +02:00
Oliver Schneider
f29ab8c245
Merge branch 'master' of github.com:Manishearth/rust-clippy into deep_code_inspection 2016-10-24 10:39:19 +02:00
Arnavion
2315a817ce Changed signature of cargo::metadata according to review comment. 2016-10-23 12:24:16 -07:00
Arnavion
ebbd00b1ab Don't assume the first package in the result of cargo metadata is the current crate.
Instead find the one with the manifest path that matches the --manifest-path argument or the current directory.

Fixes #1247
2016-10-22 18:15:42 -07:00
mcarton
6960c506ef
Fix unused import warning 2016-10-22 16:16:38 +02:00
mcarton
ceb50872ce
Bump to 0.0.96 2016-10-22 16:00:17 +02:00
mcarton
1c3fce41b6
Rustup to *rustc 1.14.0-nightly (f09420685 2016-10-20)* 2016-10-22 15:57:19 +02:00
Oliver Schneider
a177d85681
rename inspection attribute to clippy_dump 2016-10-18 17:29:01 +02:00
Oliver Schneider
ff3efc759e
initial implementation of the code inspector lint 2016-10-18 16:57:39 +02:00
mcarton
4cf87a9d49
Remove the now stable #[feature(question_mark)] 2016-10-16 14:01:55 +02:00
d-dorazio
62831c6e29 Suggest nth(X) instead of skip(X).next() 2016-10-14 13:38:00 +02:00
Patrick Horlebein
4fbd8906e1 doc_markdown: Added "iOS" and "macOS" to the doc-valid-idents list 2016-10-12 15:32:44 +02:00
d-dorazio
a4d4a372e0 Avoid redundant multiple pattern suggested when one pattern is _ 2016-10-08 16:29:19 +02:00
mcarton
47c2271497
Fix FP with print_with_newline and final arguments 2016-10-06 22:30:03 +02:00
mcarton
a4035aabf3
Bump to 0.0.95 2016-10-06 17:52:41 +02:00
mcarton
fc09eb553e
Fix dogfood problem 2016-10-06 17:50:11 +02:00
mcarton
0475eae1fa
Rustup to *rustc 1.14.0-nightly (3210fd5c2 2016-10-05)* 2016-10-06 17:46:50 +02:00
Martin Carton
e851bc7404 Merge pull request #1257 from KitFreddura/master
If let some lint
2016-10-04 23:00:05 +02:00
Manish Goregaokar
85e37795b9 Merge pull request #1262 from Manishearth/rustup
Remove warning in the latest nightly
2016-10-04 21:04:20 +05:30
mcarton
2b8500664c
Remove warning in the lastest nightly 2016-10-04 17:17:40 +02:00
Manish Goregaokar
ec93ae10e0 Bump to 0.0.94 2016-10-04 09:17:09 +05:30
mcarton
1c035f7cf9
Bump to 0.0.93 2016-10-03 21:26:25 +02:00
mcarton
4f91d66905 Rustup to *rustc 1.14.0-nightly (144af3e97 2016-10-02)* 2016-10-03 21:25:27 +02:00
Manish Goregaokar
a4198c1108 Merge pull request #1255 from Manishearth/cov
Improve test coverage
2016-10-03 22:15:23 +05:30
Kit Freddura
c8aa35e150 replaced snippet_opt with snippet for more terse code 2016-10-02 14:38:31 -07:00
Kit Freddura
97e9299a10 fixed array bounds checking 2016-10-02 14:26:41 -07:00
Kit Freddura
3573114764 replaced pat_to_string with snippet 2016-10-02 14:15:24 -07:00
Kit Freddura
1188f59102 fixed struct elison 2016-10-02 13:53:10 -07:00
Kit Freddura
c18dc13f6e added file again 2016-10-02 13:48:52 -07:00
Kit Freddura
d152ca04bd updated zero_div_zero.rs 2016-10-02 13:44:23 -07:00
Kit Freddura
ab9435a6d4 ran update 2016-10-02 13:42:11 -07:00
Kit Freddura
1c15428339 removed formatting changes 2016-10-02 13:39:28 -07:00
Andre Bogus
8188c46429 Allow option_map_unwrap_or(_else)
This fixes #1192.
2016-10-02 21:23:26 +02:00
mcarton
d982b19a0e
Fix slightly wrong comment 2016-10-02 14:30:21 +02:00
mcarton
f03bac6c3a
Remove a useless method 2016-10-02 02:47:53 +02:00
mcarton
e50cfa7e77
Add a test for a shadow corner case 2016-10-02 02:38:54 +02:00
mcarton
9a3f53dee6
Partially hash let declaration in SpanlessHash
The hash never needs to be good but before it was simply doing nothing
for these.
2016-10-02 02:17:04 +02:00
mcarton
e036a8145a
Support ExprType (type ascription) comparison
*ish
2016-10-01 22:26:57 +02:00
mcarton
3e009b9424
Implement more hir typed node comparison 2016-10-01 22:19:20 +02:00
Martin Carton
8babb2d409 Merge pull request #1250 from elliottneilclark/explicit_into_iter
Add a lint to warn about un-necessary .into_iter()
2016-10-01 15:01:43 +02:00
Oliver Schneider
9c5d3f3b85 correctly traverse match expressions for diverging_sub_expr 2016-10-01 14:41:20 +02:00
Elliott Clark
4a34087c77 Run util/update_lints.py after adding explicit_into_iter_loop 2016-09-30 17:50:02 -07:00
Elliott Clark
5fa004313b Add a lint to warn about un-necessary .into_iter()
This should close #1094.
2016-09-30 17:42:43 -07:00
mcarton
ee5a5a256f
Bump to 0.0.92 2016-09-30 22:07:01 +02:00
mcarton
ec27062bb6
Bump to 0.0.91 2016-09-28 01:10:50 +02:00
mcarton
4f3920307a
Rustup to *rustc 1.13.0-nightly (d0623cf7b 2016-09-26)* 2016-09-28 01:09:11 +02:00
mcarton
f74dcaac0c
Fix wrong suggestion in TRANSMUTE_PTR_TO_REF with lts 2016-09-19 17:59:12 +02:00
mcarton
5f1120b346
Fix markup in SINGLE_CHAR_PATTERN documentation 2016-09-18 18:27:08 +02:00
Takuma YOSHIOKA
7b6a60ca69
Fix typo in example codes of "matches" lints
Use `=>` for match arms (instead of wrong `->`).
2016-09-18 20:17:25 +09:00
mcarton
c8986b4676
Fix FP with WHILE_LET_ON_ITERATOR and refutable pats 2016-09-16 15:50:35 +02:00
mcarton
90c390ec2a
Fix typo
Who cares? Meh, consistency.
2016-09-16 15:45:19 +02:00
Martin Carton
dc84759ac5 Merge pull request #1224 from oli-obk/divergence
lint diverging expressions that are sub-expressions of others
2016-09-13 15:58:31 +02:00
Oliver Schneider
e6bfe4b514
also lint diverging methods 2016-09-13 12:41:37 +02:00
Oliver Schneider
a2257280ec
don't lint expressions referencing ! objects, just expressions creating them 2016-09-13 12:41:20 +02:00
Oliver Schneider
12a82b2007
also lint private modules for module_inception, as that is the main issue 2016-09-13 10:19:55 +02:00
Oliver Schneider
f469860dc2
lint diverging expressions that are sub-expressions of others 2016-09-12 14:24:11 +02:00
Oliver Schneider
03fa974855
Let the submodule #[allow] in module_inception 2016-09-12 10:30:42 +02:00
mcarton
7279dc3edf
Bump to 0.0.90 2016-09-10 19:13:55 +02:00
mcarton
ab6669a641
Rustup to *rustc 1.13.0-nightly (f1f40f850 2016-09-09)* 2016-09-10 19:13:49 +02:00
mcarton
9263ec3616
Bump to 0.0.89 2016-09-06 19:05:53 +02:00
mcarton
e9ba9ec1a2
Bump to 0.0.88 2016-09-04 17:50:14 +02:00
mcarton
b82f43f38e
Revert "Remove all union stuffs"
This reverts commit 888c34ad70.
This rustups to rustc 1.13.0-nightly (70598e04f 2016-09-03).
2016-09-04 17:45:36 +02:00
mcarton
b2de244cfd
Restrict len_without_is_empty to exported items 2016-09-02 15:30:06 +02:00
kennytm
5f09020e90 Added a lint_without_lint_pass lint.
Four lints were missing from LintPass, making them unavailable unless the
`clippy` lint group is explicitly enabled:

* `for_loop_over_result`
* `for_loop_over_option`
* `match_overlapping_arm`
* `filter_next`
2016-09-01 15:07:37 +08:00
mcarton
377fec7c9a
Bump to 0.0.87 2016-08-31 18:22:36 +02:00
mcarton
888c34ad70
Remove all union stuffs
The rustc's PR wasn't merged. Hopefully this commit can simply be reverted when it's time.
2016-08-31 18:22:36 +02:00
mcarton
01424f5622
Support unions here and there 2016-08-31 18:22:36 +02:00
mcarton
3f43996aa5
Rustup to *1.13.0-nightly (eac41469d 2016-08-30)* 2016-08-31 18:22:35 +02:00
mcarton
d87f137254
Add a builtin_type_shadow lint 2016-08-28 19:56:18 +02:00
mcarton
e922fa80ce
Fix FP in ZERO_PREFIXED_LITERAL and 0b/Oo 2016-08-28 18:00:09 +02:00
mcarton
f3062f4199 Bump to 0.0.86 2016-08-28 17:26:45 +02:00
mcarton
189c5e5cfc
Rustup to rustc 1.13.0-nightly (a23064af5 2016-08-27) 2016-08-28 17:25:58 +02:00
mcarton
e338f6a4f0
Remove now useless attribute type_macros 2016-08-28 17:24:34 +02:00
Andre Bogus
06235b0310 refactored misc to reduce passes
related to #1062

Before: 960MB After: 956MB

So while this reduces code size somewhat, I don't see much memory
improvement here. Still, it's probably worthwile to consider reducing
our passes at least within modules.
2016-08-24 21:47:46 +02:00
mcarton
ddf84ea845
Fix typos 2016-08-24 14:37:09 +02:00
mcarton
be329ebdf7
Typo
TIL what `wether` means.
2016-08-23 19:51:42 +02:00
mcarton
9a2aadf872
Deny missing_docs_in_private_items in some modules 2016-08-23 19:39:36 +02:00
mcarton
8b12e28e43
in_macro check in MISSING_DOCS_IN_PRIVATE_ITEMS 2016-08-23 19:00:56 +02:00
mcarton
36d8ca04a1
Add a MISSING_DOCS_IN_PRIVATE_ITEMS lint 2016-08-23 18:28:39 +02:00
mcarton
507b626b36 Add zero_prefixed_literal lint 2016-08-23 18:15:12 +02:00
llogiq
cf2b0c8dd6 New cmp_null lint (fixes #1184) (#1186)
* new cmp_null lint (fixes #1184)

* adressed comments (still fails)

* fixed tests, dogfood, ran update_lints
2016-08-22 18:29:29 +02:00
mcarton
0474fe27ea
Bump to 0.0.85 2016-08-19 17:41:24 +02:00
Oliver Schneider
14d2cd0b0a
unused_import is a valid lint to be changed on use statements 2016-08-19 17:27:24 +02:00
Oliver Schneider
2d57902a27
don't lint if snippet is shortert than 1 character
This happens with various combinations of cfg attributes and macros expansion.
Not linting here is the safe route, as everything else might produce false positives.
2016-08-19 17:27:24 +02:00
mcarton
663d8497aa
Bump to 0.0.84 2016-08-18 21:51:06 +02:00
Georg Brandl
ff919376a6 rustup 2016-08-18 21:24:35 +02:00
Oliver Schneider
6daa884e4f
version bump and changelog update 2016-08-17 18:07:25 +02:00
Oliver Schneider
40720a61e8
rustup for the ! type 2016-08-17 17:58:15 +02:00
mcarton
a34beedfe5 Add "DirectX" and "OpenGL" to doc_valid_idents 2016-08-17 15:46:33 +02:00
Oliver Schneider
3ab6ad59c4
disallow lint attributes on use and extern crate items 2016-08-17 11:36:04 +02:00
Oliver Schneider
ac16695757 Merge pull request #1143 from birkenfeld/issue-455
Lint print!("...\n") (closes #455)
2016-08-17 11:33:32 +02:00
Manish Goregaokar
f006805c4a
Bump to 0.0.82 2016-08-17 09:20:20 +05:30
Georg Brandl
ffad9a8c8c Lint print!("...\n") (closes #455) 2016-08-16 20:52:48 +02:00
Oliver Schneider
b6f320a495
address nits and improve docs 2016-08-16 14:36:48 +02:00
Oliver Schneider
7ee4a9a659
lint modules that have the same name as their parent module 2016-08-16 14:29:21 +02:00
Manish Goregaokar
e12f14f676
Bump to 0.0.81 2016-08-14 09:13:19 +05:30
David Tolnay
95df2d1bf4
Update to rustc 1.12.0-nightly (1deb02ea6 2016-08-12) 2016-08-13 14:23:38 -07:00
scurest
b0a96def09 Add lint for reads and writes that depend on evaluation order 2016-08-11 06:01:40 -05:00
llogiq
ce3be22021 Merge pull request #1151 from oli-obk/clone_ref
add suggestions to clone_on_copy
2016-08-09 06:30:25 +02:00