Michael Recachinas
535302efda
Register 'int_plus_one' lint case in clippy_lints
2017-09-17 17:27:16 +01:00
Michael Recachinas
d7ea6addf0
( #1955 ): Suggests x > y over x >= y + 1 for ints
...
This module handles the following cases:
- `... >= ... + 1` and `... >= 1 + ...`
- `... - 1 >= ...` and `-1 + ... >= ...`
- `... + 1 <= ...` and `... + 1 <= ...`
- `... <= ... - 1` and `... <= -1 + ...`
Note: this only goes 1 level deep (i.e., does not constant-fold) and
does not currently simplify expressions. Examples of these
cases include:
```rust
let x = 1;
y >= y + x; // won't catch this case or any permutation
x + 1 >= y + 2; // won't catch this case
x + 1 - 1 >= y - 1 + 1; // WILL catch this case when it likely shouldn't
```
2017-09-17 17:18:12 +01:00
Oliver Schneider
2bb8efdb4d
Merge pull request #2058 from rust-lang-nursery/ptr_arg-vs-clone
...
add suggestions for .clone() in ptr_arg fns
2017-09-17 15:37:21 +02:00
llogiq
b3d8192e27
Merge pull request #2059 from marcusklaas/manual-slice-clone4
...
Also detect manual slice cloning
2017-09-17 10:21:43 +02:00
Marcus Klaas
48ed3c058f
Extend MANUAL_MEMCPY lint so that it also detects manual clones between slices
2017-09-16 19:17:22 -04:00
Marcus Klaas
a6206cc5f8
Add test for manual slice clones
2017-09-16 18:53:55 -04:00
Marcus Klaas
e461e3f915
Format loops.rs with latest stable rustfmt
2017-09-16 18:45:28 -04:00
llogiq
708a818094
Merge pull request #2057 from topecongiro/issue-1818
...
Enhance CHARS_*_CMP lint
2017-09-16 09:16:55 +02:00
llogiq
013b1f5923
Merge pull request #2056 from topecongiro/issue-1851
...
Add suggestion to needless_borrow
2017-09-16 09:13:13 +02:00
Andre Bogus
72be166756
add suggestions for .clone() in ptr_arg fns
2017-09-16 09:10:26 +02:00
topecongiro
d5d300c034
Update tests
2017-09-16 14:50:30 +09:00
topecongiro
81f5c69131
Enhance CHARS_*_CMP lint
2017-09-16 14:50:07 +09:00
topecongiro
d8afe2ccbc
Update tests
2017-09-16 11:27:46 +09:00
topecongiro
197664e989
Add suggestion to needless_borrow
2017-09-16 11:27:24 +09:00
Oliver Schneider
f64bae4ae3
Merge pull request #2052 from topecongiro/issue-1990
...
Add ExprLoop to contains_continue_expr()
2017-09-15 09:21:46 +02:00
Seiichi Uchida
0215a1acb0
Update a test
2017-09-14 22:27:29 +09:00
Seiichi Uchida
1f6801dd6a
Add ExprLoop to contains_continue_expr()
2017-09-14 22:26:59 +09:00
Seiichi Uchida
9f0cc93ac6
Bump version
2017-09-14 22:24:00 +09:00
Oliver Schneider
86d609fdf6
Version bump
2017-09-14 09:13:54 +02:00
Oliver Schneider
33e4b3b552
Merge pull request #2049 from topecongiro/rustc-fix
...
rustc fix
2017-09-14 09:11:10 +02:00
topecongiro
49d388d4ec
Remove '\t' from .stderr
...
to make cargo test pass
2017-09-14 13:18:34 +09:00
topecongiro
86e178e786
Add a missing argument
2017-09-14 13:18:08 +09:00
Oliver Schneider
b2c88b0a35
Merge remote-tracking branch 'origin/master' into rustup
2017-09-13 15:41:09 +02:00
Oliver Schneider
32a9394490
Rustup
2017-09-13 15:34:04 +02:00
llogiq
916f2f9f71
Merge pull request #2046 from siiptuo/small-doc-fixes
...
Small documentation fixes
2017-09-12 20:12:48 +02:00
Tuomas Siipola
d768fe8c16
Fix link in trivial_regex
2017-09-12 19:08:25 +03:00
Tuomas Siipola
6d3db724b7
Fix empty documentation in unit_expr
2017-09-12 19:08:25 +03:00
Tuomas Siipola
2b698db1ae
Fix links in approx_const
2017-09-12 19:08:18 +03:00
Oliver Schneider
b7222be917
Version bump
2017-09-12 14:40:24 +02:00
Oliver Schneider
b127ad251f
Rustup
2017-09-12 14:38:59 +02:00
Oliver Schneider
36cd745640
Regressions ( #2041 )
2017-09-12 14:25:58 +02:00
Oliver Schneider
6b583d63d8
Merge pull request #2039 from rust-lang-nursery/ptr-arg-suggestion
...
suggestion for ptr_arg
2017-09-11 08:30:52 +02:00
Andre Bogus
e7e8e79020
suggestion for ptr_arg
2017-09-10 19:32:24 +02:00
Oliver Schneider
b0b60558c5
Merge pull request #2037 from Aaron1011/clone-rc
...
Add CLONE_ON_REF_PTR lint
2017-09-10 11:27:02 +02:00
Aaron Hill
d318ced660
Add CLONE_ON_REF_PTR lint
...
Closes issue #1645
2017-09-09 21:52:19 -04:00
Oliver Schneider
9c9a4953c3
Merge pull request #2034 from Aaron1011/update-rust
...
Update for latest Rust
2017-09-09 14:47:40 +02:00
Oliver Schneider
81d32123f4
Bump version
2017-09-09 14:37:16 +02:00
Oliver Schneider
edcf6e7e80
Use hir_id instead of fetching hir_id via the NodeId
2017-09-09 14:06:41 +02:00
Aaron Hill
8adc42b5b4
Update for latest Rust
...
This is mainly due to https://github.com/rust-lang/rust/commit/dead08cb33134
2017-09-09 01:23:08 -04:00
Oliver Schneider
6edab5662d
Merge pull request #2029 from rust-lang-nursery/rustup
...
Soft rustup (only fixed some tests)
2017-09-08 14:26:42 +02:00
Oliver Schneider
78f6db907c
Soft rustup (only fixed some tests)
2017-09-08 12:28:31 +02:00
Oliver Schneider
55781f5949
Merge pull request #1963 from rust-lang-nursery/upstream
...
Rust needs clippy to have a Cargo.lock
2017-09-06 07:57:57 +02:00
Manish Goregaokar
0a238a4852
Update changelog
2017-09-05 15:10:41 -07:00
Manish Goregaokar
8aa1d118b3
Merge pull request #2004 from sunfishcode/master
...
When suggesting `from(x)` for lossless casts, strip parens from `x`.
2017-09-05 15:09:39 -07:00
Manish Goregaokar
0ceba6bed6
format comment
2017-09-05 14:19:51 -07:00
Manish Goregaokar
44b852b10e
Merge pull request #2023 from montrivo/while_let_loop
...
`while_let_loop` doesn't take into account break-with-value #1948
2017-09-05 14:19:00 -07:00
Manish Goregaokar
1c01ff5200
Merge pull request #2022 from rust-lang-nursery/oli-obk-patch-1
...
Also ignore `continue` statements in `is_unit_expr`
2017-09-05 13:30:40 -07:00
Tim Nielens
7489a84c6a
while_let_loop doesn't take into account break-with-value #1948
2017-09-05 22:28:30 +02:00
Oliver Schneider
8c824e4cbc
Also ignore continue statements in is_unit_expr
2017-09-05 12:12:44 -07:00
Manish Goregaokar
7e9ba81297
for loops -> for-loops
2017-09-05 12:10:53 -07:00
