Commit Graph

475 Commits

Author SHA1 Message Date
Caleb Zulawski
60486e08ed SimdPartialOrd implies SimdPartialEq 2022-03-15 00:17:14 +00:00
Caleb Zulawski
2a02c4d9cb Create SimdFloat trait 2022-03-13 19:57:06 +00:00
Caleb Zulawski
80469c66d6 Move comparisons to SimdPartialOrd and SimdOrd traits 2022-03-13 19:07:36 +00:00
Jubilee
72df4c4505
portable-simd#261: Rename horizontal_* to reduce_* 2022-03-12 15:34:58 -08:00
Ralf Jung
49043f4434
rust-lang/portable-simd#262: also implement clamp for integer vectors
* add test from issue rust-lang/portable-simd#253
2022-03-12 15:32:28 -08:00
Ralf Jung
b6ee5293f4
rust-lang/portable-simd#259: remove Miri from CI 2022-03-11 18:14:52 -08:00
Jacob Lifshay
b6e03f5886 Change beginner's guide to explain Reducing rather than Horizontal. 2022-03-11 16:27:00 -08:00
Jacob Lifshay
c196b8abaa replace horizontal_* with reduce_* 2022-03-11 14:49:06 -08:00
Jorge Leitao
86b9f69622
rust-lang/portable-simd#260: Add .min and .max for integers 2022-03-10 15:12:40 -08:00
Jubilee
89bc660d21 rust-lang/portable-simd#255: run Miri on CI
This is allowed to fail, but might produce useful results to check on.
2022-03-09 12:08:31 -08:00
Ralf Jung
4023d77e39 run Miri on CI (but allowed to fail) 2022-03-09 10:59:28 -05:00
Ralf Jung
adbd47973e reduce number of tests being run under Miri 2022-03-09 07:54:49 -05:00
Jubilee Young
2d13059ae9 Clean up use of cargo feature "std" 2022-03-08 13:36:29 -08:00
Jubilee Young
2e5e0ec380 Remove #![feature(const_fn_trait_bound)] 2022-03-08 13:36:29 -08:00
Ralf Jung
4ddcc006a9
rust-lang/portable-simd#252: extern blocks don't have doc comments 2022-03-04 11:14:49 -08:00
Jubilee
30975615b7
rust-lang/portable-simd#250: Add bitmask i{N <8} -> u8 impls
...and copy the notes for why they're legal.
2022-03-01 16:10:49 -08:00
Jubilee
a5789d17bf
rust-lang/portable-simd#248: Remove default features
Now that we are thoroughly embedded in libcore, we don't need these on by default.
Indeed, their presence may provide confusing results during integration attempts.
2022-02-28 19:56:31 -08:00
Jubilee
5f49d4c843
rust-lang/portable-simd#239: Bitmask conversion trait
Another approach that fixes rust-lang/portable-simd#223, as an alternative to rust-lang/portable-simd#238.

This adds the `ToBitMask` trait, which is implemented on a vector for each bitmask type it supports.  This includes all unsigned integers with enough bits to contain it.  The byte array variant has been separated out for now into rust-lang/portable-simd#246 and still requires `generic_const_exprs`, but the integer variants no longer require it and can make it to nightly.
2022-02-26 12:56:23 -08:00
Caleb Zulawski
20fa4b7623 Make internal mask implementation safe 2022-02-24 18:04:02 -08:00
Caleb Zulawski
11c3eefa35 Manually implement for supported lanes 2022-02-24 18:03:40 -08:00
Caleb Zulawski
842ac87747 Use bitmask trait 2022-02-24 18:02:39 -08:00
Jubilee
78a18c3433
rust-lang/portable-simd#245: Explain unsafe contracts of core::simd
* Explain unsafe contracts of core::simd

This permeates the module with remarks on safety for pub methods,
layout of the Simd type, correct use of intrinsics, et cetera.
This is mostly to help others curious about how core::simd works,
including other Rust contributors, `unsafe` library authors,
and eventually ourselves.
2022-02-10 09:32:44 -08:00
Caleb Zulawski
dddfffcfb3 Add some safety comments 2022-02-09 16:15:01 -08:00
Jubilee
6143bdef6d
Merge rust-lang/portable-simd#243 from ./no-overflow-panic
Remove overflow panic from divrem and add basic docs to Simd<T, N>

This finishes normalizing Simd<T, N> to being approximately equivalent to Simd<Wrapping<T>, N> for all implemented operations I can think of. It also documents this fact, allowing this to close rust-lang/portable-simd#56.
2022-02-09 12:46:41 -08:00
Jubilee
5d52455c65 Review for clarity and concision
Co-authored-by: Caleb Zulawski <caleb.zulawski@gmail.com>
2022-02-08 17:43:26 -08:00
Jubilee Young
e628a2991c Document Simd is Simd<Wrapping<T>, N>
and other quirks like panicking
and the equivalence to zipping and mapping binary ops
2022-02-08 15:40:52 -08:00
Jubilee Young
672bfebfd8 Remove overflow panic from divrem
Includes some remarks in intrinsics.rs,
generated while auditing the interface for remaining UB.
2022-02-08 15:39:55 -08:00
Jubilee Young
4910274686 Genericize to_int_unchecked 2022-02-03 03:46:16 -08:00
Jubilee Young
ebf65de2ce Delete outmoded fn round_from_int 2022-02-03 03:46:16 -08:00
Jubilee
01350a222a
Merge portable-simd#203 - deantvv/add-spectral-norm
Add spectral_norm example from packed_simd
2022-02-01 23:17:17 -08:00
Jubilee Young
03f6fbb21e Omit Simd::cast during bootstrap 2022-01-27 10:59:23 -08:00
Jubilee
7072c2278e
Merge portable-simd#232 - ./feat/typecast
Add Simd::cast
Add core_simd/tests/cast.rs
2022-01-26 22:21:00 -08:00
Jubilee Young
0031b02cee Add core_simd/tests/cast.rs 2022-01-26 21:04:47 -08:00
Jubilee Young
a991d48e95 Add Simd::cast 2022-01-26 18:37:02 -08:00
Caleb Zulawski
cad74346fb
Merge pull request #231 from AlecGoncharow/patch-1
fix documentation typo
2022-01-24 20:12:31 -05:00
Caleb Zulawski
36cca22f16
Update crates/core_simd/src/vector/float.rs
Co-authored-by: Alexander Ronald Altman <alexanderaltman@me.com>
2022-01-24 20:11:17 -05:00
Alec Goncharow
4fc62c2082
fix documentation typo
Remove redundant "neither" in the documentation comment.
2022-01-23 16:42:57 -05:00
Jubilee Young
56566d816d Annotate signed type in int_divrem_guard
The way the macro expands, it may sometimes infer
"this is a uint, but doesn't impl Neg???"
Also, I made the "wrong path for intrinsics" error.
These fixes allow integration into libcore.
2022-01-20 19:22:14 -08:00
Jubilee Young
a4f5f01b8a Use intrinsics for Mask::{to,from}_array
This significantly simplifies codegen and should improve mask perf.

Co-authored-by: Jacob Lifshay <programmerjake@gmail.com>
2022-01-19 21:00:21 -08:00
Caleb Zulawski
41db15373a
Merge pull request #224 from rust-lang/feature/min-max-intrinsic
Use intrinsic for min/max
2022-01-13 20:22:00 -05:00
Caleb Zulawski
138b9cf4bf Use intrinsic for min/max 2022-01-13 17:59:55 -05:00
Caleb Zulawski
65cb2c90a0 Fix mask alias 2022-01-09 13:12:22 -05:00
Jubilee
09fa72ae84 Merge portable-simd#219 - ./std-float
impl std::simd::StdFloat

 This introduces an extension trait to allow use of floating point methods
 that need runtime support. It is *excessively* documented because its mere
 existence is quite vexing, as the entire thing constitutes a leakage of
 implementation details into user observable space. Eventually the entire
 thing will ideally be folded into core and restructured to match the rest
 of the library, whatever that structure might look like at the time. This
 is preferred in lieu of the "lang item" path because any energy the lang
 items require (and it will be significant, by Simulacrum's estimation) is
 better spent on implementing our libmvec.
2021-12-31 15:50:20 -08:00
Jubilee Young
af26e3b9fd Tear down and rewrite support for float testing 2021-12-31 14:28:14 -08:00
Jubilee Young
ecc00efee0 impl std::simd::StdFloat
While consulting with Simulacrum on how to make available the float
functions that currently require runtime support for `Simd<f32, N>` and
`Simd<f64, N>`, we realized breaking coherence with the classic approach
of lang items was, since `{core,std}::simd::Simd` is a `ty::Adt`, likely
to be quite a bit nasty. The project group has a long-term plan for how
to get around this kind of issue and move the associated functions into
libcore, but that will likely take time as well. Since all routes
forward are temporally costly, we probably will skip the lang item
approach entirely and go the "proper" route, but in the interests of
having something this year for people to play around with, this
extension trait was whipped up.

For now, while it involves a lot of fairly internal details most users
shouldn't have to care about, I went ahead and fully documented the
situation for any passerby to read on the trait, as the situation is
quite unusual and puzzling to begin with.
2021-12-31 14:22:34 -08:00
Jubilee
4bbef261b6
Merge portable-simd#210 - ./wrap-shifts
Refactor ops.rs with wrapping shifts

This approaches reducing macro nesting in a slightly different way. Instead of just flattening details, make one macro apply another. This allows specifying all details up-front in the first macro invocation, making it easier to audit and refactor in the future.

This refactor also has some functional changes. Only one is a true behavior change, however:
- The visible one is that SIMD shifts are now wrapping, not panicking on overflow
- `core::simd` now has a lot more instances of `#[must_use]`, which merely lints
- div/rem now perform a SIMD check but remain as before, which should improve performance but be invisible
2021-12-30 01:22:01 -08:00
Jubilee Young
a42420583b Use Mask::any in div check 2021-12-23 23:17:13 -08:00
Jubilee Young
bc326a2bbc Refactor ops.rs with a recursive macro
This approaches reducing macro nesting in a slightly different way.
Instead of just flattening details, make one macro apply another.
This allows specifying all details up-front in the first macro
invocation, making it easier to audit and refactor in the future.
2021-12-22 15:37:05 -08:00
Jubilee Young
533f0fc81a Use relative intrinsics paths for bitmasks 2021-12-10 22:11:27 -08:00
Jubilee Young
5dcd397f47 Finish refactoring ints in ops.rs
This should perform a SIMD check for whether or not we can div/rem,
so that we can panic several times faster!
2021-12-09 13:23:45 -08:00