Guillaume Gomez
0c29fccf03
Extend large_include_file lint to also work on attributes
2024-10-30 20:41:34 +01:00
Alexey Semenyuk
900db48900
Add test case for missing_errors_doc at tests with option check-private-items = true
2024-10-27 14:53:20 +05:00
Philipp Krones
224d1e323a
Merge remote-tracking branch 'upstream/master' into rustup
2024-10-18 13:25:37 +02:00
bors
55f6029baa
Auto merge of #13444 - kpreid:fix-8524-private-rep, r=blyxyas
...
`module_name_repetitions`: don't warn if the item is in a private module.
Fixes <https://github.com/rust-lang/rust-clippy/issues/8524 >.
There is still a warning (as there should be) if the item is reexported by name, but not by glob; that would require further work to examine the names in the glob, and I haven't looked into that.
Credit to `@Centri3` for suggesting approximately this simple fix in <https://github.com/rust-lang/rust-clippy/issues/8524#issuecomment-1729036149 >. However, per later comment <https://github.com/rust-lang/rust-clippy/issues/8524#issuecomment-2035836495 >, I am not making it configuration-dependent, but *always* checking public items in public modules only.
changelog: [`module_name_repetitions`]: don't warn if the item is in a private module.
2024-10-12 16:46:31 +00:00
Camille GILLOT
810bd5dd09
Bless clippy.
2024-10-05 00:19:43 +00:00
GnomedDev
4b7c19018d
Fix large_stack_arrays triggering for static/constants
2024-10-04 19:06:39 +01:00
Philipp Krones
277c4e4baf
Merge commit 'aa0d551351a9c15d8a95fdb3e2946b505893dda8' into clippy-subtree-update
2024-10-03 16:32:51 +02:00
Samuel Moelius
877585089e
Fix non-lifetime tests
2024-09-25 13:52:12 -04:00
Philipp Krones
b61fcbee76
Merge commit '7901289135257ca0fbed3a5522526f95b0f5edba' into clippy-subtree-update
2024-09-24 11:58:04 +02:00
Kevin Reid
a235cbd8ac
module_name_repetitions: don't warn if the item is in a private module.
...
Fixes <https://github.com/rust-lang/rust-clippy/issues/8524 >.
There is still a warning (as there should be) if the item is reexported
by name, but not by glob; that would require further work to examine the
names in the glob, and I haven't looked into that.
Credit to @Centri3 for suggesting approximately this simple fix in
<https://github.com/rust-lang/rust-clippy/issues/8524#issuecomment-1729036149 >.
However, per later comment <https://github.com/rust-lang/rust-clippy/issues/8524#issuecomment-2035836495 >,
I am not making it configuration-dependent, but *always* checking public
items in public modules only.
2024-09-23 12:25:01 -07:00
Philipp Krones
3ab1da8bab
Formatting
2024-09-22 20:52:15 +02:00
bors
b3fc578ca6
Auto merge of #13300 - kyoto7250:issue_13292, r=llogiq
...
check std::panic::panic_any in panic lint
close #13292
This PR detects `std::panic::panic_any` in panic lint.
changelog: check std::panic::panic_any in panic lint
2024-08-26 19:32:11 +00:00
Jason Newcomb
173d5a6af0
Merge commit '0f8eabd6231366bfc1bb1464601297c2d48f8f68' into clippyup
2024-08-24 18:33:44 -04:00
Alex Macleod
3474df6a8e
Rewrite empty_line_after_doc_comments and empty_line_after_outer_attr
2024-08-24 18:07:31 +00:00
kyoto7250
b179c3e7f7
check std::panic::panic_any in panic lint
2024-08-25 00:56:02 +09:00
bors
37f98fffe7
Auto merge of #13220 - y21:issue13219, r=dswij
...
[`macro_metavars_in_unsafe`]: recognize metavariables in tail expressions
Fixes #13219
`macro_metavars_in_unsafe` keeps track of the current "expansion depth" (incremented/decremented when entering/leaving a macro span) to tell if an expression from the root context is contained within a macro (see the doc comment I added for a hopefully better explanation)
Before this PR, we didn't increment said `expn_depth` for `unsafe` blocks within macros, because we already do that in `visit_stmt` anyway, so it would work fine for statements, but that's not enough for tail expressions of an unsafe block.
So we now also increment it for macro unsafe blocks.
Also updated the comment for `expn_depth` while I'm at it because "This is not necessary for correctness" isn't correct now that I think about it
------
changelog: none
2024-08-10 12:43:43 +00:00
Jason Newcomb
f9509d3574
Refactor absolute_paths:
...
* Check the path length first
* Use `is_from_proc_macro`
* Use symbols instead of strings when checking crate names
2024-08-09 22:08:29 -04:00
Philipp Krones
1ac76a2062
Merge commit 'cb806113e0f83a8f9b47d35b453b676543bcc40e' into clippy-subtree-update
2024-08-08 19:13:50 +02:00
Jason Newcomb
8bcecfff95
Handle or patterns in single_match and single_match_else
2024-08-07 11:40:15 -04:00
y21
234a1d35d9
recognize metavariables in tail expressions
2024-08-05 12:02:08 +02:00
xFrednet
0532104247
Migrating restriction lints to span_lint_and_then (e -> i)
2024-08-03 10:18:15 +02:00
Philipp Krones
4e6851e50b
Merge commit '37f4fbb92913586b73a35772efd00eccd1cbbe13' into clippy-subtree-update
2024-07-25 18:29:17 +02:00
Jason Newcomb
e34c6dbae5
Refactor for using config values:
...
* Construct lint passes by taking `Conf` by reference.
* Use `HashSet` configs in less places
* Move some `check_crate` code into the pass constructor when possible.
2024-07-17 14:05:49 -04:00
Oli Scherer
3b390d416d
Bump clippy version
2024-07-15 08:51:04 +00:00
Philipp Krones
c1fd25d0aa
Merge commit 'b794b8e08c16517a941dc598bb1483e8e12a8592' into clippy-subtree-update
2024-07-11 15:44:03 +02:00
bors
8d3b1f9e30
Auto merge of #12984 - bitfield:fix_doc_nits_c, r=Alexendoo
...
Fix doc nits
More tender love and polish for the documentation and suggestion texts: adding formatting, links, full stops, tweaking wording for readability, changing 'which' to 'that' where appropriate, and other standard copyediting changes.
changelog: Docs [ `await_holding_lock` ]: fix doc nits
changelog: Docs [ `await_holding_refcell_ref` ]: fix doc nits
changelog: Docs [ `await_holding_invalid_type` ]: fix doc nits
changelog: Docs [ `cast_precision_loss` ]: fix doc nits
changelog: Docs [ `cast_sign_loss` ]: fix doc nits
changelog: Docs [ `cast_possible_truncation` ]: fix doc nits
changelog: Docs [ `cast_possible_wrap` ]: fix doc nits
changelog: Docs [ `cast_lossless` ]: fix doc nits
changelog: Docs [ `unnecessary_cast` ]: fix doc nits
changelog: Docs [ `cast_ptr_alignment` ]: fix doc nits
changelog: Docs [ `fn_to_numeric_cast` ]: fix doc nits
changelog: Docs [ `fn_to_numeric_cast_with_truncation` ]: fix doc nits
changelog: Docs [ `fn_to_numeric_cast_any` ]: fix doc nits
changelog: Docs [ `char_lit_as_u8` ]: fix doc nits
changelog: Docs [ `ptr_as_ptr` ]: fix doc nits
changelog: Docs [ `ptr_cast_constness` ]: fix doc nits
changelog: Docs [ `as_ptr_cast_mut` ]: fix doc nits
changelog: Docs [ `little_endian_bytes` ]: fix doc nits
changelog: Docs [ `big_endian_bytes` ]: fix doc nits
changelog: Docs [ `bind_instead_of_map` ]: fix doc nits
changelog: Docs [ `same_name_method` ]: fix doc nits
2024-07-10 17:55:08 +00:00
Jason Newcomb
60af2585f7
Refactor disallowed_methods:
...
* Simplify `def_id` extraction.
* Use the span of the method name instead of the call.
2024-07-05 02:37:09 -04:00
Philipp Krones
2da0edbdf1
Honor avoid-breaking-exported-api in needless_pass_by_ref_mut
...
Until now, the lint only emitted a warning, when breaking public API. Now it
doesn't lint at all when the config value is not set to `false`, bringing it in
line with the other lints using this config value.
Also ensures that this config value is documented in the lint.
2024-07-02 19:30:01 +02:00
xFrednet
3bbec6aade
sudo CI=green && Review changes <3
2024-06-25 18:06:22 +02:00
xFrednet
1b4c281fe7
RFC 2383: Stabilize lint_reasons in Clippy 🖇️
2024-06-25 17:50:48 +02:00
John Arundel
625091d236
Fix doc nits
2024-06-23 13:11:54 +01:00
Trevor Gross
c693f31ee2
Update float tests to include f16 and f128
2024-06-19 13:30:21 -04:00
Philipp Krones
3bff119f63
Merge commit '3e5a02b13b1244545454752c6629b767522a44b1' into clippy-subtree-update
2024-06-13 12:30:48 +02:00
bors
6cfd4ac955
Auto merge of #10632 - Alexendoo:needless-maybe-sized, r=Jarcho
...
Add `needless_maybe_sized` lint
changelog: new lint: [`needless_maybe_sized`]
Closes #10600
2024-06-05 20:11:03 +00:00
Paul R. Tagliamonte
35e2027a35
Fix grammer for the Safety documentation check
...
The original message ("unsafe function's docs miss `# Safety` section")
reads quite awkwardly. I've changed it to "unsafe function's docs are missing
a `# Safety` section" to have it read better.
Signed-off-by: Paul R. Tagliamonte <paultag@gmail.com>
2024-06-05 14:11:56 -04:00
Daniel Sedlak
c342a61564
Add configuration option for ignoring panic!() in tests
2024-05-16 05:45:56 +00:00
y21
9747c80644
new lint: macro_metavars_in_unsafe
2024-05-12 17:03:30 +02:00
J-ZhengLi
46659acdbd
add configuration to allow skipping on some certain traits & collect metadata
2024-05-12 22:13:17 +08:00
Rebecca Turner
8d8c0bfb0e
useless_attribute: allow clippy::disallowed_types
...
Closes https://github.com/rust-lang/rust-clippy/issues/12753
2024-05-02 11:55:11 -07:00
Philipp Krones
e8492355a3
Merge remote-tracking branch 'upstream/master' into rustup
2024-05-02 14:21:00 +02:00
Andre Bogus
87efce4fa2
configurably allow useless_vec in tests
...
This adds a `àllow-useless-vec-in-test` configuration which, when set
to `true` will allow the `useless_vec` lint in `#[test]` functions and
code within `#[cfg(test)]`. It also moves a `is_in_test` helper to
`clippy_utils`.
2024-04-28 22:07:56 +02:00
Gary Guo
7d9f970d4e
Fix and bless clippy tests
2024-04-24 13:12:33 +01:00
Alex Macleod
f7aef635c1
Rework interior mutability detection
2024-04-18 17:33:39 +00:00
Philipp Krones
a5aaf33422
Merge commit 'ca3b393750ee8d870bf3215dcf6509cafa5c0445' into clippy-subtree-update
2024-04-18 17:48:52 +02:00
Philipp Krones
846f6e7e00
Merge remote-tracking branch 'upstream/master' into rustup
2024-04-18 17:29:59 +02:00
Alex Macleod
cf0b55eb62
Add needless_maybe_sized lint
2024-04-14 14:43:03 +00:00
bors
832fdb6d30
Auto merge of #12573 - modelflat:recognize-common-prepositions-in-module-name-repetitions, r=Jarcho
...
[`module_name_repetition`] Recognize common prepositions
Fixes #12544
changelog: [`module_name_repetition`]: don't report an item name if it consists only of a prefix from `allowed-prefixes` list and a module name (e.g. `AsFoo` in module `foo`). Prefixes allowed by default: [`to`, `from`, `into`, `as`, `try_into`, `try_from`]
2024-04-12 18:53:03 +00:00
Matthias Krüger
2e989dc280
Rollup merge of #123204 - notriddle:notriddle/include-str-span, r=pnkfelix
...
rustdoc: point at span in `include_str!`-ed md file
Fixes #118549
2024-04-12 17:41:32 +02:00
modelflat
3705073a71
Recognize common prefixes when checking for items with module name suffix
...
Fixes #12544 .
- don't report an item name if it consists only of a prefix from `allowed-prefixes` list and a module name (e.g. `AsFoo` in module `foo`).
- configured by `allowed-prefixes` config entry
- prefixes allowed by default: [`to`, `from`, `into`, `as`, `try_into`, `try_from`]
- update docs
2024-04-09 09:47:54 +02:00
Philipp Krones
0ae4a048c6
Merge commit '9725c4a162502a02c1c67fdca6b797fe09b2b73c' into clippy-subtree-update
2024-04-04 19:52:55 +02:00
