Commit Graph

4831 Commits

Author SHA1 Message Date
Hanaasagi
2b4d9d55b8 fix invalid travis-yaml in README 2018-09-25 22:40:17 +09:00
Philipp Krones
e3f7b40b03
Merge pull request #3203 from yaahallo/master
Lint for chaining flatten after map
2018-09-25 12:54:48 +02:00
Philipp Hansch
1be78b90ac
Merge pull request #3212 from matthiaskrgr/clippy_dev_ed2018
clippy_dev: port to edition 2018
2018-09-25 07:27:12 +01:00
Jane Lusby
14feb3670f Lint for chaining flatten after map
This change adds a lint to check for instances of `map(..).flatten()`
that can be trivially shortened to `flat_map(..)`

Closes #3196
2018-09-24 14:29:16 -07:00
mikerite
417cf206ca
Merge pull request #3213 from mikerite/fix-3204
Fix single_char_pattern crash (#3204)
2018-09-24 09:11:32 +02:00
Michael Wright
ab71f08663 Fix single_char_pattern crash (#3204)
This commit fixes the crash by removing constant checking from the lint.

Closes #3204.
2018-09-24 08:33:57 +02:00
ms2300
523ba2a009 Full fix of get unwrap issue 2018-09-23 19:53:25 -07:00
ms2300
de8d233b06 #3006 : Fixing for .get().unwrap().foo() 2018-09-23 19:53:25 -07:00
Philipp Krones
bc6d85ceaf
Merge pull request #3207 from mikerite/fix-3206
Fix double_parens false positive
2018-09-23 18:24:27 +02:00
Philipp Krones
af2d6a0c14
Merge pull request #3191 from vi/suggest_with_applicability
Use span_suggestion_with_applicability instead of span_suggestion
2018-09-23 15:45:55 +02:00
Matthias Krüger
f2ecee3638 clippy_dev: port to edition 2018 2018-09-23 14:44:06 +02:00
Philipp Krones
b5c4342ef9
Merge pull request #3195 from JayKickliter/jsk/mem_replace_opt_w_none
Add lint for `mem::replace(.., None)`.
2018-09-23 10:23:48 +02:00
Manish Goregaokar
8e9f1a9d68
Mention rustup self update (fixes #3211) 2018-09-22 14:35:11 -07:00
Michael Wright
867ac98d38 Fix double_parens false positive
Closes #3206
2018-09-22 17:20:34 +02:00
flip1995
987b34d090
Another Applicability adjustment 2018-09-20 14:38:48 +02:00
Vitaly _Vi Shukela
52fb7d461e
Applicability adjustment per additional comments 2018-09-20 14:38:48 +02:00
Vitaly _Vi Shukela
58729346be
Fill in Applicability from review comments by @flip1995 2018-09-20 14:38:48 +02:00
Vitaly _Vi Shukela
3eccccb367
Fix indents 2018-09-20 14:38:48 +02:00
Vitaly _Vi Shukela
2781cac839
Apply subset of "cargo fmt". 2018-09-20 14:38:47 +02:00
Vitaly _Vi Shukela
3e853a632e
Add forgotten function: span_suggestion*s* to the previous refactoting 2018-09-20 14:38:47 +02:00
Vitaly _Vi Shukela
d4c994e670
Supplement DiagnosticBuilderExt with Applicability 2018-09-20 14:38:47 +02:00
Vitaly _Vi Shukela
92034e20c8
Use span_suggestion_with_applicability instead of span_suggestion 2018-09-20 14:38:47 +02:00
Philipp Hansch
c0c770c60b
Merge pull request #3201 from phansch/rust_master_in_contributing_docs
Mention how to install master Rust in CONTRIBUTING
2018-09-20 09:37:39 +01:00
Philipp Hansch
f72cfc2985
Mention rustup component history 2018-09-20 07:10:23 +02:00
Philipp Hansch
2b57cec649
s/rustc/Rust/ 2018-09-20 06:58:07 +02:00
Philipp Hansch
f9511bfdc3
s/rust/Rust, repeat 'Clippy' less 2018-09-20 06:56:51 +02:00
Jay Kickliter
79cda3bb1e mem_replace: fix grammar. 2018-09-19 14:54:38 -07:00
Jay Kickliter
2f53aaa5bd mem_replace: match on path. 2018-09-19 14:41:22 -07:00
Jay Kickliter
12c7bc1e58 mem_replace: apply update_lints tool. 2018-09-19 14:41:22 -07:00
Jay Kickliter
1b6d739ce3 mem_replace: make examples compilable. 2018-09-19 14:38:34 -07:00
Jay Kickliter
598df08d88 Add lint for mem::replace(.., None).
Suggest `Option::take()` as an alternative.
2018-09-19 14:38:34 -07:00
Philipp Hansch
9c50aa8810
Mention how to install master Rust in CONTRIBUTING 2018-09-19 21:15:08 +02:00
Philipp Hansch
3fee6d6438
Merge pull request #3197 from mikerite/travis_lint_list
Make travis check lint list
2018-09-19 19:44:23 +01:00
Philipp Hansch
b6707ffc42
Merge pull request #3187 from flip1995/internal_fn
New internal lint: compiler_lint_functions
2018-09-19 19:43:48 +01:00
Michael Wright
c06551aba7 Update lint list 2018-09-19 07:39:50 +02:00
Michael Wright
c52b33decb Make travis check lint list 2018-09-19 07:05:36 +02:00
Philipp Krones
125907ad08
Merge pull request #3194 from flip1995/c_void
Fix c_void path
2018-09-17 11:44:06 +02:00
flip1995
a8b681cc2c
Fix c_void path
This got changed in rust-lang/rust#53910
2018-09-17 11:20:27 +02:00
Philipp Krones
d366710a01
Merge pull request #3192 from mikerite/refactor_20180916
Remove unneeded check for method call
2018-09-16 13:46:12 +02:00
Michael Wright
c78cf042ff Remove unneeded check for method call
The check can be removed because the call to `method_chains_args`
already performs this check.
2018-09-16 13:08:00 +02:00
Eduard-Mihai Burtescu
183639b70b
Merge pull request #3190 from eddyb/rextern-2
Reintroduce `extern crate` for non-Cargo dependencies, in tests.
2018-09-15 14:05:10 +03:00
Eduard-Mihai Burtescu
407ff8d6be Reintroduce extern crate for non-Cargo dependencies, in tests. 2018-09-15 13:37:21 +03:00
Philipp Krones
fbb6b13140
Merge pull request #3068 from matthiaskrgr/string
convert "".to_string() and "".to_owned() to String::new()
2018-09-15 11:56:11 +02:00
flip1995
021748eb6a
Replace another occurrence of "".to_owned() 2018-09-15 11:25:40 +02:00
Matthias Krüger
f3add4acb4
convert "".to_string() and "".to_owned() to String::new() 2018-09-15 11:20:35 +02:00
flip1995
144281c537
Formatting 2018-09-15 11:02:00 +02:00
flip1995
a4e1a90705
Fix warnings of compiler_lint_functions 2018-09-15 11:02:00 +02:00
flip1995
aaeeaa5330
Add internal lint compiler_lint_functions 2018-09-15 11:01:16 +02:00
Oliver S̶c̶h̶n̶e̶i̶d̶e̶r Scherer
f166b7d2f4
Merge pull request #3189 from eddyb/rextern
Reintroduce `extern crate` for non-Cargo dependencies.
2018-09-15 10:34:09 +02:00
Eduard-Mihai Burtescu
c70bfb2cac Revert "the cargo feature: edition 2018 is stabilized in current nightly"
This reverts commit 404a09d61c.
2018-09-15 11:16:45 +03:00