Commit Graph

2148 Commits

Author SHA1 Message Date
Phil Turnbull
a9f5b90f0f Lint usage of *& and *&mut
fixes #1316
2016-11-22 21:06:20 -05:00
Martin Carton
530083c3b9 Merge pull request #1349 from philipturnbull/extend-chars
Lint `.extend(s.chars())` (closes #792)
2016-11-22 18:21:30 +01:00
Phil Turnbull
8705f3d11c Remove mention of .push_str(s) being faster
For the `.push_str(str.chars())` case the compiler will inline `push_str` and
call `extend_from_slice` on the underlying vector, so this isn't actually
faster.
2016-11-20 17:28:14 -05:00
Phil Turnbull
e9f3911899 Suggest &s instead of s.as_str() 2016-11-20 11:19:36 -05:00
Oliver Schneider
e2908dfc82 Merge pull request #1347 from sinkuu/conditional_returns
Allow explicit returns with cfg attributes
2016-11-20 09:21:25 +01:00
Daniel S Poulin
e40cb6a9dd Further clarify recommended usage
Pushed the section on hard dependency installation to the bottom of the usage methods to further discourage its use. Also included a note in that section warning that it is not the recommended method. Lastly, changed what was said in the opening paragraph of the Usage section to reflect the multitude of options.
2016-11-19 22:16:36 -05:00
sinkuu
5d40965b50 Fix #1346 2016-11-20 10:15:40 +09:00
sinkuu
1973e94550 Allow explicit returns with cfg attributes 2016-11-20 10:02:41 +09:00
Martin Carton
501ff22402 Merge pull request #1351 from Manishearth/rustup-2016-11-18
Rustup to *rustc 1.15.0-nightly (ac635aa95 2016-11-18)* and bump to 0.0.100
2016-11-20 00:19:38 +01:00
mcarton
40fcae112d
Bump to 0.0.100 2016-11-20 00:14:25 +01:00
mcarton
be799bc085
Rustup to *rustc 1.15.0-nightly (ac635aa95 2016-11-18)* 2016-11-20 00:13:08 +01:00
Phil Turnbull
73a73638c0 Add lint for string.extend(string.chars())
fixes #792
2016-11-19 14:55:47 -05:00
Phil Turnbull
fa78b09fa7 Add lint for string.extend("str".chars())
fixes #792
2016-11-19 14:55:02 -05:00
Phil Turnbull
0ab7e6c598 Factor out lint_vec_extend 2016-11-19 14:44:32 -05:00
Daniel S Poulin
5a415f67de Clarify recco to install as a soft dependency
On IRC it was mentioned that clippy is not meant to be installed as a hard dependency.
As it was, the README placed the hard dependency instructions first and did not
mention the recommendation, misleading users into making it a hard dependency. A
quick survey of the dependent crates on crates.io reveals the reach of this issue.
2016-11-18 22:46:12 -05:00
Martin Carton
276e85b700 Merge pull request #1344 from Manishearth/rustup
[WIP] Rustup to rustc 1.15.0-nightly (0ed951993 2016-11-14)
2016-11-18 13:47:07 +01:00
mcarton
1176242b72 Rustup to rustc 1.15.0-nightly (0ed951993 2016-11-14) 2016-11-18 13:40:53 +01:00
mcarton
7140eac484 Cleanup 2016-11-18 13:40:44 +01:00
Oliver Schneider
f39c6278e1
fix the inspector 2016-11-18 13:21:07 +01:00
mcarton
945c027768
Handle closure with single expression blocks 2016-11-17 19:44:18 +01:00
mcarton
19c5f5394b
Rustup to rustc 1.15.0-nightly (0ed951993 2016-11-14) 2016-11-16 23:05:26 +01:00
Manish Goregaokar
bad26a5aca Merge pull request #1339 from dereckson/patch-1
Recognize quux as a metasyntactic variable
2016-11-10 21:20:13 -08:00
Sébastien Santoro
0e6807e86b Recognize quux as a metasyntactic variable
quux is another metasyntactic variable like foo and so
should be detected by the blacklisted names linter.
2016-11-11 05:57:29 +01:00
Martin Carton
3edf712434 Merge pull request #1337 from oli-obk/master
fix ice in `len_zero` lint when type has no inherent impls at all
2016-11-10 18:51:08 +01:00
Oliver 'ker' Schneider
cfae1e9fda fix ice in len_zero lint when type has no inherent impls at all
fixes #1336
2016-11-10 17:06:39 +01:00
Oliver Schneider
2cfe1e7b64 Merge pull request #1328 from Machtan/master
Add '--version' flag and allow version and help flags when called as 'cargo-clippy'
2016-11-09 10:49:16 +01:00
Jakob Lautrup Nysom
2d9386f86d Remove unnecessary #[allow] 2016-11-09 10:44:55 +01:00
Oliver Schneider
a260e65ead Merge pull request #1312 from devonhollowood/get-unwrap
Implement `get_unwrap` lint
2016-11-09 09:49:20 +01:00
Oliver Schneider
c56b8dff8a Merge pull request #1332 from debris/fixed_1331
fixed #1331
2016-11-09 09:25:18 +01:00
debris
d16cc47ae8 fixed #1331 2016-11-08 21:50:35 +01:00
Machtan
e5a5a95a10 Add '--version' flag and use version and help flags when called as 'cargo-clippy' 2016-11-08 14:28:46 +01:00
Machtan
3800bff4de Add '--version' flag and allow version and help flags when called as 'cargo-clippy' 2016-11-08 13:54:08 +01:00
Oliver Schneider
c687fe73bc Create PUBLISH.md 2016-11-08 11:52:38 +01:00
Oliver 'ker' Schneider
e8783be6f1 version bump 2016-11-08 11:44:55 +01:00
Oliver Schneider
18e031a112 Merge pull request #1327 from oli-obk/master
--sysroot isn't necessary anymore for the outer cargo clippy call
2016-11-08 11:42:33 +01:00
Oliver 'ker' Schneider
6a73c8f8e3 --sysroot isn't necessary anymore for the outer cargo clippy call 2016-11-08 11:35:26 +01:00
Oliver 'ker' Schneider
ea1d432f66 publish 0.97 2016-11-03 21:23:49 +01:00
Oliver Schneider
2b1b91bbff Merge pull request #1321 from EpicatSupercell/master
fixed callback changes from rustc 1.14.0-nightly (7c69b0d5a 2016-11-01)
2016-11-03 21:14:19 +01:00
Epicat Supercell
e25b010847 fixed callback changes from rustc 1.14.0-nightly (7c69b0d5a 2016-11-01) 2016-11-02 21:27:42 +02:00
Devon Hollowood
e94a4d4666 Fix suggestion in get_unwrap lint 2016-11-02 11:48:16 -07:00
Martin Carton
aa8ca9b607 Merge pull request #1317 from oli-obk/cc_attr_used_fixed
mark cyclomatic complexity attribute as used
2016-11-02 18:25:38 +01:00
Oliver Schneider
a56af73fd8
mark cyclomatic complexity attribute as used
fixes #1315
2016-11-02 10:29:57 +01:00
Devon Hollowood
6a14dc7fd4 Remove false positives from get_unwrap lint
HashMap and BTreeMap don't implement `IndexMut`, so we shouldn't lint
for use of `get_mut().unwrap()` for those types.
2016-11-01 17:48:32 -07:00
Devon Hollowood
4e0d182d1d Clean up get_unwrap code 2016-11-01 17:48:18 -07:00
Devon Hollowood
1187d333ec Add tests for get_unwrap lint 2016-11-01 01:08:47 -07:00
Devon Hollowood
c5e270a1aa Small fixes for get_unwrap lint 2016-11-01 01:08:38 -07:00
Devon Hollowood
cfc741405b Run update_lints.py 2016-10-31 23:43:19 -07:00
Devon Hollowood
0680ac3562 Add get_unwrap lint 2016-10-31 23:42:33 -07:00
Manish Goregaokar
0e1f065678 Merge pull request #1311 from gibfahn/if_let_some_result
Add to docs for if_let_some_result
2016-10-31 16:02:17 -07:00
Gibson Fahnestock
c40466e1c2 Add to docs for if_let_some_result 2016-10-31 22:55:22 +00:00