Commit Graph

5688 Commits

Author SHA1 Message Date
Philipp Hansch
d4da776ea7
Also add note about using -W clippy::lint_group 2018-12-10 22:22:57 +01:00
Philipp Hansch
04e251f623
readme: tool lints are stable now 2018-12-10 22:04:27 +01:00
bors
0fd7fe9a77 Auto merge of #3511 - phansch:remove_allow_doc_markdown, r=phansch
Remove allow(doc_markdown) in excessive_precision.rs

Closes #3299
2018-12-10 19:21:25 +00:00
bors
ada0b2b095 Auto merge of #3518 - sinkuu:redundant_clone_tw, r=phansch
Lint redundant clone of fields

Makes `redundant_clone` warn on unnecessary `foo.field.clone()` sometimes (it can detect an unnecessary clone only if the base of projection, `foo` in this case, is not used at all after that). This is enough for cases like `returns_tuple().0.clone()`.
2018-12-10 18:55:49 +00:00
Matthias Krüger
0a6e568f07 test formatting: don't format tests/ui/formatting.rs 2018-12-10 15:46:01 +01:00
Matthias Krüger
7bcc2cd9c8 update test stderr 2018-12-10 08:22:07 +01:00
bors
1b93f8d620 Auto merge of #3524 - phansch:update_contributing, r=phansch
Small updates to CONTRIBUTING.md

None
2018-12-10 07:06:44 +00:00
Philipp Hansch
740634a154
Document bors/homu 2018-12-10 08:06:07 +01:00
Philipp Hansch
2213904024
Small updates to CONTRIBUTING.md 2018-12-10 08:06:07 +01:00
Shotaro Yamada
e7d18084fb Only check the assignment found at last
If there are more than one such assignment, the last one may be
the one supplied to `clone` method.
Makes `find_stmt_assigns_to` internally reverses the iterator to make
the intent to "iterate statements backward" clear.
2018-12-10 15:59:21 +09:00
Shotaro Yamada
fd9f5df36c Add comment and rename 2018-12-10 15:48:34 +09:00
bors
02512c10b2 Auto merge of #3522 - matthiaskrgr:target_dir, r=phansch
travis: base-tests: share CARGO_TARGET_DIR between check runs of subcrates to avoid unnecessarily recompiling deps.
2018-12-10 06:01:16 +00:00
Shotaro Yamada
22f396a1c1 Apply redundant_clone on clippy 2018-12-10 08:48:14 +09:00
Shotaro Yamada
109d4b1ab3 Lint redundant clone of projection 2018-12-10 08:48:14 +09:00
Matthias Krüger
435299be30 rustfmt tests 2018-12-09 23:26:16 +01:00
Matthias Krüger
31d3bd92be travis: base-tests: share CARGO_TARGET_DIR between check runs of subcrates to avoid unneccessarily recompiling deps. 2018-12-09 22:47:22 +01:00
Matthias Krüger
1218145bc9 base tests: assert that tests are properly formatted. 2018-12-09 22:43:45 +01:00
bors
1fbcbe4aa1 Auto merge of #3520 - matthiaskrgr:test_rustfmt_skip, r=phansch
add rustfmt::skip attributes to a couple of tests

part of rustfmt'ing test code
2018-12-09 18:03:53 +00:00
Matthias Krüger
9b839cd4b5 update line numbers of tests 2018-12-09 17:24:08 +01:00
Matthias Krüger
4583d78156 add rustfmt::skip attributes to some tests 2018-12-09 17:21:49 +01:00
Philipp Hansch
5b01f7a0d6
Merge pull request #3517 from phansch/add_fast_finish
Add `fast_finish` to travis matrix
2018-12-09 16:13:37 +01:00
Philipp Hansch
06ded0ea50
Merge pull request #3516 from phansch/remove_run_rustfix_annotation
Remove a run-rustfix annotation (for now)
2018-12-09 15:56:29 +01:00
Shotaro Yamada
a4fe567602 Fix test
`if true` is recognized by MIR optimization.
2018-12-09 23:51:31 +09:00
Philipp Hansch
72d2de6807
Add fast_finish to travis matrix
This means we don't have to wait for `allowed_failures` builds to
complete. It should save us ~10 minutes until we remove the windows
build from `allowed_failures`.
2018-12-09 15:42:52 +01:00
Philipp Hansch
43542f8d89
Remove a run-rustfix annotation (for now)
Starting to work on #2376, this annotation got in the way. Going to
remove it for now.
2018-12-09 15:16:36 +01:00
Philipp Hansch
8e1cd9e83e
Merge pull request #3515 from matthiaskrgr/fmt
run rustfmt
2018-12-09 12:45:31 +01:00
Matthias Krüger
273dc82872 run rustfmt 2018-12-09 12:03:10 +01:00
Shotaro Yamada
790e611c9c Cleanup 2018-12-09 19:18:35 +09:00
Philipp Hansch
a3c77f6ad1
Merge pull request #3512 from matthiaskrgr/rustup
rustup https://github.com/rust-lang/rust/pull/56502 ( .hir -> .hir() )
2018-12-08 13:42:01 +01:00
Philipp Hansch
d93ea1ec99
s/rustfmt-preview/rustfmt/ 2018-12-08 12:41:04 +01:00
Philipp Hansch
fe3519e0dd
Swap if branches 2018-12-08 12:09:32 +01:00
Philipp Hansch
d90cad24a1
Fix c_void false positive caused by libc refactoring
The path of `libc::c_void` has changes in 5c1a6b8a6d
The DefId path is now always platform specific like
`libc::windows::c_void`. This fixes our c_void detection to only check
the first and last elements.
2018-12-08 12:05:11 +01:00
Matthias Krüger
f13d23de41
rustup https://github.com/rust-lang/rust/pull/56502 ( .hir -> .hir() ) 2018-12-08 12:05:09 +01:00
Philipp Hansch
26602ddff4
Merge pull request #3336 from HMPerson1/clone_on_copy_deref
Fix `clone_on_copy` not detecting derefs sometimes
2018-12-08 09:59:02 +01:00
Philipp Hansch
a73d051227
Remove allow(doc_markdown) in excessive_precision.rs 2018-12-07 22:47:12 +01:00
Philipp Hansch
4884c2fc2e
Merge pull request #3507 from flying-sheep/patch-1
typo: emum → enum
2018-12-07 22:20:19 +01:00
Philipp A
2fed8d9f1d
typo: emum → enum 2018-12-07 12:24:59 +01:00
Philipp Hansch
041c49c1ed
Merge pull request #3257 from o01eg/remove-sysroot
Don't try to determine sysroot. rustc_driver will use default value.
2018-12-06 22:11:29 +01:00
Philipp Hansch
1df5766cbb
Merge pull request #3501 from matthiaskrgr/rustup
rustup clippy build with latest rustc
2018-12-06 17:17:40 +01:00
Manish Goregaokar
519a6cde81
Merge pull request #3502 from rust-lang/nrc-patch-1
Remove -preview suffix from README
2018-12-06 11:17:18 -05:00
Nick Cameron
7220185560
Remove -preview suffix from README 2018-12-06 11:11:50 -05:00
Matthias Krüger
45cbdf471d rustup clippy build with latest rustc
(breakage due to 08f8faedd0 )

Fixes #3500
2018-12-06 16:44:22 +01:00
Philipp Hansch
c4ef06a9b6
Merge pull request #3497 from daxpedda/master
Fix bug in `implicit_return`.
2018-12-06 14:13:20 +01:00
daxpedda
a4ec7be06f
Forgot to remove some debugging code ... 2018-12-06 13:23:42 +01:00
daxpedda
d048e15835
Improved code noted by clippy. 2018-12-06 13:21:04 +01:00
Oliver S̶c̶h̶n̶e̶i̶d̶e̶r Scherer
0fb30218d5
Merge pull request #3496 from fkohlgrueber/macro-in-closure-in-if-cond
fix #3482 and add ui test for it
2018-12-06 12:26:43 +01:00
daxpedda
973d676cd1
Fix bug in implicit_return.
Bug was already covered by test, but test was not checked for.
2018-12-06 12:22:54 +01:00
O01eg
278b94e6db
Fix format. 2018-12-06 13:46:23 +03:00
O01eg
5113de90d1
Add sysroot gettinh code to dogfood tests. 2018-12-06 13:21:45 +03:00
Felix Kohlgrüber
a8a0b236b5 fix #3482 and add ui test for it 2018-12-06 11:07:10 +01:00