Lukas Lueg
2ed254e29f
Clarify docs for RESULT_LARGE_ERR
2023-04-29 14:18:31 +02:00
bors
96f8471d81
Auto merge of #10649 - jsoref:spelling, r=Jarcho
...
Spelling
This PR corrects misspellings identified by the [check-spelling action](https://github.com/marketplace/actions/check-spelling ).
The misspellings have been reported at https://github.com/jsoref/rust-clippy/actions/runs/4710771873#summary-12776860721
The action reports that the changes in this PR would make it happy: https://github.com/jsoref/rust-clippy/actions/runs/4710771874#summary-12776860722
changelog: none
2023-04-23 22:30:06 +00:00
Josh Soref
d2061faf9e
Spelling
...
* applying
* binding
* complex
* constituent
* demonstrate
* desugaring
* exact
* expression
* for
* functionalities
* github
* implementation
* infers
* multiple conflicting traits
* mutable
* necessarily
* nightly
* nonexistent
* optional
* parameter
* reassignments
* resources
* substitution
* suggestion
* that
* that array is
* using the
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
2023-04-23 10:52:27 -04:00
xFrednet
747ff0656b
Update version attribute for 1.69 lints
2023-04-19 14:55:18 +02:00
blyxyas
a37eb4dfc9
Fix false negative on Result<(), ()>
2023-04-03 16:07:17 +02:00
blyxyas
d602743558
only focus on double_must_use + Add Result<(), ()> test
2023-04-03 15:16:18 +02:00
blyxyas
e2742a0ea2
Fix double_must_use for async functions
2023-04-03 01:27:53 +02:00
Philipp Krones
62cba5d971
Merge remote-tracking branch 'upstream/master' into rustup
2023-03-24 13:36:09 +01:00
Vadim Petrochenkov
cae7b87711
rustc: Remove unused Session argument from some attribute functions
2023-03-22 13:55:55 +04:00
Michael Goulet
6f62887968
Use local key in providers
2023-03-21 15:38:51 +00:00
Philipp Krones
cf8a67d9ad
Merge commit '3c06e0b1ce003912f8fe0536d3a7fe22558e38cf' into clippyup
2023-03-10 10:53:50 +01:00
Samuel Moelius
90ba82bd39
Two small documentation improvements
2023-02-28 09:52:01 -05:00
Andreas Deininger
03a3f74365
Fixing typos
2023-02-27 21:45:26 +01:00
Jason Newcomb
0413fb35ba
Merge commit '149392b0baa4730c68f3c3eadf5c6ed7b16b85a4' into clippyup
2023-02-25 19:28:50 -05:00
blyxyas
89fde4abf2
Add placeholders, remove name suggesting
2023-02-18 20:05:30 +01:00
blyxyas
6ef34bf009
Remove commented code
2023-02-15 21:34:49 +01:00
blyxyas
4166b7dcfe
Fix lint message
2023-02-15 21:34:49 +01:00
blyxyas
6aa06b757d
Remove #[allow]s. Apply conversations from @Jarcho
2023-02-15 21:34:48 +01:00
blyxyas
8a2245dcb6
Change lint's from style to restriction
2023-02-15 21:34:48 +01:00
blyxyas
bdf4fd3e82
Tests pass
2023-02-15 21:34:48 +01:00
blyxyas
ade4c9b2b6
Rename lint to better fit lint naming conventions
2023-02-15 21:34:47 +01:00
blyxyas
8ec9543f13
Add impl_trait_param lint
...
As this is a lint about "style", and a purely cosmetical choice (using `<A: Trait>` over `impl Trait`), a lot of other files needed to be allowed this lint.
2023-02-15 21:29:58 +01:00
Philipp Krones
e7fe1f9c14
Merge commit '0f7558148c22e53cd4608773b56cdfa50dcdeac3' into clippyup
2023-02-10 14:01:19 +01:00
Philipp Krones
7c61b4ed89
Merge remote-tracking branch 'upstream/master' into rustup
2023-02-10 11:33:45 +01:00
Camille GILLOT
92c4f1e2d9
Take a LocalDefId in hir::Visitor::visit_fn.
2023-01-28 09:51:50 +00:00
Kyle Matsuda
afb586fa1f
change fn_sig query to use EarlyBinder; remove bound_fn_sig query; add EarlyBinder to fn_sig in metadata
2023-01-26 20:28:25 -07:00
Kyle Matsuda
38899d0c29
replace usages of fn_sig query with bound_fn_sig
2023-01-26 20:15:36 -07:00
Philipp Krones
4ccafea92d
Merge commit '4f3ab69ea0a0908260944443c739426cc384ae1a' into clippyup
2022-12-29 14:28:34 +01:00
Trevor Gross
12f2dea229
not_unsafe_ptr_arg_deref update documentation
2022-12-25 07:30:21 -05:00
Philipp Krones
d05e2865a0
Merge commit 'd822110d3b5625b9dc80ccc442e06fc3cc851d76' into clippyup
2022-12-01 18:29:38 +01:00
Jason Newcomb
7ae5c81e9f
Fix ICE in result large_err with uninhabited enums
2022-11-30 21:44:18 -05:00
Philipp Krones
46c5a5d234
Merge commit 'f4850f7292efa33759b4f7f9b7621268979e9914' into clippyup
2022-11-21 20:51:52 +01:00
bors
73efce9ee6
Auto merge of #9770 - sgued:missnamed-getters, r=llogiq
...
Add new lint [`misnamed-getters`]
```
changelog: Add new lint [`misnamed-getters`]
```
Closes #9769
The current lint matches all methods with a body of just one expression under the form `(&mut?)? <expr>.field` where field doesn't match the name of the method but there is a field of the same type in `<expr>` that matches the name. This allows matching nested structs, for example for newtype wrappers. This may cast the net a bit too wide and cause false positives. I'll run [clippy_lint_tester](https://github.com/mikerite/clippy_lint_tester ) on the top crates to see how frequently false positives happen.
There also may be room for improvement by checking that the replacement field would work taking into account implementations of `Deref` and `DerefMut` even if the types don't exactly match but I don't know yet how this could be done.
2022-11-21 19:51:42 +00:00
Philipp Krones
fd5b85c957
Merge remote-tracking branch 'upstream/master' into rustup
2022-11-21 20:01:17 +01:00
Sosthène Guédon
1f2f50c34e
Fix many false negatives caused by autoderef
2022-11-20 17:03:53 +01:00
Sosthène Guédon
0411edfbbd
Improve diagnostic for cases where autoderef is used
2022-11-20 15:49:09 +01:00
Sosthène Guédon
6178ddaded
misname-getters: Fix documentation
2022-11-20 13:46:38 +01:00
Sosthène Guédon
d9993cb133
Remove error when fields use autoderef
2022-11-20 13:45:12 +01:00
Sosthène Guédon
3f1a186bd1
misnamed_getters: Trigger on unsafe with _unchecked
2022-11-20 13:45:12 +01:00
Sosthène Guédon
a867c17ab3
Improve code
2022-11-20 13:45:12 +01:00
Sosthène Guédon
3428da6e00
Fix typo missnamed -> misnamed
2022-11-20 13:45:12 +01:00
Sosthène Guédon
3e2e81b2db
Fix internal warnings
2022-11-20 13:45:12 +01:00
Sosthène Guédon
5fa0e07cdf
Document missname_getters
2022-11-20 13:45:12 +01:00
Sosthène Guédon
81d4590834
missnamed_getters: use all_fields iterator
2022-11-20 13:45:12 +01:00
Sosthène Guédon
ddc49966dc
Fix suggestion to point to the whole method
2022-11-20 13:45:12 +01:00
Sosthène Guédon
9891af348c
missnamed_getters: Match owned methods
2022-11-20 13:45:12 +01:00
Sosthène Guédon
31b83d0895
Add missnamed_getters lint
2022-11-20 13:45:11 +01:00
Elliot Bobrow
80e5856b02
result_large_err show largest variants in err msg
2022-11-07 18:00:35 -08:00
xFrednet
9e7996b149
Update lint versions for 1.65
2022-10-31 22:11:17 +01:00
Guillaume Gomez
dff041f2b5
Rollup merge of #103625 - WaffleLapkin:no_tyctxt_dogs_allowed, r=compiler-errors
...
Accept `TyCtxt` instead of `TyCtxtAt` in `Ty::is_*` functions
Functions in answer:
- `Ty::is_freeze`
- `Ty::is_sized`
- `Ty::is_unpin`
- `Ty::is_copy_modulo_regions`
This allows to remove a lot of useless `.at(DUMMY_SP)`, making the code a bit nicer :3
r? `@compiler-errors`
2022-10-29 14:18:03 +02:00
