Aleksey Kladov
f83485839b
better change visibility assist
...
* don't add visibility before #derive
* suggest changing pub(crate) into pub
2019-01-10 19:18:15 +03:00
bors[bot]
acd90bc33b
Merge #482
...
482: fix code duplication r=matklad a=matklad
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2019-01-10 15:32:34 +00:00
Aleksey Kladov
a0c978cd0c
fix code duplication
2019-01-10 18:32:02 +03:00
Aleksey Kladov
3ca76c2039
move join_lines to a separate module
2019-01-10 17:50:49 +03:00
bors[bot]
3990f93921
Merge #481
...
481: introduce marking infrastructure for maintainable tests r=matklad a=matklad
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2019-01-10 13:47:38 +00:00
Aleksey Kladov
32fa084c07
introduce marking infrastructure for maintainable tests
...
This also fixes a particular edge case in name resolution.
2019-01-10 16:45:09 +03:00
Marcus Klaas de Vries
e78286c8e8
Save variant names in EnumData to reduce needless queries
...
We already have their names when anyway, and when in all (current)
situations where we're interested in an Enum's variants, we want
their names.
2019-01-10 14:43:01 +01:00
Marcus Klaas de Vries
978de5cf8b
Implement type inference for enum variants
2019-01-10 14:32:56 +01:00
bors[bot]
aca14c591f
Merge #475
...
475: Show types of fields in completion r=matklad a=matklad
![image](https://user-images.githubusercontent.com/1711539/50910524-0f146200-143f-11e9-84d6-0ba80761cd89.png )
r? @flodiebold
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2019-01-10 13:07:19 +00:00
bors[bot]
aef93c918e
Merge #478
...
478: WIP: implement cancelation via unwinding r=matklad a=matklad
This uses https://github.com/salsa-rs/salsa/pull/107 to implement cancellation.
Now we can get rid of `Cancelable` wrapper from everywhere except the top-level analyzer library.
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2019-01-10 12:51:58 +00:00
bors[bot]
9225033cdf
Merge #477
...
477: Extend selection for list items r=matklad a=hban
First PR, criticism welcome!
There are a few things I'm not so sure about:
* There is now a not-so-small list of "list-like kinds" in extend selection source which maybe should belong somewhere else.
* Preferring left comma doesn't seem right IMO for one reason - trailing commas are usually on the right. For example, when array values are broken across multiple lines extending selected value will cover right trailing comma (because it's the only comma on the same line), but when all values are on the same line it will pick left comma. Anyway, currently with this PR it will pick always extend to left comma when possible since that's what issue specified 😃 .
Closes : #444
Co-authored-by: Hrvoje Ban <hban@users.noreply.github.com>
2019-01-10 12:20:00 +00:00
Aleksey Kladov
495a7ea9f7
upgrade salsa
2019-01-10 13:40:43 +03:00
Aleksey Kladov
86bc898a2f
explain why we use resume_unwind
2019-01-10 13:06:42 +03:00
Aleksey Kladov
f72c031eb9
implement RefUnwindSafe
2019-01-10 13:04:04 +03:00
Aleksey Kladov
64455ad701
use unwinding for cancelation
2019-01-10 12:20:32 +03:00
Hrvoje Ban
8384b2cc38
Extend selection for list items
2019-01-09 20:51:19 +01:00
Aleksey Kladov
cf20ecae9f
unwind on cancel
2019-01-09 22:51:05 +03:00
Aleksey Kladov
56b2138d82
show field types in completion
2019-01-09 19:40:11 +03:00
Aleksey Kladov
ddf2a8a948
add completion detail
2019-01-09 19:40:11 +03:00
bors[bot]
c2b8aa1ce5
Merge #476
...
476: nicer trailing comma handling in types r=matklad a=matklad
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2019-01-09 16:15:32 +00:00
Aleksey Kladov
e8815b614e
nicer trailing comma handling in types
2019-01-09 19:14:21 +03:00
bors[bot]
ecfa68a3f5
Merge #474
...
474: Fix rev to deleted branch r=matklad a=weiznich
Co-authored-by: Georg Semmler <georg_semmler_05@web.de>
2019-01-09 15:42:38 +00:00
Georg Semmler
e7bf5dc940
Fix rev to deleted branch
2019-01-09 16:33:45 +01:00
bors[bot]
76b3985d70
Merge #473
...
473: Partial typo fix r=matklad a=marcusklaas
This fixes some typos. Mostly in documentation, but also some code is affected (`defenition` was used in a few method names).
Co-authored-by: Marcus Klaas de Vries <mail@marcusklaas.nl>
2019-01-09 12:20:05 +00:00
Marcus Klaas de Vries
0b8fbb4fad
Fix typos in ARCHITECTURE.md and a number of crates
...
specifically: gen_lsp_server, ra_arena, ra_cli, ra_db, ra_hir
2019-01-09 01:17:09 +01:00
bors[bot]
c0f48f9eb0
Merge #472
...
472: Stupidly simple idea to make DefIds more stable r=matklad a=matklad
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2019-01-08 22:59:42 +00:00
Aleksey Kladov
d18d8399f5
fuzz-lockfile
2019-01-09 01:58:25 +03:00
Aleksey Kladov
5609989368
more stable DefIds via bfs tree walking
2019-01-09 01:57:40 +03:00
Marcus Klaas de Vries
f8261d611a
Fix typo defenition -> definition
2019-01-08 23:38:51 +01:00
Aleksey Kladov
2dc85619be
one more invalidation test
2019-01-09 00:54:06 +03:00
Aleksey Kladov
bcb6fabd15
fix test naming
2019-01-09 00:49:21 +03:00
Aleksey Kladov
8f93e7b9a4
remove duplication in tests
2019-01-09 00:48:54 +03:00
bors[bot]
46f74e33ca
Merge #471
...
471: rename crates to match reality r=matklad a=matklad
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2019-01-08 19:48:48 +00:00
Aleksey Kladov
0c62b1bb7a
fix the docs
2019-01-08 22:45:52 +03:00
Aleksey Kladov
5b573deb20
fix usages after rename
2019-01-08 22:33:36 +03:00
Aleksey Kladov
6bca91af53
rename ra_analysis -> ra_ide_api
2019-01-08 22:30:56 +03:00
Aleksey Kladov
fa3c9ce392
fix usages after rename
2019-01-08 22:30:32 +03:00
Aleksey Kladov
1967884d68
rename ra_editor -> ra_ide_api_light
2019-01-08 22:17:36 +03:00
bors[bot]
4f4f7933b1
Merge #469
...
469: kill text utils r=matklad a=matklad
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2019-01-08 19:03:35 +00:00
Aleksey Kladov
921689b70d
kill text utils
2019-01-08 22:03:13 +03:00
Aleksey Kladov
f553837c1c
upstream text-utils to text_unit
2019-01-08 21:50:04 +03:00
bors[bot]
c9e42fcf24
Merge #468
...
468: decouple ra_editor from other stuff r=matklad a=matklad
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2019-01-08 18:04:08 +00:00
Aleksey Kladov
695294bbb9
ra_db is independent from editor
2019-01-08 21:03:42 +03:00
Aleksey Kladov
0c88360eb4
add comment
2019-01-08 21:01:41 +03:00
Aleksey Kladov
13301f284c
ra_hir does not depend on ra_editor
2019-01-08 21:01:41 +03:00
Aleksey Kladov
702bdacb03
move node at offset to aglo already
2019-01-08 21:01:41 +03:00
Aleksey Kladov
1b82084a5f
dont depend on ra_editor directly
2019-01-08 21:01:41 +03:00
bors[bot]
1c25bf05d7
Merge #467
...
467: move function to code_model_api r=matklad a=matklad
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2019-01-08 17:35:08 +00:00
Aleksey Kladov
ac92973a6c
move function to code_model_api
2019-01-08 20:11:13 +03:00
bors[bot]
3b166aee3c
Merge #466
...
466: switch to newer cargo-metadata r=matklad a=matklad
This handles renames
closes https://github.com/rust-analyzer/rust-analyzer/issues/464
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2019-01-08 16:36:33 +00:00