Commit Graph

399 Commits

Author SHA1 Message Date
Jacob Pratt
8253484854
Rollup merge of #132878 - aDotInTheVoid:less-pings-for-mark, r=GuillaumeGomez
triagebot: Assign rustdoc tests to T-rustdoc.

Should avoid situations like #132871, which got assigned to mark (via fallback) despite being a rustdoc change.

For now, I've assigned all our testsuites to the rustdoc group (whoever from T-Rustdoc is on review rotation), except the json one which is assigned to me.

CC `@rust-lang/rustdoc`

r? `@GuillaumeGomez`
2024-11-10 19:12:26 -05:00
Alona Enraght-Moony
7e9c46b883 triagebot: Assign rustdoc tests to T-rustdoc. 2024-11-10 21:44:28 +00:00
Jieyou Xu
e49d9173f8 Break from review rotation 2024-11-11 02:27:09 +08:00
Jubilee
0ba177083f
Rollup merge of #132825 - Noratrieb:Noratrieb-patch-1, r=clubby789
Exclude relnotes-tracking-issue from needs-triage
2024-11-09 20:28:45 -08:00
nora
2b469607b4
Exclude relnotes-tracking-issue from needs-triage 2024-11-09 22:45:17 +01:00
Ralf Jung
b81e919f65 triagebot: ping wg-const-eval when relevant files change 2024-11-05 09:13:28 +01:00
Boxy
0900a1bd80 the unvacationer 2024-10-30 13:29:05 +00:00
Jubilee
9d58475760
Rollup merge of #132293 - Urgau:tests-check-cfg-out-triagebot, r=lqd
Remove myself from mentions inside `tests/ui/check-cfg` directory

This PR removes myself from mentions inside `tests/ui/check-cfg` directory.

I'm not sure this particular mention has ever been useful to me, and lately it's been too annoying for me to ignore it.

So remove my-self from it.
2024-10-29 03:11:44 -07:00
Urgau
5ae5323d0e Remove myself from mentions inside tests/ui/check-cfg directory 2024-10-28 22:23:56 +01:00
Noah Lev
d4774ff4ab Remove my ping for rustdoc/clean/types.rs
It was useful at one time, but now it just causes notification noise.
2024-10-28 14:32:40 -04:00
Matthias Krüger
13ec1b0c97
Rollup merge of #131875 - juntyr:wasm-notification-groups-triage, r=Mark-Simulacrum
Add WASM | WASI | Emscripten groups to triagebot.toml

Tracking issue: https://github.com/rust-lang/compiler-team/issues/799

~~This is blocked on amending the notification group section so that the instructions links point somewhere: https://github.com/rust-lang/rustc-dev-guide/pull/2100~~
2024-10-26 18:45:33 +02:00
Jubilee
0e307bb90e
Rollup merge of #132017 - celinval:smir-update-reviewerss, r=scottmcm
Update triagebot.toml

Update the list of reviewers after updating the team here: https://github.com/rust-lang/team/pull/1555
2024-10-21 20:32:02 -07:00
Matthias Krüger
fb42a4581b
Rollup merge of #131647 - jieyouxu:unicode-table-generator, r=Mark-Simulacrum
Register `src/tools/unicode-table-generator` as a runnable tool

It seems like `src/tools/unicode-table-generator` is not currently managed by bootstrap. This PR wires it up with bootstrap as a runnable tool.

This tool seems to take two possible args:

1. (Mandatory) path to `library/core/src/unicode/unicode_data.rs`, and
2. (Optional) path to generate a test file.

I only passed the mandatory path to `unicode_data.rs` in bootstrap and didn't do anything about (2). I'm not sure about how this tool is supposed to be run.

`Cargo.lock` is modified because I renamed `unicode-table-generator`'s bin name to match the tool name, as bootstrap's tool running logic expects the bin name to be derived from the tool name.

I also added a triagebot message to remind to not manually edit the library source file and edit the tool then regenerate instead, but this should probably be a tidy check (if that's desirable then that can be in a follow-up PR, though may be overkill).

Helps with #131640 but does not close it because still no docs.

r? `@Mark-Simulacrum` (since I think you authored this tool?)
2024-10-20 16:54:09 +02:00
Juniper Tyree
a4ffeb0263
Add WASM | WASI | Emscripten groups to triagebot.toml 2024-10-18 10:02:28 +03:00
Celina G. Val
67081dbb14
Update triagebot.toml
Update the list of reviewers after updating the team.
2024-10-17 18:18:01 -07:00
许杰友 Jieyou Xu (Joe)
9f42f9491d triagebot: tag PRs affecting compiletest with A-compiletest 2024-10-14 19:33:58 +08:00
许杰友 Jieyou Xu (Joe)
be89da5ab5 triagebot: add reminder for library/core/src/unicode/unicode_data.rs that it needs to be generated by tool
And should not be directly edited.
2024-10-13 19:45:25 +08:00
Matthias Krüger
0969882628
Rollup merge of #131497 - jieyouxu:spin, r=onur-ozkan
Add myself to bootstrap review rotation

r? `@onur-ozkan`
2024-10-11 12:21:06 +02:00
许杰友 Jieyou Xu (Joe)
57ae34ad3c Add myself to bootstrap review rotation 2024-10-10 19:02:58 +08:00
Jacob Pratt
e481599536
Add myself back to review rotation 2024-10-10 01:09:13 -04:00
许杰友 Jieyou Xu (Joe)
db6e31bba7 Remove myself from vacation 2024-10-07 23:40:17 +00:00
Michael Goulet
65cff8a1ef Mark Boxy as on vacation 2024-10-07 12:17:55 -04:00
Jubilee
8ec549492d
Rollup merge of #131238 - michaelwoerister:triagebot, r=michaelwoerister
Remove mw from triagebot.toml

cc https://github.com/rust-lang/team/pull/1565
2024-10-04 14:11:37 -07:00
Michael Woerister
ea3d336bbb Remove mw from triagebot.toml
cc https://github.com/rust-lang/team/pull/1565
2024-10-04 15:46:19 +02:00
许杰友 Jieyou Xu (Joe)
0369ee4c9b Week off of reviews to focus on docs
Dedicating a week to work on rustc-dev-guide.
2024-10-04 11:20:38 +00:00
naskya
8ba2c7d42b
fix minor typo in triagebot config 2024-09-27 12:58:16 +09:00
joboet
b0c2c9372a
readd @tgross35 and @joboet to the review rotation 2024-09-23 13:37:52 +02:00
Ibraheem Ahmed
f5223276bd
format 2024-09-18 01:10:16 -04:00
Ibraheem Ahmed
99ea16af1a
add myself to the libs review rotation 2024-09-18 01:07:30 -04:00
Ralf Jung
db40dc3168 notify Miri when intrinsics are changed 2024-09-11 16:31:05 +02:00
León Orell Valerian Liehr
93b4b2d51c
Temporarily remove fmease from the review rotation 2024-09-04 11:43:38 +02:00
Jakub Beránek
fa77b9d21c
Remove kobzol vacation status 2024-09-02 20:06:37 +02:00
Trevor Gross
a0073104ad Mark myself as on vacation for triagebot 2024-08-31 21:24:47 -05:00
joboet
f51289214c
mark joboet as on vacation 2024-08-30 21:28:42 +02:00
Thom Chiovoloni
5c6285c5f0 Add myself to the review rotation for libs 2024-08-23 19:16:01 +00:00
Guillaume Gomez
0369e854d3
Rollup merge of #129457 - Kobzol:kobzol-vacation, r=Kobzol
kobzol vacation

r? ``@ghost``
2024-08-23 12:32:18 +02:00
Jakub Beránek
2339560239
kobzol vacation 2024-08-23 10:20:24 +02:00
Eric Huss
f458886a40 Remove JohnTitor from review rotation 2024-08-17 17:34:52 -07:00
Michael Woerister
5082e25263 Add mw back to review rotation 2024-08-13 20:16:14 +02:00
Trevor Gross
c369c2034f
Add a triagebot mention for library/Cargo.lock
Since [1], `Cargo.lock` was split into `Cargo.lock` and
`library/Cargo.lock`. Update Triagebot to give the same warning for both.

[1]: https://github.com/rust-lang/rust/pull/128534
2024-08-05 12:39:35 -05:00
许杰友 Jieyou Xu (Joe)
f4fa80ff5a triagebot: make sure Nora is called Nora 2024-07-29 17:01:39 +00:00
Michael Woerister
ab71870f8d mw out of office 2024-07-22 10:05:56 +02:00
Oli Scherer
7f3f34db74 Mark myself as on leave 2024-07-18 06:32:53 +00:00
bors
e35364a521 Auto merge of #127865 - matthiaskrgr:rollup-8m49dlg, r=matthiaskrgr
Rollup of 8 pull requests

Successful merges:

 - #125042 (Use ordinal number in argument error)
 - #127229 (rustdoc: click target for sidebar items flush left)
 - #127337 (Move a few intrinsics to Rust abi)
 - #127472 (MIR building: Stop using `unpack!` for `BlockAnd<()>`)
 - #127579 (Solve a error `.clone()` suggestion when moving a mutable reference)
 - #127769 (Don't use implicit features in `Cargo.toml` in `compiler/`)
 - #127844 (Remove invalid further restricting suggestion for type bound)
 - #127855 (Add myself to review rotation)

r? `@ghost`
`@rustbot` modify labels: rollup
2024-07-17 21:52:29 +00:00
yukang
2c2ef6ce9d add chenyukang to review rotation 2024-07-17 19:12:05 +08:00
Chris Denton
a216a34ef3
jhpratt on vacation 2024-07-17 07:53:02 +00:00
Trevor Gross
f18d4a86a7
Add myself to the review rotation 2024-07-14 17:53:39 -04:00
bors
09682988f2 Auto merge of #125935 - madsmtm:merge-os-apple, r=workingjubilee
Merge Apple `std::os` extensions modules into `std::os::darwin`

The functionality available on Apple platforms are very similar, and were (basically) duplicated for each platform.

This PR rectifies that by merging the code into one module.

Ultimately, I've done this to fix `./x build library --target=aarch64-apple-tvos,aarch64-apple-watchos,aarch64-apple-visionos`, as that currently fails because of dead code warnings.

Publically exposing these to tvOS/watchOS/visionOS targets is considered in https://github.com/rust-lang/rust/pull/123723, but that seems to be dragging out, and in any case I think it makes sense to do the refactor separately from stabilization.

r? libs

Fixes https://github.com/rust-lang/rust/issues/121640 and https://github.com/rust-lang/rust/issues/124825.
2024-07-14 16:28:07 +00:00
Mads Marquart
306d5788a6 Merge Apple std::os extensions modules into std::os::darwin
The functionality available on Apple platforms are very similar, and
were duplicated for each platform.

Additionally, this fixes a warning when compiling the standard library
for tvOS, watchOS and visionOS by marking the corresponding code as
dead code.
2024-07-14 15:31:54 +02:00
Mara Bos
c8e44471b8 Temporarily remove me from review rotation. 2024-07-10 11:56:56 +02:00