mikros/rust
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Auto merge of #112646 - vn971:document-thread-names-for-sgx-target, r=m-ou-se

Browse Source 
Document thread names for SGX compilation target

`@raoulstrackx` `@Mkaynov` `@jethrogb`
This commit is contained in:
bors 2023-07-25 09:14:11 +00:00
commit ff8fe76c0e
1 changed files with 9 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
library/std/src/sys/sgx/thread.rs
View File

@ -121,8 +121,16 @@ pub fn yield_now() {
rtassert!(wait_error.kind() == io::ErrorKind::WouldBlock); rtassert!(wait_error.kind() == io::ErrorKind::WouldBlock);
} }
/// SGX should protect in-enclave data from the outside (attacker),
/// so there should be no data leakage to the OS,
/// and therefore also no 1-1 mapping between SGX thread names and OS thread names.
///
/// This is why the method is intentionally No-Op.
pub fn set_name(_name: &CStr) { pub fn set_name(_name: &CStr) {
// FIXME: could store this pointer in TLS somewhere // Note that the internally visible SGX thread name is already provided
// by the platform-agnostic (target-agnostic) Rust thread code.
// This can be observed in the [`std::thread::tests::test_named_thread`] test,
// which succeeds as-is with the SGX target.
} }
pub fn sleep(dur: Duration) { pub fn sleep(dur: Duration) {