From fd2448b5fc9908ba5bdde152540e4935c48a7a86 Mon Sep 17 00:00:00 2001 From: Jubilee Young Date: Thu, 24 Mar 2022 22:31:46 -0700 Subject: [PATCH] Use a let-chain in _session::output (nfc) --- compiler/rustc_session/src/lib.rs | 1 + compiler/rustc_session/src/output.rs | 24 +++++++++--------------- 2 files changed, 10 insertions(+), 15 deletions(-) diff --git a/compiler/rustc_session/src/lib.rs b/compiler/rustc_session/src/lib.rs index 2db217d9716..bd4e37f1ab7 100644 --- a/compiler/rustc_session/src/lib.rs +++ b/compiler/rustc_session/src/lib.rs @@ -1,5 +1,6 @@ #![feature(crate_visibility_modifier)] #![feature(derive_default_enum)] +#![feature(let_chains)] #![feature(let_else)] #![feature(min_specialization)] #![feature(once_cell)] diff --git a/compiler/rustc_session/src/output.rs b/compiler/rustc_session/src/output.rs index c6648f9d740..e5e6579d75b 100644 --- a/compiler/rustc_session/src/output.rs +++ b/compiler/rustc_session/src/output.rs @@ -183,24 +183,18 @@ pub fn default_output_for_target(sess: &Session) -> CrateType { /// Checks if target supports crate_type as output pub fn invalid_output_for_target(sess: &Session, crate_type: CrateType) -> bool { - match crate_type { - CrateType::Cdylib | CrateType::Dylib | CrateType::ProcMacro => { - if !sess.target.dynamic_linking { - return true; - } - if sess.crt_static(Some(crate_type)) && !sess.target.crt_static_allows_dylibs { - return true; - } + if let CrateType::Cdylib | CrateType::Dylib | CrateType::ProcMacro = crate_type { + if !sess.target.dynamic_linking { + return true; } - _ => {} - } - if sess.target.only_cdylib { - match crate_type { - CrateType::ProcMacro | CrateType::Dylib => return true, - _ => {} + if sess.crt_static(Some(crate_type)) && !sess.target.crt_static_allows_dylibs { + return true; } } - if !sess.target.executables && crate_type == CrateType::Executable { + if let CrateType::ProcMacro | CrateType::Dylib = crate_type && sess.target.only_cdylib { + return true; + } + if let CrateType::Executable = crate_type && !sess.target.executables { return true; }