From f8df4fadc86f44cb5f6e69f29634dcfa6701b070 Mon Sep 17 00:00:00 2001 From: Eduard Burtescu Date: Mon, 19 May 2014 12:11:06 +0300 Subject: [PATCH] syntax: implement in-place folding of P and Vec. --- src/libsyntax/fold.rs | 11 +++++++++-- src/libsyntax/ptr.rs | 10 ++++++++-- 2 files changed, 17 insertions(+), 4 deletions(-) diff --git a/src/libsyntax/fold.rs b/src/libsyntax/fold.rs index 44ed347d70c..e63954c3680 100644 --- a/src/libsyntax/fold.rs +++ b/src/libsyntax/fold.rs @@ -35,8 +35,15 @@ pub trait MoveMap { } impl MoveMap for Vec { - fn move_map(self, f: |T| -> T) -> Vec { - self.move_iter().map(f).collect() + fn move_map(mut self, f: |T| -> T) -> Vec { + use std::{mem, ptr}; + for p in self.mut_iter() { + unsafe { + // FIXME(#5016) this shouldn't need to zero to be safe. + mem::move_val_init(p, f(ptr::read_and_zero(p))); + } + } + self } } diff --git a/src/libsyntax/ptr.rs b/src/libsyntax/ptr.rs index 92315a870f2..71cb2635280 100644 --- a/src/libsyntax/ptr.rs +++ b/src/libsyntax/ptr.rs @@ -31,8 +31,14 @@ impl P { f(*self.ptr) } - pub fn map(self, f: |T| -> T) -> P { - self.and_then(|x| P(f(x))) + pub fn map(mut self, f: |T| -> T) -> P { + use std::{mem, ptr}; + unsafe { + let p = &mut *self.ptr; + // FIXME(#5016) this shouldn't need to zero to be safe. + mem::move_val_init(p, f(ptr::read_and_zero(p))); + } + self } }