From f8bd95589fceb893e5244f8f94e010a8b30f6529 Mon Sep 17 00:00:00 2001 From: Tim Chevalier Date: Thu, 15 Nov 2012 18:11:08 -0800 Subject: [PATCH] Add comments explaining why these tests are xfailed --- src/test/auxiliary/cci_class_5.rs | 21 +++++++------------ .../compile-fail/omitted-arg-wrong-types.rs | 3 +-- .../private-method-cross-crate.rs | 6 +++--- .../regions-out-of-scope-slice.rs | 5 ++--- 4 files changed, 14 insertions(+), 21 deletions(-) diff --git a/src/test/auxiliary/cci_class_5.rs b/src/test/auxiliary/cci_class_5.rs index 94451ba4c4b..e11c75d5d99 100644 --- a/src/test/auxiliary/cci_class_5.rs +++ b/src/test/auxiliary/cci_class_5.rs @@ -1,20 +1,15 @@ mod kitties { - #[legacy_exports]; -struct cat { - priv { - mut meows : uint, - } - - how_hungry : int, - -} - - impl cat { - priv fn nap() { for uint::range(1u, 10000u) |_i|{}} + pub struct cat { + priv mut meows : uint, + how_hungry : int, } - fn cat(in_x : uint, in_y : int) -> cat { + impl cat { + priv fn nap() { for uint::range(1, 10000u) |_i|{}} + } + + pub fn cat(in_x : uint, in_y : int) -> cat { cat { meows: in_x, how_hungry: in_y diff --git a/src/test/compile-fail/omitted-arg-wrong-types.rs b/src/test/compile-fail/omitted-arg-wrong-types.rs index e6ad54f219d..7296bcfbb45 100644 --- a/src/test/compile-fail/omitted-arg-wrong-types.rs +++ b/src/test/compile-fail/omitted-arg-wrong-types.rs @@ -1,5 +1,4 @@ -// xfail-test - +// xfail-test - #2093 fn let_in(x: T, f: fn(T)) {} fn main() { diff --git a/src/test/compile-fail/private-method-cross-crate.rs b/src/test/compile-fail/private-method-cross-crate.rs index 2d258e58b84..41fa8ca47bc 100644 --- a/src/test/compile-fail/private-method-cross-crate.rs +++ b/src/test/compile-fail/private-method-cross-crate.rs @@ -1,11 +1,11 @@ // error-pattern:attempted access of field `nap` on type +// xfail-test Cross-crate impl method privacy doesn't work // xfail-fast -// xfail-test // aux-build:cci_class_5.rs -use cci_class_5; +extern mod cci_class_5; use cci_class_5::kitties::*; fn main() { - let nyan : cat = cat(52u, 99); + let nyan : cat = cat(52, 99); nyan.nap(); } diff --git a/src/test/compile-fail/regions-out-of-scope-slice.rs b/src/test/compile-fail/regions-out-of-scope-slice.rs index c6936cf8392..299e27d7a37 100644 --- a/src/test/compile-fail/regions-out-of-scope-slice.rs +++ b/src/test/compile-fail/regions-out-of-scope-slice.rs @@ -1,12 +1,11 @@ -// xfail-test - +// xfail-test blk region isn't supported in the front-end fn foo(cond: bool) { // Here we will infer a type that uses the // region of the if stmt then block, but in the scope: let mut x; //~ ERROR foo if cond { - x = &[1,2,3]blk; + x = &blk/[1,2,3]; } }