mikros/rust
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

explain why we don't inline when target features differ

Browse Source
This commit is contained in:
Ralf Jung 2023-10-28 16:50:40 +02:00
parent 615d0f2400
commit f7985afe4f
1 changed files with 5 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
compiler/rustc_mir_transform/src/inline.rs
View File

@ -439,6 +439,11 @@ fn check_codegen_attributes(
} }
if callee_attrs.target_features != self.codegen_fn_attrs.target_features { if callee_attrs.target_features != self.codegen_fn_attrs.target_features {
// In general it is not correct to inline a callee with target features that are a
// subset of the caller. This is because the callee might contain calls, and the ABI of
// those calls depends on the target features of the surrounding function. By moving a
// `Call` terminator from one MIR body to another with more target features, we might
// change the ABI of that call!
return Err("incompatible target features"); return Err("incompatible target features");
} }