Review changes

This commit is contained in:
Jakub Beránek 2024-06-29 16:07:22 +02:00
parent 151986f493
commit f6f21a8f11
3 changed files with 3 additions and 3 deletions

View File

@ -27,7 +27,7 @@ pub fn perf(builder: &Builder<'_>) {
let args = std::env::args().skip_while(|a| a != "--").skip(1); let args = std::env::args().skip_while(|a| a != "--").skip(1);
let mut cmd = builder.tool_cmd(Tool::RustcPerfWrapper); let mut cmd = builder.tool_cmd(Tool::RustcPerfWrapper);
cmd.env("PERF_RUSTC", rustc) cmd.env("RUSTC_REAL", rustc)
.env("PERF_COLLECTOR", collector) .env("PERF_COLLECTOR", collector)
.env("PERF_RESULT_DIR", profile_results_dir) .env("PERF_RESULT_DIR", profile_results_dir)
.args(args); .args(args);

View File

@ -1,3 +1,3 @@
# rustc-perf wrapper # rustc-perf wrapper
Utility tool for invoking [`rustc-perf`](https://github.com/rust-lang/rustc-perf) for benchmarking/profiling Utility tool for invoking [`rustc-perf`](https://github.com/rust-lang/rustc-perf) for benchmarking/profiling
a stage1/2 compiler built by bootstrap using `x run perf`. a stage1/2 compiler built by bootstrap using `x perf -- <command>`.

View File

@ -68,7 +68,7 @@ struct SharedOpts {
#[derive(Debug, clap::Parser)] #[derive(Debug, clap::Parser)]
struct BuildContext { struct BuildContext {
/// Compiler binary that will be benchmarked/profiled. /// Compiler binary that will be benchmarked/profiled.
#[clap(long, hide = true, env = "PERF_RUSTC")] #[clap(long, hide = true, env = "RUSTC_REAL")]
compiler: PathBuf, compiler: PathBuf,
/// rustc-perf collector binary that will be used for running benchmarks/profilers. /// rustc-perf collector binary that will be used for running benchmarks/profilers.
#[clap(long, hide = true, env = "PERF_COLLECTOR")] #[clap(long, hide = true, env = "PERF_COLLECTOR")]